summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-30loplugin:reducevarscope in sfx2Noel
Change-Id: I63ee19bfe7ad01ff4ad8c941bffadd9406101c6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103678 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-30oox smartart: snake algo: make sure child shape height stays within parentMiklos Vajna
1) When applying double outside spacing, introduced with commit 0a29c928afa74123bca05dc089c751603d368467 (oox smartart, picture strip: fix lack of spacing around the picture list, 2019-02-26), make sure that is only applied in the direction of a signle row: i.e. the bugdoc case is left/right outer spacing, but no top/bottom spacing. 2) If a child shape has an aspect ratio request, make sure that it only decreases what would be allocated by default, so the children never leave the parent's rectangle. 3) Fix a mis-match between the first and second row, the unexpected small left padding in the second row was because code assumed that all child shapes have the same width; which is not true, when widths come from constraints. With this in place, we finally do a good rendering of the bugdoc, and child shapes are always within the bounds of the background. Change-Id: Ia2606dcd945402f7dfe17c6e2f261bfd98667022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103680 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-30update creditsChristian Lohmaier
Change-Id: I84bfd619b2f8802bc311eaa221670a9cae904160
2020-09-30SwPosition::GetDoc can return a referenceCaolán McNamara
and remove discovered redundant null checks Change-Id: I90e2a84b260bfaf283b787db055cd1ed54dab4ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-30SwPaM::GetDoc can return a reference insteadCaolán McNamara
and remove discovered redundant null checks Change-Id: Iac8ad7821d9acfcc9550a96402c02ac248f16f2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-30SwHTMLTableLayout::GetDoc can return a referenceCaolán McNamara
Change-Id: I5d300ea19433b6439d8fca2152fa5ac1f5e90fef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103671 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-30tdf#137091: sc_subsequent_filters_test: Add unittestXisco Fauli
Change-Id: I435ffbdd82b5a40e56dd5f6ef55c032802184767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103604 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-30android: "make run" works also for debug configurationVasily Melenchuk
In debug mode Android package name is "org.example.libreoffice" and "make run" said that there is no such intent to launch. Change-Id: I6d8eac85dedf3e387a9dd4a228605f79ca0d5aee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103287 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-30ofz#25989 cmap parsingCaolán McNamara
Change-Id: I048e5d88d5926a4afa75afab18db5ca6354e2454 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103641 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-30loplugin:reducevarscope in scNoel
Change-Id: If88c71351fb157b8eab242fceb65422f05eec3d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-30loplugin:reducevarscope in swNoel
Change-Id: Ifed7220c6acf7049b2985f1911a806b37a54d794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-30twain32shim: Windows directory might not be in DLL search path sometimesMike Kaganski
So try the full path to TWAIN_32.DLL if first try failed. Change-Id: I9ad262c91ebc7b3df63fbec3ffe34595ffd78c75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103669 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-30tdf#137104 Added a check for headings in tablesIvan Stefanenko
New check checks if a node is a heading and if it is in a table. Change-Id: I53938ddb57573f80c7823b05bff2d1dd2cee1b8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103014 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-30loplugin:reducevarscope in svxNoel
Change-Id: I88fdaa74c4944f9ffc81db6df08a29283362375a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-30fix DrawDeviceAlphaBitmap() with mirroring (tdf#136223)Luboš Luňák
It turns out even the slow path was broken, so make it work (a hack, but it's already slow anyway, and apparently not used often). Also make the fast paths work directly, even with manual mirroring it should be still faster. Change-Id: Id798351f349e9906e85c1685f269df98a1b833b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103595 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-30tdf#135836 remove "to page" from shape/image contextmenuSeth Chaiklin
recommended in bug report Change-Id: I61ed3390d8175f00e0617e1cd234b2be0b4f3caa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103648 Tested-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-09-30tdf#43958 sc: fix fill by selecting merged cellAttila Szűcs
wholly instead of only its top left corner, if there is no marked selection present. This fixes the selection rectangle during dragging by fill handle of selected merged cells, copying their attributes in other cells of the target area, too, fixing losing merged cell structure, e.g. incomplete grid and other problems. Follow-up of commit 1ed04c2029218619aab2f3422130c890f67f309c (tdf#40993 tdf#59585 sc fill: copy merged cell structure). Note: the selection is a bit different, if there is filtered (hidden) rows in the current cell area. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I387feef640b7a89ab601c24e3641075934d3fc54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103001 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-30tdf#40993 tdf#59585 sc fill: copy merged cell structureAttila Szűcs
like other spreadsheets do. This avoids losing and recreation of merged cell structure again and again after modifying cell content using fill. By dragging the fill handle, cell attributes ATTR_MERGE and ATTR_MERGE_FLAG are copied, too, resulting the same merged cell structure in the selection. See TODOs about the remaining tasks. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Icd4287d4429d3ba27a2ffb062560856d7ad86099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102394 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-30tdf#60145 sw: fix UTF-8 encoding without BOM is not detectedTomofumi Yagi
Writer can now detect Unicode type even if importing text file does not have a BOM. Change-Id: I70fa4145672d855f9ef9df040a930ff5d1564905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102884 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-09-30Fix CppunitTest_connectivity_morkStephan Bergmann
...after 9141c300771825db5136cb6591e83dc4b541be08 "More “e-mail” → “email”" broke it: > Test name: connectivity::mork::MorkDriverTest::test_select_default_all > An uncaught exception of type com.sun.star.sdbc.SQLException > - The column name 'E-mail' is not valid. ~/lo/core/connectivity/source/commontools/dbexception.cxx:442 > > DriverTest.cxx:183:Assertion > Test name: connectivity::mork::MorkDriverTest::test_select_list_table_joe_doe_5 > assertion failed > - Expression: result > - fetch first row failed! Change-Id: I3825fbf0ff35da794c9ce038407178456552f7ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103668 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-30SwNode::GetDoc can return a reference insteadCaolán McNamara
and remove discovered redundant null checks Change-Id: I6b8bc9593434f38947e399a48888a8fa0d4f7e77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103640 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-30SwNodes::GetDoc can return a reference insteadCaolán McNamara
Change-Id: I6c3b2e5b95fb9fac8faa36fc6ae378b92e08fd89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103639 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-30vcl: add PDFiumAnnotation::getObjectCount()Miklos Vajna
And use it in xmlsecurity, instead of the upstream scopers, to standardize on a single set of pdfium wrappers. Change-Id: Iec4baf34a607b23f1b9de8c4b969801c5973c1ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103636 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-30Run gdb in gdb-core-bt.sh with PYTHONWARNINGS=default, tooStephan Bergmann
...same as fb06d5b1784cb8b91ea6d286b3f2baa38fed0b4c "Run gdb with PYTHONWARNINGS=default" Change-Id: If6523e4222f7ef9b9ce72df4a1ab3e039e63154b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103637 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-30Sidebar visibility and arangement of content panelandreas kainz
Change-Id: I57d6f5e9d89384df919aa9ab5857f18ce4d78837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103527 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-09-30tdf#137013 fix Writer find toolbar ui regressionsJim Raykowski
introduced by enhancement patch tdf#132366 Change-Id: I951fcd7891c75e7fbf715581c316b4446d967cd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103499 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-09-29Fix clunky grammarAdolfo Jayme Barrientos
Change-Id: Ib253466a346bea05fd1c268f6e55df6cf6ef26a2
2020-09-29More “e-mail” → “email”Adolfo Jayme Barrientos
Follow-up for commits 8b57d07a64e03db32b5383f58a40c1509392cd24 and 5f665a855ef26faea4dfa2ac427685b60545e8b8 Change-Id: I8f0f9a7a81636623df766f9d4ea414bde9d408bc
2020-09-30icu: fix Windows Arm64 buildJan-Marek Glogowski
I couldn't find a general solution to select the correct build path when cross compiling for Windows Arm64, so this just adds the patch in exactly this case, which WFM. Change-Id: I6e53e1531048404b70dcf61eab0a7f4021076868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102852 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-30bridges: add a Windows Arm64 UNO bridgeJan-Marek Glogowski
Since Microsoft follows the general ARM64 ABI calling conventions, and the SEH exception handling is the same, this result is a mixed port of the gcc3_linux_aarch64 bridge and the refactored x86-64 exception handling. I have no idea, if the complicated 32-bit handling in RaiseInfo() is needed, as the ARM64 trampolines definitly use 64-bit code. But since this is the first working version, I currently don't mind much ;-) There is definitly more potential for refactoring in the whole bridges directory... Change-Id: I9782a2e99c0231cdd1286af156ad312229eccf39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103642 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-09-30tdf#137009: except Togo, all French locales in African don't use AM/PMJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=137009#c4 Change-Id: I01612e79ffd947c1a4c0cf252d71bda48bc3ef8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103638 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-30Clean-up of commit: I95d394c5432d22805a761b76219f656fad3feae1Attila Szűcs
Renamed a wrongly named variable, reported here: https://gerrit.libreoffice.org/c/core/+/102173/4/sc/source/core/data/documen3.cxx#1140 Change-Id: I42ef65df78c5ad04e2c2875cf47d241a280892e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103605 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-29Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to b16f95724b69db8bd3327c36c26dd556d81c9c46 - tdf#137133 update control names on Rotation help page - change to <h1>, <h2>, <h3> and <note> - decrease heading level for "Default settings" - corrections in control names to align with dialog box Change-Id: I59fde1bde47be62b10364a1541525b2954efdce6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103652 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2020-09-29Determine CharClass difference once, tdf#137091 follow-upEike Rathke
As a side note: Clang plugin simplifybool for !(rLT1.getLanguage() == "en" && rLT2.getLanguage() == "en") told "error: logical negation of logical op containing negation, can be simplified" which is nonsense (the message stayed the same while the checks evolved). It actually complained about !(a==b && c==d) to be rewritten as (a!=b || c!=d) whether that makes sense or not.. it may save one boolean operation, yes, but.. Change-Id: Ib478d46d7ff926c1c9f65fec059c7a3f31fa7ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103601 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-29Replace include list by vectorJulien Nabet
since vector is used with: line 59: typedef std::vector< FieldSort > SortDescriptor; Change-Id: If6b6bfe4d4a162f5993522cf72fedb5da89e8457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103518 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-29oox smartart: snake algo: apply constraints on child shape widthsMiklos Vajna
This requires tracking what is the total of the width request of child shapes, then scaling them according to what is the total available width. Additionally, the height of child shapes should be adjusted based on their aspect ratio requests. A related trap is when an (invisible) spacing shape is at the end of the row, that would result in smaller spacing between the rows, so track the max height of shapes inside a single row. With this, finally the 6 child shapes are arranged on 2 rows, not 3 ones. Change-Id: I4eb2f06676df11c1432e0934ca3a0ec8891c5843 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103629 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-29Missing test dependenciesStephan Bergmann
from-scratch `make CppunitTest_sw_ooxmlexport5` failed due to > warn:vcl.builder:2286992:2286992:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file://~/lo/core/instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66 > warn:legacy.osl:2286992:2286992:vcl/source/window/window.cxx:273: Window ( 7Control()) with live children destroyed: 7VclVBox() > Window ( 7Control()) with live children destroyed: 7VclVBox() > > > Fatal exception: Signal 6 and > warn:vcl.builder:2288529:2288529:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file://~/lo/core/instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui ~/lo/core/xmlreader/source/xmlreader.cxx:66 > warn:legacy.osl:2288529:2288529:vcl/source/window/window.cxx:273: Window ( 7Control()) with live children destroyed: 7VclVBox() > Window ( 7Control()) with live children destroyed: 7VclVBox() > > > Fatal exception: Signal 6 and > warn:sal.osl:2307918:2307918:sal/osl/unx/module.cxx:159: dlopen(~/lo/core/instdir/program/libgielo.so, 1): ~/lo/core/instdir/program/libgielo.so: cannot open shared object file: No such file or directory > warn:sal.osl:2307918:2307918:sal/osl/unx/module.cxx:159: dlopen(~/lo/core/instdir/program/libgielo.so, 1): ~/lo/core/instdir/program/libgielo.so: cannot open shared object file: No such file or directory Change-Id: I99b4c983541f934cbca1a9f00f0510b90a8139af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103631 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-09-29SwNodes never passed a null SwDoc*Caolán McNamara
and some more like that Change-Id: I02dae666d8935a90afd9c43cfb32a048c69a1d4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103628 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-29tdf#136520 allow color popdowns to be tearable againCaolán McNamara
Change-Id: Ic92ef5235662e1680aadb5666e05dad1bf808e9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103625 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-29tdf#133358: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I148052d7038824b43ec0c473d4bcbcb64e2f92b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103608 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-29gdk_wayland_window_set_application_id doesn't work when called earlyCaolán McNamara
after mapped it definitely works Change-Id: Ide0fa636ee26acea0d938aef08532b9396fe901a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103609 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-29Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Id08fb3de62c55ab24f585b1bd1b9f719c78f91b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103464 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-09-29oox smartart: snake algo: start parsing relative width constraintsMiklos Vajna
This is needed, but not enough to have the correct width for each shape and spacing item on the path of the snake. Currently we give the same width for all children, while the shapes typically have a larger width than the spacings. Change-Id: I4e2638ea5b566c21cb1cf503a8cf2e5d35256e3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103594 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-09-29CreatePostItData never passed a null SwDoc*Caolán McNamara
Change-Id: Ie3f8ec6ff645b09bbdc897b45cd1de26ddc970bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-29Add extended tip to chart2 leader lines uiOlivier Hallot
Remove mention to pie charts Change-Id: I00fffd6a77be5905266999c3dc8953a507aabf15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103556 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-29Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 78dc9c1d059b48ad79620f0cc536466e701a042d - tdf#131416 Basic Syntax Diagrams for Defxxx statements - Basic language ref . toc additions - Letter range option addition - DefBool-based refactoring Change-Id: I5744c63e9c21ad5ff2801cd03a119fd2c747fef3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/103056 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-29tdf#91251 XLSX textbox export: fix missing overflow propertiesRegényi Balázs
by grab-bagging them. Co-authored-by: Szabolcs Toth Change-Id: I242bf33e1272d913805c90a2ef902be8633618fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103182 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-29tdf#80526 DOCX: import word-wrap textbox settingRegényi Balázs
See option "Word wrap text in shape" in Format->Text Box and Shape->Text Attributes... of the selected textbox. Co-authored-by: Szabolcs Toth Change-Id: I7f2ca392089043c4bec20b943aa8c1975de72e5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103109 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-29tdf#133358 fix crash in redoing indentCaolán McNamara
since... commit b070202b420129b5edd368420e0e50ec45261d01 Date: Tue Nov 20 18:26:18 2018 +0100 sw_redlinehide_4a: SwEditShell::IsMoveLeftMargin(), MoveLeftMargin() Change-Id: Ie28207747560153020341305015f1693f6ca9f50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103552 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-09-29avoid crash if DrawTransformedBitmap() would mean empty Skia bitmapLuboš Luňák
I can reproduce this sometimes with the document from tdf#136223. Change-Id: Ie6e57f18936a5de7f99ab01932be229625b737c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103596 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>