summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-04Fix typo in codeAndrea Gelmini
To complete: https://gerrit.libreoffice.org/#/c/76037 Change-Id: I4d804c4ca6f011e8a322c2d7cccb308676bfb5d2 Reviewed-on: https://gerrit.libreoffice.org/76207 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-11-04Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#128480 Incorrect call for QR Code Change-Id: I8e9c58e9c54288e2e29b80547abd5d82611cfa76 Reviewed-on: https://gerrit.libreoffice.org/81974 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-04survive missing atk_object_set_accessible_id symbolCaolán McNamara
Change-Id: If18380dfe3ab17a4584602869928b3ff50fc15d6 Reviewed-on: https://gerrit.libreoffice.org/81987 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04Update listbox after scrollSzymon Kłos
To show updated content in the Online after scroll. Change-Id: Ieb58c2a24bfcd76495d7046a0721db789b5c141a Reviewed-on: https://gerrit.libreoffice.org/81967 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-04ofz#18683 NotifyFreeObj override is not helpfulCaolán McNamara
the base one works fine, the override on the SvxMSDffClientData is sufficient to do what we want here if the base method check of groupobj children was in use Change-Id: I8ee65532d95c167ee83d6c2918dd0b8508d98b48 Reviewed-on: https://gerrit.libreoffice.org/81969 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04find Clang headers also if it's Clang built from sourceLuboš Luňák
Change-Id: I2253bdce982028277b30d7bf911201675be45ca4 Reviewed-on: https://gerrit.libreoffice.org/81919 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-11-04loplugin:finalclasses in sw/incNoel Grandin
Change-Id: I084502d8c5607f103ef987b54252ef95341f0bef Reviewed-on: https://gerrit.libreoffice.org/81981 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-04Fix build with --disable-pch on WinGabor Kelemen
Broken after commit 2cd6ff8a54b0db76b2f4c5f75988367cfb0feaf0 - apparently vcl/svapp.hxx is needed Most of sfx2/source/appl/appdde.cxx is Windows specific so took the opportunity to clean it up with IWYU and commenting out ifdefs Change-Id: Ia0ad54f590cf19033e630ea4df98c244bfdc47a0 Reviewed-on: https://gerrit.libreoffice.org/81849 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-04tdf#120315 DOCX import: fix cells merged verticallyBakos Attila
Due to rounding mistake cells weren't merged vertically, when their horizontal positions are different a little bit. Change-Id: I10623719a3759b35fcd04b154590b8ac6ec3ac45 Reviewed-on: https://gerrit.libreoffice.org/81604 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-04Build mysql_jdbc library even when building without javaTamas Bunth
Change-Id: Iecf49ab466a77f8342e69bf245a30e1529fe0078 Reviewed-on: https://gerrit.libreoffice.org/79056 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/81917 Tested-by: Jenkins
2019-11-04sw: remove dead SwFormatFollowTextFlow::mbLayoutInCellMiklos Vajna
Now that the UNO API doesn't write it and the layout doesn't read it. Change-Id: I0c9bb6aca8f3642f06cb25b9857738a751520702 Reviewed-on: https://gerrit.libreoffice.org/81980 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-04Toolbar: Added usage of ImageControl as toolbar controlSerge Krot
Reviewed-on: https://gerrit.libreoffice.org/81064 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit 48f945a3be16ee0eba0c526e51280dc8deafc316) Change-Id: I2536a505650b6e4c98e79f749c3b237518cc995d Reviewed-on: https://gerrit.libreoffice.org/81872 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-03mysqlc: replace initializer list with assignmentTamas Bunth
Because visual c++ compiler may not support it without creating a constructor for the struct. Change-Id: I6c8868c4e34cbe7b67e413b1db18aed01378c959 Reviewed-on: https://gerrit.libreoffice.org/65905 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/76727 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/81901 Tested-by: Jenkins
2019-11-03cid#1448412 Untrusted value as argumentCaolán McNamara
Change-Id: I89196af1fc823ef9fcf1e5a9cdb4ee07d72d6600 Reviewed-on: https://gerrit.libreoffice.org/81950 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-03make some classes module-privateNoel Grandin
improve the script, but it still generates some false positives Change-Id: If8ee1cba8c04ac0be11f73220149e6de15f24f44 Reviewed-on: https://gerrit.libreoffice.org/81929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03size some stringbuffer to prevent re-allocNoel Grandin
I started with 32 and kept doubling the size until the site did not need re-alloc, but clamped it at 512. Change-Id: I55fe36b31cd3d40f86e5729337a927cf920f2af6 Reviewed-on: https://gerrit.libreoffice.org/81960 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03loplugin:stringaddNoel Grandin
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03tdf#42949 restore vcl/canvastools.hxx for OSL_DEBUG_LEVEL > 2Tomoyuki Kubota
Change-Id: I6c69bcca4d5cd34efc297764d940727ef8631bf4 Reviewed-on: https://gerrit.libreoffice.org/81953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03Only initialize function pointer onceMike Kaganski
Change-Id: I559e90948b9dc1c78fa7ff03a96edc1cb9fbe3e2 Reviewed-on: https://gerrit.libreoffice.org/81958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-03tdf#127927 Writer Character Dialog Font Tab updateandreas kainz
Change-Id: I7f2b02393cdda40c07459a83c32d3ebf5569ef12 Reviewed-on: https://gerrit.libreoffice.org/81543 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-03tdf#128257 Bullet Dialog updateandreas kainz
Change-Id: I86414cbdef60663e72fe422adce081ae1ce6aaa5 Reviewed-on: https://gerrit.libreoffice.org/81144 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-03find symbols that can be privateNoel Grandin
update the script and make private standalone functions Change-Id: Icb26ce258107700c90f89ad4e0d3329d075a2eb1 Reviewed-on: https://gerrit.libreoffice.org/81879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03Cleanup copypasteMike Kaganski
Change-Id: I9b2ed3d806868689cf9f573ca5e841e3d35e644e Reviewed-on: https://gerrit.libreoffice.org/81957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-03ensure gtk creates a default label widget for the MenuButtonsCaolán McNamara
removed by... commit 80109586e6cb6d3e2e0a53a9079c3125ec9b8368 Date: Fri Nov 1 20:33:09 2019 +0300 tdf#126128 Reduce page properties dialog's height. Change-Id: I03b960046657483deafc16a3819a9b8579fb9413 Reviewed-on: https://gerrit.libreoffice.org/81951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-03unnecessary forward declaresCaolán McNamara
Change-Id: I086340ef46c3a4663867c0d0c3d14f223209a4c6 Reviewed-on: https://gerrit.libreoffice.org/81952 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-03Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - typo + faulty link Change-Id: Ic6fcb2e820f4ff5a8adfcbbed9166afc5635f36b Reviewed-on: https://gerrit.libreoffice.org/81933 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-03Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add stemmer info in omindex search Change-Id: I3e899f4e31d15ea332e6b69d14218d1e8e364c7f Reviewed-on: https://gerrit.libreoffice.org/81924 Tested-by: Jenkins Reviewed-by: Guilhem Moulin <guilhem@libreoffice.org> Tested-by: Guilhem Moulin <guilhem@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-02ofz#18620 TimeoutCaolán McNamara
Change-Id: Ifecba03620328afd20c80501aaacaf5795aee704 Reviewed-on: https://gerrit.libreoffice.org/81947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02New loplugin:conditionalstringStephan Bergmann
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3 Reviewed-on: https://gerrit.libreoffice.org/81946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-02tdf#128441: blacklist nvidia on Win10 deviceid 0x2182Julien Nabet
Change-Id: I033da69ee4f001f7dd2546822626fb2777dd040f Reviewed-on: https://gerrit.libreoffice.org/81943 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-02cid#1455212 Uncaught exceptionCaolán McNamara
Change-Id: I21e39dbaaec6c74b1c7ae1f306cb8d5c3d32c174 Reviewed-on: https://gerrit.libreoffice.org/81938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1455216 Dereference before null checkCaolán McNamara
Change-Id: I84752fcd154e2e9c344e3ad397f26c1a0d5184c2 Reviewed-on: https://gerrit.libreoffice.org/81941 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1452004 silence Explicit null dereferencedCaolán McNamara
Change-Id: I3cfc071f1ae1084801708ae82dc1f1f91402c08c Reviewed-on: https://gerrit.libreoffice.org/81944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1448338 silence Untrusted value as argumentCaolán McNamara
Change-Id: Ibf076d86181990d1ea6aded4af4345961e9f53e9 Reviewed-on: https://gerrit.libreoffice.org/81945 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1455214 Uninitialized scalar variableCaolán McNamara
Change-Id: I90ef15645eaa70a166aa1940b1b296c299aee0e2 Reviewed-on: https://gerrit.libreoffice.org/81939 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1455209 Wrapper object use after freeCaolán McNamara
Change-Id: I5883d2d954d62301c8d6ca47ceedd6401aee1dc6 Reviewed-on: https://gerrit.libreoffice.org/81935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1455208 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ie9b2503e474cc95acd040364573a4b434cabc14e Reviewed-on: https://gerrit.libreoffice.org/81934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1455210 Dereference before null checkCaolán McNamara
Change-Id: Iadf78e41afabc8e3468e23bd5b249e47c019c843 Reviewed-on: https://gerrit.libreoffice.org/81936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1455211 Dereference after null checkCaolán McNamara
Change-Id: I73ce64812d4ff88f7b1d0e122c208d64f04b893d Reviewed-on: https://gerrit.libreoffice.org/81937 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1455215 Improper use of negative valueCaolán McNamara
Change-Id: I0a397cb54192b613bf61a8faa384507b9731b828 Reviewed-on: https://gerrit.libreoffice.org/81940 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02weld SfxRecordingFloat_Impl utility windowCaolán McNamara
we can't abuse action_name anymore as the uno command are not legal actions Change-Id: Iaf9306c6e3eec852d2a50df9161bd20383881a04 Reviewed-on: https://gerrit.libreoffice.org/81902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02Table panel: Make sure all toolbox buttons has the right initial stateTamás Zolnai
For this we need to add a ControllerItem for all toolbox buttons. See SfxStateCache::SetCachedState(). Change-Id: Id69a92fe5748617e3cd98c3007afbff2885a5d3b Reviewed-on: https://gerrit.libreoffice.org/81899 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Remove useless bool manipulation.Tamás Zolnai
Must be a left over of sal_Bool -> bool conversion. Change-Id: I8b37e513dc1f36b015b29ce3dad4ade2df7807d9 Reviewed-on: https://gerrit.libreoffice.org/81898 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Make sure Row Height spin button works with the default size typeTamás Zolnai
SwFormatFrameSize() object has ATT_VAR_SIZE size type by default, before we change it to anything else. We will change ATT_VAR_SIZE to ATT_MIN_SIZE when changing the row height on the sidebar panel, similar to the row height dialog. Change-Id: I2520340e023b910549ff2a4b011e9ae3da2b7b11 Reviewed-on: https://gerrit.libreoffice.org/81897 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Redesign the panel a bitTamás Zolnai
* Remove some labels. * Move 'Merge Cells' button next to the insert / delete buttons. Change-Id: Ibe0acc8e8825dbaa84464bc7347f7711f8185680 Reviewed-on: https://gerrit.libreoffice.org/81896 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Implement functionality of Column Width spinbuttonTamás Zolnai
Change-Id: I809cfe4af82cebabe80c171cdd488ff43d749a86 Reviewed-on: https://gerrit.libreoffice.org/81895 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Implement functionality of Row Height spinbuttonTamás Zolnai
Change-Id: Ic3e3ce31fdc74c9cb4c41e1243f10f5977d5bb0c Reviewed-on: https://gerrit.libreoffice.org/81894 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Add new 'Table' sidebar panel to WriterTamás Zolnai
This is the initial layout of the panel. It does not functional yet. Change-Id: Idd67ed921b71559bb704ef50cbfa97013fb80d6b Reviewed-on: https://gerrit.libreoffice.org/81893 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-01tdf#126128 Reduce page properties dialog's height.Gülşah Köse
Change-Id: Ie35c9cb4c9b134a94f3a125dd800936b7160950c Reviewed-on: https://gerrit.libreoffice.org/81910 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-11-01Removed executable permission on src fileAndrea Gelmini
Change-Id: Id4dc99968fc453f5ab3ee5e7b30bfacf79e843b7 Reviewed-on: https://gerrit.libreoffice.org/81867 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>