summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-11-03tdf#157664 Drop operator !=, where respective operator == is definedAnkit_Jaipuriar
Change-Id: I88b25dd676fc57303978e3d5e875af129240b676 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157762 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-11-03sw a11y: No longer report underline for misspellingMichael Weghorn
No longer report a red wavy underline for misspelled words in Writer. The underline isn't really a character/text attribute, since it's not part of the actual formatting of the text, but is just shown visually. Each platform a11y API has a better way to explicitly report misspelling. commit ec2e02cfa41510c3d30b118cbf7595c84a046d03 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Oct 17 14:36:58 2023 +0200 tdf#157696 a11y: Report spelling error via IA2 "invalid:spelling" attr and commit 2bf88c172c9c9d159344b95fb96073f4891a6c30 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Oct 18 13:44:42 2023 +0200 tdf#157696 wina11y: Switch from custom to IA2 text attributes added the implementation for Windows and the Qt-based VCL plugins on Linux. On macOS (`NSAccessibilityMarkedMisspelledTextAttribute`/ `NSAccessibilityMisspelledTextAttribute`) and for gtk3/ATK, the corresponding attributes were already used before. Therefore, reporting an underline as a workaround is no longer needed. Orca on Linux, NVDA on Windows (with [1] in place) and CrossOver on macOS all make use of the specific character attribute to announce spelling errors, not the underline. If any assistive technology should stop reporting spelling errors due to this change, it should be fixed to handle the proper text attribute as well. After switching to text attributes according to the IAccessible2 specification on Windows (i.e. with, the above-mentioned commits and the NVDA commit to switch to IAccessible2 text attributes for LO [1]), NVDA was starting to announce not only that a word is misspelled, but an underline in addition, which is no more the case now that the underlining is no more reported. [1] https://github.com/nvaccess/nvda/commit/de4e8814f39ab6ae9fbc5330b007494ef6888cd3 Change-Id: Ifa29e0080a4a039c5a119dd0debe5e924fa546ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158847 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-03macOS a11y: Drop obsolete TODO to implement spelling error attrMichael Weghorn
Handling for `NSAccessibilityMisspelledTextAttribute` and the newer `NSAccessibilityMarkedMisspelledTextAttribute` [1] has been added in commit db0fa92637a1b2edf26da9917c9dce050ebc8a78 Author: Boris Dušek <me@dusek.me> Date: Sun Aug 11 16:37:48 2013 +0200 fdo#67980 - VoiceOver does not inform about misspelled text and VoiceOver announces misspelled Writer text as such, so drop the obsolete TODO. [1] https://developer.apple.com/documentation/appkit/nsaccessibilitymarkedmisspelledtextattribute Change-Id: Id8ae1ee660e87c06ac7f559b5cdf1b31e22aef90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158840 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-03tdf#156478 Remove unused default values for MediaBox and UserUnitTobias Kokolakis
Change-Id: Ica75be2fa238fdf2a40e274f1175710923b281e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156468 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-03gbuildtojson: announce every targetMike Kaganski
vs-ide-integration takes tens of minutes on my system; and most of the time, it didn't output anything to the terminal. Every target handled by gbuildtojson takes ~2 s; with more than 870 targets, it makes sense to show the progress to avoid making an impression of a hang. The "GBJ" abbreviation (for "gbuildtojson") was not used in the output before. Change-Id: I71ab3ae59d1034f47140aad0dab6ed170140acb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158846 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-03NFC related tdf#158031 editeng: flatten and simplify the codeJustin Luth
No Functional Change intended. Just some slight optimizing that leads to some nice flattening. Change-Id: I46d20a56821f218973c728f51575b104e6020500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158854 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-11-03tdf#157801 Fix direct formatting is applied after pressing OK in theJim Raykowski
Character properties dialog when the Highlighting tab Color page is open and the color has not been changed This is noticeable when character highlighting direct formatting is already at paragraph level. The expected result of opening the properties dialog, and immediately pressing OK without changing anything (or alternatively, after changing something there and then pressing Reset then OK), is no changes in applied properties at all. Inspiration for rework of the background tab page. With this patch XATTR_FILL items need not be included in the InAttrs set, for example, as part of this patch, the XATTR_FILLSTYLE, XATTR_FILLCOLOR range is removed from the sw_CharDialog core set. Change-Id: Ic2de53a29579c33820fc381d354a4afebe048a5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158100 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-11-03tdf#158039 sw track changes: fix cycle case of selected sentencesLászló Németh
Previous tracked changes of cycle case weren't removed, if the selection doesn't end in a tracked change, i.e. sentences with punctuation, or selections end in a capitalized word etc. Fix also lost selection of multiple selected nodes. Follow up to commit 4cf8de89bad9143a5b2dd3d6351080bf62b76029 "tdf#157667 sw track changes: fix cycle case on multiple words", commit dc748d7dbd114fbf663752258dbaf003af2926c3 "tdf#141198 sw: fix cycle case with change tracking" and commit 79435eb55ef226fb0e3507aabdc2f8af062680f6 "tdf#157988 sw track changes: fix cycle case on a selected word". Change-Id: I24476c359200a25ca9bcd467c33b0ebeb1afb037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158804 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-11-03SwNavigator: Improve field content sortingJim Raykowski
Shave some time off sorting field content entries for documents with large number of fields by eliminating a second sort and the loop used to determine if a second sort is done because a field is found in a frame. Also corrects ordering of fields in nested frames which prior to this patch are placed at the beginning of the field content entries. Change-Id: I5fbd67b6fb0ac1ef49a5df7721bb209d4cba4013 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158606 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-11-02Related: tdf#157939 put CppunitTest_svgio under non_application_font_use:abortCaolán McNamara
Change-Id: Ib48e8045ad739b6f6fe98ab00cd609b54d4c3113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158843 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-02tdf#157939 drop duplicates from the FontConfig SetCaolán McNamara
when we drop them from our own font list, that way we don't get suggestions for glyph fallback which we can't satisfy Also prefer our application fonts to system fonts when they share the same version number where they should be the same, but more than once we have a system-side font with oddities. Change-Id: I90bd3311e0f37bacd60d20e1c1a6769b551b8b76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-02this should never be null, so we can use a referenceCaolán McNamara
Change-Id: I682e30cfb4fd63a4f906bfb875cafdf77ae9cfe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158805 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-02crash seen in EditView::GetTransferable in calcCaolán McNamara
if (pColor->getComplexColor().getType() == model::ColorType::Unused) (gdb) print pColor $10 = <optimized out> but: (gdb) print *pSet $12 = {_vptr.SfxItemSet = 0x7f7cd56f3198 <vtable for SfxItemSet+16>, m_pPool = 0x31e7d880, m_pParent = 0x0, m_ppItems = 0x33ecece0, m_pWhichRanges = { m_pairs = 0x7f7cd47b2480 <svl::Items_t<(unsigned short)4008, (unsigned short)4064>::value>, m_size = 1, m_bOwnRanges = false}, m_nCount = 1, m_bItemsFixed = false} (gdb) print *(pSet->m_ppItems) $11 = (const SfxPoolItem *) 0x0 so, apparent null deref of pColor #0 SvxUnoTextRangeBase::_getOnePropertyStates (pSet=0x7ffe47b3ded0, pMap=0x7f7cd5a50600 <ImplGetSvxTextPortionPropertyMap()::aSvxTextPortionPropertyMap+384>, rState=@0x38ae2d4c: com::sun::star::beans::PropertyState::PropertyState_DIRECT_VALUE) at editeng/source/uno/unotext.cxx:1179 #1 0x00007f7cd1e6f5be in SvxUnoTextRangeBase::_getPropertyStates (this=0x3543bc00, PropertyName=..., nPara=nPara@entry=-1) at editeng/source/uno/unotext.cxx:1057 #2 0x00007f7cd1e6fa12 in SvxUnoTextRangeBase::getPropertyStates (this=<optimized out>, aPropertyName=...) at editeng/source/uno/unotext.cxx:1031 #3 0x00007f7cd41e723b in (anonymous namespace)::FilterPropertiesInfo_Impl::FillPropertyStateArray (this=this@entry=0x32e94820, rPropStates=std::vector of length 0, capacity 0, rPropSet=..., rPropMapper=..., bDefault=bDefault@entry=false, pOnlyTheseProps=pOnlyTheseProps@entry=0x0) at xmloff/source/style/xmlexppr.cxx:327 #4 0x00007f7cd41e9230 in SvXMLExportPropertyMapper::Filter_ (this=this@entry=0x34dc72a0, rExport=..., xPropSet=..., bDefault=bDefault@entry=false, bEnableFoFontFamily=bEnableFoFontFamily@entry=false, pOnlyTheseProps=0x0) at xmloff/source/style/xmlexppr.cxx:651 #5 0x00007f7cd41ea026 in SvXMLExportPropertyMapper::Filter (this=this@entry=0x34dc72a0, rExport=..., rPropSet=..., bEnableFoFontFamily=bEnableFoFontFamily@entry=false, pOnlyTheseProps=pOnlyTheseProps@entry=0x0) at xmloff/source/style/xmlexppr.cxx:526 #6 0x00007f7cd42dbbcd in XMLTextParagraphExport::Add (this=this@entry=0x37110830, nFamily=nFamily@entry=XmlStyleFamily::TEXT_TEXT, rPropSet=..., aAddStates=..., bDontSeek=bDontSeek@entry=false) at xmloff/source/text/txtparae.cxx:685 #7 0x00007f7cd42dd09f in XMLTextParagraphExport::exportTextRange (this=this@entry=0x37110830, rTextRange=..., bAutoStyles=bAutoStyles@entry=true, rPrevCharIsSpace=@0x7ffe47b3eef0: true, openFieldMark=@0x7ffe47b3ec34: XMLTextParagraphExport::NONE) at xmloff/source/text/txtparae.cxx:3731 #8 0x00007f7cd42e57df in XMLTextParagraphExport::exportTextRangeEnumeration (this=this@entry=0x37110830, rTextEnum=..., bAutoStyles=bAutoStyles@entry=true, bIsProgress=bIsProgress@entry=false, rPrevCharIsSpace=@0x7ffe47b3eef0: true) at xmloff/source/text/txtparae.cxx:2438 #9 0x00007f7cd42ea746 in XMLTextParagraphExport::exportParagraph (this=this@entry=0x37110830, rTextContent=..., bAutoStyles=bAutoStyles@entry=true, bIsProgress=bIsProgress@entry=false, bExportParagraph=bExportParagraph@entry=true, rPropSetHelper=..., eExtensionNS=<optimized out>) at xmloff/source/text/txtparae.cxx:2378 #10 0x00007f7cd42e0634 in XMLTextParagraphExport::exportTextContentEnumeration (this=this@entry=0x37110830, rContEnum=..., bAutoStyles=bAutoStyles@entry=true, rBaseSection=..., bIsProgress=bIsProgress@entry=false, bExportParagraph=bExportParagraph@entry=true, pRangePropSet=<optimized out>, eExtensionNS=<optimized out>) at xmloff/source/text/txtparae.cxx:2008 #11 0x00007f7cd42e113a in XMLTextParagraphExport::exportText (this=this@entry=0x37110830, rText=..., bAutoStyles=bAutoStyles@entry=true, bIsProgress=bIsProgress@entry=false, bExportParagraph=bExportParagraph@entry=true, eExtensionNS=eExtensionNS@entry=TextPNS::ODF) at xmloff/source/text/txtparae.cxx:1762 #12 0x00007f7cd1e78669 in XMLTextParagraphExport::collectTextAutoStyles (bExportParagraph=true, bIsProgress=false, rText=..., this=<optimized out>) at include/xmloff/txtparae.hxx:459 #13 (anonymous namespace)::SvxXMLTextExportComponent::ExportAutoStyles_ (this=0x7f7cb4522930) at editeng/source/xml/xmltxtexp.cxx:341 #14 0x00007f7cd406121c in SvXMLExport::ImplExportAutoStyles (this=this@entry=0x7f7cb4522930) at xmloff/source/core/xmlexp.cxx:1127 #15 0x00007f7cd40645f5 in SvXMLExport::exportDoc (this=0x7f7cb4522930, eClass=<optimized out>) at xmloff/source/core/xmlexp.cxx:1380 #16 0x00007f7cd1e78d64 in SvxWriteXML (rEditEngine=..., rStream=..., rSel=...) at editeng/source/xml/xmltxtexp.cxx:321 #17 0x00007f7cd1da1d0c in ImpEditEngine::WriteXML (this=this@entry=0x34f87990, rOutput=..., rSel=...) at editeng/source/editeng/impedit4.cxx:270 #18 0x00007f7cd1d88881 in ImpEditEngine::CreateTransferable (this=0x34f87990, rSelection=...) at editeng/source/editeng/impedit2.cxx:3843 #19 0x00007f7cd1d4c091 in EditEngine::CreateTransferable (this=<optimized out>, rSelection=...) at editeng/source/editeng/editeng.cxx:816 #20 0x00007f7cd1d5c91a in EditView::GetTransferable (this=0x33eb8190) at editeng/source/editeng/editview.cxx:662 #21 0x00007f7cc2c03eac in ScModelObj::getSelection (this=<optimized out>) at sc/source/ui/unoobj/docuno.cxx:904 Change-Id: Idb8cbbebe02188678f9c1b17e80cf89feffa9de8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158803 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-02add a fast path for the 1999-12-31 date in calendar conversionCaolán McNamara
seen in: https: //user-images.githubusercontent.com/833656/279971758-ef3d86b1-23ea-4e57-ad15-1f9b12df6bdd.svg Change-Id: I76f5e83860ea49e52099ece670e7c259fd89e666 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158830 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-02Clarify when the logo will be shownSamuel Mehrbrodt
Change-Id: Ie6ac8530b3351a2c9899c33932ba6ab70b246cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158797 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-02Save with latest gladeSamuel Mehrbrodt
Change-Id: Ibaa2851fede2ecd78b86388e151b4484e1ff60db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158796 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-02tdf#112661 tdf#112662 a11y: Fix toggling button via a11y actionMichael Weghorn
`PushButton::Click does not` toggle a `PushButton` that is a toggle button. Therefore, call `PushButton::Check` and `PushButton::Toggle` instead when the acessible "press" action is performed on a toggle button, which makes this work as expected. The same is already done in the UITest code, see `ButtonUIObject::execute`. The originally rerported issue in tdf#112661 and tdf#112662 was that there was no action available for the "Templates" and "Recent Documents" toggle buttons in the start center via the NSAccessibility API on macOS at all. By now, the "press" action was available, but performing the action (e.g. using the Ctrl+CapsLock+Space keyboard shortcut for VoiceOver) didn't have any effect. The same was true when performing the action via Accerciser using the AT-SPI Action interface when using the qt6 VCL plugin on Linux. With this change in place, toggling between showing the templates and the recently used documents in the start center works using that action, just as it does when clicking on one of the toggle buttons in the UI using the mouse. For gtk3, which is using native GtkToggleButtons, this was already working without this change in place. Change-Id: Ie3f02ec914239e0718ca1bfb4ba701f0831bb16a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158807 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-02Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 846a915406627d0663080fd22b26aa6a2f12c48e - update translations for master and force-fix errors using pocheck Change-Id: I1ac45a9287f6a2b5f00788a065fd85e3da4548f4
2023-11-02Related: ofz#63786 make it clearer what m_aShortSprm is used forCaolán McNamara
its not used as a SVBT32, only as a little buffer Change-Id: I7a6d364c68ae31520cbb7432da832d108a9daeff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-02'new Character' is deprecated in JavaNoel Grandin
replace with Character.valueOf Change-Id: I9938db0fce6490eba6f4900efc3c139a1b71d120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158786 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02tdf#157860 - UI: Part 14 - Unify lockdown behavior of Options dialogBalazs Varga
for Load/Save VBA Properties Page. Change-Id: I9526c2a5aa25fbdea1edbc0051d9b6a29c643d8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158781 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-02resave with latest gladeBalazs Varga
Change-Id: Id4482f53a84e93f44c1a0cda2d20bf3ece48d44a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158762 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-11-02VS IDE integration: enable Python pretty printers when debugging a WSL buildMike Kaganski
See https://learn.microsoft.com/en-us/cpp/linux/deploy-run-and-debug-your-linux-project#debug-with-attach-to-process Change-Id: I16d50ebe5f087518de1953ea1f9aad4180714cc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158789 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-02'new Double' is deprecated in JavaNoel Grandin
replace with Double.valueOf Change-Id: If5be8e500e31ebf9d5fb20ea7dd474677d7c74ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158785 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02'new Float' is deprecated in JavaNoel Grandin
replace with Float.valueOf Change-Id: Ib6408b24dac2953789d0ec67e73b8be8aefca252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02tdf#156565 sw: PDF/UA export: split Link SE at line breakMichael Stahl
There must be one Link SE per Link Annotation, so ensure that a new one is created for a new line. (regression from commit 4c5283a3a11008a06a995c49ed777734dc1f6066) Change-Id: I2585d9e22a435d7716f48fec89a78149c129f71d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158775 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-02Localize <FollowPage> to CatalanJoan Montané
Change-Id: I088047a94f2bd7a7405cf42e9c0eca73cdb11c6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155776 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-11-02sw: PDF/UA export: produce Link SEs for RTL textMichael Stahl
This is a SwBidiPortion containing a nested SwLineLayout containing SwLinePortions for the link or text, and only the SwBidiPortion had a tag helper, so add one for the inner portion too. (Apparently this never worked before.) Change-Id: I803191dafe101a42e4dbe1c0167411c2f1f76a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158773 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-02sw: SwLinePortion::Move() should be constMichael Stahl
Change-Id: I79938773034fbe708ba867960c9effecb2e24a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158766 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-02tdf#157816 sw: PDF export: filter out links on empty space, INetAttrsMichael Stahl
Several problems here: * As with fields, there may be selection rectangles with no text * SwRootFrame::CalcFrameRects() adds flys that are anchored in the selection to the selection * A fly text portion causes Link annotations to split, but not Link SE * If a fly only partially overlaps a line vertically, then CalcFrameRects() produces a full-width half-height rectangle and another 2 half-width half-height rectangles on both sides. This is useless, the rectangles must be full line height. Add some code in CalcFrameRects() to use the fly portions in the SwParaPortion instead of the fly frame areas. Change-Id: I93f0c12a5e5a3d5f51fcc4b33052a112e9174863 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158576 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-02tdf#157816 sw: PDF export: filter out links on empty space, fieldsMichael Stahl
If there is a fly overlapping a paragraph, it may happen (depending on wrap settings and position) that there's an empty space on one side of the fly; the cursor selection region has the flys removed, and this region is used here for the PDF export. So there is a rectangle on the text on one side of the fly, turned into the desired Link annotation, and another rectangle on the other side of the fly, turned into another undesired Link annotation that isn't connected to any SE because without text there is no SE. This is a tricky problem, and the only idea to fix it is to try to see if there is text in the rectangle by first GetModelPositionForViewPoint() resulting in a SwPosition and a SwSpecialPos with an index inside the field; then see if GetCharRect() for this position returns a cursor rectangle that intersects the original selection rectangle. Change-Id: I6918eac16690e7194208a828108bfa968d28d12a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158571 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-02tdf#157816 sw: fix getting position in field portion followMichael Stahl
SwSpecialPos can be used to get index inside a field, but SwTextCursor::GetModelPositionForViewPoint() has several problems: * the field portion follow has length 0 so an early return is taken * the nCharOfst is set to the index in the portion, but it needs to also count preceding portions of the same field in the line, and nLineOfst needs to be set as well, because the SwPosition corresponds to the start of the field * m_bFieldInfo must be set to guarantee SwPosition before the field in the nLenght==0 branch, but then there are 2 branches that first set nLength=0 and then decrement it, resulting in a SwPosition 1 char before the field. Change-Id: Ib7d30981e41b40f4c068fa6d84211c000ecde753 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158570 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-11-02tdf#158038 fix opening pdf files in appstore ver (sandbox issue w/ helper tool)Christian Lohmaier
https://developer.apple.com/documentation/xcode/embedding-a-helper-tool-in-a-sandboxed-app "Adding other entitlements to the tool can cause problems. If the tool immediately crashes with a code signing error when your app runs the tool, check that the tool is signed with just these two entitlements: com.apple.security.app-sandbox and com.apple.security.inherit." This is indeed what happened.. Change-Id: Id03948c03b7d453aae4ca58719f582576e30a16f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158790 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-11-02Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to eb5efb80b63d29c6d4ec84c0c35b9b4a0298a5f7 - Fix typo Change-Id: I7821feb7aff0b9c4833d53c71e0b58799deab916 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158788 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-02Improve and extend STYLEREF testsSkyler Grey
- I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19, Ib664fec059aa1f7f130acc76c253d5d298fa59f7 and Iad8e8001807f5ceeaedc9665838672695174a936 added STYLEREF flags. This commit adds tests for them - The tests in I35dc36197b62fa53def4745da1d4755ece79ed22 were partly broken due to the fields occasionally being inserted in the wrong place (i.e. at the end of the document), this commit makes sure to move the cursor before inserting a field - The tests in I35dc36197b62fa53def4745da1d4755ece79ed22 were not separated into sections which made it difficult to tell what was being tested. All STYLEREF tests that create documents are now clearly split into arrange/act/assert steps with comments denoting the sections - The tests in I35dc36197b62fa53def4745da1d4755ece79ed22 had a lot of repetition, particularly in creating the document, adding headings, etc. This has been refactored into some helper functions - I35dc36197b62fa53def4745da1d4755ece79ed22 was missing an ODF import test. This commit adds one Follow-Up-To: I25dd7a6940abee5651a784b9059fe23b32547d6c Follow-Up-To: I35dc36197b62fa53def4745da1d4755ece79ed22 Follow-Up-To: I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19 Follow-Up-To: Ib664fec059aa1f7f130acc76c253d5d298fa59f7 Follow-Up-To: Iad8e8001807f5ceeaedc9665838672695174a936 Follow-Up-To: Iecd3e83a6bd3f8c2c6adba5c7eba9ee55b773510 Follow-Up-To: Ifaa67fbc2d53b0d4fb85e7305b2dbdf78cf0a1ad Follow-Up-To: Id991c92b9aeaa054b136f7a3d9c7c8ea0026e514 Change-Id: I941b477c8e860270a400869cb9ea15e5561e402a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158352 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-02MSI: Fix Signature table's FileName column typeMike Kaganski
It was "Filename" [1] since commit 68d28e25348ced2619733d8b177423d3aefab900 (#i28464# ooo native installer, 2004-05-24). But according to the spec [2], it should be "Text" [3]. Found accidentally, because of an MSM bug in VS 2022 [4]. The unnecessary entries there for Signature table conflicted with ours, preventing merge. [1] https://learn.microsoft.com/en-us/windows/win32/msi/filename [2] https://learn.microsoft.com/en-us/windows/win32/msi/signature-table [3] https://learn.microsoft.com/en-us/windows/win32/msi/text [4] https://developercommunity.visualstudio.com/t/Microsoft_VC143_CRT_x64msm-v14363253/10505819 Change-Id: I9911b8c02df57f202d197c634b565ce74b35d7e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158783 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-11-02vcl: removed redundant checkVasily Melenchuk
Change-Id: Iec2c344df9eb1fa61bb04355c3eee38499edcdac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158422 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2023-11-02tdf#104288: rtf export: drop \nonshppict on exportVasily Melenchuk
- these days hard to find a reader not able to read shapes - RTF file will became compact without pictures duplication - WordPad nowadays is able to display shape pict, no reason for fallback - Fixing possible rtf file bloat on exporting some WMFs Change-Id: Icc8b60da6541acef939f42021d8d5e81bbcd1ae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158507 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2023-11-02Drop SvxHtmlOptions::IsPrintLayoutExtensionGabor Kelemen
as it is just now a simple wrapper over officecfg Change-Id: If41c7c9db191af7ebede9072fd995d015056bf1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158779 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02Fix typoStephan Bergmann
...spotted by Ilmari Change-Id: I7414d77d91a4d11d16de1417e60cddf72a0746c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158782 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-02tdf#156670 Add 'Alt text' command to shapes popup menuGabor Kelemen
Change-Id: Ib55491cb4d209088cfed344452700eab41da67d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158763 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-11-02Revert "WW8PLCFx_PCDAttrs::m_aShortSprm can be local"Noel Grandin
This reverts commit 2779984709d24ad263547407069a5da0fda36ceb. Reason for revert: we are storing a pointer to this field Change-Id: Idce917f676f2f1f845f4f4a3ea6dd911818c3eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158707 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02tdf#157956 convert ellipses to quarter rounded circlekhushishikhu
The change is about corner rounding of a 'Flowchart Alternate Process' shape. The quarter circles remain circles even after stretching the shape. Change-Id: I4ecaba9a9f39cfb797e248eb4728ed7dea844f5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158580 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-11-02Adapt to Clang 18 trunk ElaboratedTypeKeyword reworkStephan Bergmann
<https://github.com/llvm/llvm-project/commit/4ad2ada5216ee2bb3c334a3233a9ab51f2521b82> "[clang][NFC] Refactor ElaboratedTypeKeyword" Change-Id: I1ee6592fe76bb484441ca859986e7217eaba58f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158764 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-02uitest: check that dialog really did openNoel Grandin
to make it easier to debug cases where the event.executed flag is not sufficient to indicate that the dialog has finished opening Change-Id: Ibcbd089372e47908e3692d452f4064edbc7f788d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-02Update pointers to yet again moved ICU site / CLDR pagesEike Rathke
Change-Id: Icf33b45a013393ac114e5a8866921bc8ce368189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158778 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-11-01Writer: German language shortcuts.Gökay Şatır
* CTRL + M for incrementing the tab indent. * CTRL + SHIFT + M for decrementing the tab indent. Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: I1dcf87808cdf1a0e4c91666557531e7550878236 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157583 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit b90c1c15fbbe01e5343cfc384c2cb427e76908a0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158777 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-01Writer:Gökay Şatır
Added ALT + SHIFT + UP and ALT + SHIFT + DOWN combinations for: * Moving paragraphs up and down in the document. Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: I5aef03456bce1cfd66349f41cae0ef37889ef0bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157520 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 6b68b8c4819139c54072d2f28186b1fb6d937d56) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158776 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-01sc: Fix conditional formatting icon set order for smiliesofftkp
The order of these icon sets was not consistent with other icon sets (traffic lights, flags, circles) and Excel Change-Id: I5cbc2ff96118530420341f6994310f946717e0d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158703 Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> Tested-by: Jenkins
2023-11-01macOS a11y: Don't report (non-)expanded state when not expandableMichael Weghorn
When the a11y object is not expandable, also don't report a true/false value for the expanded state on macOS. Otherwise, the CrossOver screen reader on macOS will explicitly announce "collapsed" for these objects, e.g. when moving focus between paragraphs in Writer (as reported on the a11y mailing list [1]) or between toolbar butons, since `isAccessibilityExpanded` gets called and returns false, so it is assumed that this is an expandable item that is currently not expanded, i.e. it is collapsed. Quoting from the NSAccessibilityProtocol doc [2]: > You can control which accessor methods the assistive app can > use by overriding isAccessibilitySelectorAllowed(_:). > Return true if the assistive app can call the selector; > otherwise, return false." [1] https://listarchives.libreoffice.org/global/accessibility/msg01068.html [2] https://developer.apple.com/documentation/appkit/nsaccessibilityprotocol: Change-Id: Iac9027a598e5793d6bd0da79212d7b07448a4c34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158733 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit (git 2.34.1) at 2025-01-25 19:01:16 +0000