Age | Commit message (Collapse) | Author |
|
caused by commit e79741488cc740f49ebd4426c40b45e7139ff663
Change-Id: I04fe66124af831c73834b7f695458e1667198ddb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149470
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
after my patch to merge the bufferadd loplugin into stringadd
Change-Id: Ieac16a01fde6467a2f6fe47864069304a3c44e47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149552
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
notifyEach was changed to lock the mutex before returning.
Change-Id: I0dc0e11e51e28890e98035cf8356846f9b49c436
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149575
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
after my patch to merge the bufferadd loplugin into stringadd
Change-Id: I625a0adf89f54ea25f0377a266c37acf9a37d723
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149550
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
A fly that has text wrap through it does not need to be considered
for table offsets.
Change-Id: I1b1e58bca3f59d8789581f978f15355c2d4d7ee0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149465
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
|
|
basically disabled back with:
commit cc93f06f93eeaaee5811588d90929ebc72bf9724
Date: Fri Apr 23 12:28:26 2010 +0200
#i111108# do not prefer fontconfig familyname because of i79878
to avoid stuff like "DejaVu Condensed" getting reported as "DejaVu" with
a "Condensed" style.
Rather than reopen that problem, just tweak analyzeSfntFamilyName to
use the UI lang instead of the system lang as the preferred lang.
Change-Id: I41f128d1a21397ff7880f34985c1553b890b4747
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149542
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I03624956bebc7c6ce435482bc7cc5fc8b3fc31cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149547
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I352d66bf6926a1d839de538dd02d1f2f7c355da8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149461
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
frmpaint.cxx:801: SwTextFrame::PaintSwFrame: Assertion `!isPDFTaggingEnabled || oTaggedParagraph || rRect.GetIntersection(getFrameArea()) != getFrameArea()' failed.
This happens because the SwNumberPortion is outside of the
SwTextFrame 16's area so it is not painted at all (table cell clipping).
The first-line indent is incorrect 1233 instead of 2084
because in SwTextMargin::CtorInitTextMargin() the mnLeft is incorrect
2084 instead of 2935 because it erroneously took the branch to set
mnLeft = m_pFrame->getFramePrintArea().Left() + m_pFrame->getFrameArea().Left()
because the nLMWithNum check wasn't adapted to the change of including
the text-left-margin in it.
(regression from commit 92280ad0c65a3d1b5aa8ac77c87ec6a964389a01)
Change-Id: Ic7cd2b272a79e70cb5e0313bb6bcf1e909c3a68a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149538
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
add frame to checkboxes under "For Selected Entry"
add grid for navigation buttons
add typographical quotes to extended tips
add missing colons to three "Phonetic reading" labels
Change-Id: Id630febb01165e4a0faf1a228e436457867748da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148695
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Similar to commit f3ffdc1a5fe965016550f20ada405ef638bf5f75
(Introduce non-static query() and queryThrow() to css::uno::Reference,
2023-03-23), this adds a syntactic sugar for css::uno::Reference ctors:
css::uno::Reference<css::SomeNamespace::SomeInterface> xSomeInterface(anAny, css::uno::UNO_QUERY);
would become
auto xSomeInterface(anAny.query<css::SomeNamespace::SomeInterface>());
and
css::uno::Reference<css::SomeNamespace::SomeInterface> xSomeInterface(anAny, css::uno::UNO_QUERY_THROW);
would become
auto xSomeInterface(anAny.queryThrow<css::SomeNamespace::SomeInterface>());
Change-Id: I06f8d97fe200a7dd03ecc965a431eb54b10a3c91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149549
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
In order to see wether this test keeps failing in the new file
or it's affected by another test
Change-Id: I73ef0287a81d0ea8c2b26f466cd0d623a62933c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149543
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ic7d3a63516aae263aaffec9fba9d9673469bede4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149445
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
The function thought it was dealing with a wrap-through shape,
but actually it is wrap parallel.
Attempts to syncProperty of RES_SURROUND meet with instant disaster,
and likely this emulation works better if the doubled-up shape
only has one wrap anyway.
There is a helper function for this after all,
so that highly suggests workarounds are necessary
instead of just syncing the wrap property.
There were two existing unit tests identified:
-tdf123163-1.docx (doesn't even open in MS Word 2010/2003)
-testCustomShapePresetExport.odt (on round-trip)
-no differences noticed.
Change-Id: I7b0828ce6406fa9cfb1debb68040ea02e8d6fe45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149463
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
Change-Id: I8106dc197585b823b52d675698533e8a5167819b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149537
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
it already has 109 tests
Change-Id: I1e7adf3fa9c1cdb22fb1402306c2f9478d94038c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149546
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Iab8001f8be8a8af437e8898079d55ff57dd6fa3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149494
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Iea1190aa7e0b9d81a8cf73ebbafd318e73fca757
|
|
after my patch to merge the bufferadd loplugin into stringadd
Change-Id: I66f4ce2fd87c1e12eefb14406e0e17212f68ceff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149497
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to ed90b5c51e0cda59e30995bbfb26d9ea69123fe8
- tdf#154364 (part) refactor "related topics" for swriter/guide/
Change-Id: I16d60d69f8ab0e5c79079ad54ad58752673082c7
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149544
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 1cb08818a1cc6b2ea566316b7904dc77749028e1
- Fix bad link for SUMIF
Change-Id: I8f7bfe2a4427c5465d8bd428fd58510cf90cca57
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149473
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 3b91921b052201ce082d96fa3d9c8d85170808c5
- Fix menu path for color bar in Impress
+ PLus refactoring
Change-Id: I4c6fe7d906fb63fa1a2b293ed7f7a161e9548634
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149471
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 47a4762f1c5c7f208beaada82f71995ea084d923
- fix dead link to Modify or Insert Layer
Change-Id: Ib708c5314136143dc6c3b43e1e906b4d7c6d66ed
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149516
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 742aa91199f41ef96f1b47bbc163b7c3bb6e2a9d
- tdf#154335 Deprecate layer_new.xhp in favour of insert_layer.xhp
+ refactoring for XML simplification
+ #2 replace layer_new by insert_layer
Change-Id: I12e7bac9da6652d5b3d98e8a4cee0eb40aa9c627
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149474
Tested-by: Jenkins
Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
This reverts commit 5b07acbf3345918f450fccf7ee243ad5bcb3fd67.
The reverted commit claims that
"This option is stored at the document level like the other
layout options."
which is not true. The option is saved in the user profile,
which makes other documents to look wrong.
Reverting for now until it's implemented at document level
as the commit suggests
Change-Id: I2ae0daeb410090949f1b6cfc8245b711fe518216
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149541
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I4cc8dbd5a315844f858bf60e3b5b949c4adb1f58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149535
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
itrpaint.cxx:421: void SwTextPainter::DrawTextLine: Assertion `!roTaggedParagraph' failed
because the first portion is a SwKernPortion due to some text grid.
(regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
Change-Id: I95b87871b7db3c7ced223b477b9f7522c1622d69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149469
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
The code is now in vcl/source/gdi/formpdfexport.cxx
Change-Id: I07ca1d87eedadc9778e08a491a77adc88f393586
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149468
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: Ic5a86254b5d969c8242c124fa0515e4f1537114f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149460
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
after my patch to merge the bufferadd loplugin into stringadd
Change-Id: Ieb9b4f5154173738e26b429b55c7a3ea38733553
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149478
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Pressing the "down" key in the middle of the last line of the A1 cell on
page 1 went to the end of the paragraph instead of going to the A2 cell
on page 2.
The problem was that fly frames don't have a "next" pointer to the
follow fly frame, so the cursor travel code thought there is no follow
frame to jump to.
Fix the problem similar to how explicitly chained frames do this in
lcl_FindLayoutFrame().
While at it, also fix the the "up" direction.
Change-Id: I8dd0c2d011300520b126abf3ca8d17722ab5ff92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149476
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Introduces ODF import/export for ParaTabStopDefaultDistance
(loext:tab-stop-distance).
Also adds a unit test that covers import & export of the
property.
Change-Id: I8a69a9e2b73e8f1172f92dc35fada901f4b887f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148540
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Ideally SwFrame should not really know anything about footers.
Change-Id: I5fe349b0a9bf11f84649d6f274c2620b7563174d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149472
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I6af7a8933662dc5b8585c14d1cb66e2aad883252
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149444
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I5d0fc2a4b078e49be684b4a9b8a27f6059d9e5c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149475
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Change-Id: I3d356905fe8548dbf6a72169f72f1d4b741d63c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149454
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
in favor of sidebar deck
Change-Id: I2daf34edbe71341ebc44ca9b966c97f8e494d583
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149433
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: I5234aca76153e1a781b7df1d3fbea8bb856af921
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149430
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: Ic3f347b9a588bda459411f917be47cbfa442d3e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149459
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
to better distinguish it from nAnimCount
Change-Id: I2fc5912964e8d48a991dfe0d755e5ce27d9e0905
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149458
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
e.g.
https://crashreport.libreoffice.org/stats/crash_details/b68d5267-16b1-4ee9-bd42-bdcecdb7043c
this went wrong with:
commit 91bc1e6a8c92a7c895f0ba9dcad9ac4d35f3f791
Date: Sat Jun 25 10:21:17 2022 +1000
vcl: extract function Animation::RenderNextFrameInAllRenderers()
Change-Id: Iaccf12b251ffe06e24813c48ba3a169d0eaaa61c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76416
which substituted mnAnimCount with nAnimCount which is a subtle one char
difference, but mnAnimCount is a different thing entirely than the (then
local variable) nAnimCount. mnAnimCount is the count of animations
active, not the number of animation frames in a specific animation.
orig code was const size_t nAnimCount = maFrames.size();
so replace mnAnimCount here with maFrames.size() to get back to the
original logic
Change-Id: I11d1797eb0b9ef61addb3769d12d8364872071df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149457
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
It already has 99 tests
Change-Id: I672de980ce170b83ba84252170878731e1ce02f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149462
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Set accessible name and tooltip "Left" and "Right" for the
left and right arrow buttons, as suggested in tdf#135769 comment 6.
Change-Id: I233d7f9028b2336130475ce50a4161df0629a835
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149355
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
.. before doing any changes for tdf#135769
Change-Id: If9ae28a979c4d4c12120711b90a9361b2e90b6c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149421
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: Ife02e6d2be3ebfbb08522ab0183ef4aa31a99e19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149415
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
To do this, I re-organized FillGradientPrimitive2D and
how it creates it's decompose. This provides the needed
tooling to also do a more direct rendering in primitive
processors if needed.
The decompose no longer collects the matrices & colors
as a 1st step in a helper data struecture (so I removed
B2DHomMatrixAndBColor). It now uses a lambda function
callback that hands over the matrix & color for each
created step, so you can process it directly, in this
case to create the needed primitives.
NOTE: The decompositions are both tested. There was
createNonOverlappingFill, but also createOverlappingFill
that I am not sure is still used - and if in re-creating
an old, strange XOR-using gradient paint mechanism in
old metafiles (encapsulated with gradient info anyways),
but I converted that and made sure it works.
To do so I forced it to be used in paint. This is not
really usable in paint since we need to paint using AA
(else we would get staircase effects, esp. in new 'hard'
color changes in multi-color gradients) and - as should
be known - same edges painted in AA do *not* add up to
full opacity, but leave behind awful 'jaggies' (e.g.
opacity 0.5 and 0.5 create 0.75 and *not* 1.0). Still
important to have the working geometry creation for this
case.
This already makes the decompose faster, but the main
purpose is to use it as tooling for painting in own
primitive renderers.
Thus processFillGradientPrimitive2D now uses that
instead of using the decomposition by default.
This avoids one level of primitive creation, use
that new FillGradientPrimitive2D tooling to directly
create needed geoemtry & color for getting better
performance (to partially compensate for potentially
more expensive multi color gradients). It then paints
directly using OutputDevice calls.
NOTE: This can also be used in SDPRs as a 1st step
to just directly and rapidly render filled single-
color polygons, but of course there an implementation
using the back-transformations (which are also
adapted for MCGRs aleady and work) will be superior.
Change-Id: I5079f76d6d8fe86007a098614c276447f2bfebce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149456
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
Change-Id: I55cf235919df3c19019ca5d280f10f6720cc4f15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149416
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id29ec01a9ffefeb7da0c4e61011fff966d9cf3c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148787
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149364
Tested-by: Jenkins
|
|
rather than default to nothing selected, if we switch pages and then
back to page 1 this will be selected anyway, so start off that way
Change-Id: Ia684a5e44b12c984df3920f18b34c99693a2702c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149426
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id5cad5f2f4ac21db8675de16f1bc0ceeff39fe6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149424
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|