summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-12-11reuse RID_SECURITY_WARNING_TITLE for update links infobarCaolán McNamara
Change-Id: Ifbfb10ee373b8eca8e1019f999ac8e545f180c97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-11Fix typoAndrea Gelmini
Change-Id: Iac459eb04dda615a37631ed370907b50277a9c7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143941 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: خالد حسني <khaled@aliftype.com>
2022-12-11Replace backslashes in config params before usage in cxx filesThorsten Behrens
With cbfac11330882c7d0a817b6c37a08b2ace2b66f4, LOKit tries to pass full configure line on via JSON - which, on Windows, might contain backslashes and other nasties, so we better try to clean that up here. Change-Id: I8314783fc6f49e9b2b374d94448ed735de39bf81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143940 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-12-10Fix English on extended tipOlivier Hallot
Change-Id: I3aad959d3d309b4ee4a1095edc16d68c86a3ed0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143921 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-10tdf#152267: Strike out changed to underline in small zoomKhaled Hosny
The font has bogus value in the regular style. Add configuration support for ignoring metrics of such fonts, similar to what we do with line metrics. Change-Id: Ia7cfb44400601e89b8425c9a1144f630f67569f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143648 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-10Fix typo in codeAndrea Gelmini
Change-Id: Ic0a54ef30bd8e4350b6a47ddf9f67ae608a7e122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143938 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2022-12-10Fix typoAndrea Gelmini
Change-Id: I9bded67c9e044ed4e96f8520a3a5486b8d3ecf0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143937 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-10tdf#152455: Strings not translatable in paste special dialogJulien Nabet
Change-Id: I0c8834813af22f3de2da1f80a8895d518f66dada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143908 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-12-10tdf#152203 DOCX import: fix mixed footnotes/endnotesLászló Németh
Footnotes (like endnotes) were imported in the order of their w:footnote elements in footnotes.xml, resulting mixed footnote text content during loading documents exported from Google Docs. Import them in the order of their w:id attributes. Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357 "tdf#76260 DOCX import: fix slow footnote import". Change-Id: I7d9ed36fe96b2b90c4d62fb1ca7201318581775d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143824 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-10tdf#152029 related: Prevent crash on nullptr iter_compareJim Raykowski
Fixes crash that happens with x11 and qt5 backends when iter_compare is given a nullptr iterator to compare. Change-Id: I80995071dbc5b9e9807fc8b5cf10b0868b851ee4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143907 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-12-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3f394267138498a70430a44dcbc4cff8727ce367 - Mute L10n in code instructions Change-Id: I92f719fbd4b646809fb385360541b285a41fd3d9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143919 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-12-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 232f60bed77834ad7d1624bc88e08305fe1ba016 - More typo fixes after https://gerrit.libreoffice.org/c/help/+/143716 Change-Id: I9b550a68674b2e8ec31b3b8111186d58542686d9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143918 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-12-10Introduce CPPUNIT_PROPAGATE_EXCEPTIONS environment variableStephan Bergmann
Often a developer debugging a failing CppUnit test wants a core dump with the place where an uncaught exception is thrown. So if the newly introduced CPPUNIT_PROPAGATE_EXCEPTIONS environment variable is set (to any value), disable all the protectors that would otherwise catch such exceptions (and just report some limited information about them). Change-Id: I3052f71c0787583c496279a6f5b35a0299c357b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143882 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-10vcl: Add /Name key to Type 3 font dictionaryKhaled Hosny
Even though the spec says it is deprecated and Acrobat ignores it, several tools including Acrobat readers won’t show font name for Type 3 fonts unless there is one in the font dictionary. Change-Id: I8e65a1cf1d89744e9d89542d3540c7f3ba938369 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143903 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-10vcl: Add subset ID to Type 3 fonts embedded in PDFKhaled Hosny
This was overlooked before and can lead to duplicate font names in PDF. Change-Id: I16bd0e64663b5f62f90b91576644439079213e64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143901 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-12-10Related: tdf#152266 open 'event' page by default for SID_CONFIGEVENTCaolán McNamara
Change-Id: I7a3f6def8bda00588ef2846e5d3b5ed5d1da04de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-10be a little more explicit that we want the Accel config hereCaolán McNamara
its all handled the same way at the moment, but this is page we want here Change-Id: I8ff3e671d67d3f273fa5eb747411eab226e20fc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-10switch to the 'keyboard' tab if a SID_MACROINFO is setCaolán McNamara
Change-Id: Ie615ab2598309b0324daa11732e5345d1a927437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-10tdf#120190: sc_pdf_export: Add unittestXisco Fauli
Exporting to pdf is the only way I could find to test this issue Change-Id: I1f75d841b09d13807fb1e9e4418a58638d985870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143890 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-10Related tdf#152381: fix "lengths do not match"Julien Nabet
On console, I noticed these: warn:dbaccess:111457:111457:dbaccess/source/ui/browser/unodatbr.cxx:754: DBG_UNHANDLED_EXCEPTION in InitializeGridModel exception: com.sun.star.lang.IllegalArgumentException message: "lengths do not match at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:872" ArgumentPosition: -1 0 cppu::OPropertySetHelper::setPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (this=0x55eca23d3b90, rPropertyNames=uno::Sequence of length 6 = {...}, rValues=uno::Sequence of length 7 = {...}) at cppuhelper/source/propshlp.cxx:872 1 0x00007f39c7a7ecb6 in comphelper::OPropertySetAggregationHelper::setPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (this=0x55eca23d3b90, _rPropertyNames=uno::Sequence of length 6 = {...}, _rValues=uno::Sequence of length 7 = {...}) at comphelper/source/property/propagg.cxx:589 2 0x00007f39ac81f057 in dbaui::SbaTableQueryBrowser::InitializeGridModel(com::sun::star::uno::Reference<com::sun::star::form::XFormComponent> const&) (this=0x55eca23b1960, xGrid=uno::Reference to (frm::OGridControlModel *) 0x55eca23d3c30) at dbaccess/source/ui/browser/unodatbr.cxx:594 3 0x00007f39ac834d46 in dbaui::SbaTableQueryBrowser::implLoadAnything(rtl::OUString const&, rtl::OUString const&, int, bool, utl::SharedUNOComponent<com::sun::star::sdbc::XConnection, utl::DisposableComponent> const&) (this=0x55eca23b1960, _rDataSourceName="file:///tmp/Table_Default_Firebird.odb", _rCommand="Table2", nCommandType=0, _bEscapeProcessing=true, _rxConnection=...) at dbaccess/source/ui/browser/unodatbr.cxx:2384 4 0x00007f39ac8312ee in dbaui::SbaTableQueryBrowser::implSelect(weld::TreeIter const*) (this=0x55eca23b1960, pEntry=0x55eca243bd90) at dbaccess/source/ui/browser/unodatbr.cxx:2678 5 0x00007f39ac8343e2 in dbaui::SbaTableQueryBrowser::implSelect(rtl::OUString const&, rtl::OUString const&, int, bool, utl::SharedUNOComponent<com::sun::star::sdbc::XConnection, utl::DisposableComponent> const&, bool) (this=0x55eca23b1960, _rDataSourceName="file:///tmp/Table_Default_Firebird.odb", _rCommand="Table2", nCommandType=0, _bEscapeProcessing=true, _rxConnection=..., _bSelectDirect=true) at dbaccess/source/ui/browser/unodatbr.cxx:2445 6 0x00007f39ac8398c5 in dbaui::SbaTableQueryBrowser::impl_initialize() (this=0x55eca23b1960) at dbaccess/source/ui/browser/unodatbr.cxx:3251 7 0x00007f39ac7a3eee in dbaui::OGenericUnoController::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (this=0x55eca23b1960, aArguments=uno::Sequence of length 17 = {...}) at dbaccess/source/ui/browser/genericcontroller.cxx:259 8 0x00007f39ac718dd7 in (anonymous namespace)::DBContentLoader::load(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XLoadEventListener> const&) (this=0x55eca23aacf0, rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x55eca1f13750, rURL=".component:DB/DataSourceBrowser", rArgs=uno::Sequence of length 16 = {...}, rListener=uno::Reference to (framework::(anonymous namespace)::LoadEnvListener *) 0x55eca23b0828) at dbaccess/source/ui/browser/dbloader.cxx:230 9 0x00007f39c65f5f13 in framework::LoadEnv::impl_loadContent() (this=0x7fff7788a6e8) at framework/source/loadenv/loadenv.cxx:1154 At least from 59bc10eb4609c "INTEGRATION: CWS insight01 (1.152.38); FILE MERGED" (2004-08-02) this part seems the root pb: - Sequence< ::rtl::OUString> aProperties(6); - Sequence< Any> aValues(6); + Sequence< ::rtl::OUString> aProperties(6 + ( m_bPreview ? 5 : 0 )); + Sequence< Any> aValues(7 + ( m_bPreview ? 5 : 0 )); if m_bPreview is false, there are only 6 attributes: - PROPERTY_FONT - PROPERTY_TEXTEMPHASIS - PROPERTY_TEXTRELIEF - PROPERTY_ROW_HEIGHT - PROPERTY_TEXTCOLOR - PROPERTY_TEXTLINECOLOR Change-Id: I91cd81f87ae0685123e273fa6d106fdd22003147 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143889 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Lionel Mamane <lionel@mamane.lu>
2022-12-09configure.ac: update links to avoid redirects, fix broken links.Aurimas Fišeras
Change-Id: I7269205ecaac450123e153ea549036abd9a567d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143884 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-09Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to f5dc5a9dc64efa25a9553a0bcc4f1c94b775a15a - Fix typo Change-Id: I859153f912a952e105e6d124fa85e7f81a702d83 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143891 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-09Fix typoAndrea Gelmini
Change-Id: I96297815043ea213f67d0ccc4224b12d7bcf7d36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143887 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-12-09sw layout: invalidate margins of body content when moving a fly from pageMiklos Vajna
The (simplified) bugdoc has 9 pages, and once the ToC is updated, the two tables below the (only) bookmark in the document has a 5879 twips gap between them for no reason. Adding a new paragraph to the second table "fixes" the incremental layout. What seems to happen is that there is an anchored image on page 8, but the layout decides that it doesn't fit there so it gets moved to page 9. Before this move happens, SwTabFrame::Format() handles the outer of the nested table below the unwanted gap and its CalcFlyOffsets() notices that a large upper margin is wanted so that the table wraps around the anchored image. Later the image gets moved to the next page, but the removal doesn't invalidate the print area of the table with the large top margin, so the unwanted gap appears. Fix the problem by looking at the old page in SwPageFrame::MoveFly() and walking through the immediate children of the body frame: if the frame print area is invalidated, then SetYMargins() is called from SwTabFrame::Format(), which also invalidates the size of the outer table frame, so it will use Shrink() to have a correct size. This appears to be a regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb (tdf#134298 sw: layout: remove left-over page frame without content, 2020-11-13). Change-Id: I0424d9eea4d8a030959f8534985950c7efad4686 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143881 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-12-09tdf#143311 offapi,oox,writerfilter,xmloff,sw: decorative flag on flysMichael Stahl
* sw core RES_DECORATIVE as a FRMATR * sw API SwXFrame property "Decorative" * UI checkbox "Decorative" * ODF import/export as loext:decorative on draw:frame * DOCX export * DOCX import - very non-obvious how to get it from model.xml to dmapper * PDF/UA export: tag flys with this flag as Artifact * test for DOCX filters, ODF filters, PDF export Change-Id: I1ceb67fdd4e1cfa212aafdeb1c5f4ccd873d433e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143815 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-09tdf#150578 sw track changes: fix table toolbar at row deletionLászló Németh
In Hide Changes mode with enabled change tracking, table row deletion disabled the table toolbar, so it wasn't possible to repeat the click on the toolbar deleting multiple rows row by row. Follow-up to commit 16c705ec0d1ab4b4428577ccb0ea3fc14ee0fc88 "tdf#148849 sw: fix cursor pos at tracked DeleteRow in Hide Changes". Change-Id: I297bae405cb24f7090144344947c01a1dadf9261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143876 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-09Related: tdf#146395 drop default textCaolán McNamara
Change-Id: Iaeedf11df5f1d5739ec247222cc4fc1f10abe1e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143875 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09Related: tdf#152425 Use ww::sti enum instead of respective number literalsMike Kaganski
Simplifies reading and checking its correctness greatly. Change-Id: I16253f324cbafac6cb526ab195a7257530abe0a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143827 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-12-09external/zxing: Silence MSVC 2022 error C3781Stephan Bergmann
> workdir\UnpackedTarball\zxing\core\src\Generator.h(20): error C3781: Generator<ZXing::DetectorResult>::promise_type: a coroutine's promise must declare either 'return_value' or 'return_void' seen at least when building with --with-latest-c++ against VS 2022 17.5.0 Preview 1.0 Change-Id: Ie69100d87e6cb85526d772e8f0f5d11e1f9d6704 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143853 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-09Related: tdf#152266 add a remove all buttonCaolán McNamara
Change-Id: Ibf6b749089d2d6da71a9ce00779bce8886453856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143833 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09resave with latest gladeCaolán McNamara
Change-Id: Ia9dc0446c2dc69c0e04d67b0d4da30319807a6cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143852 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09tdf#151548 sw content controls: preserve tag for block SDTsJustin Luth
The tag is critical for VBA access. Although we do not yet import blockSdts as content controls, losing this would break any VBA macros for MS Word. So make sure it round-trips. I can't imagine why it wasn't treated the same as alias. I guess because Alias is seen, while tag appears to have no valuable function (until VBA, where it becomes the most likely ID field.) Change-Id: I05a04faa9d2314c7b37c5b86f107bd1a16019509 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143830 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-09tdf#152413: sw_layoutwriter: Add unittestXisco Fauli
Change-Id: Ic485c1521969b126d66b0e33b72ca966d02d0ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143846 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-09Related: tdf#152266 give feedback which events are assignedCaolán McNamara
where assigned is means an event is assigned to a non-empty url, now the delete button is only enabled when there is something to delete, bringing the customizie event page into line with the sheet event page and the writer frame event assignment page Change-Id: I7e016bf578dff24b7d47312fd5f7cc63883d1e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143848 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09drop unnecessary pThis indirectionCaolán McNamara
Change-Id: I28c338a4f09036c9365937af99cb85fd4be95901 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09python3: upgrade to release 3.8.16Michael Stahl
Fixes CVE-2022-37454 and a few other ones that look less relevant including CVE-2022-45061 and CVE-2015-20107. Change-Id: I10fd254f7f0801d47119234bb3436874e98d8c91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143849 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-09svx: fix unmaintainable TypeConstant definitionMichael Stahl
Add one new token and every test in CppunitTest_sd_import_tests-smartart fails. Change-Id: I0d79a5000fc2ef9b699ffca3d75199e9479cf561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143834 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-12-09tdf#146842 Do not use Skia for printingPatrick Luby
Skia does not work with a native print graphics contexts. I am not sure why but from what I can see, the Skia implementation drawing to a bitmap buffer. However, in an NSPrintOperation, the print view's backing buffer is CGPDFContext so even if this bug could be solved by blitting the Skia bitmap buffer, the printed PDF would not have selectable text so always disable Skia for print graphics contexts. Change-Id: I214ba83b6e368af3ef51ea770b093612d04047a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143798 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09Fix hang during JunitTest_framework_complex on macOSStephan Bergmann
...when [NSSpellChecker init] is called on a non-main thread, leading to deadlock (see below). The fix is noticing that the first half of SfxFrameLoader_Impl::load and the call to SwGlobals::ensure from Writer_SwTextDocument_getImplementation both don't need to be covered by SolarMutex. Which in turn showed that the call to StartListening from the constructor of SwModule needs to be covered by the SolarMutex (which it no longer was now). The deadlock was at > thread #7, name = 'cppu_threadpool::ORequestThread' > #1: libsystem_pthread.dylib`_pthread_cond_wait > #2: Foundation`-[NSOperation waitUntilFinished] > #3: CoreFoundation`_CFXNotificationPost > #4: Foundation`-[NSNotificationCenter postNotificationName:object:userInfo:] > #5: AppKit`-[NSMenu insertItem:atIndex:] > #6: AppKit`-[NSApplication(NSServicesMenuPrivate) _fillSpellCheckerPopupButton:] > #7: AppKit`-[NSSpellChecker _fillSpellCheckerPopupButton:] > #8: AppKit`-[NSSpellChecker init] > #9: AppKit`__36+[NSSpellChecker sharedSpellChecker]_block_invoke > #10: libdispatch.dylib`_dispatch_client_callout > #11: libdispatch.dylib`_dispatch_once_callout > #12: AppKit`+[NSSpellChecker sharedSpellChecker] > #13: libMacOSXSpelllo.dylib`MacSpellChecker::getLocales at lingucomponent/source/spellcheck/macosxspell/macspellimp.mm:117:42 > #14: liblnglo.dylib`LngSvcMgr::GetAvailableSpellSvcs_Impl at linguistic/source/lngsvcmgr.cxx:969:63 > #15: liblnglo.dylib`LngSvcMgr::getAvailableServices at linguistic/source/lngsvcmgr.cxx:1395:9 > #16: liblnglo.dylib`LngSvcMgr::getAvailableLocales at linguistic/source/lngsvcmgr.cxx:1459:42 > #17: liblnglo.dylib`LngSvcMgr::UpdateAll at linguistic/source/lngsvcmgr.cxx:654:49 > #18: liblnglo.dylib`LngSvcMgr::LngSvcMgr at linguistic/source/lngsvcmgr.cxx:411:5 > #19: liblnglo.dylib`LngSvcMgr::LngSvcMgr at linguistic/source/lngsvcmgr.cxx:399:1 > #20: liblnglo.dylib`::linguistic_LngSvcMgr_get_implementation at linguistic/source/lngsvcmgr.cxx:1840:30 > #21: libuno_cppuhelpergcc3.dylib.3`decltype(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>(fp)(std::__1::forward<com::sun::star::uno::XComponentContext*>(fp0), std::__1::forward<com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(fp0))) std::__1::__invoke<com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #22: libuno_cppuhelpergcc3.dylib.3`com::sun::star::uno::XInterface* std::__1::__invoke_void_return_wrapper<com::sun::star::uno::XInterface*, false>::__call<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #23: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__alloc_func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #24: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #25: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__value_func<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const > #26: libuno_cppuhelpergcc3.dylib.3`std::__1::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const > #27: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::doCreateInstance at cppuhelper/source/servicemanager.cxx:702:13 > #28: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::createInstance at cppuhelper/source/servicemanager.cxx:667:30 > #29: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::createInstanceWithContext at cppuhelper/source/servicemanager.cxx:1002:36 > #30: libswlo.dylib`com::sun::star::linguistic2::LinguServiceManager::create at workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/linguistic2/LinguServiceManager.hpp:38:129 > #31: libswlo.dylib`SwLinguServiceEventListener::SwLinguServiceEventListener at sw/source/uibase/uno/dlelstnr.cxx:53:22 > #32: libswlo.dylib`SwLinguServiceEventListener::SwLinguServiceEventListener at sw/source/uibase/uno/dlelstnr.cxx:46:1 > #33: libswlo.dylib`SwModule::SwModule at sw/source/uibase/app/swmodule.cxx:161:44 > #34: libswlo.dylib`SwModule::SwModule at sw/source/uibase/app/swmodule.cxx:137:1 > #35: libswlo.dylib`std::__1::__unique_if<SwModule>::__unique_single std::__1::make_unique<SwModule, SfxObjectFactory*&, SfxObjectFactory*&, SfxObjectFactory*&> > #36: libswlo.dylib`SwDLL::SwDLL at sw/source/uibase/app/swdll.cxx:98:26 > #37: libswlo.dylib`SwDLL::SwDLL at sw/source/uibase/app/swdll.cxx:81:1 > #38: libswlo.dylib`(anonymous namespace)::SwDLLInstance::SwDLLInstance at sw/source/uibase/app/swdll.cxx:57:212 > #39: libswlo.dylib`(anonymous namespace)::SwDLLInstance::SwDLLInstance at sw/source/uibase/app/swdll.cxx:58:9 > #40: libswlo.dylib`rtl::Static<(anonymous namespace)::SwDLLInstance, (anonymous namespace)::theSwDLLInstance>::get at include/rtl/instance.hxx:399:18 > #41: libswlo.dylib`SwGlobals::ensure at sw/source/uibase/app/swdll.cxx:70:9 > #42: libswlo.dylib`::Writer_SwTextDocument_get_implementation((null)=0x000000011fde9130, args=0x000000028bb087b0) at sw/source/uibase/uno/unodoc.cxx:40:5 > #43: libuno_cppuhelpergcc3.dylib.3`decltype(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>(fp)(std::__1::forward<com::sun::star::uno::XComponentContext*>(fp0), std::__1::forward<com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(fp0))) std::__1::__invoke<com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #44: libuno_cppuhelpergcc3.dylib.3`com::sun::star::uno::XInterface* std::__1::__invoke_void_return_wrapper<com::sun::star::uno::XInterface*, false>::__call<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #45: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__alloc_func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #46: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) > #47: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__value_func<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const > #48: libuno_cppuhelpergcc3.dylib.3`std::__1::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const > #49: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::doCreateInstance at cppuhelper/source/servicemanager.cxx:702:13 > #50: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::createInstance at cppuhelper/source/servicemanager.cxx:671:16 > #51: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::createInstanceWithContext at cppuhelper/source/servicemanager.cxx:1002:36 > #52: libsfxlo.dylib`(anonymous namespace)::SfxFrameLoader_Impl::load at sfx2/source/view/frmload.cxx:668:58 > #53: libfwklo.dylib`framework::LoadEnv::impl_loadContent at framework/source/loadenv/loadenv.cxx:1160:37 > #54: libfwklo.dylib`framework::LoadEnv::start at framework/source/loadenv/loadenv.cxx:395:20 > #55: libfwklo.dylib`framework::LoadEnv::startLoading at framework/source/loadenv/loadenv.cxx:300:5 > #56: libfwklo.dylib`framework::LoadEnv::loadComponentFromURL at framework/source/loadenv/loadenv.cxx:168:14 > #57: libfwklo.dylib`framework::Desktop::loadComponentFromURL at framework/source/services/desktop.cxx:605:16 > #58: libgcc3_uno.dylib`callVirtualFunction at bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx:38:5 > #59: libgcc3_uno.dylib`(anonymous namespace)::call at bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx:293:13 > #60: libgcc3_uno.dylib`::unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx:505:17 > #61: libbinaryurplo.dylib`binaryurp::IncomingRequest::execute_throw const at binaryurp/source/incomingrequest.cxx:235:13 > #62: libbinaryurplo.dylib`binaryurp::IncomingRequest::execute const at binaryurp/source/incomingrequest.cxx:78:26 > #63: libbinaryurplo.dylib`::request at binaryurp/source/reader.cxx:85:9 > #64: libuno_cppu.dylib.3`cppu_threadpool::JobQueue::enter at cppu/source/threadpool/jobqueue.cxx:100:17 > #65: libuno_cppu.dylib.3`cppu_threadpool::ORequestThread::run at cppu/source/threadpool/thread.cxx:164:31 > #66: libuno_cppu.dylib.3`::threadFunc at include/osl/thread.hxx:189:15 > #67: libuno_sal.dylib.3`osl_thread_start_Impl at sal/osl/unx/thread.cxx:264:9 vs. > thread #1, queue = 'com.apple.main-thread' > #1: libsystem_pthread.dylib`_pthread_cond_wait > #2: libc++.1.0.dylib`std::__1::condition_variable::wait(std::__1::unique_lock<std::__1::mutex>&) [inlined] std::__1::__libcpp_condvar_wait > #3: libc++.1.0.dylib`std::__1::condition_variable::wait > #4: libvclplug_osxlo.dylib`void std::__1::condition_variable::wait<SalYieldMutex::doAcquire(unsigned int)::$_0> > #5: libvclplug_osxlo.dylib`SalYieldMutex::doAcquire at vcl/osx/salinst.cxx:215:36 > #6: libvclplug_osxlo.dylib`comphelper::SolarMutex::acquire at include/comphelper/solarmutex.hxx:86:5 > #7: libvclplug_osxlo.dylib`osl::Guard<comphelper::SolarMutex>::Guard at include/osl/mutex.hxx:142:17 > #8: libvclplug_osxlo.dylib`SolarMutexGuard::SolarMutexGuard at include/vcl/svapp.hxx:1348:11 > #9: libvclplug_osxlo.dylib`SolarMutexGuard::SolarMutexGuard at include/vcl/svapp.hxx:1348:78 > #10: libvclplug_osxlo.dylib`AquaSalTimer::callTimerCallback at vcl/osx/saltimer.cxx:140:21 > #11: libvclplug_osxlo.dylib`AquaSalTimer::handleDispatchTimerEvent at vcl/osx/saltimer.cxx:162:9 > #12: libvclplug_osxlo.dylib`AquaSalInstance::handleAppDefinedEvent at vcl/osx/salinst.cxx:406:47 > #13: libvclplug_osxlo.dylib`-[VCL_NSApplication sendEvent:] at vcl/osx/vclnsapp.mm:101:9 > #14: libvclplug_osxlo.dylib`AquaSalInstance::DoYield at vcl/osx/salinst.cxx:567:17 > #15: libvcllo.dylib`ImplYield at vcl/source/app/svapp.cxx:465:48 > #16: libvcllo.dylib`Application::Yield at vcl/source/app/svapp.cxx:532:5 > #17: libvcllo.dylib`Application::Execute at vcl/source/app/svapp.cxx:444:9 > #18: libsofficeapp.dylib`desktop::Desktop::Main at desktop/source/app/app.cxx:1587:13 > #19: libvcllo.dylib`ImplSVMain at vcl/source/app/svmain.cxx:198:35 > #20: libvclplug_osxlo.dylib`AquaSalInstance::handleAppDefinedEvent at vcl/osx/salinst.cxx:396:20 > #21: libvclplug_osxlo.dylib`-[VCL_NSApplication sendEvent:] at vcl/osx/vclnsapp.mm:101:9 > #22: AppKit`-[NSApplication _handleEvent:] > #23: AppKit`-[NSApplication run] > #24: AppKit`NSApplicationMain > #25: libvclplug_osxlo.dylib`AquaSalInstance::SVMainHook at vcl/osx/salinst.cxx:971:5 > #26: libvcllo.dylib`ImplSVMain at vcl/source/app/svmain.cxx:191:54 > #27: libvcllo.dylib`SVMain at vcl/source/app/svmain.cxx:230:12 > #28: libsofficeapp.dylib`soffice_main at desktop/source/app/sofficemain.cxx:98:12 > #29: soffice`sal_main at desktop/source/app/main.c:49:15 > #30: soffice`main at desktop/source/app/main.c:47:1 Change-Id: Ic5681f21a153e42a27680a9a6a179aff38f77fcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143565 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-09make Notebookbar customize page match indent with the othersCaolán McNamara
remove intermediate grids with just one child, name the containers of the groups of widgets to be hidden and hide the container rather than the individual members so the container space doesn't push this page out of alignment with the others. Change-Id: Ie3fb291da49a6b43ca4516e5fe55b828543631e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09resave with latest gladeCaolán McNamara
Change-Id: I548fac08a9b4d62d6e71bf5fa687d5c1ff2e11b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-09tdf#149240 docx content controls: round-trip showingPlcHdr betterJustin Luth
ShowingPlaceHolder causes all the text in the control to be selected when the control gains the focus. Otherwise, just a cursor is placed at the click point. While round-tripping this attribute worked for inline SDTs, it was lost for block SDTs. But BlockSDTs are very easy to create. The MS templates are full of them. Also, these are boolean, but it could have a val=0 specified, in which case it is off, but we were importing it as on. Change-Id: I167afa935311a63bba408ecd489ae819485a5cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143818 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-09sw: remove unused DocumentContentOperationsManager::InsertGraphicObject()Miklos Vajna
Only tests called it, migrate those to DocumentContentOperationsManager::InsertGraphic() instead, which is what SwFEShell::Insert() and SwXFrame::attachToRange() use. Change-Id: Ie05b501507f8722bc0a312c2e729ecd76154ce98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143836 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-12-09Fix typoAndrea Gelmini
Change-Id: Iaa550d83da5823fe52c25afb8e403c998ce68b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143842 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-12-09tdf#152029 Bring drawing objects to attention in the document viewJim Raykowski
when mouse pointer is over drawing object entry in the Navigator content tree Change-Id: Idfeeb3854ffe76745f2f30a6ffac8528b2dda725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143844 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2022-12-09Deduplicate table styles insertionMaxim Monastirsky
(Not adding a test here, as this should already be covered by several tests in sw/qa/extras/odfexport/odfexport.cxx.) Change-Id: Ic3cae9f38efc55d3d9055a45bc642d7b15fa382a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143840 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-12-09Fix sd encoded table style name handlingMaxim Monastirsky
Found this while looking into improving insertion of pages with tables, as SdDrawDocument::InsertBookmarkAsPage uses "_" as the rename suffix for styles with identical names but a different content. This commit fixes two issues: - For import, cell styles with encoded names couldn't be found by table styles. The reason is that styles are referenced in ODF by encoded names, but at runtime by display names. Yet we were searching the cell style family by encoded names. This was already handled for sw in insertTabletemplate(), and now do the same for sd. - For export, table template names were encoded, but then referenced by tables using their non-encoded names. This is unlike the sw code that doesn't encode them, and therefore doesn't have this problem. Looking at the schema, both table:name attribute of a table template, and table:template-name attribute of a table are of type "string", which suggests that there is indeed no need to encode those names. This aligns with the fact that table templates don't have a display-name attribute. Change-Id: Ie61b6a1c95b033404ee98f3fc40d8e82434a6a6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143839 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-12-08tdf#132293 remove unused imports from uitestBogdan B
Change-Id: I6f5b5d97dab27986a6b0046c42c20ec4d0527980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142531 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-12-08tdf#114441 - Convert use of sal_uLong to better integer typesNalini Prasad Dash
The variable type of nHeight was changed as the return type of pFontHeightItem->GetHeight() is sal_uInt32.Also nBit was assigned the underlying datatype of LB(int) as it was checked against LB::LAST(Value converted to underlying datatype of LB) in the for loop . Change-Id: I657d545ac7af1786edd61569ba43b42e55d1f47b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143145 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-12-08tdf#152299 - Remove unused define(s) from C/C++ filesBogdan B
Change-Id: I22185ee21af426974cf57bda288320413bd119a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143434 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>