summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-15sd: define three columns for the slide transition paneHenry Castro
Instead of calculating extra space Change-Id: I26e763e5db0ff05fb1bd6f64f3054d8ef88a2156 Reviewed-on: https://gerrit.libreoffice.org/82526 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit 58a3e6ad29eb7b616f03737265ef7a25afe83a36) Reviewed-on: https://gerrit.libreoffice.org/82673 Tested-by: Jenkins
2019-11-15do not clean up EncryptionData during SaveAsVasily Melenchuk
As the SID_ENCRYPTIONDATA and SID_PASSWORD are used for setting password together, EncryptionData should be removed only when Password was set (reset of Password protection for the document). Elsewhere EncryptionData should remain as is, while it could contain encryption data used for opened document. Change-Id: I46b757af81e68ad4781e83b1a0e0b6da3a5e13e1 Change-Id: I1213ec55d6dc42f062930467976de45c73152f0b Reviewed-on: https://gerrit.libreoffice.org/82616 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-15Silence -Werror,-Wsometimes-uninitializedStephan Bergmann
Change-Id: I491566c9f1fbbaabf9b050150b1567c5354227d0 Reviewed-on: https://gerrit.libreoffice.org/82752 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15use icerun also for python/java/ui testsLuboš Luňák
Change-Id: If25c4949b999435e7a444d80a45f3dce9b8184ee Reviewed-on: https://gerrit.libreoffice.org/82715 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-11-15-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I0e9e7be9ba7dfc2f8c6d4e17aa6c08aa1d97db45 Reviewed-on: https://gerrit.libreoffice.org/82755 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15loplugin:indentationStephan Bergmann
Change-Id: Iea0f624e0f46c6555dace701a543787c48ab9549 Reviewed-on: https://gerrit.libreoffice.org/82754 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15Log exceptionStephan Bergmann
Change-Id: Icde4e8a6598eb2d4aca7b67d96876bf0ecf017ab Reviewed-on: https://gerrit.libreoffice.org/82753 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15sw: WW8 import: instead of control character insert '?' for footnoteMichael Stahl
SwWW8ImplReader::ReadChar() inserts a U+0002 control character to temporarily mark a footnote anchor; this is then deleted and replaced with a real footnote hint by SwWW8ImplReader::End_Footnote(). The assumption is that it is necessary to insert a placeholder character to be able to apply formatting to it. But if the document is corrupted, the control character could survive the import, which sounds less than ideal. So either make this magic character more explicit by documenting it in hintids.hxx and removing any outstanding ones at the end of the import, or use a non-offensive character instead; since this should only affect invalid documents, choose the solution with the least effort. Change-Id: I76d396258b32e0f0fb6393942a58a4dc57912211 Reviewed-on: https://gerrit.libreoffice.org/82723 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-15tdf#128737 svx: fix off-by-one in SdrObjList::sort()Michael Stahl
Increment if the previous one was a text-box, not the current one. Also add some consistency checks while at it. (regression from a8b1699ca9c7e8c43eff79467451fd1fcb4fde9b or its follow-ups) Change-Id: Iab79e884f4f9cfa358630681495848f4f894506b Reviewed-on: https://gerrit.libreoffice.org/82724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-15ofz#18526 sw: WW8 import: don't insert control charactersMichael Stahl
Sanitize string before calling InsertString(). This segfaults since: commit b522fc0646915d4da94df38dd249c88b28f25be7 Date: Tue Sep 24 18:11:45 2019 +0200 sw: maintain fieldmarks in DeleteRange()/DeleteAndJoin()/ReplaceRange() Change-Id: I9ef73d924420686f6838fa21900ec57b4d25c905 Reviewed-on: https://gerrit.libreoffice.org/81949 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-15tdf#128538: Open filesystem directories in Finder after allStephan Bergmann
Where option "-R" means, according to the open(1) man page: "Reveals the file(s) in the Finder instead of opening them." This appears to always reveal in Finder, even for *.app "application directories", so should not affect CVE-2019-9847.) Change-Id: I775db7bf71c09adc6570931a977b82dfee8dc95a Reviewed-on: https://gerrit.libreoffice.org/82749 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15tdf#128700 ww8import: no relative width table if made into a flyJustin Luth
This is a partial revert for LO 6.0's bug 55528 commit e69473539a33da5450d3878999eba7f9bfb9e631 Apparently Word tables can float without a frame, but in LO they need to wrapped in a frame? The relative size is supposed to be relative to the container they are in - so floated tables must not be assigned a relative value - otherwise the tablesize becomes relative to the custom frame that was created to float it. The fix was easy to make, but then trying to figure out whether to test using InLocalApo(), or just m_xSFlyPara took a lot of time. The documentation is sparse and unclear. In the end I settled on ignoring relative width if pFlyFormat exists, since certain conditions can cancel (bNoFly) a FloatingTableConversion. I tested what happens if a real frame is created and then a relatively sized table is dropped inside. I confirmed that relative SHOULD be relative to the frame. That case still works fine since it isn't considered an x_sFlyPara - I think because it actually is a textbox that the table is anchored onto. LO round-trips frame/table as textbox/table. Conclusion: tables inside of frames/textboxes MAY be relative, but if the table itself is floating (a WORD-ONLY feature) then it should not be relatively sized. Change-Id: I2b0bd525051a33b5606b79d2b26665d3edeb5357 Reviewed-on: https://gerrit.libreoffice.org/82647 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-15xmloff: create XMLDrawContentExportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I4bb0ef49ef429df053af83ff0dd7d22edc2d907b Reviewed-on: https://gerrit.libreoffice.org/82742 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-15tdf#127294 add tip about removing multiple hyperlinksSeth Chaiklin
Change-Id: I465d459dce8bd279cb3052d4563340efc3092ec7 Reviewed-on: https://gerrit.libreoffice.org/82691 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-15Revert "tdf#126128 Reduce page properties dialog's height."Heiko Tietze
Discussion in BZ. This reverts commit 80109586e6cb6d3e2e0a53a9079c3125ec9b8368. Change-Id: I01e23a7eeaa78d60f106dfa67a54ff9d7904cb19 Reviewed-on: https://gerrit.libreoffice.org/82698 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-11-15Revert "ensure gtk creates a default label widget for the MenuButtons"Heiko Tietze
Discussion on BZ, have to revert this patch first. This reverts commit 3937d3d035a03530b78acc648c07b6e099fb6770. Change-Id: I8ab49e7296bc403f2706f986b2711025f468c4be Reviewed-on: https://gerrit.libreoffice.org/82699 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-15make some classes module-privateNoel Grandin
Change-Id: I95845d7217fc5e77e3f8e205030e9cd761ad0cc5 Reviewed-on: https://gerrit.libreoffice.org/82116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-15tdf#123734 Prepend "Custom." for values of custom PPD optionsMichael Weghorn
CUPS supports using custom options in PPDs, which go beyond what is specified in the PPD specification, s. doc at at [1]. [2] mentions that the "Custom." prefix is needed when specifying custom page sizes: > When Custom is listed for the PageSize option, you can specify custom > media sizes using one of the following forms: > > lp -o media=Custom.WIDTHxLENGTH filename > lp -o media=Custom.WIDTHxLENGTHin filename > lp -o media=Custom.WIDTHxLENGTHcm filename > lp -o media=Custom.WIDTHxLENGTHmm filename While I did not find any explicit documentation that the same is true for CUPS-specific custom options, this is apparently the case. (The "CustomPageSize" keyword is expclicitly specified in the PPD specification [3], section 5.16 "Custom Page Sizes" and thus not a CUPS-specific custom option.) This can be seen e.g. by the fact that after setting the default value for a PPD option to such a custom value, the corresponding entry in the PPD does get the "Custom." prefix, e.g. *DefaultPassword: Custom.12345 for the sample PPD from tdf#123734. For more details, s.a. the discussion on the similar bug report for Gtk+ at [4], where e.g. comment 0 says: > According to the cups people, the value should have been > "Custom.ThisIsAtest" in this case. Without the "Custom." part, > this is not used by the cups filters. Therefore, add the "Custom." prefix for custom options, but don't show them in the UI. [1] https://www.cups.org/doc/spec-ppd.html#OPTIONS [2] https://www.cups.org/doc/options.html [3] https://web.archive.org/web/20161017222612/http://partners.adobe.com/public/developer/en/ps/5003.PPD_Spec_v4.3.pdf [4] https://bugzilla.gnome.org/show_bug.cgi?id=543520 Change-Id: I570d8b55212c6fc33405460f11d152e86cedb0f9 Reviewed-on: https://gerrit.libreoffice.org/82722 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-15reduce iteration in ScViewData::GetScrPosNoel Grandin
we already have a ScTable::GetRowHeightScaled method that uses spans, so use that. Change-Id: I126292b4a8b37ebf2d4f737dcbfdadc31226531e Reviewed-on: https://gerrit.libreoffice.org/82520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-14coverity#1242892 Untrusted value as argumentCaolán McNamara
Change-Id: Ia4fd0a270d42fc2da233da18d4122f786c79dc3d Reviewed-on: https://gerrit.libreoffice.org/82697 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix L10N of xapian templates Change-Id: I23e3adc4a4232e9f9d998fa9f41951f7c530c335 Reviewed-on: https://gerrit.libreoffice.org/82721 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-14jsdialog: send paragraph margins for impressSzymon Kłos
Change-Id: Ie0d4d3dc33de66609c005b77c1ef9802446ad57c Reviewed-on: https://gerrit.libreoffice.org/82658 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 29733bb39a16fc0e1398a7c18781226cfe755ff3) Reviewed-on: https://gerrit.libreoffice.org/82670 Tested-by: Jenkins
2019-11-14jsdialogs: fix CID 1455691 & CID 1455690Szymon Kłos
Change-Id: Idbb3e70c1a09be7dd7c43747250f3a6368251cd9 Reviewed-on: https://gerrit.libreoffice.org/82662 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-14cid#1455325 establish that pDoc cannot be null thereCaolán McNamara
Change-Id: Ia7bca1e74a8ede90e29ec6cbd63c7fdcaf25b072 Reviewed-on: https://gerrit.libreoffice.org/82696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14mpDoc is assumed to be non-nullCaolán McNamara
Change-Id: Ib3fbd6cc2b01e4923e97260b66aa1cd7807ee281 Reviewed-on: https://gerrit.libreoffice.org/82684 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14Details always dereferences ScDocument argumentCaolán McNamara
Change-Id: If56c03af49606ffe6b5d4d782bd4a848aa79d8c2 Reviewed-on: https://gerrit.libreoffice.org/82695 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14tdf#128104 Input Engine events are delivered via CommandCaolán McNamara
so editengine needs to get those events too. Change-Id: I528065ef804f0a2dfa98e49034c86e9483bade2d Reviewed-on: https://gerrit.libreoffice.org/82718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14Add ChartTypePanel to the ChartDeckMuhammet Kara
Consists of the first part of the implementation. Pushing to be able to see/use/tinker with it on the online/mobile side. Will be completed with follow-up patches. Change-Id: If49be54418c3b4c5ccc92fc7ee3e414847904162 Reviewed-on: https://gerrit.libreoffice.org/80799 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82663 Tested-by: Jenkins
2019-11-14cid#1448329 Wrapper object use after freeCaolán McNamara
Change-Id: I2c0352fee1621f03604409f9899cc1f9e8a6cbf8 Reviewed-on: https://gerrit.libreoffice.org/82717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14New loplugin:consttoboolStephan Bergmann
...to: "Find implicit conversions from non-'bool' constants (e.g., 'sal_False') to 'bool'". Due to how FALSE is defined as just #define FALSE (0) (i.e., a literal of type 'int') but TRUE is defined as #define TRUE (!FALSE) (i.e., an implicit conversion from 'int' to 'bool') in GLib (see the comment in ConstToBool::VisitImplicitCastExpr), we get more warnings about uses of 'TRUE' than of 'FALSE'. For example, in libreofficekit/source/gtk/lokdocview.cxx there is a warning about the 'TRUE' in g_main_context_iteration(nullptr, TRUE); but not about the 'FALSE' in g_main_context_iteration(nullptr, FALSE); (where the parameter of 'g_main_context_iteration' is of type 'gboolean'). Lets live with that asymmetry for now... (Besides the issues addressed directly in this commit, it also found the two bogus asserts at 7e09d08807b5ba2fd8b9831557752a415bdad562 "Fix useless assert(true) (which would never fire)" and 122a0be8ae480473bd1d7f35e197a2529f4621e3 "Fix useless assert(true) (which would never fire)", plus 5f0d6df7f57ae281fe161e61c7f25d67453fddd2 "Use two-argument form of static_assert".) Change-Id: Id77322de9f94b85a7b65608a03e0e9865d14467b Reviewed-on: https://gerrit.libreoffice.org/82667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-14tdf#114746 Restore asian and complex tags in Classy_Red templateLaurent BP
Manually add tags to fix size, bold and italic: style:font-size-asian style:font-size-complex style:font-style-asian style:font-style-complex style:font-weight-asian style:font-weight-complex Change-Id: Ib878ce99908b1e42822204a468c011739e3b62ff Reviewed-on: https://gerrit.libreoffice.org/80802 Tested-by: Jenkins Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2019-11-14tdf#114746 Restore asian and complex tags in BrightBlue templateLaurent BP
Manually add tags to fix size, bold and italic: style:font-size-asian style:font-size-complex style:font-style-asian style:font-style-complex style:font-weight-asian style:font-weight-complex Change-Id: Ic95e94eed9992d679add70f73ba5c588002e16a7 Reviewed-on: https://gerrit.libreoffice.org/80798 Tested-by: Jenkins Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2019-11-14tdf#114746 Restore asian and complex tags in Blueprint_Plans templateLaurent BP
Manually add tags to fix size, bold and italic: style:font-size-asian style:font-size-complex style:font-style-asian style:font-style-complex style:font-weight-asian style:font-weight-complex Change-Id: I9cee55543d2c8dade79b85ea1e65d79ad2c37858 Reviewed-on: https://gerrit.libreoffice.org/80792 Tested-by: Jenkins Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2019-11-14tdf#114746 Restore asian and complex tags in Blue_Curve templateLaurent BP
Manually add tags to fix size, bold and italic: style:font-size-asian style:font-size-complex style:font-style-asian style:font-style-complex style:font-weight-asian style:font-weight-complex Change-Id: I18e266cbacf6bb461dd58afaee572e874609907f Reviewed-on: https://gerrit.libreoffice.org/80791 Tested-by: Jenkins Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2019-11-14tdf#114746 Restore asian and complex tags in Beehive templateLaurent BP
Manually add tags to fix size, bold and italic: style:font-size-asian style:font-size-complex style:font-style-asian style:font-style-complex style:font-weight-asian style:font-weight-complex Change-Id: I6e6f8fbadde917a1bbac94dd44996fbda507bc0b Reviewed-on: https://gerrit.libreoffice.org/80747 Tested-by: Jenkins Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2019-11-14tdf#114746 Restore asian and complex tags in Alizarin templateLaurent BP
Manually add tags to fix size, bold and italic: style:font-size-asian style:font-size-complex style:font-style-asian style:font-style-complex style:font-weight-asian style:font-weight-complex Change-Id: I2c23ad83296c73b6e4c028cbb5a10d4b62d1e134 Reviewed-on: https://gerrit.libreoffice.org/80744 Tested-by: Jenkins Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2019-11-14sw: RTF export: fix invalid RTF for shapes and text framesMichael Stahl
RtfAttributeOutput::OutputFlyFrame_Impl() writes SdrObject into m_aRunText buffer, but for a text frame it writes directly into m_rExport.Strm(), also writing m_aRunText into it in the middle. So if you have both SdrObject and text frame at the same anchor position, first the shape goes into the buffer and then the first part of the text frame is written to the stream before it and the last part after it, and we get this: sw/source/filter/ww8/rtfattributeoutput.cxx:1886: m_aRunText is not empty And Word refuses to open the file with a funny error message about running out of memory. Reportedly this is a regression from commit d53dd70b15f0e3f7c8a05a93f8fcd70e1147c1f7 but really it was broken already in commit a8b59ef5951fe76b0b733ecef739173c1d104f6f. Change-Id: If01465dee71b63531b46c39dd557066f804c425d Reviewed-on: https://gerrit.libreoffice.org/82702 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2019-11-14mpDocument is assumed to be non-nullCaolán McNamara
Change-Id: I2ca91a1baf2c34b89b972871025c4039f0eea85b Reviewed-on: https://gerrit.libreoffice.org/82683 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14SetReference ScDocument arg is never nullCaolán McNamara
Change-Id: Ifdfe305e5319926d804e14962e786389b79fe476 Reviewed-on: https://gerrit.libreoffice.org/82682 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14ParseWithNames pDoc arg assumed to be non-nullCaolán McNamara
Change-Id: I97451daf3a99ace4c936912a3978dfaee8fe9fb2 Reviewed-on: https://gerrit.libreoffice.org/82681 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14uitest for bug tdf#126673Zdeněk Crhonek
Change-Id: Ic5fad97da8f01c0a62159ba74d6312fa88240a50 Reviewed-on: https://gerrit.libreoffice.org/82646 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-14mDocument is assumed to be non-nullCaolán McNamara
Change-Id: I53cf6625a24fe0b79914736f271ed3577af2e6e5 Reviewed-on: https://gerrit.libreoffice.org/82680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14mDocument is assumed to be non-nullCaolán McNamara
Change-Id: I180c0a6d5041c52cef332b07a0ff433e47f2f384 Reviewed-on: https://gerrit.libreoffice.org/82679 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14mpDoc is assumed to be non-nullCaolán McNamara
Change-Id: Iecb34ff0483b522146e1a4e89da71e6a06b0b3c2 Reviewed-on: https://gerrit.libreoffice.org/82678 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14mDocument is assumed to be non-nullCaolán McNamara
Change-Id: I8b012305363116393c88a81ab6e78f6074d6955a Reviewed-on: https://gerrit.libreoffice.org/82677 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14Adapt solenv/flatpak-manifest.in to a874172b9b048cfc6c4aa73cdf52c54b9b34872aStephan Bergmann
..."Update to language-subtag-registry-2019-09-16" Change-Id: If63e6ac9803f37b957099d7485d5dcd10c3b96cd Reviewed-on: https://gerrit.libreoffice.org/82674 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-14pDoc is always dereferencedCaolán McNamara
so make it a reference Change-Id: I0b732c76f864129521c2c15a8556359b7367a026 Reviewed-on: https://gerrit.libreoffice.org/82668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14Resolves: tdf#128788 crash in autovalueCaolán McNamara
Change-Id: Ifeb3b3fcb464e1d6db7e1a4a557b34b3ee30c82a Reviewed-on: https://gerrit.libreoffice.org/82652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14Improve error messageStephan Bergmann
(When temporarily taking a plugin out of the shared plugin by modifying its leading > #ifndef LO_CLANG_SHARED_PLUGINS line I often forget about a trailing > #endif // LO_CLANG_SHARED_PLUGINS line, which then caused a hard to understand > [GEN] compilerplugins/clang/sharedvisitor/sharedvisitor.cxx > Incorrect version '' failure. This way, at least somehow mention the name of the problematic plugin to give a bit of a clue.) Change-Id: I9a9178ba0d7a32f448e91076376989f088ea70f8 Reviewed-on: https://gerrit.libreoffice.org/82657 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-14Revert "tdf#108687 vcl: always enable tabstop on radio buttons"Justin Luth
This reverts LO 6.2 commit f2cd1c3c7cce2699d1341f726fc90cf30b52612c because it most recently caused regressions tdf#128749 and tdf#128625. There are places where radio-groups are not properly defined, and things are a big mess. -about 4 levels of radio buttons are created. -the last level does not do grouping properly. -the tab order is defined too early, before all the controls are fully made. -this code is repeated for EVERY control added. Already reverted in 6.2 and 6.3, this also reverts 6.5 because after looking again I don't see any way out of this, short of rewriting all of the old code. Reviewed-on: https://gerrit.libreoffice.org/75157 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4109dfff009f017e8994ea0a57119e79291ca2c8) Change-Id: Ic62fd7bb50e67647703cba3796f6d11ffb797eb5 Reviewed-on: https://gerrit.libreoffice.org/82523 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
generated by cgit (git 2.34.1) at 2025-02-02 15:38:26 +0000