summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-11Remove duplication of Paper enum as #definesTor Lillqvist
Not needed any more. We still have the fragile requirement that the order of entries in the aDinTab array in i18nutil/source/utility/paper.cxx has to match the enum order. Change-Id: I858fd56ad6bb1a3f3c2c39f7830b4dc6aea7cc1f Reviewed-on: https://gerrit.libreoffice.org/44600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-11-11A user object id is *NOT* a SotClipboardFormatIdEike Rathke
Do not try to squeeze it into such.. especially if SotClipboardFormatId::... enum identifiers are used in a user object id context that is completely not related to the identifier name this is totally confusing. commit fb14be5f8f74f83ba89e15f891ddf1f753dcc62f Date: Thu Mar 12 14:53:28 2015 +0200 create new 'enum class' SotClipboardFormatId to unify types overdid with that. Change-Id: I34b570be9f52b7b94ca8af6b23983393ac3a3a55 Reviewed-on: https://gerrit.libreoffice.org/44612 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-11TSCP: simplify setting the highest classificationTomaž Vajngerl
No need to check the document header for the current document classification category. It is right there in the document properties. Change-Id: I46d31fe2ead034b591ea10b478e7cc9e3ef410ef Reviewed-on: https://gerrit.libreoffice.org/44575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-11TSCP: use classification key creator instead of stringsTomaž Vajngerl
Change-Id: I2bc224aa0e290b0fab1c989834e5d79a72de35aa Reviewed-on: https://gerrit.libreoffice.org/44574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-11Resolves: tdf#113405 don't try and assign a master page to a master pageCaolán McNamara
when in master view mode go straight to adding the master page to the list of masters Change-Id: I345ce30b44099cd546267fb2acae0b1cc8a73dbe Reviewed-on: https://gerrit.libreoffice.org/44606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-11TSCP: bail out quickly in paragraph classification check on saveTomaž Vajngerl
Before saving a document we need to check that the document level classification is at the higher or same level as the individual paragraph level classification is. The trouble here is tha this can be quite a costly operation, so bail out quickly if we don't detect that no paragraph classification has been applied to the content by checking if we have the RDF metadata present or not. Change-Id: Iaef29de7e138937a5c1881cf34c9075fb37ba87d Reviewed-on: https://gerrit.libreoffice.org/44573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-11tdf#113591 Fix crash when switching between Calc and other LO windowSamuel Mehrbrodt
Need to get the ContentNode from EditDoc, as the selection might have a pointer to an already deleted ContentNode. Change-Id: I5c17be8ec2cbc57686eaf90e8b03c026aea7f28f Reviewed-on: https://gerrit.libreoffice.org/44583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-11loplugin:unnecessaryoverride: suppress warnings when default args differStephan Bergmann
...instead of blacklisting such cases. Reuses the checkIdenticalDefaultArguments code that was originally in loplugin:overrideparam (and appears to work reasonably well for the default arguments that actually happen in practice). Change-Id: I9cf2db17101beb135b2039a9b7ed335bd2af2c08 Reviewed-on: https://gerrit.libreoffice.org/44594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-11Avoid using O[U]StringConcat lvalues containing dangling refs to temporariesStephan Bergmann
...in code accidentally using auto like > auto const aURL = uri->getUriReference() + "/" > + INetURLObject::encode( > m_sEmbeddedName, INetURLObject::PART_FPATH, > INetURLObject::EncodeMechanism::All); > > uno::Reference<uno::XInterface> xDataSource(xDatabaseContext->getByName(aURL), uno::UNO_QUERY); in <https://gerrit.libreoffice.org/#/c/44569/1> "Properly construct vnd.sun.star.pkg URL" did (causing hard to debug test failures there). So make functions taking O[U]StringConcat take those by rvalue reference. Unfortunately, that also needed adaption of various functions that just forward their arguments. And some code in sc/qa/unit/ucalc_formula.cxx used CPPUNIT_ASSERT_EQUAL on OUStringConcat arguments in cases where that happened to actually compile (because the structure of the two OUStringConcats was identical), which needed adaption too (but which would arguably better use CPPUNIT_ASSERT_EQUAL_MESSAGE, anyway). Change-Id: I8994d932aaedb2a491c7c81c167e93379d4fb6e3 Reviewed-on: https://gerrit.libreoffice.org/44608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-11Remove unnecessary makePropertyValue specialization for AnyStephan Bergmann
...that had been introduced with 9e87a00e11486a2be64b0dc2799e3efca4b000cc "oox: replace PUT_PROP macro with comphelper::makePropertyValue() calls", but for reasons unclear to me. toAny is specifically there to either wrap its argument in an Any or, if the argument already is an Any, pass it on unwrapped. There is no deleted toAny overloads or explicit specializations. Change-Id: I63edf22ba3a63f6b3ebb3347ec5dc9ff81fd3bc4 Reviewed-on: https://gerrit.libreoffice.org/44607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-10slideshow: clip shapes in secondary screen windowMichael Stahl
When using the presenter console, the secondary screen has a small view of the current slide. Currently nothing clips the shapes that are on the slide, so they may be rendered outside the slide rectangle, because there's a single VCL-canvas and OutPutDevice that covers the entire screen. Set up some brute force clipping in DrawShape::getViewRenderArgs(). Change-Id: I3b21f08c12718254b6cf166b7fb1540e9381b243
2017-11-10sdext: document 2 different canvasesMichael Stahl
Change-Id: Icb8815ed20b06d2f43fbfb0088e6bdd0d5b389f6
2017-11-10tdf#86508 Use Yellow and Green for 2 entry color scaleYousuf Philips
Change-Id: Icde57593fb2cb589465c574894ab10184702655a Reviewed-on: https://gerrit.libreoffice.org/44603 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-10TSCP: strip metadata fields when copyingAshod Nakashian
Since the RDF entries are not copied (due to limitations in the clipboard doc), metadata fields become inconsistent upon copying. This is especially problematic for signatures and classification as they are no longer maintainable or verifyable (which is a particularly critical issue for crypto signatures of paragraphs). Change-Id: I5468a961ed43befdc48fcea8be00734453917c1f Reviewed-on: https://gerrit.libreoffice.org/43631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-11-10Elementary: update icon packandreas kainz
Change-Id: Ic20330ed474d434dfb2ab25d4c94875ff305eca8 Reviewed-on: https://gerrit.libreoffice.org/44596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-11-10Related: tdf#112549 gtk3 hide/show menubar on enter/exit fullscreenCaolán McNamara
Change-Id: I0436d0f3404a88abd81c4eedea09b16c81536b61 Reviewed-on: https://gerrit.libreoffice.org/44599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-10tdf#103080 Add Noto fonts into default installationYousuf Philips
Includes the regular, italic, bold and bold italic for * Noto Sans, Noto Serif Includes the regular and bold for * Noto Kufi Arabic, Noto Naskh Arabic * Noto Sans Armenian, Noto Serif Armenian * Noto Sans Georgian, Noto Serif Georgian * Noto Sans Hebrew, Noto Serif Hebrew * Noto Sans Lao, Noto Serif Lao Includes the regular and bold for * Noto Mono * Noto Sans Lisu Change-Id: I2a423b7cac031e2e899df22ad902bd09d1da250d Reviewed-on: https://gerrit.libreoffice.org/44128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-11-10tdf#113725: Sidebar: Controls are crammed in Slide content panelTamás Zolnai
Need to trigger a layouting to get the right panel size after we show / hode context related items. Change-Id: I791921ecb491bb65c53a4fe9562207d47f66a88a Reviewed-on: https://gerrit.libreoffice.org/44565 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-10loplugin:unnecessaryoverride: no warnings when fns are actually differentStephan Bergmann
Change-Id: I90d8af7a1affa459400b1cae4805e3a80b6c5200 Reviewed-on: https://gerrit.libreoffice.org/44593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-10No need to blacklist this loplugin:unnecessaryoverrideStephan Bergmann
...a using declaration should fix it just fine Change-Id: I05cf76672bcceb7a94afa602e215a0b5a32de82b Reviewed-on: https://gerrit.libreoffice.org/44591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-10No need to blacklist this loplugin:unnecessaryoverrideStephan Bergmann
...a using declaration should fix it just fine Change-Id: I0279994c155775e9a58e93aef8da4522d4fd93fd Reviewed-on: https://gerrit.libreoffice.org/44590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-10Forgot to add compilerplugins/clang/test/unusedvariablecheck.cxxStephan Bergmann
...to CompilerTest_compilerplugins_clang in 871e420cbbd8afe064e7bbc0ed426db3b01fddfa "Fix loplugin::unusedvariablecheck check for std classes" Change-Id: I011d8ff73189dfa85adb4cbd50e556f25be9b79c Reviewed-on: https://gerrit.libreoffice.org/44592 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-10ofz#4163 Null-dereference READCaolán McNamara
Change-Id: I3d1ae5f55343b1b8ec3b0d79a56c9368385a0af8 Reviewed-on: https://gerrit.libreoffice.org/44581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-10rework tdf#113647 solution to be safeCaolán McNamara
rather than passing the pointer around, tragic use of uno apis means monstrous awt::Window thingy has to be passed around and still smuggled through the dispatch arguments to get through the eye of the XDispatch::dispatch needle Change-Id: I353f8a3b0bb698bb58f75576e49efd701f3db8bf Reviewed-on: https://gerrit.libreoffice.org/44585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-10tdf#95635 use different font size keyboard shortcutsManfred Blume
Decrease is Ctrl-8, increase isCTRL-9. German-only, to prevent issues with inaccessible combinations. Change-Id: I8e009a9827265f49948464cc5356680c141663e6 Reviewed-on: https://gerrit.libreoffice.org/44584 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-10-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I545fb159960974841008d2a0e7843b71a59698aa
2017-11-10Translate German comment to EnglishSamuel Mehrbrodt
Change-Id: Ia7970d9318c0e9f738d7cdf646de2dd38f869a3c Reviewed-on: https://gerrit.libreoffice.org/42847 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-10loplugin:unusedmethods new analysisNoel Grandin
look for classes containing protected methods where we can convert them all to private Change-Id: I4a448341943e0a613cde30501c4012da61dba713 Reviewed-on: https://gerrit.libreoffice.org/44588 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-10editeng: Simplify calls to HasSelection()Samuel Mehrbrodt
Change-Id: I424cd5aee41334aebfd9bc41e1f8a9aeb69b9827 Reviewed-on: https://gerrit.libreoffice.org/44582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-10Properly construct vnd.sun.star.pkg URLStephan Bergmann
...in SwDBManager::LoadAndRegisterEmbeddedDataSource. For example, when the authority encodes a file URL whose path contains '%23' (because one of the pathname segments encoded in the file URL contains a '#' character), the original code would have left it as %23 in the vnd.sun.star.pkg URL, instead of encoding it as %2523. That lead to bad file URLs being recovered from the vnd.sun.star.pkg URL in dbaccess. (And 03f58aa36c5150ea305b5fd0023e0ec53a334051 "dbaccess: properly encode path to prevent stripping 'fragment' from it", which this commit reverts, wrongly tried to address that on the consuming instead of the producing side.) Change-Id: I17d2dc9e6306d006361fbcb63d77e93a9e20bf31 Reviewed-on: https://gerrit.libreoffice.org/44569 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-10upload expat 2.2.5David Tardon
Change-Id: Ic92002ec4f5edc48ca1bb3ac84836c4e6d19833c Reviewed-on: https://gerrit.libreoffice.org/44552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-11-10ofz#4158 Integer-overflowCaolán McNamara
Change-Id: I117156abf0e1f52491bf6bbe42bf18f4efd364f7 Reviewed-on: https://gerrit.libreoffice.org/44579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-10tdf#113736 Default value PDF export placeholders=falseManfred Blume
Default value for 'Export placeholders' in dialog 'Export as PDF...' should be false like in the print dialog Change-Id: Ib68a0921bfcb62849774c1388b0d77761384a130 Reviewed-on: https://gerrit.libreoffice.org/44546 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-11-10sw: remove temporary debug code in txttab that no longer builds anywayMiklos Vajna
Change-Id: I40dfa40dd157046aa5c1285b1855fb8c100fc315 Reviewed-on: https://gerrit.libreoffice.org/44577 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-10loplugin:unusedmethodsNoel Grandin
Change-Id: I543b0943f0bc918d59debc8ee051f88c29d18454 Reviewed-on: https://gerrit.libreoffice.org/44553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-10Upgrade these SAL_WARNs to INFOPranav Kant
These are very common occurrences. Let's not flood the warning output. Also ressurrect some helpful looking commented out SAL_INFOs Change-Id: I3368fb46b27b72edd8ba1f52e2a145a661c40477
2017-11-10tdf#113647 bullet dialog has wrong modal parentCaolán McNamara
Change-Id: Ia2e6171a1aeb3b8ad679a547a63ccaeac20481df Reviewed-on: https://gerrit.libreoffice.org/44554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-10rtl: change nullptr comparisonChris Sherlock
Change-Id: I0c356b100b732e259646d4ebb5d0aedd4dc4bcdd Reviewed-on: https://gerrit.libreoffice.org/44302 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2017-11-10Do not create arbitrary OpCode values from binary garbage, ofz-relatedEike Rathke
Change-Id: Ifb6f22472a9e9c0be95131bf8f49985ccc17c483
2017-11-10ofz#4123 do not read past end of fileEike Rathke
Change-Id: I1fa3543d541ea084a43a1a11f62680fa798f5647
2017-11-10loplugin:finalclasses in basctlNoel Grandin
Change-Id: I5974cf3df434ebfff1e3748ddd291e2a21cbb0de Reviewed-on: https://gerrit.libreoffice.org/44536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-10tdf#48300 kde4+gen: bring forward the window with already opened docKatarina Behrens
Send _NET_ACTIVE_WINDOW message to the mapped frame with the timestamp of current X11 server time (the real timestamp, not CurrentTime constant, otherwise e.g. KWin focus stealing prevention would kick in) Change-Id: I637e1c3548b874e7267f8fc71ffcca4b1a82a412 Reviewed-on: https://gerrit.libreoffice.org/44409 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-11-10There is no "paperconf" command on macOSTor Lillqvist
Change-Id: I01c4cf877eca81880381060e1b3ebedf2979bcb8
2017-11-10fix buildCaolán McNamara
Change-Id: I9fc79d2fc68cc0471fe6b8485a5fa62a1b81172a
2017-11-10upload nss 3.33David Tardon
Change-Id: Ib7f49b06669a5199b4bbe91d1b3eecf29ae6cfae Reviewed-on: https://gerrit.libreoffice.org/44521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-11-10No need to check both (identical) param_size() and getNumParams()Stephan Bergmann
Change-Id: I481cfa8b0f4bb9cbc257d28f36c372fb7367f294
2017-11-10clang-tidy modernize-use-equals-default LanguageTagJochen Nitschke
mbIsFallback was added to ctor but not to copy assignment in commit 258d9fac7544f925c8250bad99b9554cc49578d5 CID#1103756 missing initialization Change-Id: I91ee5daf68c3c3682b5d7007c028eaf3579a0715 Reviewed-on: https://gerrit.libreoffice.org/44563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-10loplugin:finalclasses in accessibilityNoel Grandin
Change-Id: I9d8bc018dfe8bd8668d28daccd85ea5770fe31b0 Reviewed-on: https://gerrit.libreoffice.org/44537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-10loplugin:finalclasses in basic,basegfxNoel Grandin
Change-Id: Iff223782fa0ded0fe46b8b7af35bfd21f331015f Reviewed-on: https://gerrit.libreoffice.org/44535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-10loplugin:finalclasses in chart2Noel Grandin
Change-Id: I35afa226beb6fe4319313125c323d9f059837357 Reviewed-on: https://gerrit.libreoffice.org/44534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-25 09:28:30 +0000