summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-20drop unnecessary includesCaolán McNamara
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20ofz#7026 Integer-overflowCaolán McNamara
Change-Id: I90928a34ce79903885fe903d69a64dac2eb3e45c Reviewed-on: https://gerrit.libreoffice.org/51593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20tdf#116516: INTERNET_PROXY_INFO always contains char* dataMike Kaganski
Regression from e80aef4e032f08ef0c4cfbb028bf83b81002f112 The InternetQueryOption has two variants: ANSI (A) and Unicode (W) (see https://msdn.microsoft.com/en-us/library/aa385101). INTERNET_PROXY_INFO struct we are using is defined to contain two LPCTSTR members (see https://msdn.microsoft.com/en-us/library/aa385148). When UNICODE is defined, InternetQueryOption expands to W variant, and at the same time, all MS-specific generic string types (like TCHAR or LPCTSTR) are expanded to wchar_t-based types. So, the expectation is that InternetQueryOptionW fills the struct with pointers to widechar strings. But actually this is not true: InternetQueryOptionW still returns char-based strings in the struct; so just revert partially commit above. Change-Id: I0facb1baf2a191f7bafdf185e684bfe741ca677a Reviewed-on: https://gerrit.libreoffice.org/51629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20tdf#116494: Don't ask parent if no help textMuhammet Kara
And add/use an IsHelpInstalled() method to SfxHelp. Change-Id: Ib87573067d6c44fa5adb22253c1a51a78580acf6 Reviewed-on: https://gerrit.libreoffice.org/51584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-20updater: Tone down the geekiness in user-facing stringsAdolfo Jayme Barrientos
Pro tip: The user doesn’t have to know that the updater is a separate program. Change-Id: I04c447a16a322b7f4139e69f6cababc797148bb1
2018-03-20tdf#16083 writer table resize behavior is randomNoel Grandin
regression from commit 890d6790715c4c3f3565b476d538643f04dc6936 convert TableChgWidthHeightType to o3tl::typed_flags in the process, improve the fix from commit bfafda5829f75091c9db798f953d617cde688a1f tdf#107866 - Changing table column width with Alt+arrow key strokes is broken Change-Id: I8740d2e1b925ad72ac69f87c5a06d30a55afeb72 Reviewed-on: https://gerrit.libreoffice.org/51625 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20Speed up SdPage comparisonMike Kaganski
Move trivial comparisons to front; return early on object comparison Change-Id: I4db927ac87dbb165e80b70046ff44a260b8a504b Reviewed-on: https://gerrit.libreoffice.org/51624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20Show start centre thumbnail indicating the file is encryptedKatarina Behrens
Change-Id: Ie46096b3198852c6ef70960b22652767c09d4779 Reviewed-on: https://gerrit.libreoffice.org/51532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-20Werror=misleading-indentationCaolán McNamara
Change-Id: If128194d45a4cf7265d0ca839f062ab70c22bcc1
2018-03-20Make failure to create symlink a fatal errorStephan Bergmann
...see commit message of f07e2496963baf8f7c0fecc79e7a420544075d98 "sdk/lib dir missing from Linux installation sets" Change-Id: Idb0f3437c27c867bc628fd3084f2a54c47beef17 Reviewed-on: https://gerrit.libreoffice.org/51428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-20drop now unused SvxMessDialogCaolán McNamara
Change-Id: I019b73b3ae6bf2d61a90cf893b7f4cb356771192 Reviewed-on: https://gerrit.libreoffice.org/51605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20convert SvxMessDialog use to standard message dialogCaolán McNamara
Change-Id: Id70d0d93027f6e9e35227b20f6a22f982b287eaa Reviewed-on: https://gerrit.libreoffice.org/51602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20ofz#6999 improve fixCaolán McNamara
Change-Id: Ib95ac17011ca2cc98a4d2288cb5879e163482932 Reviewed-on: https://gerrit.libreoffice.org/51573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20coverity#1430079 Overflowed return valueCaolán McNamara
Change-Id: I623f9f317496f281af408d1418d3cc7f2bd2d412 Reviewed-on: https://gerrit.libreoffice.org/51569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20weld SwSendWarningBoxCaolán McNamara
and then MessageDialog can become a vcl internal Change-Id: I8bf1f963971420b11f6c4163f624be26603cc942 Reviewed-on: https://gerrit.libreoffice.org/51601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20coverity#1430100 Uninitialized pointer fieldCaolán McNamara
Change-Id: I6d544b97c2b22a16d6a12b898cbe25580c433b61 Reviewed-on: https://gerrit.libreoffice.org/51570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20tdf#116269 RTF import: implement reverse deduplication for listsMiklos Vajna
This is the same mechanism that was added in commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17), except that here the reference is a list definition, not a paragraph style. Also, this commit only implements the part that inserts explicit defaults for not repeated properties, not the actual deduplication, as that already works at a dmapper level. (Saving the bugdoc as DOCX, it's visible in document.xml that DOCX marks these defaults explicitly: <w:ind w:left="0" w:right="-6" w:firstLine="0"/> but RTF does not, so the right place to fix this is in the tokenizer.) Change-Id: Iec88d9bf1032d1d89194bd272500d6780c3c2224 Reviewed-on: https://gerrit.libreoffice.org/51589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-20tdf#83877 Add ODF roundtrip test for signature linesSamuel Mehrbrodt
Change-Id: I4c55b19c9f7eaeb7c1c8df4266ea72ce24b17428 Reviewed-on: https://gerrit.libreoffice.org/51620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-20Fix commentMike Kaganski
Change-Id: I73ec0af22c19674c4b120a68c63710a1b46928ae Reviewed-on: https://gerrit.libreoffice.org/51623 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20no need to construct a new object in SfxIntegerListItem::operator==Noel Grandin
looks like an obvious typo Change-Id: Icea0952ec8203725cf5ba1ec90bdddd82eca7b3c Reviewed-on: https://gerrit.libreoffice.org/51562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20loplugin:useuniqueptr in PPTStyleTextPropReaderNoel Grandin
Change-Id: I5110ef58302323a59b52cc5451ddba4caa00b6d9 Reviewed-on: https://gerrit.libreoffice.org/51553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20tdf#115005 Do not remove original vector images from slidesSerge Krot
During calculation of the quality index of the image, we should take into account also SVM vector image type. Its mime type is image/x-vclgraphic. Change-Id: I7c723e99995f73258bb59d976a6c7670c51f7a25 Reviewed-on: https://gerrit.libreoffice.org/51599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-20remove unused maShapesVectorNoel Grandin
Change-Id: I6ce10a74ed9c665ff20d6408fe2f6b31faf46bcc Reviewed-on: https://gerrit.libreoffice.org/51552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20loplugin:useuniqueptr in SpriteNoel Grandin
Change-Id: I55eb8f931cdfd1898ff5a74868dc97f31ce1ae7c Reviewed-on: https://gerrit.libreoffice.org/51551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20loplugin:useuniqueptr in ImplImageListNoel Grandin
and fix leak in RemoveImage in the process Change-Id: I20e395178f92f7127e99011aebbe97246f255d1d Reviewed-on: https://gerrit.libreoffice.org/51550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20loplugin:useuniqueptr in SwCalcNoel Grandin
update the table to use a template, which gets rid of lots of casting Change-Id: Ic9ed3901a33e1cd1a1d4335a704d0dd91a5c2f8a Reviewed-on: https://gerrit.libreoffice.org/51414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20tdf#83877 SignatureLineDialog: Fix reading "can add comments" propertySamuel Mehrbrodt
Change-Id: I771428a37a624f80dba2db9a10297d3a1624f215 Reviewed-on: https://gerrit.libreoffice.org/51546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-20tdf#83877 ODF: Load signature linesSamuel Mehrbrodt
Change-Id: I6a92246161be34bc6ecea8f1c04229a5dd593deb Reviewed-on: https://gerrit.libreoffice.org/51535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-20Signatureline ODF export: Use tokens instead of plain stringsSamuel Mehrbrodt
Change-Id: I80eca35b03be2a7f288705295a355f08fbc757be Reviewed-on: https://gerrit.libreoffice.org/51542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-20Colibre icons: update base table small iconsandreas kainz
Change-Id: Iaa16f4cc70ae705f18e1b43b0bf7f8c7f1500277 Reviewed-on: https://gerrit.libreoffice.org/51600 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-20Breeze icons: add ed03 for base and update colors in colibreandreas kainz
Change-Id: I13aa38fa5a08b6bd4ef1c66e03622a3a64615a08 Reviewed-on: https://gerrit.libreoffice.org/51604 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-20Colibre icons: sc_formatimagemenu.png -> sc_insertgraphic.pngandreas kainz
Change-Id: I6f4d61682182d44bea4194f66fe1c9c0bcf8a13a Reviewed-on: https://gerrit.libreoffice.org/51606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-19coverity#1430069 silence Uninitialized scalar fieldCaolán McNamara
Change-Id: I54b2140d965fc9c7dddfdcbddd9602ede800c3f7 Reviewed-on: https://gerrit.libreoffice.org/51566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1266496 Untrusted loop boundCaolán McNamara
Change-Id: I89aaf8aab9e4f5230feb4c398fa4ebe9dc5e0add Reviewed-on: https://gerrit.libreoffice.org/51563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19Colibre icons: add base iconsandreas kainz
Change-Id: I7d4aecf09e34e6202efcc9bab3a41726c2f3ca3e Reviewed-on: https://gerrit.libreoffice.org/51592 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-19coverity#1430074 Uncaught exceptionCaolán McNamara
and coverity#1430066 Uncaught exception coverity#1430095 Uncaught exception Change-Id: Idca2e12d3911e3ea768a2a9fb8e7f3b03a2c887f Reviewed-on: https://gerrit.libreoffice.org/51567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19sw XHTML export: avoid <strike> for strikeout in ReqIF modeMiklos Vajna
Similar to how <u> for underline is avoided, the spec explicitly forbids this. Change-Id: I314a49df496d7b02049154564884e296b9633576 Reviewed-on: https://gerrit.libreoffice.org/51578 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-19sw: more tweaks to sanity check in SwFrame::GetNextSctLeaf()Michael Stahl
* ooo50432-1.sxw has a move from a page with columns to a page without columns * kde327565-1.odt has a move from a page without columns to a page with columns * novell348228-1.odt has a section inside a fly frame that has no mpUpper Change-Id: I65afbbad7bb1b7aa3bf7cac8ff78e864adf66c3c Reviewed-on: https://gerrit.libreoffice.org/51572 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-19coverity#1430061 silence Unchecked return valueCaolán McNamara
Change-Id: I76288e6c7907487efb986f9367c640257f47deb1 Reviewed-on: https://gerrit.libreoffice.org/51559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430065 silence Uncaught exceptionCaolán McNamara
Change-Id: I71d5fedb8753d41effa3ebf41811f81f369dae54 Reviewed-on: https://gerrit.libreoffice.org/51564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430097 Dereference null return valueCaolán McNamara
Change-Id: I1cba6a67c2b94b5906c017960e5636d5e7b87dd2 Reviewed-on: https://gerrit.libreoffice.org/51565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430057 silence Argument cannot be negativeCaolán McNamara
Change-Id: I58bf1a204393ea95c85f51cf9ef3387db1565a4e Reviewed-on: https://gerrit.libreoffice.org/51558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430077 add assert for 'Division or modulo by zero'Caolán McNamara
and coverity#1430076 Division or modulo by zero coverity#1430078 Division or modulo by float zero coverity#1430082 Division or modulo by float zero coverity#1430083 Division or modulo by zero coverity#1430085 Division or modulo by zero coverity#1430102 Division or modulo by zero coverity#1430103 Division or modulo by zero Change-Id: I9d7190f95d19a755c681f1f897a8921105ef7c46 Reviewed-on: https://gerrit.libreoffice.org/51568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19Colibre Breeze icons: links.txt updateandreas kainz
Change-Id: Ibd0a22986c5eb67a5b1a9078ed7415b71f882cf6 Reviewed-on: https://gerrit.libreoffice.org/51586 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-19sw XHTML export: fix missing type attribute for fallback imageMiklos Vajna
This was working in OutHTML_FrameFormatGrfNode(), but not in OutHTML_FrameFormatOLENodeGrf(). Change-Id: I4f8e280713cad2a00cad5da65a09afc5a36d40d0 Reviewed-on: https://gerrit.libreoffice.org/51571 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-19lokdialog: Set parent for AutoCorrect Options... so that it can be tunneled.Jan Holesovsky
To get this dialog: Right-click on a mis-spelled word, and it's in the tunneled context menu. Still it should be converted to async though. Change-Id: Ia8f2aaf0d04f144c74999107de98e52cd51876e7 Reviewed-on: https://gerrit.libreoffice.org/51441 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 7b83827d7b5d07401878fe552c421331629a7880) Reviewed-on: https://gerrit.libreoffice.org/51548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-19Add BSTR handlingTor Lillqvist
Change-Id: I89fcb37a5848120d5a3b2d73d40384c18d6cc069
2018-03-19coverity#1430056 Dereference null return valueCaolán McNamara
Change-Id: Ib3b0ca660c1d44794179abf71a81e1bda5124064 Reviewed-on: https://gerrit.libreoffice.org/51557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430073 silence Unchecked return valueCaolán McNamara
Change-Id: I3c40f0679fea99b22489fedb5af17982c1502a86 Reviewed-on: https://gerrit.libreoffice.org/51560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19coverity#1430093 Logically dead codeCaolán McNamara
regression from... commit e9171066136868fe89947dda5095e9479d5e50e7 Date: Sat Mar 10 18:00:58 2018 +0100 Use for-range loops in editeng Change-Id: If7601ecc0d8d87bf87d982544e0f4b5b2a5d91c6 Reviewed-on: https://gerrit.libreoffice.org/51561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-11 21:55:59 +0000