summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-06-04coverity#1302607 Logically dead codeCaolán McNamara
also coverity#1302606 Logically dead code Change-Id: I510f17e93f7caf5f1c35becdf6b7d626c0160b66
2015-06-04coverity#1302656 Unchecked dynamic_castCaolán McNamara
Change-Id: If84fc54892bbe65799b3bc344c700bb43bedc0cd
2015-06-04get-bugzilla-attachments: actually use the fdo bugzillaMichael Stahl
bugs.libreoffice.org redirects to bugs.documentfoundation.org, which isn't very helpful as it just causes duplicate downloads. Arguably freedesktop.org could be removed; the are just ~5 interesing attachments since the TDF bugzilla migration. Change-Id: I26d2667848582209e382226108c47549e99cee97
2015-06-04get-bugzilla-attachments: avoid writing incomplete filesMichael Stahl
Change-Id: I7d1139ddf8c88626dd716aa537a305c31b5be5d9
2015-06-04get-bugzilla-attachments: avoid FDO-TDF duplicates...Michael Stahl
... by checking that a file with "fdo" already exists for bugs older than the migration, instead of just ignoring the old bugs on TDF. There are > 300 additional attachments not on freedesktop.org. Change-Id: Ib7ee63041109071cc1241a875ef2cccbddfc699d
2015-06-04get-bugzilla-attachments: fix the multi-threadingMichael Stahl
The queue was limited to an arbitrary maximum size, causing half of the jobs to be droppend on the floor. Also it didn't run on Python 3. Change-Id: I90bfba448291d901c5a7c83389d17c6acdd919c8
2015-06-04update to liborcus 0.9.1David Tardon
Includes switching to dynamic libs. Change-Id: I959c4e9430f8cf95f50d48e1b01d8323dba4af81
2015-06-04Fix using /opt/lo/bin/nasm on windows/cygwinAndrzej Hunt
Change-Id: Ib3755598bfccffc2efd67816ae5fa5dc8903553e Reviewed-on: https://gerrit.libreoffice.org/16083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-04Fix a regression introduced at 3d30077af27c8a6e91fb91175e6d2ea9a6f03d11Takeshi Abe
Change-Id: I245bff2ac179381b7eef7c276bbade15b0a57938 Reviewed-on: https://gerrit.libreoffice.org/16082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-04coverity#1304135 Missing break in switchCaolán McNamara
from commit 0e2ef262bea4cbc7cb04cfcd1d47f2a9d6092398 Date: Thu May 21 13:58:52 2015 +0200 tdf#88276: Add background colour toolbar and sidebar buttons but they do nothing yet, follow-up commit(s) add real functionality to them I take it that bNeedTextSpacing = true where it used to be mpToolBoxSpacing->Enable() so fall-through that happens anyway also sets bNeedTextSpacing so presumably everything is ok here Change-Id: I8f1d4137a74fcc2c7ba6959e5b5c4b1f7464643c
2015-06-04tdf#91260: cleanup - textboxes extending beyond the pageLászló Németh
Storing Undo data is unnecessary here, because shrinking is applied only on the text frame of the textbox. The shape component of the textbox isn't modified. Change-Id: Iaff64ff4953adbfa830832da146343cef2734547
2015-06-04tdf#91781 Changes based on discussion of heiko suggestionsYousuf Philips
Change-Id: I6d70e40c829e125205516d894e4fd1a36e7882fa Reviewed-on: https://gerrit.libreoffice.org/16067 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2015-06-04fix rendercontext rendering of standard toolbar iconsLászló Németh
Change-Id: I6e0399c16d3e900fbca56fc757f342ea893d0ad4
2015-06-04Don't downcast this to derived in base ctorStephan Bergmann
Change-Id: I1a0a6a7f0ac2292a7824bd35967140a20ee93f89
2015-06-04abpilot: refer embedded data source from doc settingsMiklos Vajna
So that even if the address book data source wizard creates the embedded data source, next time the document is loaded, we can find it. Change-Id: Ibb11fa119fb27976437e54bed1d590cfd9863236
2015-06-04tdf#90996: don't overwrite comments in ScTable::FillFormulaVerticalMike Kaganski
IDF_CONTENTS includes IDF_NOTE, which should not be used here Change-Id: I904fbdbfcb97865a5682d9073e0ce2d5a2c694fb Reviewed-on: https://gerrit.libreoffice.org/16085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-04DomainMapper::lcl_attribute: fix missing breakMike Kaganski
Change-Id: Ibf0bd1c8bf2799ffbe5254ae11998a58d927b592 Reviewed-on: https://gerrit.libreoffice.org/16074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-06-04GetWin seen as NULL sometimesCaolán McNamara
Change-Id: I08974e3a8a3f34e2c1f0843c536e72ca0eb4b29d
2015-06-04Match basicide_choose_macro in basctl/source/basicide/basobj2.cxxStephan Bergmann
Change-Id: I9add8be1c20c2529edf8d8616fe5e372938cd355
2015-06-04Match basicide_macro_organizer in basctl/source/basicide/basobj2.cxxStephan Bergmann
Change-Id: Ib185645e84f8792d3ed29e7d5e674e5e7cc39fc5
2015-06-04unusedStephan Bergmann
Change-Id: Ie11bf740c0ae672e7e1b14652f93bb6222bf45b7
2015-06-04tdf#91840: Default to transparent text backgroundKatarina Behrens
(+ label the button) Change-Id: Icc6a0c5e3e715bcfe1392496bef2514fd1bdb62b
2015-06-04Use switch-case instead of overly long 'if (a || b || ...)'Katarina Behrens
they were growing a bit out of control Change-Id: I80441179b4d4aacc57c469fc8f3a3937866ceae8
2015-06-04abpilot: embed the data source definition, if possible + requestedMiklos Vajna
Change-Id: I0e70459e331995388b36c77c351bff89ece004a6
2015-06-04abpilot: store embedding preference in AddressSettingsMiklos Vajna
Change-Id: I83235f79d30e5f573fee95a525b4cfe1211a24b7
2015-06-04abpilot: add checkbox to embed data source in datasourcepageMiklos Vajna
Change-Id: Iea9984af3f08ed214815b9477019695f2339a7f3
2015-06-04Resolves: tdf#84483 postit layout not available in print preview modeCaolán McNamara
for the moment don't crash anyway, maybe we can rearrange matters to make this possible. Change-Id: I2dc9831e5b026004b2f7603e618330154dbd6d1b
2015-06-04tdf#91425 CRASH - Calc Insert Columns LeftTakeshi Abe
This fix is a SCCOL variant of: commit c66d1b9fcc2244b4fd8940f17ebf4e772f09c84e Author: Kohei Yoshida <kyoshida@novell.com> Date: Thu May 5 00:23:25 2011 -0400 fdo#36406: Let's not use invalidated iterators. std::set::erase(iterator) call invalidates the iterator of the erased element. We better not use it after the erase() call. Since the number of manual breaks should not be high enough to cause a performance bottleneck under normal usage, a safer linear copy should just be fine. Now, I'm not sure if this indeed is the cause of the erroneous amount of manual breaks in the test document, but I didn't see any other likely spot. Change-Id: I0c2e8f738949776aa7f8ea5528e2c0eeb9351c16 Reviewed-on: https://gerrit.libreoffice.org/16063 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-06-04loplugin:simplifyboolStephan Bergmann
Change-Id: I19e96b882a5cc8991035a8275aebd4ff586bf9f3
2015-06-04disable off-screen drawing of statusbar items (for now)Tomaž Vajngerl
Change-Id: I5deac9924b99ac1b3e1440623364004b0b44aaf5
2015-06-04Fix typo in .gitignoreZsolt Bölöny
Change-Id: Ibecee87ffe3ec6990e36952488668b790a8e54eb Reviewed-on: https://gerrit.libreoffice.org/16076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-06-04Resolves: tdf#46440 SIGSEGV on toolkit bootstrap without running instanceCaolán McNamara
Change-Id: I9a78a75b3d72586b1702ed6fa63bb0b62ce6cd72
2015-06-04replace FLYPROTECT with scoped enumNoel Grandin
Change-Id: I665d2944f5d24b4ec5015274c1b95b106a028291 Reviewed-on: https://gerrit.libreoffice.org/16072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04Revert "disable JunitTest_dbaccess_complex part RowSet"Stephan Bergmann
This reverts commit 217dbf61ece9318f4430780d10cef60920086de7, the test should work now reliably after the preceeding "Finalizers must not access UNO objects" commit.
2015-06-04Finalizers must not access UNO objectsStephan Bergmann
If the object being finalized (A) has the last reference to the UNO object (B), and B is actually a proxy for a remote UNO object, then A and B become eligible for finalization in parallel, and the finalizer of B may already have run when the finalizer for A runs. That means that B may already have been removed from the remote bridge, causing an "unknown OID" error from the remote end when the finalizer of A now tries to make a call on B. (We try to assert that close() has actually been called before finalize() calls delete(), but the corresponding exception may be silently swallowed by the JVM finalization machinery.) This caused spurious "URP: queryInterface request message with unknown OID received" failures during JunitTest_dbaccess_unoapi. Change-Id: Ia47c3ef2c22a6adc75b1b8271eb4b3140accebe7
2015-06-04More informative exception messageStephan Bergmann
Change-Id: If168a3be2630170636c333e177c5db0d40092cbe
2015-06-04Let JUnit take care of exceptionsStephan Bergmann
Change-Id: Ic628e4eccab59dce5d6d5e77656cac1f0006a491
2015-06-04tdf#91529 hopefully fixes the issue by painting immediatelyTomaž Vajngerl
Change-Id: I0c97e489150cd65d1ab1dbff4ee9f1699f89ac2e
2015-06-04convert GOTOOBJ constants to scoped enumNoel Grandin
Change-Id: I2f44e780c7250cdbf40fde8779beb81f29498f8b Reviewed-on: https://gerrit.libreoffice.org/16071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04svl: prefix remaining members of SvxSearchItemMiklos Vajna
Change-Id: Id538ee368de6cd63f08618e6284bca97e20bf7a3
2015-06-04convert MT_ constants to scoped enumNoel Grandin
Change-Id: I21e253ed9dccdab84be4838b5beee9385467ed37 Reviewed-on: https://gerrit.libreoffice.org/16068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04uno::Sequence provides now begin and endNoel Grandin
use begin() and end() when calling std::copy on an uno::Sequence Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2 "uno::Sequence provides now begin and end" Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b Reviewed-on: https://gerrit.libreoffice.org/16057 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04convert SW_DB_SELECT constants to scoped enumNoel Grandin
Change-Id: I03387e8e90891b3477c9c15200acc127262170bc Reviewed-on: https://gerrit.libreoffice.org/16070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04convert SP_EXTEND_RANGE constants to scoped enumNoel Grandin
Change-Id: I4d6ed976f4df63c7c51dd110b45787f2396518e4 Reviewed-on: https://gerrit.libreoffice.org/16069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-04convert PropertyMode to scoped enumNoel Grandin
Change-Id: I9b0bbf6273aa18ae918d1d69af5dcc7652181f5c
2015-06-04convert B2DLineJoin to scoped enumNoel Grandin
Change-Id: I4fb8f2c9e2080e3aa542d2ccf838e6784baa8429
2015-06-04convert B2VectorContinuity to scoped enumNoel Grandin
Change-Id: Ifa401dd0d2d1bef8c0ae2987d2aee86100b59816
2015-06-04convert B2VectorOrientation to scoped enumNoel Grandin
Change-Id: Id7e444bc896ae5d52e5a0bd1b471679c4945afa4
2015-06-04convert basegfx::FillRule to scoped enumNoel Grandin
and drop unused NONZERO_WINDING_NUMBER value Change-Id: If2a8f01934796eaf9a343113387b775fd169ccb9
2015-06-04convert basebmp::Format to scoped enumNoel Grandin
Change-Id: I6eb213d6dcf387936967271fba9e2de3879ef479