summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-05-08Fix testStephan Bergmann
...after 7764439f85f23efb4510b41e795abd1e4c9089e9 "WidgetDefinition: add 'action' state for the PushButton" introduced code that downcasts that suspicious ImplControlValue to a PushButtonValue Change-Id: I3ed24cc4a862d53ad5b6e95b4707bab7947ce7ba Reviewed-on: https://gerrit.libreoffice.org/71998 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2019-05-08Add some comments to macOS backend impl. of SalBitmapTomaž Vajngerl
Change-Id: Idfefe7598df0b2e382be84aa5bfc8b60201768a7 Reviewed-on: https://gerrit.libreoffice.org/71991 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-05-08crashtesting: many asserts in SmTextNode::PrepareCaolán McNamara
e.g fdo58094-1.mml since... commit 13894996601daf10d133f4a71eb0b26794d782bc Date: Sat May 4 21:46:31 2019 +0200 handle empty Rectangle better in starmath Change-Id: I01d11352b8bc9f6dcf6d6565fa41b84d549f620f Reviewed-on: https://gerrit.libreoffice.org/71963 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-08improve tip to indicate its only writer, and the text cursor editing positionCaolán McNamara
Change-Id: I66db4b9f800eb2e3e0b81d4e8f9c2b7f742d23cf Reviewed-on: https://gerrit.libreoffice.org/71953 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-08downgrade warning to infoCaolán McNamara
Change-Id: Ia29abf667b1d010692e89b3b8c23614a4b345669 Reviewed-on: https://gerrit.libreoffice.org/71962 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-08find-unneeded-includes: dont propose to replace ctime with internal headerGabor Kelemen
As seen in sw/source/core/inc/layact.hxx Change-Id: Icc4281cd57b0cd8310a1044f6106691a5d1cd3c4 Reviewed-on: https://gerrit.libreoffice.org/71884 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-08merge duplicated TriStateEnabled classCaolán McNamara
Change-Id: I1c10010eb7fd33a03f477af0cba03ae74859b174 Reviewed-on: https://gerrit.libreoffice.org/71959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-08tdf#119931 Fix a11y warnings in compressgraphicdialog.uiRasmus Jonsson
Rearrange objects in code to correspond to actual layout & conform to rest of file. Change-Id: I9c86000f335c2d5305286b42b9cd434e922f07c6 Reviewed-on: https://gerrit.libreoffice.org/70340 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08tdf#119931 fix a11y warnings in docking3deffects.uiRasmus Jonsson
+ rearrange code to correspond to actual layout in dialog Change-Id: I4a83f230e1d523a5d03121338de0466e9a61852e Reviewed-on: https://gerrit.libreoffice.org/70608 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08tdf#119931 Fix a11y warnings in classificationdialog.uiRasmus Jonsson
Remove warning suppressions. Create svx.false for false warnings. Rearrange objects in code to correspond to their actual position on the screen. Add new label for part entry box. Change-Id: I2a7293024427e65cca2ea754fac4fe1bc7d6d0bd Reviewed-on: https://gerrit.libreoffice.org/70338 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08make update_pch.sh work with symlinked path or CDPATH setLuboš Luňák
Change-Id: I059393357c3b0d91e30c16df066fb6dd8ba28ab9
2019-05-08Fix commentSamuel Mehrbrodt
Change-Id: Ic2093aaea6e71559ba49e248f9afd5d86bcb0b67 Reviewed-on: https://gerrit.libreoffice.org/71949 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08Respect page margins of the source doc during redactionMuhammet Kara
Change-Id: Ieaa50a2eba17145180ddd5d2bfc77add4801c43a Reviewed-on: https://gerrit.libreoffice.org/71929 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-05-08AddressSanitizer: alloc-dealloc-mismatch (malloc vs operator delete)Stephan Bergmann
__cxa_demangle uses malloc/free for memory management, see <http://itanium-cxx-abi.github.io/cxx-abi/abi.html#demangler> Change-Id: I57f8465d1c70fbef4537068fd3aefc52295e1c63 Reviewed-on: https://gerrit.libreoffice.org/71942 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-08Fix typed flags bitmask, tdf#125099 follow-upEike Rathke
Change-Id: I25327cfcafc9e1f2e88b388677853c638dd9b0e6 Reviewed-on: https://gerrit.libreoffice.org/71946 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-05-08improve tools::Rectangle->basegfx::B2?Rectangle conversionNoel Grandin
Improve the conversion method to do something reasonable with empty Rectangle. Use the conversion method in more places. Change-Id: I48c13f3d6dae71f39f03f7939101e545c8125503 Reviewed-on: https://gerrit.libreoffice.org/71853 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-05-08Convert OSL_ENSURE to SAL_WARNSamuel Mehrbrodt
Change-Id: I6213bd2b10746416a5e0bc9029c49b0b09a8b0a4 Reviewed-on: https://gerrit.libreoffice.org/71947 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08Replace remaining lists by vectors in xmlsecurityJulien Nabet
Change-Id: Ia7e47e8398a0022a281de2b8866e779d471909b0 Reviewed-on: https://gerrit.libreoffice.org/71951 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-08tdf#116501 fix freezing at embedded text tablesLászló Németh
by disabling their in-row splitting using loop control. Change-Id: Ibd93213fa0ce45458ce188de20da982e4abc17c5 Reviewed-on: https://gerrit.libreoffice.org/71920 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-05-08Typo in tip of the dayStephan Bergmann
Change-Id: I344300807b0bfce0b779b2d64337dad96eee86c9 Reviewed-on: https://gerrit.libreoffice.org/71945 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2019-05-08Fix typoAndrea Gelmini
Change-Id: Iea5bd392f82e26e3c60ca332ae4bea942888e236 Reviewed-on: https://gerrit.libreoffice.org/71928 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-08Fix typoAndrea Gelmini
Change-Id: I7abab185624c5a6a6e28334dd680fafece7abfab Reviewed-on: https://gerrit.libreoffice.org/71940 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-08desktop: can pass by value in LOKTransferableMiklos Vajna
Change-Id: Iba7c216f28700e8899d76942a4a0a8b77ed3c549 Reviewed-on: https://gerrit.libreoffice.org/71930 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-08tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl
Replace OSL_VERIFY with if-statement and SAL_WARN. Change-Id: I356a875e1364f3d16f562f3cfa0b41e0939e43d5 Reviewed-on: https://gerrit.libreoffice.org/71923 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-08tdf#120269 Remove misleading description from safe mode dialogSamuel Mehrbrodt
Change-Id: Ieec62c2793419ee82ecd6f95497e710900ad9be1 Reviewed-on: https://gerrit.libreoffice.org/71886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-08Resolves: tdf#125099 round duration results in interpreter alreadyEike Rathke
So wall clock time formats less likely display a one-off value, duration formats are too rarely used if the expected duration is less than 24 hours. Change-Id: I9b0872420699b17e3ed3f20993f8cfe02761f862 Reviewed-on: https://gerrit.libreoffice.org/71909 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-05-07Test RANK(), not the underlying floating point representation of durationEike Rathke
The RANK() results depended on the floating point representation of time differences (durations), which for visually equal MM:SS display values don't have to be equal if similar durations result from different start and end times. Change that to a well defined duration in seconds. Change-Id: Ib69a6b43f48abd2d4fe605021acfd2800e75b5e1 Reviewed-on: https://gerrit.libreoffice.org/71926 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-05-07Win7 is current baseline, so no need to differentiate for 32- vs 64-bitMike Kaganski
Also remove special-casing for 64-bit libraries introduced in commit 92dfaaa0bfd08de58ccf9387c805ade24c04b41b, which is obsolete with 6.01. Change-Id: Ia5befa99788321292b1a4343c2dbb5d8fbba08c9 Reviewed-on: https://gerrit.libreoffice.org/71915 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-07PPTX: Fix import / export of image transparencyTamás Zolnai
Change-Id: Ib07c606083b833389fcb82aac57ca8535d6e861f Reviewed-on: https://gerrit.libreoffice.org/71916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-05-07Fix typoAndrea Gelmini
Change-Id: I43ba5d6591be6ad782bc72bac1938ae9763c7103 Reviewed-on: https://gerrit.libreoffice.org/71900 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-07Fix typoAndrea Gelmini
Change-Id: Idefeaeb8dbe53f6709d2f9655c2bbcd1486632cc Reviewed-on: https://gerrit.libreoffice.org/71921 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-07Fix typoAndrea Gelmini
Change-Id: I8d705a0d31f36242f8a93591a2c0fc69ee6847a0 Reviewed-on: https://gerrit.libreoffice.org/71911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-07Drop LINK_X64_BINARY: any MSVC linker is suitable for any target platformMike Kaganski
Change-Id: I8b080ad44f10e52fa5a726bd7cdf7dd8ff7e2dd4 Reviewed-on: https://gerrit.libreoffice.org/71913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-07tdf#123549 Qt5 implement Qt5Menu::ShowCloseButtonJan-Marek Glogowski
This includes some not-so-nice lifetime handling of the button "clicked" connection handling. I decided to keep the code in one place, simply always forcing a disconnect on show, instead of a more "optimized" code version in SetFrame. First we try to get the icon from the system theme, but use LO's own icon theme as a fallback. Change-Id: Ic0459623ec907b9a54bef4670bf65cf587cd47ea Reviewed-on: https://gerrit.libreoffice.org/71784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-07Resolves: tdf#125106 fix cell protect TriState togglesCaolán McNamara
Change-Id: I1f145558fe9d86682e03481fb2800386d04d2b1d Reviewed-on: https://gerrit.libreoffice.org/71904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-07foruilo-ArgEdit is not a buildable anymoreCaolán McNamara
Change-Id: Id3b2e769afb32a6a5214ae6feae8d7251d676af5 Reviewed-on: https://gerrit.libreoffice.org/71906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-07Resolves tdf#124978 - Tip-of-the-day referencesheiko tietze
* LibreOffice changed into %PRODUCTNAME * std::pair made into std::tuple and hyperlinks separated from strings * tip about donation / getinvolved added * "Use an array formula to repeat a calculation with different values..." removed * "%PRODUCTNAME supports 110 languages"->"%PRODUCTNAME supports over 150 languages" * code added to open offline help * online hyperlinks converted into offline links, if available * Ctrl, Shift, Alt uppercased * › replace by > * ellipsis removed Change-Id: Ic35257d0a6d6e77750716254fb9d1f6983a54af1 Reviewed-on: https://gerrit.libreoffice.org/71760 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-07tdf#125153 vcl: fix ImplReadDIBFileHeader()Michael Stahl
Apparently the offset needs to be checked against the total size of the stream, not against the remaining size. (regression from b67d9a5db61de3cef2dac072c55bf1dac9a2dc4c) Change-Id: I7e714b7c4ce34b5285cfbf9ca81133ecbbb16fc1 Reviewed-on: https://gerrit.libreoffice.org/71903 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-07loplugin:badstaticsNoel Grandin
add some more false+ which interestingly enough, only started showing up when I switched on --enable-pch=system Change-Id: I2d52644dc3665db19b28772eb818c138e063dae4
2019-05-07tdf#43157 Clean up OSL_VERIFY (replace with SAL_WARN)Jens Carl
Replace OSL_VERIFY with if-statement and SAL_WARN and add some unit tests to ensure the implementation works and the replacements don't introduce some side effects. Change-Id: I4ed50eee53e4dba4d392ed2486186d48f919ce1d Reviewed-on: https://gerrit.libreoffice.org/71712 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-07downgrade warning to infoCaolán McNamara
Change-Id: Id337f26471f54d7d52c293629b9d19901b188c63 Reviewed-on: https://gerrit.libreoffice.org/71897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-07tdf#119044 setup_native: let -core depend on -ooofontsMichael Stahl
Things break without OpenSymbol font. On the other hand, if you install just the fonts, but not anything else, you can happily use the fonts in other applications. So just invert the dependency. Change-Id: I4c2dbff59699365cba67d3b1c6ade5ec7c2462bf Reviewed-on: https://gerrit.libreoffice.org/71898 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-07weld FormulaDialogCaolán McNamara
drop xFocusWin hack, I don't see what gain it gives Change-Id: I31952b5440797e6209ed1de6b546f1e4c0238d08 Reviewed-on: https://gerrit.libreoffice.org/71675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-07Resolves: tdf#125132 xml signatures dialog should be modalCaolán McNamara
Change-Id: I6b8e93070e89e90341e02e8d714c47d4b0931845 Reviewed-on: https://gerrit.libreoffice.org/71899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-07tdf#124829 sc: fix crash during progress updateSerge Krot
Call reschedule() during update of the cells height is not thread safe. Change-Id: Ia938aead79a048f12a53aa55c034e84ce3bf433b Reviewed-on: https://gerrit.libreoffice.org/71892 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-05-07unipoll: emit user input-events & uno commands directly when in unipoll mode.Michael Meeks
Rather than emitting asynchronously at idle. Change-Id: I6c72e9fad0b5587941e3a4a4d17d331a0d889942 Reviewed-on: https://gerrit.libreoffice.org/71809 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-07tdf#63640 FILEOPEN/FILESAVE: particular .odt loads/saves very slow, part2Noel Grandin
Use the existing sorting functionality in SfxItemPool and extend it to search for NameOrIndex item in SvxUnoNameItemTable This is a little tricky in that we are defining only a partial ordering over the CntUnencodedStringItem (and their subclasses) items. Partial because I can only use the part of the item that is not randomly mutated by various code, which is why the other fields in the subclasses are mostly out of bounds. I had to exclude FillBitmapItem because it triggers a unit test failure and I cannot figure out why that specific item does not play nice with this optimisation. After this optimisation, the load time goes from 3.6s to 2s on my machine. Change-Id: I52d58c68db2536b69a7b0a9611a2b4c703bc4928 Reviewed-on: https://gerrit.libreoffice.org/71461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-07tdf#62699 Drop pass-through header file include/svx/xattr.hxxGabor Kelemen
Change-Id: I8db9a4de494fbd045a0f4da810c3887ce62dd350 Reviewed-on: https://gerrit.libreoffice.org/71595 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-07Get properties from both setsArkadiy Illarionov
Fix copypaste typo Change-Id: I59fe87a8739b968404012b41796f1092dc0e0f7f Reviewed-on: https://gerrit.libreoffice.org/71890 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-07missing includeStephan Bergmann
Change-Id: If495a201b1d15a3bf754fbabeecf9f1239a2d406
generated by cgit (git 2.34.1) at 2025-01-07 18:44:51 +0000