Age | Commit message (Collapse) | Author |
|
Change-Id: I089fd6b9281cc35768462e83a7e18588f357df4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152003
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
See
https://crashreport.libreoffice.org/stats/signature/sw::GotoPrevLayoutTextFrame(SwNodeIndex%20&,SwRootFrame%20const%20*)
and
https://crashreport.libreoffice.org/stats/signature/sw::GotoNextLayoutTextFrame(SwNodeIndex%20&,SwRootFrame%20const%20*)
Change-Id: I2233078051bd653de5634f1e0dabab9c1f59acb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151994
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
|
|
Tooltip of a deleted table column shows "Column Deleted",
an inserted table column (will) show "Column Inserted".
Follow-up to commit ffd8d20d368a885d6d786749278fa438573227a7
"tdf#150673 sw xmloff: import/export tracked table column" and
commit 84fbb3398f7486f00e7b7dea415e1ea2510a9535
"tdf#146144 sw: add tooltip to table rows with change tracking".
Change-Id: I79fd2397410328b320bd2536285cc5cc835da9fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151998
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Type info for ScCondFormatItem is now needed, see
<https://ci.libreoffice.org/job/lo_ubsan/2782/console>.
Change-Id: I7cd7762bbd9f961e78d6f2fa98a808ff88a82269
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151993
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Iae2332f088a5ed48f373f6f5389c4ea47f64f308
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151986
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: If39ff84ec74e29fdfcd21194ef371108b591caed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151996
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I27c03c0312331b7f1050f5edb28fc5e658240b41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151997
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Reset the MajorOrigin property after import to avoid
of the bad export of the modified document, which reset
the original On tick marks/Between tick marks value.
Follow-up to commit 40d83914d43f60a196dfabddea0b52e2046b333a
"tdf#127792 implement UNO chart attribute MajorOrigin".
Change-Id: I0e3915b7d1b601abd40fbd1ba9d01fc05a8fb7c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151885
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Make Reference Marks behave like nesting attributes such as
Hyperlinks. This is described as the ideal behavior in
<https://bugs.documentfoundation.org/show_bug.cgi?id=81720#c24>
Change-Id: I34ddfb3a6aa0147ba4bc281ebbb6342089b7bd08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146941
Reviewed-by: Matti <matty@uef.fi>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
When closing the dialog, UpdateCursor() creates a table cursor for
ExtendedSelectedAll() because mbSelectAll isn't set.
1 SwShellTableCursor::SwShellTableCursor
2 SwCursorShell::UpdateCursor
3 SwCursorShell::ShowCursor
4 SwView::ShowCursor
5 SfxViewFrame::Enable
6 SfxViewFrame::Notify
7 SfxBroadcaster::Broadcast
8 SfxObjectShell::SetModalMode_Impl
9 SfxViewFrame::SetModalMode
(regression from commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda)
Change-Id: Ie73f8e42f764f8041288eb0850721a530d106a0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151880
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Fails with commit 971c9945825db02a4809538d26fff3ae77d16866 (Fix
"AddressSanitizer: heap-use-after-free", 2023-05-18) reverted in an ASan
build.
Change-Id: Ie87039c2c46abaf2f73cb1bbad48d2d1f7e59392
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151991
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Added code to make WriteGradientFill directly use the
available BGradient implementation. The goal is to
never directly work on awt::Gradient2, but use
BGradient & it's tooling methods.
Added constructors and tooling to BGradient and
BColorStops to make that easier (single line
conversions between uno::Any, basesgfx classes
and awt:: incarnations). Directly handle uno::Any
and awt:: classes, changed stuff to make use of
this.
Change-Id: I083a323b9efee8ca4f3becb2966aac0a294b9a60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151842
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
There seems to be some crashes related. See
https://crashreport.libreoffice.org/stats/signature/ScDocShell::GetDocument()
or
https://crashreport.libreoffice.org/stats/signature/ScDocShell::RegisterAutomationWorkbookObject(com::sun::star::uno::Reference%3Cooo::vba::excel::XWorkbook%3E%20const%20&)
Change-Id: I9affce5a28cb1198eb472d369debf83fd7dd8c0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151955
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
See https://crashreport.libreoffice.org/stats/signature/static%20void%20%60anonymous%20namespace'::SvxStyleBox_Base::Select(bool)
Change-Id: I6edce9c8bad1ee087ddf884ff47439cceee3f1de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151964
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I9a9ef0b85140dd622c42983613464f76e29ee35e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151870
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
EndActionByVirDev only arises in the non-mainstream use html web document case and precedes the introduction of DoubleBuffer. It would be helpful to have one less corner case to consider.
Change-Id: Ibb9064cf5b37b1806f90c24ad9fbf84a8e37c0c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151854
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
A reduced bugdoc from tdf#155002 has 2 floating tables: one table on the
first page, second table on the second page. The second page had 2 fly
frames: the first row of the 2nd table in the first fly and the
remaining rows from the 2nd table in the second fly, and they were not
joined, which lead to overlapping text.
It seems what happens is that the fly is split: first row goes to the
first page, rest goes to the second page. Later we move the master fly
to the 2nd page as well, but we don't try to join the table, since the
master fly has no additional space. It's a circular problem: once we
split the fly, we limit the master fly size to what's necessary, so once
the 2 flys are on the same page, we don't move content from the follow
fly to the master fly because we believe it has no space... but it has
no space because the content is not moved.
Solve this problem similar to what the web view already does: in case a
table frame has a follow and the table frame is in a split fly that can
grow to host at least one follow, then try to grow it to host all
follows. This prevents layout loops, since we don't move content from a
follow fly to a master fly when it would not fit anyway, but allows
large enough master flys so table joining happens.
The crash with the original tdf#155002 bugdoc needs more work, still.
Change-Id: I411b21d796be82ab5600d66b600cb50c116db4e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151956
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
seen reports in crashreporter
Change-Id: I10ecac363eea0292f9dc257769da6d060dc350f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151962
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Ideally SwFrame should not really know anything about table frames.
Change-Id: I8d7902e1e80124aa7e09cebc823d9e2bb1425ede
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151982
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I144687f794b4a6f80d5b8b20e0ce0618030aa0ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151985
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Icfb9b79b16dc46a722c46a08f647afaf9ad49b4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151661
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151753
Tested-by: Jenkins
|
|
https://github.com/CollaboraOnline/online/issues/6380
Commit 7481e8b5500e86626be5f8eae1e7f48b7f51e21a (sw_redlinehide_4a:
SwEditShell::AutoCorrect() etc., 2018-11-28) explicitly relied upon
the reference to the node text being updated on editing operations.
Commit 14f6700fefa945c4cf995c09af9326c2a022f886 (use more string_view
in editeng, 2022-04-14) converted the argument of FnChgToEnEmDash to
a string view, which means that any change in the underlying OUString
frees the memory referenced by the view.
But in this method, we really don't want to have the text updated;
so use a local OUString copy for later reference.
Partially revert commit 14f6700fefa945c4cf995c09af9326c2a022f886.
And copy mst's commit 7481e8b5500e86626be5f8eae1e7f48b7f51e21a
message to document the assumptions in SwEditShell::AutoCorrect.
Change-Id: I0ff02958c8de9566d774f366d905aa9bb603055c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151970
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
... and repeated Date::operator++/--() that each calculate
lcl_DaysToDate( GetAsNormalizedDays() + 1 )
where Date::AddDays() does it once.
Also, that probably never worked correctly with negative time results >=24h
Change-Id: Ic67aaa3d93e0d6533501d52671acf765e2d9bbdd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151984
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I885b9e86b9078dc89ba0543103fd630a9ad3bc41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151963
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
|
|
* Update helpcontent2 from branch 'master'
to ccce5b9aa0c1d59f6e3d102eb48191ca7fdb0a0c
- Fix typo
Change-Id: I11c8cfde4e8a53b541cea2ae165044fac11dcae7
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151919
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I33ddd35cc09d0976ac64af80d597ba9d307041e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151960
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ida74d3ff99c4e8c7e6c6402d580ae9d279217105
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151961
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
To connect Xcode's Instruments application to profile LibreOffice, the
"com.apple.security.get-task-allow" entitlement must be added to the
soffice executable.
This script will set the "com.apple.security.get-task-allow" entitlement
instdir/LibreOfficeDev.app/Contents/MacOS/soffice executable so that
profiling can be done using a local build.
Credit for documenting this Xcode requirement goes to the following blog:
https://cocoaphony.micro.blog/2022/10/29/solving-required-kernel.html
Change-Id: I547edf7c1ad340267e9ed4c396fc723b7ea719be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151981
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@neooffice.org>
|
|
since we know that this is a matrix only used for 2D transforms,
we know that the last row of the matrix is always { 0, 0, 1 }.
Therefore, we don't need to store that information, and
we can simplify some of the computations.
Also remove operations like operator+ which are not legal for
such a matrix.
Change-Id: I482de9a45ebbedf79e3b6033575aab590e61c2d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151909
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
to check the whole repository
Change-Id: Ic2df1248604e6e0053a8eeda50869eb5a3b1db0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151942
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
'/' is a better default separator (1 / 5)
than '-' (1 - 5)
Change-Id: I94bc704fbb22e817dfc0008f47880c1d41578880
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151965
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
1. List restart flag in the node does not yet mean that the restart
would actually happen: it will be ignored, if the next node is more
nested than the previous one.
2. When writing nested list items, we should not write additional
<li><ul> pairs for current level (previously, only level 0 was
skipped); same for closing.
Change-Id: I5f67e8fa9236e7e2e6dba2e0ec5dffbf0d7b7f8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151958
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Otherwise these files would be flagged as unused
Change-Id: I3203ef7820a6e5b31d48578d9184b5822836f27c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151940
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
rather than writing a bunch more code, extract the common part from
comphelper::SequenceInputStream into a new base class
Change-Id: I0d3561e3ca2e748b904128e3b5955e27196d7170
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151943
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
XML needs shape geometry so as if no rows/cols are hidden. This had
been calculated by using the shape start and end cell. But that did
not work in some cases. Now the snap rectangle of the shape is used.
During testing I noticed, that the fix in tdf#154005 does not work
correctly. The fix had provided only a workaround for controls. It did
not address the root cause that a shape was size protected but has an
anchor 'To Cell (resize with cell)' at the same time. Such combination
is no longer needed as we have 'To Cell' anchor now, but shapes using
it still exist. The current solution catches such cases now in general.
As large parts of the method are changed anyway, I have put existance
tests at the beginning. That allows shorter conditions and flattens
if-constructions.
Change-Id: I6bd1e15dbdafc43e309a6e12c1c5e3218bb12675
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151717
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
|
|
Otherwise these files will be flagged as unused
Change-Id: I6ae0f8327bc81f57fb63e65dde66742177fc693d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151938
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Commented out since it was introduced in
731a9aab0fa42ed42b5470e2c6f7e9fc6b1e3a85
"add first test for user defined functions"
it no longer crashes
Change-Id: I8a35dc2a737c946e9af1bafb4cc913bb9dc925fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151941
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I83b181b5b613fa8c973f673e1afdc6ee12422545
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151886
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins
|
|
2 parts:
1) in extensions/source/propctrlr/standardcontrol.cxx
if value retrieved from the field is 0, let's return an empty Any var.
2) forms/source/xforms/datatypes.cxx
Allow to select 0 in the spinbox for String and URI ("hyperlink") datatypes
to be homogeneous
Change-Id: Ife9a94c279e8651623112c0bf8a64555cb9c556c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151740
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ia737462375311bb8642a9326a2980111e3ef7064
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151953
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I65b7269dc8717ac12f12bde2b59082cbb2faca53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151952
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ie097c4afad429ed23a616658502e3936afaea86a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151951
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I1a18149550cdfbaf7537213bdf41734751503598
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151950
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I101861eaa810dc6e2f92a57ddc4e247a76a4b558
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151949
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I89d8b370cf95d43de33c35b788fc955adfb85a0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151948
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I372395970887c4201e973aa0583c288714fdbf6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151947
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I7a79c2a4d145d1d847d71e5b36ccdb42278b06cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151946
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I4a9abe0683f6dfd116fa15a6e1202d5a69328553
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151945
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Ifbda8492c1b7c6cef1616a6183e2d04aee1b9bde
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151944
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
and
cid#1530396 Uncaught exception
Change-Id: Ib484a788fc2defd4a337645526f410ee365f7209
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151933
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|