summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-31Fix MSVC2019 build after 629dfff3c7289f185268c7088e67931f6bbd9ce0Mike Kaganski
... failing like this: [CXX] desktop/source/app/sofficemain.cxx C:\PROGRA~2\WI3CF2~1\10\Include\10.0.18362.0\um\winnt.h(656): error C4005: 'DECLARE_HANDLE': macro redefinition C:\lo\src\core\include\sal/main.h(91): note: see previous definition of 'DECLARE_HANDLE' C:\PROGRA~2\WI3CF2~1\10\Include\10.0.18362.0\shared\minwindef.h(250): error C2371: 'HINSTANCE': redefinition; different basic types C:\lo\src\core\include\sal/main.h(93): note: see declaration of 'HINSTANCE' make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:293: C:/lo/src/core/workdir/CxxObject/desktop/source/app/sofficemain.o] Error 2 Apparently MSVC2017 isn't affected, since the problematic commit passed CI happliy (didn't test myself if MSVC version is actually the problem, or maybe specific Windows SDK version). Change-Id: Ibcaa3a8d09bae54e436366623fe103e8c5f58f40 Reviewed-on: https://gerrit.libreoffice.org/78334 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-31Unify executables to take version resource from default.rcMike Kaganski
Pass file description in optional second argument to gb_Executable_add_default_nativeres. Remove duplicating version resources from officeloader.rc and launcher.rc. Change-Id: I55c4fc85c470c3dd6f03d909a39459839e70b9cd Reviewed-on: https://gerrit.libreoffice.org/78333 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-31sw sd lok: Don't enter the OLE editing mode right after inserting a chart.Jan Holesovsky
Turns out that it is confusing for the users that they can edit the properties of the chart rather than its position just after inserting it in the browser. Let's change it accordingly. When the user wants to edit the chart itself, they have to double-click. Calc is not handled in this patch. Change-Id: If5661b843a06ebaeb8d4cd1b2c469aeedda4257e Reviewed-on: https://gerrit.libreoffice.org/78318 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-31Add version resource to executables where it was missingMike Kaganski
Change-Id: Iee965c3f720827b20347f6228e891562c8295d22 Reviewed-on: https://gerrit.libreoffice.org/78327 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-31tdf#126656 Remove unnecessary items from itemset.Gülşah Köse
Change-Id: I62fc660ea061fe9665e0166a08871ba0a592fc41 Reviewed-on: https://gerrit.libreoffice.org/78332 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-08-30Blind fix for Android, take twoStephan Bergmann
After 1928ced074260d2d40345bdf4c96767abb99bb4f "Blind fix for Android", tb24 still fails with > Linking obj/local/armeabi-v7a/liblo-native-code.so > /home/android/lo/master-android-arm/instdir/program/libsofficeapp.a(sofficemain.o):sofficemain.cxx:function soffice_main: error: undefined reference to ´sal_detail_initialize´ > clang++: error: linker command failed with exit code 1 (use -v to see invocation) Lets see if including sal/osl/unx/salinit.cxx in ANDROID/iOS builds works (even if the contents is not normally used there, including it should be harmless). Change-Id: Ifa38af8f5217a17d3ac74851b46bdb3b50cd4efd Reviewed-on: https://gerrit.libreoffice.org/78325 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-30Hide macro selector button in kit mode.George Wood
Change-Id: If068d23a5aeb9be6d8e1736543c002bf2e68dacb Reviewed-on: https://gerrit.libreoffice.org/78321 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-30Extract common code from #if/#else blocksStephan Bergmann
Change-Id: I7d14fd76ec4e571d5971131b5ee16f4dfe648b23 Reviewed-on: https://gerrit.libreoffice.org/78316 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-30weld addressbook wizardCaolán McNamara
Change-Id: I118ed34ddaf7d62e5bb15497399cd10533339328 Reviewed-on: https://gerrit.libreoffice.org/78287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-30tdf#127233: QR-code generator, use UTF-8 encodingJulien Nabet
Thank you Mike Kaganski for reference here: https://bugs.documentfoundation.org/show_bug.cgi?id=127233#c4 Change-Id: I01bbc408df8bc87cf4e8be52143efb9fc3fa1e38 Reviewed-on: https://gerrit.libreoffice.org/78304 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-30adapt to runToolOnCodeWithArgs API change in clang 10Noel Grandin
which required including config_host in generator, which in turn required adapting the makefile Change-Id: Icafa3b59816f52c349fbbd76ce71305856c9ce33 Reviewed-on: https://gerrit.libreoffice.org/78293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-30Open links when editing the text in impressSzymon Kłos
Change-Id: Ibfead6dce019400ad5fa32a5f5351fa3e8fdea7d Reviewed-on: https://gerrit.libreoffice.org/78315 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-30Blind fix for AndroidStephan Bergmann
tb24 started to fail with > In file included from /home/android/lo/master-android-arm/desktop/source/app/sofficemain.cxx:35: > /home/android/lo/master-android-arm/include/sal/main.h:48:2: error: No code that includes this should be built for iOS or Android > #error No code that includes this should be built for iOS or Android > ^ after 28c39b3d13485ae27a8b03d78fa208a443a50298 "Replace is_soffice_Impl hack with a better(?) hack". Change-Id: I586a666ff2b822cb49c271378e9bed26c7eb5640 Reviewed-on: https://gerrit.libreoffice.org/78314 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-30tdf#127230 vcl: about dialog double-buffer on macOS is not neededMiklos Vajna
This was a problem since commit 7eb37a422f2e66bc177d72404c53659a248661ca (tdf#118856 vcl: avoid flicker in the about dialog, 2019-08-12). Given that probably sooner or later this application-level double-buffering will not be needed anyway, just do the minimal fix and avoid it for the about dialog on macOS. (Versus low-level double-buffering as macOS, gtk3 or OpenGL does.) Change-Id: I5dc60e5c064d1e90057f9aa9a22db9f67680eb26 Reviewed-on: https://gerrit.libreoffice.org/78313 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-30tdf#127211 Revert "tdf#71087 sfx2: avoid flicker in the start center"Miklos Vajna
This reverts commit d5c7657c541c1f6d17bfe5e605594c235eecfcdb. By the time I created that, I forgot to test the case when there are no recent documents. I'm not exactly sure how to fix that, so just go back to the old behavior for now (trading a regression for a normal bug). Change-Id: I8abc251a3e6506ca17429ba106e2dd70fff31556 Reviewed-on: https://gerrit.libreoffice.org/78301 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-30Introduce gb_Executable_add_default_nativeres to add version resourceMike Kaganski
... to executables on Windows Change-Id: I31bd2447052915bb299820034f99128e0e97db54 Reviewed-on: https://gerrit.libreoffice.org/78290 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-30Fix typosAndrea Gelmini
Change-Id: I965ade27bdbd5d1f0e6cc902c1f01fa905e668f2 Reviewed-on: https://gerrit.libreoffice.org/78305 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-30Smaller-width animations pane on mobileMuhammet Kara
Change-Id: I2c3a2a703c7e9fa776e7a6c88cdca5414ce2c2c1 Reviewed-on: https://gerrit.libreoffice.org/78300 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-30tdf#103988 OOXML export: fix bubble chart MSO interoperabilityBalazs Varga
Write <c:bubble3D val="0"/> into each <CT_BubbleSer> OOXML element to allow file opening in MSO without removing the (previously "corrupted") bubble chart. Change-Id: Idf31a0d3d8f98a3be4c9a3b29e65d4d4c582be53 Reviewed-on: https://gerrit.libreoffice.org/78259 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-30tdf#114657 OOXML chart export: fix broken chart with NaN X valueBalazs Varga
Export c:pt elements only for numbers instead of replace the correct X values with the sequence 1, 2, 3..., when the X values contain a NaN value. This reverts commit a211c754003f98bc8f7761224a0b265bd224f61f "fdo77216-Charts-Scattered chart: Chart gets distorted on RT" Change-Id: I6d0bec870b5317575d93eff407b3ec2ada56431e Reviewed-on: https://gerrit.libreoffice.org/78221 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-30Move spsupp components to a separate installer featureMike Kaganski
Change-Id: Ic95b9f887da83d0931ed54b76d23465660786a79 Reviewed-on: https://gerrit.libreoffice.org/78273 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-30Replace is_soffice_Impl hack with a better(?) hackStephan Bergmann
...that involves adding a second, one-off special meaning to the existing sal_detail_initialize function. This at least gets rid of the "osl_getExecutableFile contains 'soffice' substring" guesswork (and of the osl_systemPathGetFileNameOrLastDirectoryPart call there, which is what I'm actually after, for a different change to come). Change-Id: I4dd6eef1fd0411bf66943ffea415876c92d08526 Reviewed-on: https://gerrit.libreoffice.org/78291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-30Simplify Sequence iterations in lingucomponent..lotuswordproArkadiy Illarionov
Use range-based loops, STL and comphelper functions. Change-Id: I975a9c09265976d5ce4a1d7ac2023cbb75bb7f28 Reviewed-on: https://gerrit.libreoffice.org/78242 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-30Clean up some osl::X, X_u function combosStephan Bergmann
(adapting call sites where necessary) Change-Id: Ib9ad1122571b1c00ebbb4638f94eb5698b18a1a7 Reviewed-on: https://gerrit.libreoffice.org/78289 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-30tdf#126966: The share/palette folder was missing from the iOS appTor Lillqvist
Maybe it would be good to simply include all of share as such, without trying to pick only what is actually needed? Must investigate. Change-Id: Ide991334fe4bbe2b1e9807b8dba2b1e635e4f469 Reviewed-on: https://gerrit.libreoffice.org/78292 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-08-30tdf#124083 OOXML import: fix broken charts with missing value XBalazs Varga
Importing NaN value X, ie. where only "ptCount" was defined without explicit data, messed up the charts replacing all X values with sequence 1, 2, 3..., showing data points in wrong X positions, also showing the invalid "NaN" data points. Now internal data table contains the original X values, including NaNs, fixing broken charts. Change-Id: Ic3c69e15095d9b29643f5daef8f58c58b4a442db Reviewed-on: https://gerrit.libreoffice.org/78177 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-30solenv: teach create-tags to handle CPPUNIT_TEST_FIXTURE()Miklos Vajna
So that e.g. :ts testOleSaveWhileEdit works in vim. Inspired by the upstream-documented DECLARE_FUNCTION() macro from <https://github.com/universal-ctags/ctags/blob/master/docs/parser-cxx.rst>. Note that if your ctags is old enough to not handle -D (like, more than 3 years old), it'll still index the rest, so it seems we can do this unconditionally. Change-Id: I5545f3a172bdac613bba07bd364ad5b00d1fd970 Reviewed-on: https://gerrit.libreoffice.org/78281 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-30fix PolyPolygon move operator=Noel Grandin
and add move constructor, found by loplugin:noexceptmove Change-Id: I89507113b354c4ae080f7107c996b55ab1285738 Reviewed-on: https://gerrit.libreoffice.org/78285 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-30loplugin:noexceptmove in AnyNoel Grandin
but we needed to make moveAnyInternals noexcept, which is fine because uno_any_construct is already noexcept Change-Id: Iddbe7666d8649cde4e638099a17484193055f549 Reviewed-on: https://gerrit.libreoffice.org/78283 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-30SwAutoFormat::HasObjects() could be fasterMichael Stahl
Change-Id: I928401382ca986fb75de3689b9ef5e08474e2b85 Reviewed-on: https://gerrit.libreoffice.org/78278 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-30loplugin:noexceptmove in pyunoNoel Grandin
needed to make scratch() and get() noexcept Change-Id: I7d50405698557eb9794adc6523d4878675903db2 Reviewed-on: https://gerrit.libreoffice.org/78284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-30Remove work-around for isMobile()Muhammet Kara
Let's remove this dangerous work-around since it is no longer needed after 6ceab5b233da675b25f42fadff9e85d404903322 Change-Id: Idb18d83f9eac571334fe8bfcd7f212f2f0a930a9 Reviewed-on: https://gerrit.libreoffice.org/78282 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-30new loplugin:noexceptmoveNoel Grandin
idea from mike kaganski look for places where we can mark move operators as noexcept, which makes some STL operations more efficient Change-Id: Id732b89d1fcadd5ceb0ea2b9d159fed06136330f Reviewed-on: https://gerrit.libreoffice.org/78251 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-30tdf#126959 impress table border resize handle supportTomaž Vajngerl
This adds support to edit the resize handles for the impress. It includes: - sending the positions of handles when table object is selected or changed - a implementaton of SID_TABLE_CHANGE_CURRENT_BORDER_POSITION to perform the changing of the border positions of a table Change-Id: I6f60822c5cd9afc3be5c48ea7b775f1860bfa5a7 Reviewed-on: https://gerrit.libreoffice.org/78201 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-30moves outdev font functions in font.cxxAdrien Ollier
Change-Id: I02e133b1682d4d1aab1d56eae0528856b0fabe55 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/77232 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-30RTFSprms: code refactorizationAdrien Ollier
Four lambda expressions were declared doing the same thing, which leads to the creation of four internal different types for the same thing. That makes no sense. Class RTFSprms_compare allows to factorize this code and makes code shorter where it is used. Change-Id: I5ed6821a67a50e96d9425064841c2b3421323001 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/76214 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-29tdf#127180: Propose migration + Firebird by default only in experimentalJulien Nabet
See: http://document-foundation-mail-archive.969070.n3.nabble.com/About-putting-back-Firebird-experimental-td4265392.html#a4265519 Change-Id: I651baa78d345ce56e8d38d56aba096d04a225c5c Reviewed-on: https://gerrit.libreoffice.org/78240 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-29cid#1448379 silence Explicit null dereferenced false positiveCaolán McNamara
Change-Id: I5ff321520dd38f644b66bb78918035b512d5e67f Reviewed-on: https://gerrit.libreoffice.org/78090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-29Update commentStephan Bergmann
external/liborcus/0001-Blind-fix-attempt-for-older-macOS-builds.patch has been removed with df2b4a9daa643e66b705a7b39d8988a3d97d731e "Update liborcus to 0.15.2." Change-Id: I1014e1ff847468b5b6c05ee363c1e6017722fd47 Reviewed-on: https://gerrit.libreoffice.org/78271 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-29related tdf#81345: make unit test robust - check last pageJustin Luth
On KDE Neon 18.04, something was causing page 1 to spill over onto page 2. Checking the last page instead of the second one is fine for testing the problem solved for bug 81345. Confirmed with bibisect53 that same header/page style had been used for the whole document originally. Change-Id: Id85562153d7ce1d570806a611f11d33fa5b83c87 Reviewed-on: https://gerrit.libreoffice.org/78250 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-29tdf#127211 start center: fix background of the main area with no recent docsMiklos Vajna
The background was white instead of gray, but the text color remained white, making the text unreadable. This was a problem since commit a5cafe5d7e87c0f5ecdcffbbe58c66abcb97ac8e (tdf#91843 sd sidebar: fix unexpected borders around the slide layout previews, 2019-08-27). Given that the background fix was intended to help with the slide previews in impress, move the change affecting the background handling down to ValueSet and revert the VCL changes. This preserves the impress slide preview fix, but restores the old good behavior for all non-ValueSet widgets, including the start center. Change-Id: I7efcd5b9c12e5df8e10261c992bf7a774960fa11 Reviewed-on: https://gerrit.libreoffice.org/78280 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29tdf#126078 Autotext: fix lost space between first-/lastnamebrinzing
Change-Id: I3f8c1e25e06097cbed37fba1ca6a634704387e00 Reviewed-on: https://gerrit.libreoffice.org/76000 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-29Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Insert the description of the change. Change-Id: I2dba6f76867798d59eae1e1f2d7c6c2734dd6eb4 Reviewed-on: https://gerrit.libreoffice.org/78276 Reviewed-by: LibreOfficiant <LibreOfficiant@sfr.fr> Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-08-29LOK: Proper use of isMobile() on embedded chartsMuhammet Kara
We are moving the isMobile() check to a higher layer, to avoid changing a published API method This is the follow-up of the commit feae0c186e700f6a48c3fad124fb4795ad1a8f83 Change-Id: Ia84baa36d66d5832e00e6466f5206631df0de443 Reviewed-on: https://gerrit.libreoffice.org/78277 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29LOK: per-view support for isMobile()Muhammet Kara
embeddedobj/source/commonembedding/embedobj.cxx will have a follow-up patch, which also removes the -1 case. It is left out because it has many call-sites, and inheritance/override relations. Change-Id: Iaf00530916f3772f7aec151cbd358f255b7aab24 Reviewed-on: https://gerrit.libreoffice.org/78272 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29lok: Disable chart editing on mobileTamás Zolnai
Disabled editing of all embedded objects. [ Miklos: motivation is that the UI is complex and the small mobile screen is not suitable to expose this functionality as-is. Disable till a more compact UI can be exposed. ] Change-Id: Id1c598c84adc12b8b52d006992d85dcae5601ad9 Reviewed-on: https://gerrit.libreoffice.org/78270 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29Added mobile friendly ui design for ConditionalFormattingDialogmerttumer
[ Miklos: added solenv/ bits to silence the same warnings as the non-mobile layout. ] Change-Id: If2d91da45cf5eecf099f246320ffaf84f55708f1 Reviewed-on: https://gerrit.libreoffice.org/78268 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29Make oslDirectoryImpl a bit more C++yStephan Bergmann
Change-Id: Iff5e26369889345d1f907e52d86eff6b89c63e20 Reviewed-on: https://gerrit.libreoffice.org/78260 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-29Update liborcus to 0.15.2.Kohei Yoshida
Change-Id: I1a16e7ba9a096862933536268dacf5ab49476896 Reviewed-on: https://gerrit.libreoffice.org/78246 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-29lok: Add isMobile() methodMuhammet Kara
[ Miklos: this allows core to e.g. serve tunelled dialogs with more or less compact layouts, depending on if the client is mobile or not. ] Change-Id: I3559bee84e6ef6f757809617e303aa090698ce5d Reviewed-on: https://gerrit.libreoffice.org/78261 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-10 12:36:45 +0000