summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-10unnecessary null check before dynamic_cast, in sdNoel Grandin
Change-Id: I91579ece17b85b1ae9926b7a05eb641672e8ecbd Reviewed-on: https://gerrit.libreoffice.org/58772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-10unnecessary null check before dynamic_cast, in svxNoel Grandin
Change-Id: I5174c9530d18e5d88ad8a41cc2bb02c6d090f3cf Reviewed-on: https://gerrit.libreoffice.org/58771 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-10unnecessary null check before dynamic_cast, in swNoel Grandin
Change-Id: I4f3f3f8b8b7fdf57fe76ff9a24cd8c58e386392d Reviewed-on: https://gerrit.libreoffice.org/58770 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-10sw: Reduce redundant copyTakeshi Abe
Change-Id: Iee865bbbc5cbb98ba64305c6e90273ce3c719e6e Reviewed-on: https://gerrit.libreoffice.org/58804 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-10Fix typosAndrea Gelmini
Change-Id: I98d9120160fb652cae490513765670f447cf5911 Reviewed-on: https://gerrit.libreoffice.org/58791 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-08-10tdf#96469 Export Data Point properties in Charts on DOCX/XLSXBalazs Varga
If the color or other property of a datapoint in the chart deviates from the dataseries property, this patch will write it into a separate dPt tag and fixing the lost properies during OOXML export. Change-Id: I3d975675ac3691fcafe76de16e46851561eb2807 Reviewed-on: https://gerrit.libreoffice.org/58752 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-08-09One last attempt at fixing UITest_writer_tests for Jenkins ASan+UBSan buildStephan Bergmann
...where <https://ci.libreoffice.org/job/lo_ubsan/997/> still triggered the assert at sw/source/core/layout/findfrm.cxx:1702 during the second .uno:Undo. Lets see if a little sleep "fixes" that. Change-Id: I659ea86aab03f2d39913122af2cc8869abff5578 Reviewed-on: https://gerrit.libreoffice.org/58777 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09No more need for CppunitTest_cppuhelper_qa_weak to be a subsequentcheckStephan Bergmann
...as gbuild can handle such dependencies from tests to libraries from modules higher up in the hierarchy Change-Id: Ia3993c50feba3916572febe0748c99561b8a8675 Reviewed-on: https://gerrit.libreoffice.org/58775 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09Remove unnecessary test dependencyStephan Bergmann
Change-Id: I8202cf38e4b54fc4b457d2a7d70ad42b29ee9dec Reviewed-on: https://gerrit.libreoffice.org/58769 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09uitest for bug tdf#108654Zdeněk Crhonek
Change-Id: I70698e02cc6c6555b8dc4b362a7dfa0cfafa2327 Reviewed-on: https://gerrit.libreoffice.org/58776 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-08-09Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - New Help housekeeping remove deprecated files (gbuild has replaced them) Change-Id: I00a0a1558dfa80486dd64df37273c90bc6262fb0 Reviewed-on: https://gerrit.libreoffice.org/58784 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-09Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - Use PRODUCTNAME from the configure. Change-Id: Ibc742e653f44093372bed4e103fedb3a597dfdac Reviewed-on: https://gerrit.libreoffice.org/58793 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-08-09forcepoint#72 negative string indexMichael Stahl
The problem is that the pMaster->GetFormatted() screws up the offset of the follow frame; there isn't any hope of fixing this up when it happens so deep inside Format_()... so instead try a conservative check on the outside (can't check the position there as Format_ moves around quite a bit) and format the master there already, and then SetOfst() to fix things. Change-Id: I0a119ccf1561ece031cec03db3c36155f271a6a8 Reviewed-on: https://gerrit.libreoffice.org/58726 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-09Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - Update the README.txt. Change-Id: Id493d2d1fa21a160b4fc7d2bb160e6cb6a38c93b
2018-08-09Various fuzzers need pdffilter_component_getFactoryStephan Bergmann
Change-Id: I59c5499586c16768afde822cd6d580540d1bcd73 Reviewed-on: https://gerrit.libreoffice.org/58764 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09Set umask /before/ using itStephan Bergmann
The test used to fail when umask originally was e.g. 077. Change-Id: I21d346532698feebccc8bb3f6cb9a9dd3002a20e Reviewed-on: https://gerrit.libreoffice.org/58757 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09Toolbar and menu containers are similar enoughMaxim Monastirsky
... to be handled by the same code. Change-Id: I96fae066ccf2bef474fe4faf8068b7290eea8d8b Reviewed-on: https://gerrit.libreoffice.org/58766 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-09forcepoint73 deleted SwAnchoredObject still referenced in TmpConsiderWrapInflCaolán McNamara
Change-Id: If255723834d049865fcf6fd0eac7768dfcbad2a1 Reviewed-on: https://gerrit.libreoffice.org/58760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-09dynamic_cast followed by static_castCaolán McNamara
Change-Id: I931ed8945b4af713ead42e0eca0bb5fb6cb07d9c Reviewed-on: https://gerrit.libreoffice.org/58759 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-09No need for CppunitTest_cppuhelper_qa_misc to be a subsequentcheckStephan Bergmann
Change-Id: I5b27c4803a9927ff9e2be084e7abbae7fdf94f55 Reviewed-on: https://gerrit.libreoffice.org/58696 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09Don't use internal __CxxDetectRethrow: it has side effectsMike Kaganski
Since the __CxxDetectRethrow may increment __ProcessingThrow, which then must be decremented in __CxxUnregisterExceptionObject, and the latter does many other funny things with exception handling CRT machinery, we cannot use those internal functions (neither alone, nor together), or we end up breaking runtime's expectations: the runtime code checks __ProcessingThrow left and right, expecting its non-0 value to indicate "we are unwinding... possibly called from a dtor()". In this case, e.g., std::current_exception returns nullptr inside catch block. This creates our own copy of __CxxDetectRethrow, which does not mangle the global state, and just performs the same checks. This is a dirty hack, and it relies on current layout of the exception description layout - so must be synchronized in the event of changes! Change-Id: I2c475fbc2468073b796c7e9d0f4dfcd315896489 Reviewed-on: https://gerrit.libreoffice.org/58730 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09Improve wording of commentStephan Bergmann
...as discussed on #libreoffice-dev Change-Id: I5314bdcaf0e023db615c68785b76f4ee6144b079 Reviewed-on: https://gerrit.libreoffice.org/58758 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09loplugin:unusedmethodsNoel Grandin
Change-Id: I0308ddd467ab6e283c0503f98885a248eb28290c Reviewed-on: https://gerrit.libreoffice.org/58738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-09Silence external/boost deprecated std::iterator warnings with MSVC 2017Stephan Bergmann
At least cl version 19.14.26433 generates such warning C4996 now. While the one about the using declaration in boost/iterator.hpp looks somewhat bogus, the one in boost/circular_buffer/details.hpp is about an actual use of std::iterator as a base class in Boost-internal code. If further such places in external/boost crop up that need fixing, an alternative approach could be to extend the external/boost/include/ wrappers to be also used with MSVC. (Globally setting _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING has avoided, as it also finds uses in our own code that should be fixed, like 58222feb7fee0c08fb54b9ee29f8f0674c5cf508 "warning STL4015: std::iterator is deprecated (clang-cl)".) Change-Id: I6a41421a590fcee57b4ac8bcb7c3631fdfdecb81 Reviewed-on: https://gerrit.libreoffice.org/58755 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-09tdf#101254: Enable arrowheads in sidebar for drawsXisco Fauli
It's enabled in Line and Filling toolbar so do the same in the sidebar Change-Id: Icc64705268a9efb46ab463131ddf486dad12f085 Reviewed-on: https://gerrit.libreoffice.org/58747 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-08-09remove Calc's software interpreterLuboš Luňák
- it's in practice never used nowadays, group threading has higher priority in the code and since SwInterpreter's allowed opcodes are a subset of group threading's, there should be no formula where control flow gets as far as using SwInterpreter - the only opcodes SwInterpreter allows are ocAdd, ocSub, ocMul, ocDiv, ocSum and ocProduct, which is a rather limited set and group threading should handle all that as well - if SwInterpreter performs anything better than group threading, there shouldn't be a problem doing the same for group threading - it's yet another code path that should be handled, tested, etc. and the added complexity is not worth it - it shares some code with OpenCL handling, which is both added hassle in case OpenCL code needs changes, and it also causes confusion such as people thinking SwInterpreter has something to do with OpenCL Change-Id: I99052862b60b6266c70dd436d1d7938177dc6bd9 Reviewed-on: https://gerrit.libreoffice.org/58643 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-08-09svl windows: remove last traces of pre-CNG signingMiklos Vajna
Mostly only the certificate selector was left + the global runtime switch. Change-Id: I11e8e0920806eb61848512df6dea48c594febfe4 Reviewed-on: https://gerrit.libreoffice.org/58751 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-09menubar draw: add choosemodebar commandsandreas kainz
Change-Id: I1baee1ec55e310aec2ec1010234d739eec5020c8 Reviewed-on: https://gerrit.libreoffice.org/58749 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-08-08tdf#83659 Enable outline commands for text boxes and tablesMaxim Monastirsky
Change-Id: I2fff7354556769104e9ffaafc504d3159f63e4e8 Reviewed-on: https://gerrit.libreoffice.org/58748 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-08tdf#116350 Fix export of fontworkSzymon Kłos
Change-Id: Icf3a07c6b79296feb233bbe08a6d69ab21a41414 Reviewed-on: https://gerrit.libreoffice.org/58746 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-08loplugin:singlevalfieldsNoel Grandin
Change-Id: I75554209ad247173381ea96a14c8bf532bed13a8 Reviewed-on: https://gerrit.libreoffice.org/58724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: I9ce151dfdb58fd4bb539aaa461a6c873c9ad18a5 Reviewed-on: https://gerrit.libreoffice.org/58716 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-08sw TextGraphicObject: handle XBitmap for GraphicURLMiklos Vajna
This restores compatibility for API users who called getByName() on the bitmap table and expected that the result can be set as a value for the GraphicURL property. Changing the property type to cppu::UnoType<css::uno::Any>::get() is necessary, otherwise scripting languages figure out (via reflection) that the type doesn't match, and SwXFrame::setPropertyValue() is not called. Change-Id: Idd62f109e91dbaebf1138b9038f66c6c648d780e Reviewed-on: https://gerrit.libreoffice.org/58745 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-08tdf#42949 Fix IWYU warnings in chart2/source/inc/[d-l]*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Try harder to use fw declarations, and a few newly analyzed files Change-Id: I50299e9115ced60468c7bc5e63013addbaec48c0 Reviewed-on: https://gerrit.libreoffice.org/58618 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-08Remove presumably unused distro-configs/Jenkins/*_libreoffice-5-0.confStephan Bergmann
Change-Id: I0b6c2d116496da64f91cb5cafb81b69e02366d96 Reviewed-on: https://gerrit.libreoffice.org/58743 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-08tdf#116350 Correctly display text on arcSzymon Kłos
Change-Id: Ice8c141db20d43ccc8d6e2b56004a4a28d2b257a Reviewed-on: https://gerrit.libreoffice.org/58729 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-08sw HTML import: apply default table autoformat on cells in reqif modeMiklos Vajna
The reqif xhtml subset doesn't allow formatting of cells, which means that the tables created with the UI and imported tables look different, e.g. the later ones have no borders. Fix this inconsistency by applying the default table autoformat during import (in reqif mode). The import result looks better this way, and the export will ignore it anyway. Change-Id: I310770594e7a00e62f23d9df8cb16c2b95e1e44a Reviewed-on: https://gerrit.libreoffice.org/58741 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-08Resolves: tdf#118281 control positions always in cmCaolán McNamara
Change-Id: I7803f673e835bd4575616d4e4b465ca144e282c8 Reviewed-on: https://gerrit.libreoffice.org/58720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-08Temporarily sprinkle test code with debug print statementsStephan Bergmann
...to hopefully find out why <https://ci.libreoffice.org//job/lo_ubsan/996/ consoleFull#-14523843999567f988-cbcf-4519-af05-6000b834f13f> still fails in UITest_writer_tests after c57191e0c45f9735a33953d6b95d54b0e10c876f "Try to make test_tdf81457_table_merge_undo deterministic". Change-Id: I142f89c508eb66a82e656b0ef32f595796b547fc Reviewed-on: https://gerrit.libreoffice.org/58728 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-08upload libwps 0.4.10David Tardon
Change-Id: Ib29c429a34a3895fa0747a54194dcd60ad41e45d Reviewed-on: https://gerrit.libreoffice.org/58704 Tested-by: Jenkins Reviewed-by: David Tardon <dtardon@redhat.com>
2018-08-08nss: remove inline patch message from nss-android.patch.1Michael Stahl
forgot to remove this in the 3.38 upgrade Change-Id: Idaa9fd8e8036f305ec64c4a474d904d72daef0e8 Reviewed-on: https://gerrit.libreoffice.org/58721 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-08tdf#112343 Change dependency from dbus-glib to dbusArkadiy Illarionov
Add check for GLib support for modules which depends on dbus and glib separately. Also fix copy-paste typo. Change-Id: Ibd33573b2f8dff9e0a7f2e0fc983d93878bb5357 Reviewed-on: https://gerrit.libreoffice.org/57157 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-08tdf#103961: delay merge of default props until exportJustin Luth
Until now, during docx import the pPrDefault properties have been directly added to the parentless styles. However, things like table styles are supposed to over-ride these document defaults, but not style defaults. Since the docDefaults are merged into the style, table-styles were unable detect if they could override them. Exporting doesn't export pPrDefaults well, so the properties still need to be merged into the style when round-tripping. Almost every existing unit test document is a proof test. It effectively ought to act as a non-functional change. Plus, this basically reverts 7f697ec27b1175ed94228155935d9ccd3cd5606c so that unit test still covers bug 103961. Change-Id: I4948299ddd610c07d828f2bd57c58734f1b94c49 Reviewed-on: https://gerrit.libreoffice.org/58203 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-08tdf#118731 delay on showing dialogs that create SdrModelsCaolán McNamara
for their preview widgets. since... commit 4be44a7a6f2f480e55255d7cdd119f3d6577d085 Date: Thu May 24 19:09:44 2018 +0200 SOSAW080: Cleanup of SdrModel Change-Id: I102b64bdacc56a41091bbe60e932c2915f20323f Reviewed-on: https://gerrit.libreoffice.org/58693 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-08-08nss: upgrade to release 3.38Michael Stahl
Fixes CVE-2018-0495 and "the ASN.1 code". Remove one hunk of nss-android.patch.1 that should be obsolete with the current Android toolchain baseline. Change-Id: I5516edec17b72f53acd2749e8840805eead077bc Reviewed-on: https://gerrit.libreoffice.org/58697 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-08tdf#42949 Fix IWYU warnings in include/rtl/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iae997959a0ec2c9edb1c795533692ec4e579449f Reviewed-on: https://gerrit.libreoffice.org/57313 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-08loplugin:useuniqueptr in SfxApplication::LoadTemplate and SfxMediumNoel Grandin
pass SfxItemSet around by std::unique_ptr Change-Id: I54da96d8df224f7c4f2fb9ebf06ed32d479298e7 Reviewed-on: https://gerrit.libreoffice.org/58649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I3fe82f6e3aad299fe42d6256c0deaba1339df0c1 Reviewed-on: https://gerrit.libreoffice.org/58708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08the TimeEventHandler stuff is deadNoel Grandin
ever since commit c760d61bad637bf178566884039dd07d81ab17ed Date: Fri Jul 27 15:28:44 2018 +0200 remove SdrGrafObj::IsSwappedOut Change-Id: I68c98449b98a3ac5da3bf26917ad2a76226f470c Reviewed-on: https://gerrit.libreoffice.org/58707 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08loplugin:unusedfieldsNoel Grandin
Change-Id: I9ae44279f1cce06bd6868005fbb878ba4894aed7 Reviewed-on: https://gerrit.libreoffice.org/58706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-11 00:54:03 +0000