summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-11-18tdf#163792 gtk3: Don't always focus combobox when its popup closesMichael Weghorn
Since commit 405cf00e4818886b0d3053d03cfb2e3f3a5e8eb8 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue May 28 11:50:12 2024 +0200 related tdf#160971 gtk3 a11y: Keep new combobox value , closing an (editable) combobox like the font size one in the Writer formatting toolbar resulted in the combobox's entry having focus, while the focus was set to the document before that commit. Make this work as expected (again), by making grabbing the focus conditional in 2 places: 1) In GtkInstanceComboBox::signal_popup_toggled, only set the focus to the GtkEntry of the custom combobox implementation if the child focus is already inside of the combobox. As I understand it, the intended logic is "move focus from the combo box's button to its entry", not "unconditionally grab the focus". This also matches what the gtk4 implementation does. Sync the comment from the gtk4 implementation, which explicitly mentions the case of the font combobox in the toolbar (which behaves the same as the font size one in that regard) where focus should not be grabbed. 2) In GtkComboBox::menu_toggled, only explicitly set focus to the toggle button if the combo box is located inside of a popup. This is the same condition used to grab all keyboard events. The code to do both was introduced in commit 131c1c7da8c567636ca55751e49d24cb6d6c9b9e Date: Sun Nov 21 19:53:47 2021 +0000 Related: tdf#145786 cooperate between our own grabs whose commit message only explicitly mentions grabs for popups. The scenarios described in the commit message still work as expected with GDK_BACKEND=x11. With this in place, focus now moves to the document as expected when clicking on a combobox entry in the popup for the font size combobox in Writer's formatting toolbar, while clicking an entry in any of the comboboxes in e.g. Writer's "Format" -> "Character" dialog's "Font" tab still results in the entry of the combobox getting focus. Change-Id: Ib07b034f8327dab19a2264ae3ed8e20ea918dd89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176713 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-18tdf#163486: PVS: reference may become invalidXisco Fauli
V758 The 'rModel' reference becomes invalid when smart pointer returned by a function is destroyed. Change-Id: I34cbf998da49a576b43b946187de94495f5e5529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176716 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-18Limit to len the number of UTF-16 code units being readStephan Bergmann
Change-Id: I62bcf2919cb97d16811e9a59a63f1155437b6740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176718 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-11-18CppunitTest_sw_layoutwriter2: split in twoXisco Fauli
It already had 109 tests Change-Id: I52e7416091bb3ffa80c39a1409dc283771f7d9ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176710 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-18tdf#163945 Lower priority of Skia flush timerPatrick Luby
Commit f4c2c7c79cfe4464ac596afda37b8904d06969db fixed tdf#157312 by lowering the timer priority to TaskPriority::POST_PAINT. But it caused tdf#163734 so it was reverted to TaskPriority::HIGHEST in commit 5a38e4f9798c5ff247aa57581adf2671485627fd. While reverting to TaskPriority::HIGHEST did not cause tdf#157312 to reoccur, it did cause tdf#163945 so set the timer priority to TaskPriority::HIGH_IDLE. This priority appears to be low enough to fix tdf#16394 without causing tdf#163734 to reoccur. Change-Id: Ifc2833a886d52117d46c02a80c88c674ad080824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176698 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins
2024-11-18Windows Taskbar: use progress bar feature (ITaskbarList3)Vasily Melenchuk
Any status progress in LO status bar is also represented as progress in Windows taskbar. Change-Id: Ibd7131ff6246cf5ea37ab8730d0eddfa084265c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171886 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-11-18tdf#39468 Translate German commentJohnny_M
Change-Id: If0b996ff97b29860367e6ef939682b3753d47f35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176663 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-11-18crashtesting: crash on import of rtf exported from forum-en-32886.odtCaolán McNamara
see: git diff -w Change-Id: Id50e45e53b7b433d6c468038a7de14441f4ee560 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176707 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-18tdf#142741: Add unit test to set valid pages for footnote links PDF export.MelvinYG
Change-Id: I90abb354fb9c4c6319034d994165f2e5cd667d2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175945 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-11-18tdf#163251 Fix for missing flags in single click obj creationAshSinc
Change-Id: I0f6e65c4cf3ad9cac3096144d8a0efec29030739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174420 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-11-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to b3bc6425768d93d6b9bb7304ed3a0ead4b03e2a7 - Mute L10n of <embedvar> + typos Change-Id: I06d3cf6d3d56dc030d422228f1e37cd68a7bddb5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176697 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-11-18loplugin:dllprivate: Extend for new qtbase macroMichael Weghorn
Qt's qtbase commit [1] commit cecca90ff23ff27b9396defc21abd472b3fe0003 Author: Thiago Macieira <thiago.macieira@intel.com> AuthorDate: Tue Oct 1 11:26:30 2024 -0700 Commit: Thiago Macieira <thiago.macieira@intel.com> CommitDate: Tue Nov 12 17:14:46 2024 -0800 moc: fix support for generating meta objects for nested private classes introduced a new QT_OBJECT_GADGET_COMMON macro, causing my `--enable-qt6` clang plugin build with current qtbase git dev (as of commit 957e2be00a5c45223a5ef842a5f9f2f7b7be882b) to fail as follows for classes using the Q_OBJECT macro: In file included from /home/michi/development/git/libreoffice/vcl/qt6/QtAccessibleRegistry.cxx:10: In file included from /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtAccessibleRegistry.cxx:11: In file included from /home/michi/development/git/libreoffice/vcl/inc/qt6/QtXAccessible.hxx:10: /home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtXAccessible.hxx:27:5: error: declaration nested in DLLPRIVATE declaration redundantly marked as DLLPRIVATE [loplugin:dllprivate] 27 | Q_OBJECT | ^~~~~~~~ /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:145:5: note: expanded from macro 'Q_OBJECT' 145 | QT_OBJECT_GADGET_COMMON \ | ^~~~~~~~~~~~~~~~~~~~~~~ /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:132:5: note: expanded from macro 'QT_OBJECT_GADGET_COMMON' 132 | Q_DECL_HIDDEN_STATIC_METACALL static void qt_static_metacall(QObject *, QMetaObject::Call, int, void **); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:98:39: note: expanded from macro 'Q_DECL_HIDDEN_STATIC_METACALL' 98 | #define Q_DECL_HIDDEN_STATIC_METACALL Q_DECL_HIDDEN | ^ /home/michi/development/git/qt5/qtbase/src/corelib/global/qcompilerdetection.h:190:46: note: expanded from macro 'Q_DECL_HIDDEN' 190 | # define Q_DECL_HIDDEN __attribute__((visibility("hidden"))) | ^ /home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtXAccessible.hxx:25:7: note: parent declaration is here [loplugin:dllprivate] 25 | class QtXAccessible : public QObject | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 26 | { | ~ 27 | Q_OBJECT | ~~~~~~~~ 28 | 29 | public: | ~~~~~~~ 30 | QtXAccessible(css::uno::Reference<css::accessibility::XAccessible> xAccessible); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 31 | 32 | /** Reference to the XAccessible. | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 33 | * This is cleared once it has been passed to the QtAccessibleWidget, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 34 | * which then keeps an own reference and takes care of all required | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 35 | * access to the XAccessible for the Qt a11y bridge. */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 36 | css::uno::Reference<css::accessibility::XAccessible> m_xAccessible; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 37 | }; | ~ 1 error generated. make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:339: /home/michi/development/git/libreoffice/workdir/CxxObject/vcl/qt6/QtAccessibleRegistry.o] Error 1 Extend the plugin to also take the new macro into account in addition to Q_OBJECT. [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=cecca90ff23ff27b9396defc21abd472b3fe0003 Change-Id: I990f0b25010b3a0f0cc3902f732b93d13bb85d78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176702 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-18dbaccess/qa - Seperate database connection so it can be reusedAdam Seskunas
Change-Id: I982cf589aff159149190c7f0f78dc8085a700240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174981 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-18updated vim footers in vcl/qt6/*.cxxlovatico21
Change-Id: I98f15800abf65bf3c69b473e8eb68b01838b2ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176556 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-18tdf#81913 - Keep cell highlighting active during arrow key navigationAndreas Heinisch
Don't delete range finder during arrow key navigation since cursor keys don't count as modifications. Change-Id: I53566a4a84ff4dc81fdf0d8b8f6468f956958925 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176689 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2024-11-17crashtesting: use after freeCaolán McNamara
commit 8393267c651d0a3071472a8d6ad9861ed75af38b CommitDate: Tue Nov 12 09:03:21 2024 +0100 clang-tidy: performance-unnecessary-copy-initialization in various Change-Id: I1033c33a6b4bf06e365ce183b1a73c98bea777ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176442 Change-Id: Id9e253b849c74a2828ef889f9a13854de0fe2f8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176693 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-17Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to c4bd6c98f97baeebb9ab087939cf6675ac27a2ce - Basic MiD() method has 2 different signatures - arguments syntax precisions - keyword names correction, the 4th argument keyword name is unknown Change-Id: I6d38dcf61286f88d28090d9e18fafde25bd89376 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172821 Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org> Tested-by: Jenkins
2024-11-17cid#1607974 silence Overflowed return valueCaolán McNamara
Change-Id: I9663f3e0cb641bd4530e1aca06d4216de74e38cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176691 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-17cid#1607833 Overflowed constantCaolán McNamara
Change-Id: Ie90b759b76fa587cddd3c160fe7845dec01652c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-17cid#1607905 Data race conditionCaolán McNamara
Change-Id: Idb525a4e19cfbe0c4a493f511be7dadafac0cff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176465 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-17create BaseContent with the state required and drop mutexCaolán McNamara
and ContentEventNotifier can be de-friended Holding this mutex to write to a just created local doesn't make sense to me. I can't see any where that there might be another thread that matters here. Change-Id: I803a45a0cf02ebc306767595555018ee97d96caf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176684 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-17cid#1607919 Overflowed constantCaolán McNamara
Change-Id: I842357000f3282521aa927921a5598fddaef5dee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176686 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-17pNew is only possible if there is a pRedLineCaolán McNamara
so we can move this inside the other conditional Change-Id: I63259598d5165e3aafbf0c1cfef70ccb1b16bb38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176685 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-17tdf#143148 Use pragma once instead of include guardsSloane Vaznova
Refactored include guards into pragma once for some files alphabetically c-d in sw/inc. Change-Id: I8cf8059851169472d7953f4e6f5408666d27c2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176688 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-17Drop DECL_LINK missed in commitJim Raykowski
60a77c7ef46f6fa82b016c7605ec3451de291344 Change-Id: I9141380327aa111bee02257ea2dda53a19bcb0d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176687 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-11-16Avoid UBSan when negating the most negative sal_Int64 valueStephan Bergmann
...as exhibited by recently added 08e566f0c97fb6cc2ee17813e81c221a8d7154c0 "add a couple of tests for tools::BigInt" Change-Id: Icd1080f86ccd985868fce34d6f86e2706acd58df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176677 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-11-16cid#1606752 silence Overflowed return valueCaolán McNamara
and cid#1607158 Overflowed return value cid#1607271 Overflowed return value cid#1608107 Overflowed return value cid#1606975 Overflowed return value cid#1608009 Overflowed return value cid#1608353 Overflowed return value cid#1608486 Overflowed return value cid#1607009 Overflowed return value cid#1606780 Overflowed return value its totally unclear what the source of these warnings is Change-Id: If46cac6a329dec397bd784f57d9ffe5e53af9a1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176683 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-16cid#1371295 avoid Missing move assignment operatorCaolán McNamara
Change-Id: I27cca1b737c441a9f31ed6aa0fc462190ca818da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176682 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-16cid#1557644 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I63510464b74e72f8fc73899e963e20891cdf0f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176644 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-16tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 146, 158. This will still be the case, the code being just at the moment similar. Change-Id: Iceca3c717ccc6ee3ea865d3a469418ff6e8accd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175146 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-16Fix typoAndrea Gelmini
Change-Id: Iffd36495c9a1424ad02756dbc9bde6ae55df86c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176662 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-11-16Fix typoAndrea Gelmini
Change-Id: I05757dccf4abc66f11454d2587902d25fca4312a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176660 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-11-16Fix typosAndrea Gelmini
Change-Id: Ibeadfb72c54887ac8a74dbb11958266fbbda46e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176659 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
2024-11-16Fix typoAndrea Gelmini
Change-Id: I4ffd3af20662e92512119ddfa27ea255a114f910 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176661 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-11-16Related tdf#105112: FB fix request for getFunctionsJulien Nabet
add missing spaces + quote before and after function name searched Change-Id: I3b0bd3ca780c4de9d04fda7d2c80c29e60ddd1ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176669 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-15tdf#151423 Only allow modifiers for mouse scrollwheel eventsPatrick Luby
The Command modifier converts scrollwheel events into magnification events and the Shift modifier converts vertical scrollwheel events into horizontal scrollwheel events. This behavior is reasonable for mouse scrollwheel events since many mice only have a single, vertical scrollwheel but trackpads already have specific gestures for magnification and horizontal scrolling. So, behave like most macOS applications and ignore all modifiers if this a trackpad scrollwheel event. Also, ignore all modifiers for swipe events since it appears that devices that generate swipe events can generate both vertical and horizontal swipe events. Change-Id: I3c0c726759ef010d528f221c63d1e7e401726db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176410 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-11-15tdf#163876 ignore marked text generated from Command-` eventsPatrick Luby
For some unknown reason, when using the standard macOS French layout, pressing Command-` causes -[NSView interpretKeyEvents:] to temporarily set and unset the marked text. Command-` should only cycle through the application's windows so ignore marked text changes from such key down events. Change-Id: Ifeb4ad637d572b339d7b389466815bb60a4b3120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176652 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins
2024-11-15Related tdf#105112: use XDatabaseMetadata3 in Firebird + implement getFunctionsJulien Nabet
Firebird query for getFunctions comes from Jaybird (Firebird JDBC client). Change-Id: I427cc1a103ed6fe2b1ad3554bb7c3e2f7a903d87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176273 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-15tdf#130564: getTableTypes retrieves only table types of the current databaseJulien Nabet
So indicate to LO that at least PostgreSQL and MySQL/MariaDB support views Change-Id: I241fa3cfc599e11c1f1523a78a1905beadc80307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176308 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-15tdf#163383 Skip adding a tooltip to internal links in all casesIlmari Lauhakangas
Change-Id: I1d4e46b6e886d45982f3e8145e0bc12ec12d9884 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176626 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-11-15render master and slide content separately (drawinglayer render)Miklos Vajna
This renders master and the main slide as 2 separate layers, which is useful because in a huge slideshow we can reuse the master slide and only render the rest of the slide, which should be more compact in size as the master slide is the one that usually contains the (complex) background. Change-Id: I5e86d718b7ab3b03bd0b6146ce4df218a4dd72d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176622 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-15Cleanup notebookbar.ui for drawHossein
Fix duplicate IDs found by glade-previewer Change-Id: I5331d5ebdc226bb370d2fd6d6f00c2315952f5ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176625 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-11-15tdf#163486: PVS: V614 Uninitialized variable usedBogdan Buzea
V614 Uninitialized variable 'aLStyle' used. V614 Uninitialized variable 'aFStyle' used. Change-Id: I2e545d7909818d8850728bea7cbb533d5ddd87e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175860 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15tdf#79450 - Other: Bubbles too near disappear in a Calc chartKurt Nordback
An existing optimization avoids rendering a bubble chart bubble if it is nearly the same size and position as the preceding bubble. This results in incorrect rendering in the case of transparent fill. Skip the optimization in this case. Change-Id: Ie21235a66c4d22ac2ce793264ef5bb7b6434117e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15tdf#163486: PVS: fix assertXisco Fauli
V547 Expression '!"unknown reference mark type"' is always false. Change-Id: I7f984c0e008924b23e3a2384c2e36390bf76cfec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 830, 840, 850 V1037 Two or more case-branches perform the same actions. Check lines: 960, 1148 Change-Id: Ifff7612b44d2a3bc0ea573077104b460fed8cf76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175222 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-15tdf#163486: PVS: Identical branchesBogdan Buzea
Change-Id: I71c6cd9b5dbcb3126da1919108be009f6512b0d0 V1037: Two or more case-branches perform the same actions. Check lines: 100, 122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175054 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-15vcl: make Calendar constructor initializer functions more clearChris Sherlock
Change-Id: I670f219e98bb83f0e8efd0054a06aa869f8fc098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174719 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15tdf#39468 vcl: translate German comments in control/calendar.cxxChris Sherlock
Change-Id: I6d741a7b1da28f0111df1b1947e510d595d282dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15tdf#136003 Change labels in the protect sheet dialogSahil Gautam
previously a comment `(for unprotected cells)` was added to the `Delete Rows` and `Delete Columns` menu entries as a solution of tdf#136003. The change has been reverted https://gerrit.libreoffice.org/c/core/+/176614 As tdf#136003 says "Can't delete rows, despite of allow to deletes", the source of confusion is these labels `[ ] Delete Rows` and `[ ] Delete Columns` in the protect sheet dialog. Changed these to `Delete rows with unprotected cells` to make it more clear what they are about. Change-Id: I1009fca2a3cf56ffdc513fdb9b6192b3b965d050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176616 Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-10 10:51:01 +0000