summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-02-17svtools: extract EmbeddedObjectRef::dumpAsXml() from SwOLEObjMiklos Vajna
Because sw/ doesn't have access to the internals, but dumping should show the state as-is, without calling getters that change the state. Especially GetGraphic() is not a trivial wrapper around mpImpl->pGraphic. Change-Id: I2cf43130d4eeab63611e37b4a978bb7aa546c7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130056 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-17ODBC: fix signatures of Bulk, SpecialColumns et NativeSQLJulien Nabet
I compared with https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/odbc-api-reference?view=sql-server-ver15 Change-Id: Iac38c2305fbf3ace502f9e75802510f76a6bd700 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130055 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-17SwNavigator: reduce the amount of content tracking codeJim Raykowski
Same behavior, less code. Change-Id: I2b93a0a31f754538be2663df90825fc14f4eb210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129981 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-02-17sd theme: add doc model for shape fill colorMiklos Vajna
In preparation of adding UNO API for this. Change-Id: Iecb2e44c43bca9e892fcb6242870ec12faa48be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130050 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-17tdf#132057: sc_uicalc: Add unittestXisco Fauli
Change-Id: I56c385e0458e2096e0c1e4fd0c85d47c40fe207b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129987 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-17tdf#147164 Drawings are gone converting to PDF from commandlineNoel Grandin
regression from commit 9a850dd9f3c221660b6259bdfd64a77343f2256c Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Jan 12 10:27:38 2022 +0200 used cache value in ViewObjectContact::getPrimitive2DSequence (2nd attempt) for reasons I do not understand, the cached maObjectRange is wrong at this point in the execution, so switch back to fetching it again, like the code did before the above commit, Change-Id: I4a9f0abc38e59ef687b460689a30ee4badf620a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129994 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-17remove MAXCOL/MAXROW from ScExternalRefCacheLuboš Luňák
The range is used just for filtering out, and since this is about references to other documents, I wasn't sure which document to use as the limits, so I did a copy that of the functions that returns all. Change-Id: I9711534004796496558848adef03d38ddb115441 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129988 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-16lok: sc: handle all local mouse tracking for CalcHenry Castro
Change-Id: I11f3477c0f966d403e076fc73b7e5507ad6597f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118877 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117779 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-16Extend loplugin:stringview to OUStringBuffer::copyStephan Bergmann
(Somewhat oddly, there is no OStringBuffer::copy counterpart.) This required some modification to StringView::VisitCXXConstructExpr to avoid > In file included from odk/qa/checkapi/checkapi.cxx:29: > In file included from workdir/CustomTarget/odk/allheaders/allheaders.hxx:351: > In file included from instdir/sdk/include/rtl/math.hxx:31: > instdir/sdk/include/rtl/ustrbuf.hxx:1687:16: error: rather than copy, pass with a view using subView() [loplugin:stringview] > return copy( beginIndex, getLength() - beginIndex ); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ while building CppunitTest_odk_checkapi as external C++03 code, where the returned value is wrapped in a CXXConstructExpr. And testing for that case required a new CompilerTest_compilerplugins_clang-c++03 that uses gb_CXX03FLAGS and needs to not set LIBO_INTERNAL_ONLY (via gb_CompilerTest_set_external_code), as compiling as C++03 would otherwise generate lots of errors like unknown char16_t at include/sal/types.h:118. (There was a choice whether to name the new test "-c++03" or "-external", but the issue it tests is caused more by the code being compiled with C++03 than by this being external code, see above.) Change-Id: I873a9c5a70d3ea949cf13a169d46920b71282712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130036 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-16Add sanity check to avoid potential crash in the Collabora Online serverTor Lillqvist
Make sure some coordinates don't become huge negative numbers. This doesn't fix the unknown root cause of course. There already was such a sanity check here in this branch, but for Android only. I now made it cross-platform. Let's use the same Change-Id as in the corresponding commit in the co-2021 branch. Change-Id: I28e343271b3f80ac203b52db1be58d2add89eecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128932 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130051 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-02-16do not allocate columns in ScTable::GetPattern()Luboš Luňák
Otherwise e.g. going to the last column allocates all columns. Change-Id: I9cbdb18545bb200379616484c46c85ca31833563 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129995 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-16for unallocated columns check default column attributes (tdf#132057)Luboš Luňák
The problem was that this was returning false for the protected attribute just because a column was not allocated, but the default attributes had the flag set (so if the column had been allocated first it would have the flag set too). Change-Id: I2ef1ef40cafb7e8fc6f7b561c0a376af63f2ad26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129984 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-16move simple checks out of DEBUG_COLUMN_STORAGELuboš Luňák
These few look like useful assertions and they should be cheap, so keep only the extensive checks inside the #if block. Change-Id: I9e6851d25d8b4d637041c1efe1d9712d410262e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130003 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-16Remove apparently obsolete external/boost/boost-android-unified.patch.1Stephan Bergmann
The two checks for __clang_major__ == 5 etc. had been added with 23a8d5ffbbe58761b89f590f0735abccd69a3681 "Upgrade external/boost to Boost 1.69.0" because "with the non-standard Clang 5.0.300080 from NDK r16b, the build now caused failures". But for our current Android build baseline NDK r19c (cf. README.md), > $ android-ndk-r19c/toolchains/llvm/prebuilt/linux-x86_64/bin/clang --version > Android (5058415 based on r339409) clang version 8.0.2 (https://android.googlesource.com/toolchain/clang 40173bab62ec746213857d083c0e8b0abb568790) (https://android.googlesource.com/toolchain/llvm 7a6618d69e7e8111e1d49dc9e7813767c5ca756a) (based on LLVM 8.0.2svn) [...] has __clang_major__ == 8 by now. Change-Id: I5a5131c14ddf410ed60337992c2d827792c3bbc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130029 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-16sw: layout: allow keep-with-next paragraph with fly to move backMichael Stahl
The problem is that a paragraph that has the fo:keep-with-next="always" and also a fly anchored at-char or at-para with style:flow-with-text="true" will never move to the previous page, even with space available. In SwContentFrame::MakeAll() it will first MoveBwd() and then go into the special case "if ( bKeep && bMoveable )" which calls Calc() on the next frame. But this fails to move the next frame because of SwFlowFrame::IsPrevObjMove() finding the fly with a mis-matching mpVertPosOrientFrame - that will not be fixed until the first SwContentFrame::MakeAll() is done and SwObjectFormatter::FormatObjsAtFrame() is called. But SwContentFrame::MakeAll() first detects that the frame is not on the same page as the next one despite bKeep, so it MoveFwd() again. This happens already in OOo 3.3. IsJoinLocked() should be a reasonably good heuristic for "is the previous frame being formatted". Change-Id: I86996dcb3d0c46fcb99ec9ad463569abbb8b99f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130033 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-16tdf#146622 sw crash fix: don't delete already deleted rowsLászló Németh
Delete tables and rows removed also tables and table rows with tracked row deletion/insertion. This resulted not only lost change tracking, but a crashing Undo. Crash regression from commit 99059a1ececa3621c2fe46fabdd79eed9d626c42 "tdf#143359 sw: track deletion of empty table rows". Non-tracked deletion of the tracked row changes was a temporary solution for the missing UI of tracked row changes, implemented in commit 05366b8e6683363688de8708a3d88cf144c7a2bf "tdf#60382 sw offapi: add change tracking of table/row deletion". Note: UI was added in commit f348440e17debacbcba9153e238e010e8c020bdc "tdf#146120 sw: show tracked table changes with different color", commit 95c003d75e0f8b255344715a35358072b5eba99d "tdf#146145 sw: 1-click Accept/Reject of table row changes", commit 84fbb3398f7486f00e7b7dea415e1ea2510a9535 "tdf#146144 sw: add tooltip to table rows with change tracking", commit eebe4747d2d13545004937bb0267ccfc8ab9d63f "tdf#144270 sw: manage tracked table (row) deletion/insertion", commit f481c2c8e74bded11fac754e493560391229dbcd "tdf#144057 sw track changes: hide deleted table rows" and commit 23846867ea32667ccf328c36142394dd6aaee8ba "tdf#147182 sw: accept/reject all changes of a table selection". Change-Id: I384b750b0d3626fa8b3f256c7eaf5b93f382e4e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129958 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-02-16flat-odf-cleanup.py: fix FutureWarningMichael Stahl
The behavior of this method will change in future versions. Use specific 'len(elem)' or 'elem is not None' test instead. Change-Id: Ic1aedaff3569b9b3063823c747c1d09623b2efad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130032 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-16sw: convert an OSL_FAIL to SAL_INFOMichael Stahl
Change-Id: I1ff4c56b52716822dd04cb0e07347a19a2122a4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130031 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-16reenable fuzzing for InsertMatrixFormulaCaolán McNamara
Change-Id: I9a665df74882eb4edac9a1787afe83af5e5e144e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129990 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-16Don't confusingly use the term "gesture" for plain old mouse eventsTor Lillqvist
"Gesture" is a term typically used for finger input on touch devices. The LibreOfficeKitMouseEventType type is for traditional mouse events. Change-Id: Id14ab725567546e33f3dd1277fb4380b9f81d59b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129985 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-02-16clamp ColumnSpanSet::executeAction() to allocated columnsLuboš Luňák
It's already done by executeColumnAction() and currently existing actions do not need unallocated columns. This prevents allocating all columns e.g. when selecting a full row just because ScDocument::GetRangeScriptType() gets called. Change-Id: I517ce14a756be83a385968549b32d430274b8002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129993 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-16do not allocate columns in ScTable::GetNumberFormat()Luboš Luňák
Change-Id: I9347f1d638473f9bcca9b96640a71ae1ef09e415 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129997 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-16Resolves: tdf#147398 Test Intersects() instead of Contains(), tdf#119083Eike Rathke
Regression from commit 8406139062d9ffe1daed32aefe4e261c6c55d63e CommitDate: Mon Dec 6 15:45:35 2021 +0100 process broadcasts for adjacent cells together (tdf#119083) that changed single cell broadcasts to blocks of rows broadcasts and - if (rAreaRange.Contains( rAddress)) + if (rAreaRange.Contains( rRange)) but a block of rows may be distributed over several broadcast areas so rRange is not contained within one rAreaRange and thus was not broadcasted. Testing for intersection instead fixes this. Change-Id: I10700296ebc897e4b7b7752e0e6bcb480085b487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130027 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-02-16tdf#127113: sc: Add UItestXisco Fauli
Change-Id: I3e40d775d95083d96776f3bcd36f92c11110a8a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129986 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-16Related: tdf#147421: optimize O(U)String's replaceAll*Mike Kaganski
... and underlying low-level C functions. Change-Id: I78c2dd75e272e6d3cdd2cfae007ca0a0ec1635e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129942 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-16De-duplicate some codeMike Kaganski
Change-Id: I355fd800e09cef0776408375bd4d6053048d7eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129943 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-02-16simplify some vector constructionNoel Grandin
Change-Id: I0bd131066f5d70fb1dc1c4f851d4d6059994a6f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-16non-const ScTable::GetFormulaCell() doesn't need to allocate columnsLuboš Luňák
A newly allocated column would contain no formula anyway. Change-Id: I7a9f65e5048c9fb6793caafdd4c60892659a1a57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129998 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-16speed up DefaultProperties::SetObjectItem when loading large chartNoel Grandin
The cost of creating a SfxItemSet to pass around changed item information is surprisingly high, so avoid that and just pass the vector of changed items down (which we are already building anyway). Change-Id: Ifa48e3ce07fb6c92ad05a119ae95ce002af76199 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129976 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-16Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 0fa83de4173e9dfaaca3b3c288ec4843d15b9252 - tdf#146733 (Related to: tdf#146937) remove "refresh" from help - refresh command was removed (tdf#146937), so remove from help + add clarification about templates in relation to categories + add "New Category" option + add explanations about conditional items in Manage dropdown menu Change-Id: I1cb7757b0a8b0546989c8a6bfe3e8a4ef1b196a0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129619 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-16configure.ac: Update kf5 include/lib check to work with KF5 >= 5.91Michael Weghorn
The 'kcoreaddons_version.h' header was moved to the 'KCoreAddons' subdirectory in kcoreaddons commit commit d971ba9bb27a3e8f18a116692fdf98c1729ac244 Author: Ahmad Samir <a.samirh78@gmail.com> Date: Sat Jan 15 14:14:13 2022 +0200 Install kcoreaddons_version.h in /usr/include/KF5/KCoreAddons/ Instead of /usr/include/KF5/kcoreaddons_version.h. For more details see: https://invent.kde.org/frameworks/kservice/-/merge_requests/79 GIT_SILENT Adapt the KF5 check to check for the 'KFileWidget' header and the 'libKF5KIOFileWidgets.so' library instead. This is more exact anyway, since we require KIOFileWidgets, and the previous check didn't ensure that. (So in case only KF5CoreAddons but not KIOFileWidgets was installed, configure would previously pass, but the build fail.) [1] https://invent.kde.org/frameworks/kcoreaddons/-/commit/d971ba9bb27a3e8f18a116692fdf98c1729ac244 Change-Id: I7ecf7f29dce85e1a6e6b0d4f2519fa37ab04ca84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129996 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-02-16Fix typosAndrea Gelmini
Change-Id: I3e1e3d214b465f071e57b2e9d349c38aa15657af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126639 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-02-16Related tdf#143578 - Rename SAL_NO_QUERYSAVE to NO_QUERYSAVEHeiko Tietze
Change-Id: Iccec99ba55a1a99a71c685489890e0695a6d6d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129992 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-16lok: sc: apply local mouse tracking only for CalcHenry Castro
Change-Id: I6c3d4c3c59652f20596e32d3f31c5357b7ed61eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118873 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117778 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-16Resolves tdf#143578 - Environment variable SAL_NO_QUERYSAVE to not show the ↵Heiko Tietze
dialog on changes Candy for the QA team Change-Id: I00094872e0c2e6113a7136fa5fd7fd5cb91ba3ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129967 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-02-16CppunitTest_sw_ooxmlexport2: avoid mustTestImportOf()Miklos Vajna
Can use CPPUNIT_TEST_FIXTURE() instead. See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I68841addb024a45bc3a98e5fdb2994f0eacfadc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129977 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-02-16avoid debug build failing on an assert for tdf#144537Luboš Luňák
It really should be an assert, and something is clearly wrong, as the chart shows one row twice after the operation, but I have no idea how to fix this, and it's not that critical, so reduce to just a warning until somebody fixes the problem. Change-Id: Idf0a3496a6f0472301ecb3c0e53ead43312c2f84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129980 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-16simplify codeLuboš Luňák
Change-Id: I5e5c419f2888d0f305f6b83445c66c187f3e0e8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129979 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-16Update mdds to 2.0.2.Kohei Yoshida
See (https://gitlab.com/mdds/mdds/-/releases/2.0.2) for the detail of this release. Change-Id: Ib72a3eee4e1754bd7c0ca25ca25b62abac6d16e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129982 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2022-02-15Removed executable bits on pptx fileAndrea Gelmini
Change-Id: Ib14e5357830b587921b633fb57fa74b1314aa1e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129975 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-15svg filter: google chrome doesn't render white spaces correctlyMarco Cecchetti
In Google Chrome white spaces at the beginning of a text line are not rendered at all. Change-Id: Idd3b1bc5a383b21a54cc1629173bbe26a6da83bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129918 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 5eec28d86a5953de3aa0d5f0c424e92334860270) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129939 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2022-02-15make ScBigAddress use 64bitLuboš Luňák
It may points outside of the document, so with huge sheets 32bit may not be enough. Change-Id: I7aee1d8e90d6c59b91ec07584aa9f36d9352b55c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129972 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-15move nInt32Min/nInt32Max to ScBigRange and rename to nRangeMin/MaxLuboš Luňák
Change-Id: I4537d6ebcd8293bc7a62651345a517ebfe901638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129965 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-15remove harcoded MAXCOL/MAXROW from ScBigAddressLuboš Luňák
Change-Id: I670bb5d6e7a1eb20d2bfd48b853d1d2ebf87fe70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129964 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-02-15tdf#145759 Use symbolic constants instead of magic numerical constantsKunal Pawar
1.4142... -> M_SQRT2 0.4142... -> M_SQRT2 - 1 3.1415... -> M_PI 2.7182... -> M_E Change-Id: If5b19aa38d9902b1a4b717f89f18bdf2f73a47cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129745 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2022-02-15tdf#146848: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I6460a99ce31cbbcba0498a6caaaac3b304a5134e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129966 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-15Resolves: tdf#147421 Do not use OUString::replaceAll() to strip null-bytesEike Rathke
It reallocates and concatenates for each replacement so for massive amounts takes ages. Change-Id: Ibe1673fd4775c5b95833000669c1a24e718fd77c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129971 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-02-15sw HTML export: add a new LeadingTabWidth optionMiklos Vajna
This is a simple way to not loose indentation done with tabs (e.g. source code) during the HTML export. A more complex way would be ask the layout for the tab portion width, ask VCL what's the size of an nbsp glyph and then act accordingly, which is is not done here. Change-Id: I2a5c0512e9e5541e55e10f29952679bf05d63f1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129974 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-02-15Fix typoAndrea Gelmini
Change-Id: If0c567307fe169eda90bd3db81eb538b0c1d03e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129795 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-02-15Fix a CLANG_VERSION checkStephan Bergmann
These functions became available with <https://github.com/llvm/llvm-project/commit/a32a2e34431480759d4983949cbcc25456c6199b> "[clang] Move two utility functions into SourceManager" towards Clang 8 and <https://github.com/llvm/llvm-project/commit/5ef88bdb68234b21b2ecda683dfe2f76513502d9> "Fix isInSystemMacro to handle pasted macros" towards Clang 9 Change-Id: I95b20bc88ff416b49502bdea23e223e6fa966eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129970 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>