summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-26loplugin:unusedfieldsNoel Grandin
Change-Id: I21e538b8e9c7a5f0fb233019efac37a3555e3c93 Reviewed-on: https://gerrit.libreoffice.org/40438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26tdf#99634 Change equal sign tooltip to 'Formula'Yousuf Philips
Change-Id: Ic1bedf1c6ca7fb2a5346aede6c12a6dab372d189 Reviewed-on: https://gerrit.libreoffice.org/40431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-26tdf#100491 fix DOCX import shape line with arrow markerVasily Melenchuk
Line shape with arrow end markers was rendering rather thick arrow, not connected to main line. Moreover, arrow width should depend on actual line width. Change-Id: I8d9a6e7f5d89a1645dcc5939ecc592e86e6fe34f Reviewed-on: https://gerrit.libreoffice.org/40286 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-26xmlsecurity: remove unused XMLEncryption_NssImplMiklos Vajna
This is unused since commit 2303d4f1a2b7e25fe864323adeec398057cebe72 ([API CHANGE] offapi: remove unused css.xml.crypto.XMLEncryption, 2017-07-18). Change-Id: Iefe201a9e93fc02e1295d23ad1b6c27286547241 Reviewed-on: https://gerrit.libreoffice.org/40434 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-26tdf#36747 add sort to match format list in file dialogsJames Raykowski
Change-Id: Ia2883bfe4c020b5c9664eef3001fc90a99c82981 Reviewed-on: https://gerrit.libreoffice.org/38375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-25Resolves: tdf#109331 stupid looking cast was relied upon to do useful thingCaolán McNamara
originally as... sal_uInt32 nErrIdx = aEr.FindIndex((sal_uInt16)(sal_uInt32)lErrId); prior to commit 00657aef09d854c74fb426a935a3e8b1fc390bb0 Date: Sun Jun 11 20:56:30 2017 +0100 migrate to boost::gettext Change-Id: I283f5398ebb81c7183c9013589c326c129787840
2017-07-25tdf#109242 fix save/load of form button alignmentNoel Grandin
Regression introduced by commit dcffc21805828ddff7de1282f3d40ffdf3fac38d "use actual UNO enums in svx" Change-Id: Ie3bb025fa0ef52d2e746e4556cf29dbd3c3d55a9 Reviewed-on: https://gerrit.libreoffice.org/40416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25Convert IMG_ constants to scoped enumNoel Grandin
Change-Id: I4cb65be468422f3cfbf88a6b9ef39fc370fd1a08 Reviewed-on: https://gerrit.libreoffice.org/40408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25fix propcontroller extension regressionNoel Grandin
since cmmit 00657aef09d854c74fb426a935a3e8b1fc390bb0 "migrate to boost::gettext" Change-Id: I9127203ac86a87b916980186efa6f8877868955b Reviewed-on: https://gerrit.libreoffice.org/40415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25VclReferenceBase::getRefCount should return sal_Int32Noel Grandin
Change-Id: I30f8b82fe79fb4822ff9888acd0aa16889bbf4ac Reviewed-on: https://gerrit.libreoffice.org/40413 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25Clear Recent View and Fav view using Right ClickAkshay Deep
Conflicts: sfx2/inc/doc.hrc sfx2/source/doc/doc.src Change-Id: I0aa2919815a3fa63ee180b808834a8aa760af649 Reviewed-on: https://gerrit.libreoffice.org/40234 Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-25tdf#108928 Branding 6.0Heiko Tietze
Improved splash image, now with the proper size Change-Id: If663e7128765c8111332b3524d42630b58366b29 Reviewed-on: https://gerrit.libreoffice.org/40357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-07-25Updated coreBuovjaga
Project: help d91a31ef72b13ae5aa135ef468771254bd31bf1a tdf#97745 Enhance help page layout * Horizontal (stackable) navigation * Work in progress Change-Id: I16a9816b2465e995dd63e36fda0f0d89ea6053e4 Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/40421 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-07-25tell msvc our source code is written using utf-8Caolán McNamara
Change-Id: I4fb364ceb34e0851f2d04c403333bf428e8cfa98 Reviewed-on: https://gerrit.libreoffice.org/40305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-25drop unused definesCaolán McNamara
Change-Id: I2677c5f4458ff5baef61c8015d3e5a226f591913 Reviewed-on: https://gerrit.libreoffice.org/40410 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-25Export to PNG: add SUPPORTSSELECTION flag to Calc and Writer filter fragmentsEike Rathke
Seems this is needed in some obscure (internal dialog?) context to enable the SelectionBox, see sfx2/source/dialog/filedlghelper.cxx FileDialogHelper_Impl::updateSelectionBox() Change-Id: If7c7d5ce5362779c25985c7d492878e31c00f283 Reviewed-on: https://gerrit.libreoffice.org/40417 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-25WIN don't process the SendMessage from DoYieldJan-Marek Glogowski
Actually we just want to remove the SAL_MSG_TIMER_CALLBACK messages, but this seems to be impossible using PeekMessage, without the side effect of processing some messages: "During this call, the system delivers pending, nonqueued messages... Then the first queued message that matches the specified filter is retrieved.". But it is actually enought to ignore the SAL_MSG_THREADYIELD message send using SendMessage from DoYield, which can be filtered by using PM_QS_POSTMESSAGE. Probably this should be resolved not using PeekMessage at all by using a variable to hold the time of the last posted SAL_MSG_TIMER_CALLBACK message, so we just run the callback once, if our time is <= MSG time and ignore the multiple queued messages. Same for mbOnIdleRunScheduler handling. Change-Id: Ifacb20aa38e6b5aca908e5411cf2e100f702ad1f
2017-07-25DomainMapperTableManager::sprm: use std::findMike Kaganski
Change-Id: Iaad2fe950372ecd5261d83554015dc771b3abbf8 Reviewed-on: https://gerrit.libreoffice.org/40403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-25tdf#109281 add fallback to GDI back when we can't bind a DCTomaž Vajngerl
Change-Id: Ibaa0a86562cdeaff989c2a548efa03ea24933213 Reviewed-on: https://gerrit.libreoffice.org/40398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-07-25OOXMLPropertySet: initialize variables on creation and cleanupMike Kaganski
Change-Id: Iea92bdb4759ed9514674125325352d2fd2b372f8 Reviewed-on: https://gerrit.libreoffice.org/40400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-25Related: tdf#102909 use menubar style for non-native menubarsCaolán McNamara
this code should typically not get used at all, as the menubar is a native one, but there is a possible configure route at the moment where this could be achieved. Change-Id: I23c7fa8ad05a378c7d64c75de5f895aa49001597
2017-07-25Resolves: tdf#104368 allow toolbars to have keyboard focusCaolán McNamara
note that there aren't any floating dockable toolbars available under wayland, just X so export GDK_BACKEND=x11 to get gtk's X backend under wayland Change-Id: I07e345a00f8fef4c40dcaf208e3438783f8f280e
2017-07-25Use isEmpty instead of getLengthSamuel Mehrbrodt
Change-Id: Ic0f325bcb28f199b3456dabcd861e40fab17569c Reviewed-on: https://gerrit.libreoffice.org/40397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-25fix image map item idsCaolán McNamara
broken since... commit 4bbf35572d94efe8b321e3159e9810f52bc3f9f8 Date: Mon Jul 7 11:24:48 2014 +0200 RID_SVXDLG_IMAP conversion to .ui Change-Id: Ic08b82af0b8890fb910153c87fb170618d95f34f Reviewed-on: https://gerrit.libreoffice.org/40404 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-25loplugin:unusedfields in scNoel Grandin
The *chart* fields in ScTabViewShell in sc/source/ui/inc/tabvwsh.hxx are unused since: commit 5021f298418f6efa7bb7b6540113b712599778fe Author: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Date: Mon Jul 28 12:11:08 2014 -0300 Remove some unused code The bEveryoneButMe field in ScChangeViewSettings is unused since commit 90e8ad7ab779740c7381d26ffe7d08acc3a9ff96 Author: Noel Grandin <noel@peralex.com> Date: Tue Jul 21 15:39:17 2015 +0200 loplugin:unusedmethods scripting,sc Change-Id: Ie9fbdf8f5e9177449316aaeb40ca3bd26df78a95 Reviewed-on: https://gerrit.libreoffice.org/40264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25Resolves: rhbz#1372630 update recently used color with direct button clickCaolán McNamara
Change-Id: I7373916e7cfd3365afc6c9a1dc728cfeee95be81
2017-07-25fix some "deffer" spellingNoel Grandin
Change-Id: I8fa9782242e92d754eaa131d424eb0a26f04a319 Reviewed-on: https://gerrit.libreoffice.org/40394 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25MeasureHandler: Remove incorrect numeric-value-of-constant commentsMike Kaganski
Change-Id: I89ab3028af12cede2ff1c80c41be053208bf9a43 Reviewed-on: https://gerrit.libreoffice.org/40396 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-25OOXMLPropertySet::add: resize->reserve + range-based loopMike Kaganski
Change-Id: I22fd6893137fcc8815fa222fdfa59f7076887399 Reviewed-on: https://gerrit.libreoffice.org/40393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-25Related: rhbz#1372630 select color from color update, not colortable updateCaolán McNamara
Change-Id: Ia8f0925243bad6754eb3628c1f17d6e910c55437
2017-07-25convert UNO event ids to scoped enumNoel Grandin
I'm fairly sure there are more simplifications that could be make here. It seems like we have both an ID and a string name for all of these events, and we could probably get by with just one of those, or alternately, centralise the name<->id mapping somewhere Change-Id: I978073822ddbebce94ac5b560fea675bea905a35 Reviewed-on: https://gerrit.libreoffice.org/40392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25loplugin:unusedmethodsNoel Grandin
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb Reviewed-on: https://gerrit.libreoffice.org/40391 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25use more comphelper::InitAnyPropertySequenceNoel Grandin
Found with: git grep -n -A10 'Sequence.*Any' -- *.cxx | grep -B5 -w PropertyValueProvider and: git grep -n 'Sequence.*Any.*( *&' Change-Id: Icb18c98bdd3f8352817e443ff78de5df042859ad Reviewed-on: https://gerrit.libreoffice.org/40389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-25OOXMLPropertySet::add: remove redundant checkMike Kaganski
Change-Id: I06aa0d2a2e463069ad200c93329d263f0bd2a00e Reviewed-on: https://gerrit.libreoffice.org/40388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-25fix oss-fuzz buildCaolán McNamara
Change-Id: Ieaf90f70fe9416801f3a22861338fa24c45a0254
2017-07-25tdf#108793 do not use cache for virtual deviceTamas Bunth
Change-Id: Ie75eafac9d716c01464a6a93fd8376a8451bf634 Reviewed-on: https://gerrit.libreoffice.org/40390 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-07-25tdf#107135 Add missing ODFF function FINDB.Winfried Donkers
Change-Id: I96bbca8e6d91448fbb27fe95a57ce62a78d1b2c5 Reviewed-on: https://gerrit.libreoffice.org/40242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-25tdf#109304: Seems infobar child window wasn't registered in MathKatarina Behrens
thus no signature status infobar appeared (I wonder if read-only bar ever worked too) Change-Id: I8829b2b6a17fb8d38e3ea79b87d544e3fb29f1c1 Reviewed-on: https://gerrit.libreoffice.org/40377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-25tdf#108951 RTF import: fix missing custom bullet typesMiklos Vajna
Regression from commit f528f9499bd91b700c549575e88fa102cfffede9 (tdf#106953 RTF import: fix missing paragraph left margin, 2017-05-16) where I fixed the parent of the ooxml::CT_NumPr_numId token at one place, but forgot to adapt RTFDocumentImpl::popState() accordingly. Change-Id: Ibddd2486a50f284e11c2cd96339e7140b427aae1 Reviewed-on: https://gerrit.libreoffice.org/40381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-25Typo: tyoe->typeJulien Nabet
Change-Id: I65c1da9adaec5f95d38cb523822d50e9a05386bd Reviewed-on: https://gerrit.libreoffice.org/40384 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-07-24Export to PNG: use selection if Selection is selectedEike Rathke
The SelectionOnly property from the export file dialog was not passed down from GraphicExportFilter::filter() to DocumentToGraphicRenderer so that always passed a component model instead of a selection object to the implementation of XRenderable (getRendererCount(), getRenderer(), render()) Also have GraphicExportDialog consider the selection so the DocumentToGraphicRenderer at its GraphicExportOptionsDialog calls XRenderable the same. Change-Id: I976bf16cf87cf5ca2678bdba7adfaf61c2063168 Reviewed-on: https://gerrit.libreoffice.org/40380 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-24don't jump back to selected slide on right click context menuCaolán McNamara
i.e. two many slides to fit in slide sorter panel, so scroll bar, select slide one, scroll to the end and right click between slides (or anywhere that isn't a slide) and without this fix the sorter jumps back to make the selected slide 1 visible. The right click menu will offer "new slide", choosing that will insert a slide at the point that was originally clicked, not at the point it was scrolled back to losing focus trigger a (dubious looking) callback to jump to the selected slide, so disable it while context menu is up Change-Id: Ie42bf158258cc38c9b7cfda7672f24d2ac8bfa11 Reviewed-on: https://gerrit.libreoffice.org/40379 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-24SdrGlobalData::aUserMakeObjUserDataHdl is unusedNoel Grandin
ever since commit ddb1d5ebf0a81888001ffa1dbab883df70cdc279 Author: Felix Zhang <fezhang@suse.com> Date: Fri Nov 18 18:23:52 2011 +0800 remove unused Sdr methods removed the SdrObjFactory::MakeNewObjUserData method Change-Id: I95c167b2f20b436bcc0085b6b616406ac210045f Reviewed-on: https://gerrit.libreoffice.org/40363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-24updater: make sure the old oosplash process closesMarkus Mohrhard
Change-Id: Idc0c0231552c79b5e944facffd2d64352bb94cff
2017-07-24sw: prefix members of SwAccessibleFrameBaseMiklos Vajna
Change-Id: Ia0e59c028ec3ca98c39b3097043b512d476faae6 Reviewed-on: https://gerrit.libreoffice.org/40375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-24WIN don't yield the scheduler in PeekMessageJan-Marek Glogowski
The scheduler is restarting the timer at the end of the most important task search. It uses PeekMessage PM_REMOVE to remove old SAL_MSG_TIMER_CALLBACK messages from the queue. Without PM_NOYIELD, in combination with an other thread yielding using SAL_MSG_THREADYIELD, this could re-start scheduling inside these PeekMessage calls, resulting in various assertions inside the scheduler code, most time due to the changed ascheduler list in "assert( pPrevSchedulerData->mpNext == pSchedulerData )". Change-Id: Ia96b6c0e06ffc3126b1428723b53f4b2112f8a5f
2017-07-24Add some const and fix some scheduler loggingJan-Marek Glogowski
Change-Id: Id20767ff2be34a21896d3ce2b76f3944acdb1b77
2017-07-24WIN use Reschedule instead of own dispatch loopsJan-Marek Glogowski
Since we're filtering the wakeup timer event in the main dispatch loop, we should use Application::Reschedule in the Backend. Change-Id: Ie02c3533e8a6a7905281f129489e4f6f53f74692
2017-07-24VBA tests-functions RIGHT,RTRIM,SECOND,SGN,SIN,SLN,SPACE,SQRZdeněk Crhonek
Change-Id: I0db9233f20fccbc4b2c4f4b3e36cf0aaa8583c99 Reviewed-on: https://gerrit.libreoffice.org/40339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-07-24tdf#109306: consider percent unit specification for table sizesMike Kaganski
According to ECMA-376-1:2016, ST_MeasurementOrPercent (the type of "w:w" attribute of table sizes) is allowed to have this specification (and then is expected to be a floating-point value). First edition of the standard (of 2006) only defined this attribute to contain int32 value (of fiftieths of percent when holding relative widths). Unit test included. Change-Id: I700912e4eb07430e55fe1d169d99e8e7e0e1a00b Reviewed-on: https://gerrit.libreoffice.org/40361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>