summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-01-29pdfium: add wrapper for FPDFText_FindClose()Miklos Vajna
So we can call it in the dtor, so we can't forget calling it. Change-Id: I9cea58ca53763d85a4c239fd90611ac1c398564d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110092 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-29KJ: tdf#139988: make Export and Import icon in Template Manager show upRizal Muttaqin
Change-Id: Ibfbea62c1890d72d5b7b4611d9c09d49e67a85ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110116 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-01-29Factor out common parts in scshapetest.cxxRegina Henschel
Change-Id: Ifb63fa5162ea2fe0d1083c6a4361e9595af23317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110038 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-01-28tdf#126248: sc: Add UItestXisco Fauli
Change-Id: Ibbe7aa2229c2a522725bc600a1ba94844910cc84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110087 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-28mac: allow cross compiling with host/build x86_64-apple-macosChristian Lohmaier
apple silicon supports to cross compile without special build-tools/full cross-compiling setup, so just always pass the build/host for firebird. firebird and nss don't recognize the -macos specifier, so substitute it by -darwin to make those happy… Change-Id: I953317fc87da2a20dc91acd88c8528796c3b2a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110093 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-28nss: makefile bitrot: no need for android spcial case anymoreChristian Lohmaier
check for AARCH64 is done for all OS now, so get rid of the superfluous statement. The all-OS line was initially ARM64 for apple silicon, then AARCH64 was added in addtion since that is what ~all other tools use as label - and finally use withing LO was also unified to use AARCH64 and ARM64 was removed… Change-Id: Ief7e5d8bd399c839ff2910fa91ca5bbbff4bcf31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110080 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-28check-missing-unittests: improve scriptXisco Fauli
* Use findall since there might be more than 1 bugId in the summary * put everything from 'source/core/' in others Change-Id: I7d8d6e28f06a97415378c3d235b617ebc7441fbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110072 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-28sw: fix SwTOXMgr::UpdateOrInsertTOX() for user-definedMichael Stahl
The main problem is that when editing an existing user-defined index, the "Create From" changes aren't applied, because it does pCurTOX->SetCreate() and not pNewTOX->SetCreate(). But that wasn't obvious as the function is obviosly very confused about its 3 different TOX variables. pTOX is just used at the end, so just move it there. pCurTOX can be const. Then there is an odd condition on pSh->HasSelection() which ends up doing DelRight() but fortunately it's dead code since commit e9da29679bce3b544add9233a4aca2b19b78da1a #i97572# cleared the selection already. The pNewTOX = pCurTOX there seems pointless because pNewTOX is already a copy of *pCurTOX. Change-Id: I1e9c8178e314a188a50272410fbe566e4a566742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110021 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-28sw: don't repaint all text frames on text node delete for bullet numberingsMiklos Vajna
The intention of the InvalidateNumRule() call is probably to make sure that generated number portions in e.g. Arabic numbering are up to date. But this is not necessary for bullets and causes not needed invalidations. Change-Id: Iad555727e5e2b069bbffae0e7650fb8c75a56770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110079 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-28ofz#30005 crash in LwpFribPtr::XFConvertCaolán McNamara
Change-Id: I4f03c1cd8bc12f3fa09c815837b289ff088c91d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-28simplify code, use more subView()Noel
Change-Id: I569c7f34acbdf8451cd5c9acf1abd334637072d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-28WIN handle GetMessageW return valuesJan-Marek Glogowski
GetMessageW returns a BOOL with three defined return values; a bit unexpected (-1 = error, 0 = WM_QUIT, * = dispatch message). So this tries to handle the non-dispatch results in some way. It's not clear for me, if there is some sensible way to "recover" from an error, but from all I've read it doesn't look like it. "Recover" means in this case, that the last call failed but next call may still succeed without changing the parameters. Change-Id: Ib1f366c7ce8b48158d1935938b49d8da991b30e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110043 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-01-28tdf#64690: sw: Add UItestXisco Fauli
Change-Id: I5fb9c630cb4c7e51add571c1fe24b1e5f14cffba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110045 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-28tdf#134210 Apply mirror property to custom cropped graphic.Gülşah Köse
Change-Id: I5bf2ba8fa432af8b6a560cc60c18bef799834fd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110039 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-01-28WIN refactor ImplSalYieldJan-Marek Glogowski
While looking for some reason for multiple ABORTED Jenkins runs, presumely due to unprocessed Idles, I found the ImplSalYield code way too hard to follow, so this restructures the PeekMessage loop and adds some better comments to make that easier. We now bail out a bit earlier in m_nNoYieldLock mode and also account for eventual tick wraps in single message mode, which isn't needed, as we already just process one message, but it removes additional conditions and further simplifies the code. We also now explicitly report GetMessageW non-message return codes. Change-Id: Ibd745d5540dd9998570ece9aeb0d37886b627eb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110042 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-01-28WIN move dtrans log to vcl.win.dtransJan-Marek Glogowski
Missing from commit 9613165239ade3f0b4d3d06e238430aabc9fcff3 ("WIN move dtrans code into vcl/win/dtrans"). Change-Id: I257017ae617f72c3ce48828ee34e9246af08fd8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110073 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-01-28tdf#123476 filter: Also handle empty ODFMike Kaganski
This builds on top of commit ada07f303e7cd1e39c73abe0741aefe7d9d73a57, to allow 0-byte ODT, ODS etc. Possible TODO would be somehow use default template for such empty files, getting the template name using SfxObjectFactory::GetStandardTemplate. That would enable using 0-byte ODF files as means to "create new document at this location from default template" workflow. Change-Id: I36e07b80f60c42aecdcc6a7357e5bdd18f62e4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109989 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-28Improve macro checksSamuel Mehrbrodt
Change-Id: Ie40801df8866b52c1458e020ffa9cba120720af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109552 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-01-28uitest: sw: close document at the endXisco Fauli
Change-Id: Ic07b3eac1b4e3a5555da5a54d2ce1fa4d284d886 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110047 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-28MouseFollowFlags::DDList is deadNoel Grandin
has been since initial import Change-Id: Ib3e708cddd114f63fd6c77e743b56e35d5929d89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-28MouseSettingsOptions::AutoFocus is deadNoel Grandin
ever since initial import Change-Id: I4ada9a00d3d13b90caa23e90eb66a13eef5c9f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110050 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-28tdf#139781 Handle also "icon-name" property nameMaxim Monastirsky
Change-Id: Iaf2c8521588bdf58daa3166b1efa27979eca2e1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110048 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2021-01-28TopLeft().Y() -> Top() etc.Caolán McNamara
TopLeft().X() -> Left() BottomLeft().X() -> Left() TopRight().X() -> Right() BottomRight().X() -> Right() TopLeft().Y() -> Top() TopRight().Y() -> Top() BottomLeft().Y() -> Bottom() BottomRight().Y() -> Bottom() Change-Id: I5050f619bf92cfc59b6f8dfe7c9f98ef1453c294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110022 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-28add string_view variants of methods to O[U]StringBufferNoel
and update the stringview loplugin to detect cases where we can use these new methods. Change-Id: I998efe02e35c8efcb3abfb4d7186165bbe6dfb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-28Revert "tdf#138122 Detect window scaling for multi display configurations on ↵Stephan Bergmann
macOS" This reverts commit f318b856ed055f1952276355f811153f6b29c93e. It appears this reliably causes CppunitTest_vcl_backend_test to fail on macOS on at least tb69, see e.g. <https://ci.libreoffice.org/job/gerrit_mac/82587/ consoleFull#-500134232d893063f-7f3d-4b7e-b56f-4e0f225817cd> and <https://ci.libreoffice.org/job/gerrit_mac/82592/ consoleFull#-500134232d893063f-7f3d-4b7e-b56f-4e0f225817cd>, [_RUN_____] BackendTest::testDrawBlendExtended /Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/vcl/qa/cppunit/BackendTest.cxx:688:BackendTest::testDrawBlendExtended equality assertion failed - Expected: c[000080ff] - Actual : c[ffffffff] BackendTest::testDrawBlendExtended finished in: 1ms [_RUN_____] BackendTest::testDrawAlphaBitmapMirrored /Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/vcl/qa/cppunit/BackendTest.cxx:749:BackendTest::testDrawAlphaBitmapMirrored equality assertion failed - Expected: c[ff0000ff] - Actual : c[000000ff] BackendTest::testDrawAlphaBitmapMirrored finished in: 1ms [_RUN_____] BackendTest::testTdf124848 /Users/tdf/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/vcl/qa/cppunit/BackendTest.cxx:808:BackendTest::testTdf124848 equality assertion failed - Expected: c[000000ff] - Actual : c[ffffffff] And it also causes my local macOS 11.1 ARM64 build to consistently fail that way, both the original patch set 1 (with the older parent) and the submitted patch set 2 (with a newer parent). Change-Id: I2c36fada271e8bc300b6caa19370d8e8bb1e7599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110055 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins
2021-01-28tdf#122714 Avoid tracking mode for a toolbar's title menu buttonMaxim Monastirsky
Regression of commit c3e552ac25be001a623469c549ee8d0719b98133 ("wayland: Make popup menus not show off-screen"). Apparently executing the menu async used to give the tracking mode a chance to be turned off. Avoid the problem by not activating that mode in the first place. And because the Tracking method will no longer be executed, we also need to reset the "pressed" state here instead. Change-Id: Iab63f1eaada1f4945507d6bdd05dc6171e6afbab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110029 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2021-01-28remove unused SelectionOptions valuesNoel Grandin
Focus is dead since commit 6a22fc81e219667566b9cc3ed5e9de1898c1fe6b Date: Thu Apr 23 20:49:05 2020 +0200 loplugin:unusedmethods Invert seems to have dead since initial import Change-Id: I9f03a9cd9abef6d056331ead47bfff5ffcef512b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-28pdfium: use PDFiumTextPage in SearchContextMiklos Vajna
Change-Id: I12332ac101ecb3c92a343c8bd9a038b0238b6791 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110030 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-28Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 586ced62fd1bea8a07e84fea7c3befc59c1249e1 - add N--N to "replace dashes" in AutoCorrect Options Change-Id: Ica225160efba504163c6a5b946e63b0e37cbffc5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110052 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-01-28tdf#108654: sc: Move UItest to CppUnitTestXisco Fauli
While at it, reduce the size of the file a bit Change-Id: I84b81515a908aa5fb4e5a1688964829b17868e43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110033 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-28tdf#57523: sc: Add UItestXisco Fauli
Change-Id: I6ae33cf1151820716cc089a105dbfd8aa9994c2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110037 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-27Improve loplugin:stringliteralvarStephan Bergmann
...to also consider O[U]String ctors taking pointer and length Change-Id: Iea5041634bfbf5054a1317701e30b56f72e940fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110025 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-27Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 72fb074096addac2c8cc732bb7a73f0fb45ee2a1 - tdf#135895 improve explanation about copy and renumbering lists + add <note> about copying and moving numbered list items and how to restart numbering. * update command name to "Toggle Numbered List" and add shortcut * update icon for "Toggle Numbered List" and move it into an icon table * update to <h1>,<h2>,<menuitem>,<note> Change-Id: I5d7e55e18f0c5d3bd523442a12a3c12448085f92 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109986 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-01-27uitest: sc: this test can goXisco Fauli
Change-Id: Ia1f7af4d52ad6f318247b7aa9d87f2775f34b9b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110036 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-27uitest: sc: no need to have one module for just one testXisco Fauli
Change-Id: I2787a3bca577f8f34a9f37b25ed4bc6631bb446d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110035 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-27cid#1472567 Dereference null return valueCaolán McNamara
Change-Id: If5e63883c831ee1ff164126750db86e4c2ec2efd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-27update creditsChristian Lohmaier
Change-Id: Ib58485cc97b61b6e8178b2c2b143a30e520cb373
2021-01-27packaging: remove resolve_variables_in_downloadnameChristian Lohmaier
OOODOWNLOADNAME was set in the global section of openoffice.lst, so the code always did set the target path with set_download_filename. Thus remove the superfluous sub and then also the no longer used OOODOWNLOADNAME variables In the same vein: the "script that extracts a tarball that is appended to it" method is no longer in use since many years, delete that as well. Change-Id: I43481a3ec09e064ef77138e1cbfc1dba6854f2d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110017 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-27Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 1a2b3002632852187c0f5c5585888e8cb419f414 - Minor copyedits Change-Id: Id238b9ae6987152c7759cac21154b61a495b8685 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110027 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-27tdf#126577: sc: Add UItestXisco Fauli
Change-Id: Ic4fdfec07437be0f6c85aa8c90a82177de007f75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110020 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-27tdf#131442: sc_uicalc: Add unittestXisco Fauli
Change-Id: Idbe03f327593b2ada5de82d725aee96920aecf90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110011 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-27PPTX filter: fix lost is-narration property for slide narrationsMiklos Vajna
Otherwise removing narrations don't work in powerpoint, it would say there are no narrations, just plain media shapes. Change-Id: Ibd0478540ac018bc23f81223846518b3bf7c7c2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110016 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-01-27Use std::u16string_view instead of OUString in one placeStephan Bergmann
...due to which an upcoming loplugin:stringliteralvar improvement would otherwise have suggested to turn the MinusChar array into an OUStringLiteral, but which would have lead to awkward code elsewhere. (And the code is a bit more efficient this way now anyway, of course. The remaining OUString numberChar, multiplierChar, decimalChar, separatorChar; might benefit from a similar change, but they didn't interfere with the loplugin:stringliteralvar improvement, so are left alone at least for now.) Change-Id: I41e3ef987450cbd29d3663a9aeefda336d798170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110019 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-27NSApplication's appearance property exists in macOS 10.14 and later onlyTor Lillqvist
Change-Id: I12f586d91e40da130f59eeba3ab65e07eec088d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110013 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110015 Tested-by: Jenkins
2021-01-27tdf#138727 help browser didn't flow textCaolán McNamara
because of its size request, while the paned shrink lets the pane shrink below the size request the contents stay at a min of the size request and aren't really shrunk, just clipped. Instead don't let the pane shrink but don't set a size.request letting it shrink to its natural min of its contents which are then truly resized so the text flow works. Change-Id: Iaf6738ace28c82379ac6322310de9a22f9653473 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110014 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-27pocheck: don't require reference for stock labelsChristian Lohmaier
See d5d905b480c2a9b1db982f2867e87b5c230d1ab9 and related commits for the rationale on why those are not extracted like other strings. Change-Id: I2a339747626e0fb314cac7f57bccb2b91853249c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109916 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-27sw_fieldmarkhide: adjust SwPaM::HasReadonlySel() to the fact that...Michael Stahl
... there is, in fact, an else branch. D'oh. (regression from f8da730bd66d5d6d3e49935573b3223c06baffbe) Change-Id: I378b0a78a4ccc9a0e7fa9a6bf2e1ecb456133bed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110012 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-27tdf#139941 wrong transparency in 3D objectNoel Grandin
regression from commit 508c2e4a2d2b26d6b1842ff98e9aaa4d3adddf80 transparency->alpha in vcl::RawBitmap Change-Id: I45a1759fb9a78bc0fc5caa4a5b5362eaddc6f743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110010 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-27tdf#138590 use the highlighted menu entry, not the combobox active textCaolán McNamara
Change-Id: I2fb68c1491d129d5fd9b963ae4db1fb83171a154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109996 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-27tdf#138907 sw TitlePageDlg: Goto correct (inserted) pageJustin Luth
Especially with inserted-in-the-middle pages, until the layout was re-calculated, the new pages were not recognized. This patch should bring this format option into pretty good shape. I made a couple of decisions: 1.) Insert an additional content page when adding to end of document (otherwise the last index page turned into content). 2.) Ensure that index pages don't inherit page-renumbering This CalcLayout could take a fair amount of time on a huge document. I tested on a document that took over a minute to load. It inserted pages in about 10 seconds. The experience seemed reasonable to me given the known slowness of the document. make UITest_writer_tests5 UITEST_TEST_NAME=\ titlePageWizard2.tdf138907.test_tdf138907 Change-Id: I6d7763ab10b46b5a459e9b62ed96b0194b2258b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109830 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-27 04:26:46 +0000