summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-13NFC tdf#154703 docx export framePr: cleanup prep before patchJustin Luth
This sets up the building blocks for a series of patches. Lets get this formatting/renaming stuff out of the way first so that we can focus on the actual logic changes later on. Change-Id: I20aa333080d9f31af4f4b9e89a51eafba1d39530 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150354 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in ea331fa8b498c66ec687c6611c69ffc61e58bc79 "tdf#131553: Add unittest". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I9841713baf718be5b19d25acb35f3b856a94e1cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150358 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13sal_uInt16 is not a good choice to store SwTwipsMike Kaganski
The latter is tools::Long, which is even 64-bit on most platforms. Just use auto here. Change-Id: I5b45220b79cd4798bafdb416ad7a44eb4d5d1f99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150320 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-13add some debugging on failure to find impress_allCaolán McNamara
Change-Id: I4d303f7f60bb0f086fad8f3883dee1393a5d6eb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13Resolves: tdf#152619 crash inspecting uninserted XFieldMasterCaolán McNamara
Change-Id: I765dd5d7e1ed2c1749841491a50216a6afe903c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150351 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13pointer is always dereferenced make it a referenceCaolán McNamara
Change-Id: I77c5dc3a4d4f290f5020019f3f455b1fec2497ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150350 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13use more string_view in PrinterInfoManagerNoel Grandin
Change-Id: Ib0173b1a33be7156c27c81b0804ac7c4d3373857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13remove unnecessary exportStyleFamily methodNoel Grandin
Change-Id: I59c75494ffd3f132a041beebb4336714c1e94143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13use more string_view in SwHTMLParserNoel Grandin
Change-Id: I49675277766146c948886b58c8eeaecb7e41b90b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13tdf#154451 uitest: use more oneprocess modeMiklos Vajna
Execution time changes: - UITest_writerperfect_epubexport: 20,023 -> 6,083s - UITest_svx_table: 15,214s -> 14,378s - UITest_cui_tabpages: 13,561s -> 12,503s - UITest_math_demo: 19,737s -> 13,578s Change-Id: Ide03d5d9cb884297291a5ed1351de5a7602fcba4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150346 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-13tdf#154481 sw DOCX import: fix page loss and freezing at ODT exportAttila Bakos (NISZ)
Disable TOC creation in case when field context stack is empty but TOC creation is in progress in textboxes. Before if TOC creation failed because it is already existed, the TOC creation member (mbStartTOC) kept true resulting in broken textbox handling. Textbox and TOC import use the same text append stack but the TOC was not removed from the stack so content have been written into the TOC instead of the textbox, resulting page loss, and because of the broken structure, freezing at further ODT export. Change-Id: If27aa477c49f276d4e538b6e125798d89f0ac423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150099 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-13query getUserAllowsLinkUpdate for the case of content in a floating frameCaolán McNamara
similarly to how it works for the more common "normal" embedded objects Change-Id: I83e38dfa2f84907c2de9680e91f779d34864a9ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13adjust IFrameObject so it could reuse mxFrame for a reload of contentCaolán McNamara
Change-Id: I7eec3132a23faafd9a2878215a0a117a67bc9bf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150343 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13use parent window as dialog parentCaolán McNamara
it makes no odds, but is more convenient for upcoming modification Change-Id: Ibc5333b137d2da089b3b701ff615c6ddf43063d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150342 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13extract a OCommonEmbeddedObject::SetInplaceActiveState for reuseCaolán McNamara
no behaviour change intended Change-Id: Ia1d12aa5c9afdc1347f6d4364bc6a0b7f41ee168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150341 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-13Content Control Properties dialog alignmentSzymon Kłos
Make explicit that ok/cancel buttons should be the last row Change-Id: If22da5222fc9dc1c1c5f94fd08c945364284daee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146904 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150095 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-04-13use more string_view in SwHTMLParserNoel Grandin
Change-Id: If1dcb2e4207b15eb71bd79469f89526c76f05772 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13fix SwHTMLParser::InsertCommentTextNoel Grandin
which went wrong in commit 7a504c8752bf7c5accbb9bcc33a98f79b31b8bf2 Author: Palenik Mihály <palenik.mihaly@gmail.com> Date: Fri Aug 9 13:51:08 2013 +0200 Change String to OUString in SwHTMLParser class Change-Id: I7623e5fe1f4ca07adff8de11d7c01b1cea3733d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150334 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13deduplicate o3tl::trimMike Kaganski
Change-Id: I5d4b3555b59b5abf622c389662e83cbd0f7d142d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150213 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-13lok: trim glibc allocator's pending heap when called.Michael Meeks
Change-Id: I8d1bda01a0e6ccff0fa868013c67c0fbbf78a836 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150299 Tested-by: Jenkins
2023-04-13no need to allocate these separatelyNoel Grandin
Change-Id: Icc24e0aaf1762e5b318b8364dd9fdb496edfb77c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13sw floattable: restrict selection of follow flysMiklos Vajna
Select a follow flys that is at the top of the page, drag it towards the bottom of the page, release it, it'll jump back to its original position, which is frustrating. The reason for this is that the layout ignores the vertical offset for follow flys on purpose, but this is communicated to the user poorly. Fix the problem by selecting the master fly on fly selection (for split flys), this allows changing the horizontal position for all flys in the chain and changing the vertical position for the master flys. This is now less confusing, since the indicator of the new position is also drawn for the master fly. This is somewhat similar to what 7596e26fd259ce5445212949403e7cd32303b2bd (Add SwTextBoxHelper::findShapes, 2014-06-24) did for textboxes, but there we selected the owning draw shape of the fly frame. Change-Id: Ie8171d32a306bfb5d28cc750db5bbae6021ef72f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150310 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-13Fix UBSan function-type-mismatchStephan Bergmann
...as seen with the additions to CppunitTest_i18npool_transliteration made here, > i18npool/source/transliteration/textToPronounce_zh.cxx:175:17: runtime error: call to function get_zh_zhuyin through pointer to incorrect function type 'unsigned short **(*)()' > workdir/CustomTarget/i18npool/indexentry/zh_zhuyin.cxx:1512: note: get_zh_zhuyin defined here > #0 in i18npool::TextToPronounce_zh::TextToPronounce_zh(char const*) at i18npool/source/transliteration/textToPronounce_zh.cxx:175:17 > #1 in i18npool::TextToChuyin_zh_TW::TextToChuyin_zh_TW() at i18npool/source/transliteration/textToPronounce_zh.cxx:149:5 > #2 in TextToChuyin_zh_TW_CreateInstance(com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory> const&) at i18npool/source/registerservices/registerservices.cxx:236:1 > #3 in cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceEveryTime(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx:173:24 > #4 in cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx:230:12 > #5 in non-virtual thunk to cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx > #6 in cppuhelper::ServiceManager::Data::Implementation::doCreateInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx:709:26 > #7 in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool) at cppuhelper/source/servicemanager.cxx:675:16 > #8 in cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx:1006:36 > #9 in non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx > #10 in i18npool::TransliterationImpl::loadBody(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::i18n::XExtendedTransliteration>&) at i18npool/source/transliteration/transliterationImpl.cxx:619:45 > #11 in i18npool::TransliterationImpl::loadModuleByName(std::basic_string_view<char16_t, std::char_traits<char16_t>>, com::sun::star::uno::Reference<com::sun::star::i18n::XExtendedTransliteration>&, com::sun::star::lang::Locale const&) at i18npool/source/transliteration/transliterationImpl.cxx:630:5 > #12 in i18npool::TransliterationImpl::loadModuleByImplName(rtl::OUString const&, com::sun::star::lang::Locale const&) at i18npool/source/transliteration/transliterationImpl.cxx:278:9 > #13 in (anonymous namespace)::Transliteration::testTextToChuyin_zh_TW() at i18npool/qa/cppunit/transliteration.cxx:120:27 For one, there had always been a mismatch between the return type `const sal_uInt16**` generated in i18npool/source/indexentry/genindex_data.cxx since d319c4611e932b286c0bef14387382da0f2e92d2 "INTEGRATION: CWS i18n24 (1.1.2); FILE ADDED" vs. `sal_uInt16**` used in i18npool/source/transliteration/textToPronounce_zh.cxx since f4705bf0a3efeebfe74568abb355ad60621300dd "INTEGRATION: CWS i18n24 (1.8.36); FILE MERGED". And for another (and more severe, as it caused random writes), there had also been a mismatch between the parameters `(sal_Int16 &max_index)` newly generated in i18npool/source/indexentry/genindex_data.cxx since 7696cd3902ca248951205f15930787488368ea26 "INTEGRATION: CWS i18n31 (1.4.60); FILE MERGED" (and correctly used in i18npool/source/indexentry/indexentrysupplier_asian.cxx since 58dcf0ffaf8668827fc2f47445c9d8faf3d29555 "INTEGRATION: CWS i18n31 (1.9.60); FILE MERGED") vs. the original `()` used in i18npool/source/transliteration/textToPronounce_zh.cxx ever since f4705bf0a3efeebfe74568abb355ad60621300dd "INTEGRATION: CWS i18n24 (1.8.36); FILE MERGED". For DISABLE_DYNLOADING, the second (missing max_index parameter) issue appears to have been broken even further with 9db03b879b912d79060ab06f03a54d4a59e6ac65 "i18npool: fix wrong static function symbols", replacing the wrong sal_uInt16** get_zh_zhuyin(); sal_uInt16** get_zh_pinyin(); declarations in i18npool/source/transliteration/textToPronounce_zh.cxx with the even worse declarations sal_uInt16** get_collator_data_zh_zhuyin(); sal_uInt16** get_collator_data_zh_pinyin(); corresponding to function definitions generated by i18npool/source/collator/gencoll_rule.cxx (which also happen to have zero parameters, but non-matching return types, and apparently completely different collation vs. transliteration semantics). Change-Id: Id91b17eeb7fcdd0c711d52a624375356dc47fc32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150302 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13tdf#105035 writerfilter framePr: don't allow overlap in extreme caseJustin Luth
I NEED to do something about preventing overlap because in certain cases MS Word (2010/2016 tested) does not overlap frames even though their vertical placement is identical. The previous commit just fixed mis-combining separate frames into one, but now those frames might overlap each other - which is worse than being combined into one IMHO. Unfortunately, Microsoft's decision to not overlap seems arbirary. In most cases it needs to be allowed, so I have developed a minimal set of specifications that prevent overlap for bug 105035's specific document, and it should be flexible enough to allow other cases to be added. I tested a number of cases when designing my formula. It doesn't seem to prevent overlap for page or margin position. It doesn't seem to prevent overlap when set to top/middle/bottom. It doesn't seem to prevent overlap if the frames are below the first line of text. I still have a problem: the order of the frames might layout wrong - as in this unit test. Sigh. Too bad this code is so ugly and long, but it should be relatively performant. make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf105035_framePrB Change-Id: Iddaf36b9797a38b7906bb980e06cc73da7012eed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150063 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-13sw: fix undo comment of FN_DELETE_FIELDSMiklos Vajna
It's fields, not field. One has to dispatch .uno:DeleteFields to see this in action, which does something if the document already has existing reference marks. Change-Id: I81e3be3f2b68bfee2ed85a2a060dd05c3eb56670 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150300 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-13try to fix CppunitTest_framework_dispatch on windowsNoel Grandin
I see occasional failures here, possibly they are a threading issue since we are touching these fields from multiple threads. Add a mutex to see if it helps. Change-Id: I7277e96d07d292a6bc1d333dabec7a82fc607465 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150281 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in 6de8d3109dffa7d4d0cc06f319cca70134f0a8f3 "tdf#103474 handle edge cases in ARCANGLETO". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I40342955feedad25435c03f16a31b9585281c1f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150306 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since the two variables got introduced in 919a4ef592b6026a7533a93682f39118fef29ce8 "tdf#105461 PDF export of editeng fill color: restrict to logic map modes" and fddd956c0cf3b2c22a152bbb30554def1336b466 "tdf#96892 vcl: add unit test for misplaced soft-hyphen ...", respectively. (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I538a8cf410355ca4b5230f89947587b58d67e205 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150304 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13-Werror,-Wunused-variableStephan Bergmann
Unused ever since it got introduced in 463178fef5c22f1a04d10e54491852d56e2038b0 "xmloff, sw: ODF import/export of fieldmark separator". (Found with an experimental Clang build supporting __attribute__((warn_unused)) on individual ctors rather than just whole class types, and the corresponding css::uno::Reference ctor marked accordingly.) Change-Id: I8d665d12f923725773f6a55f7edee70ebc72e3ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150303 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-13tdf#153806 sw a11y test: Drop obsolete workaroundMichael Weghorn
This is no longer needed with commit d1f5b3c5cb226fd5f58fe2cdc8be9d1330fad6a2 Date: Sat Apr 1 23:35:50 2023 +0300 tdf#153806 a11y: Improve keyboard interaction in special char dialog in place. The insert action is available right away now. Change-Id: Id47f306ba17ed428a4bfc978177e367991509eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150289 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-13Related: tdf#153374 Don't release autoreleased attributeNamesPatrick Luby
Also, return an autoreleased empty array instead of a retained array. Change-Id: I5f494b301dbae859486d6bc4874112b714022b60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150307 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-04-12tdf#140730 a11y: Focus form control property dlg when it startsMichael Weghorn
Make sure the dialog gets focus again when it starts after having been welded in commit 1efeb17837c22499f00299c033ae59ba3910f7d7 Date: Mon Nov 4 13:06:04 2019 +0000 weld Property Browser (Tested with gen, kf5 and on Windows.) Change-Id: Ie5d28a60b459735d1f1fa4c2d5d679f3d5a27cec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150284 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-12Use more *string_viewMike Kaganski
OUString::equalsIgnoreAsciiCaseAscii and compareToIgnoreAsciiCaseAscii taking string_view are added as overloads, rather than replacements to the variants taking const char*, because the latter have benefit when the passed C-style string's length is unknown, because these variants don't pre-calculate the length. Change-Id: I2def689d7b7784212dc6cd6b8ae9ab1d42604079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150272 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-12Use o3tl::trim in strtmpl.hxxMike Kaganski
Change-Id: I4de8658c36c21fe07fa45f697cf3145c567a95c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150210 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-12qt: Don't show non-visible menu entriesMichael Weghorn
Take the visibility of the menu item (that e.g. gets set in `QtMenu::ShowItem`) into account when updating the menu in `QtMenu::DoFullMenuUpdate`. With this in place, only the relevant entry is shown in the context menu for items in the character table in the special characters dialog (Writer: "Insert" -> "Special Character") while previously, the "Add to favorites" and "Remove from favorites" entries would both be shown at the same time regardless of whether the character was present in the favorites or not. (Both entries would actually do the same: add the character if it was not present in the favorites, remove it if it was already there...). Change-Id: Ica5f07d6009d97db2df0540293b096565bf1dd52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150285 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-12Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 5eebbe317f7515c901355e1a14e5374169f0223c - tdf#154689 clarifications for "to" and "Horizontal Change-Id: I05fcbb9fe7628783a89807f91b215d397a7586d0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150206 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-04-12tdf#154771 sw: fix drag & drop moving of table columnsLászló Németh
Only first selected column was moved, the other ones were copied during drag & drop moving of table columns. Regression from commit 5e8aa259e48d5602b932353bb146ebb523982cf2 "tdf#146967 sw table: fix freezing in Hide Changes mode". Follow-up to commit 912336f3c85d9a631fa0ac0f270bab04b204f619 "tdf#154599 sw: fix crash at drag & drop table columns". Change-Id: I31ca5b3d6004ed53c11a951fa184b9db48f21041 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150280 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-12mpMouseLeaveTimer has been deadNoel Grandin
ever since it was added in commit 8229967979d96bd01e63e2954b7af35a57d9e08c Date: Thu Sep 20 15:23:39 2007 +0000 INTEGRATION: CWS os2port01 (1.2.2); FILE ADDED 2006/11/29 14:34:20 ydario 1.2.2.1: Initial OS/2 import. Change-Id: Ic1bbf9f9167f9a7146f3c7d18b6fdb69c1f44e0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-12use more unique_ptr in SalDataNoel Grandin
Change-Id: Ib6e5131bff38b55b2dbf0805b63ca3554c5ee349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-12xmloff: ODF import/export for style:overflow-behavior "clip"Sarper Akdemir
Adds initial support for style:overflow-behavior According to OpenDocument-v1.3-part3 style:overflow-behavior can take values of: - "clip" - "auto-create-new-frame" This patch doesn't properly implement support "auto-create-new-frame", only "clip". If "clip" is set, TextClipVerticalOverflow is set to true, causing the vertical overflowing text to be clipped. "auto-create-new-frame" is treated the same as omitting the style:overflow-behavior attribute, setting TextClipVerticalOverflow to false. Change-Id: Iea298f41fbf0cf18dc07f41788ba0b665515db8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150122 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-04-12tdf#39593: remove trim(), use o3tl::trim() insteadBayram Çiçek
trim(std::u16string_view in) and trim(std::string_view in) functions were removed and replaced with o3tl::trim(rString) function Change-Id: I29b2274422dbfe9dc26177c3e1dbf20786c811d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150245 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-12Revert "remove unnecessary UnoControlModel::setPropertyValues"Noel Grandin
This reverts commit 19c18c94085f7a70e536a914ed978fc54b5625b9. Because it breaks the MRI extension, I was wrong, it does not do quite the same thing as its superclass method. Change-Id: I65bfb4264615dea5f6d0f2fb7b989352e7e83ee1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150274 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-12lok: capture and publish the modified status in save resultAshod Nakashian
This is necessary to flag to the storage whether or not the contents of the file being uploaded has any user modifications or not. This is typically used to optimize the versioning and storage utilization. We also add the time when saving started and the duration it took. The timestamp is to figure out if there has been subsequent activity/commands that could have modified the document. The duration is to help Online throttle saving if too frequent. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: Id6d8e629ef9b6e723d1d8b84d64fc7741b997bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149985 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-12Remove duplicated includeAndrea Gelmini
Change-Id: Iff23fcd5d88ce33d66f5f7255d0967c695b91f84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150247 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-12use more unique_ptr in ImplSVWinDataNoel Grandin
Change-Id: Id1d42e2de480e8ec248e5716ababc8bddfc905ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150276 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-12rename intern->internalNoel Grandin
where appropriate Change-Id: I440d277e7be242eeecb7767fa11d1c4dad937e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150268 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-12tdf#153903 "Numbering" -> "Number" for "number range" cross-ref formatSeth Chaiklin
Change-Id: I5857e7b42177b9b6db4903371e14a7d30822ce45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150137 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-12loplugin:stringview whitelist getLength and isEmptyNoel Grandin
Change-Id: I38f3410c0b25ff579879b9de1f266af4d8fd51e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-12OUString::intern is a relicNoel Grandin
and a pessimisation. Remove usage thereof. Change-Id: I98f6197aa375349b909a7ef1403ec06ca37890d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-12sw floattable: don't try to set left margin as cell propertyMiklos Vajna
Cell UNO objects don't have such a property, and this generates a warning on importing sw/qa/core/layout/data/floattable.docx, silence it. Change-Id: I573c6f95edb8577e70518a9c21119a0e32b6a411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150271 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-28 21:39:56 +0000