Age | Commit message (Collapse) | Author |
|
Change-Id: If22d82d506c365ae956de3d15e64c7065ad6b585
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89625
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1f3d17f0d735a95c40e2fb9f1f6a7f12b5b30b82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87808
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: Ib66a2a48b6e0d746fc54d2b1987a574c26ea1c1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89619
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
regression from
commit 0528012fd0dc4b93645ef7790b0db9d1cecbae66
loplugin:constantparam
Change-Id: I7e6d366c60da95f7839755e4ce228cfeff7354af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89618
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I528d0bd7408ab9761de2d6fe8e60a5a521dda4dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89414
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Tested-by: Jenkins
|
|
Size of buffer on stack is 256 characters. Logging function usage
in make check, of >1 100 000 invocations, the longest string was
80 characters, average being 4.6 characters. So heap allocation
is unlikely in scenarios with intensive function usage.
Several existing unit tests had to be fixed. Usually, the change
is either minimal or getting closer to what Excel returns (for
Calc tests). But in case of AMORDEGRC, I had to change rate value
passed to the function from 0.3 to 0.31. It's because the closest
double value for 0.3 is 0.29999999999999999, which is a bit less
than 0.3; multiplied by 1.5, this gives 0.44999999999999996, and
then rounding the result of multiplication of the latter by cost
gave the result 1 less than before, when 0.3 was imported as
0.30000000000000004. Now the function returns a value 1 less than
Excel for that set of arguments. I don't see how to fix that.
Having rate slightly different gives consistent result between
Calc and Excel.
Change-Id: Icae5ce374fe0c31a1aa10cee815e65ef0014f382
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89422
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
... representation of given decimal.
Use dtoa.c from https://www.netlib.org/fp/dtoa.c to build a custom
static library that doesn't use current locale (unlike strtod from
stdlib.h). This is the implementation used by e.g. python and nss
(search for "dtoa.c" under UnpackedTarball).
To avoid name clash with the standard strtod, rename the function
to strtod_nolocale.
Size of buffer on stack in ImpSvNumberInputScan::StringToDouble is
256 characters. Logging function usage in make check, of ~124 600
invocations, the longest string was 14 characters, average being
2.1 characters. So heap allocation is unlikely in scenarios with
intensive function usage.
After std::from_chars is available in baseline compilers, external
library can be dropped, and call to strtod_nolocale replaced with
the standard function.
The artifact at https://dev-www.libreoffice.org/src/dtoa-20180411.tgz
is created with
mkdir dtoa && mkdir dtoa/src && wget https://www.netlib.org/fp/dtoa.c -O dtoa/src/dtoa.c && \
printf 'd8bab255476f39ea495c8c8ed164f9077da926e6ca7afb9ad3c56d337c4484fe dtoa/src/dtoa.c' | sha256sum -c && \
tar -c --owner=0 --group=0 --mode=go=r,u=rw --mtime='Wed, 11 Apr 2018 15:59:39 GMT' dtoa/src/dtoa.c | gzip -n > dtoa-20180411.tgz && \
printf '0082d0684f7db6f62361b76c4b7faba19e0c7ce5cb8e36c4b65fea8281e711b4 dtoa-20180411.tgz' | sha256sum -c
(where the date "Wed, 11 Apr 2018 15:59:39 GMT" is from
`wget -S https://www.netlib.org/fp/dtoa.c`
"Last-Modified: Wed, 11 Apr 2018 15:59:39 GMT" header).
Change-Id: Ia61b7678e257c4bc1ff193f3f856d611aa5c1a21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88854
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I62a0b760e49e38a4565eebf272492159047dda5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89613
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
... because Word's funny limitation to 25 listEntry children causes data
loss, as seen in commit d9634e3c9bfaf826b3d4d39e9a57d6c2d8d9a3dc
"sw: DOCX export: limit FORMDROPDOWN listEntry to Word's abilities".
Instead write SDT dropDownList, which appears to be able to store at
least 26 listItem children without complaint from Word, so it's an
improvement.
Funnily domainmapper converts it to a form control on DOCX import.
Change-Id: Ic0f24144cb2b5233f82c7b3bc67946a6e56448a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89541
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
Writer shapes are implemented using SwXShape, Impress shapes use
SdrGrafObj. So switch to working with the XShape interface, which is
supported by both.
Also, don't work with the transformed graphic if it has the same
checksum as the original graphic: the transformed graphic is not linked
to the original JPG/PNG data.
Now selecting an image in Writer Online has the same speedup that
Impress Online already had.
Change-Id: Iab2791c5f5c7a2754e3de0ebb2d6ea664f6c77e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89540
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
regression from
commit 0ef5c47547bec6319b853326603f3b807407fe78
sc: rowcol: tdf#50916 convert core/tool
Change-Id: I8cb8fa4c6abf7450386a284a26be0a6d3ab9a623
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89617
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
the question in 2012 was, is this still necessary? It slows down every warm
start so let's assume it is not, remove it and see what happens
Change-Id: Ia185fd18433d4145c0f33df8d7f60ba734f8504a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85609
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I0d3941ed2a6f0caadbe080ac8a6273c5ec21462c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89616
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
nDataId is not a togglebutton so IsItemChecked is always false
Change-Id: I6b75e36ee34f7234f1ffa11f38495e4dc1ad1eb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89558
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
probably a regression from...
commit a22de0aacc9fb4197e9051f572b1a9298b2472e2
Date: Thu Jan 23 23:34:59 2020 +0100
tdf#130096 Wrap Sidebar update use common .uno commands and layout
because there were two toolbars with radiobuttons each toolbar has
to have one active radiobutton so they fight it out toggling on and
off when attempting to make one toolbar with all inactive radiobuttons
Change-Id: Iafe70dc1328ad80744cb4569365e25bf5eba6b53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89596
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Trying to compile with option --disable-skia failed with:
error C2027: use of undefined type 'SkiaControlsCache'
Change-Id: I44b40cf7c2a8f356f8a49312a413c924c141c7df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89458
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Icca5eeb6c8974e0422bebd93bc017a2d3f270e94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89592
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
reading of it was removed in b11293297e581b87fba7e995d350ba59ecb820f2
Change-Id: I1900082f8e94737111180a21b25de96afa034fdd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89615
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Except for source/ui/
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: If3e2a4cea3c44bd26f1c44309c52eae522904ae3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89299
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Move XIndexAccess Java tests to C++ for ScTableSheetsObj.
Change-Id: Idb130a51dc024cebbbc739d15c767f99558a69b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89609
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
from commit 0528012fd0dc4b93645ef7790b0db9d1cecbae66
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Mon Feb 3 10:05:12 2020 +0200
loplugin:constantparam
Change-Id: I563f053a33898f971b382efd513979e459156c0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89612
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I3aa19805fab937cd9516ce8127753a0f599c73c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89611
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Cursor to jump to end of line when pressing the down key
Change-Id: Ib9548d02039a17257ac7ed63221952abb7792590
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89533
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
|
|
Change-Id: I601ff29cede5ef5f594fd00c8bea810080cb8388
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89383
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
strings
Change-Id: I5db72d13291073fc5cb42d12dc3fadf6fd9adaf1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89587
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: Ie3efe6ff7de51bf80b2d80012ebd39ad60c01899
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89604
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
* Update helpcontent2 from branch 'master'
to 3c28b5afd108e5d2704a79aa5426bd19456cb866
- Fix links in xapian results page
Contents, Bookmarks and Modules links of xapian results pages
were broken after I486cbfbd680d52d00ef99ade9af5ecac2967c115
Change-Id: I7b912d9ff842810a66846b6a6da7857db69cac01
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89598
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
- Add missing Merge Dialog icons
- Update collate for Print dialog
Change-Id: I48a67800b2ffa3457465a06c74d93c8dfaa3c8c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89561
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: I341eed4d2eaf152380cc97ec24b4caeb3e46d108
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89553
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: Ibc86d1e380b91c4fe063f0b033e36bf6957aaa4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89588
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
19746d24aa976cc409e58fe452b6ab5b039d0525 "Update the reference rdbs to
libreoffice-6.4.0.3-buildfix1" had erroneously labeled
LD_LIBRARY_PATH=.../master/instdir/program \
.../master/workdir/LinkTarget/Executable/unoidl-read --published \
.../libreoffice-6.4.0.3-buildfix1/instdir/program/types.rdb \
.../libreoffice-6.4.0.3-buildfix1/instdir/program/types/offapi.rdb \
>.../master/offapi/type_reference/offapi.idl
as "no changes", so I redid that part correctly now:
* plus manual fixup by re-applying offapi/type_reference/offapi.idl part of
214e6caf2c503d817c47ebcc419e4f7e33b336ac "[API CHANGE] remove BasicImport UNO
interfaces"
Change-Id: If58251331c1b379a04bf0c60dfffc2ffb0f6bc6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89565
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This UNOIDL entity had been included in libreoffice-6-4 prior to the first
LO 6.4 release at libreoffice-6.4.0.3-buildfix1 with
ad86ebb1f86f6347ccb9bbe40b0ca080562cbae8 "tdf#121658 Add option to not hyphenate
words in CAPS".
Change-Id: I34df2ebeb56fdfe72bc9e19cc77eddd8a97a5c59
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89564
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I921956e5640cc16941109969d059809be66f0228
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89489
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Change-Id: Ia60061ae35c1822ebd52f109f128510eb2454140
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89488
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Change-Id: Ie15add04d66458493476bcbdc9a4f4a1034575e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89487
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Change-Id: I5a43d233b55edb13b479c1d1d246a4a6682b79a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89484
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Helps accelerate different views at different scales, as well as
document / image thumbnailing on save, as well as stray views that
can get rendered behind the scenes at odd scales on mobile.
Each scale + bitmap combination is another key in the LRU table.
Change-Id: Id82ce2e4180608082c9ca16fad35bba9e8c2e81a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89497
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89503
Tested-by: Jenkins
|
|
after
commit ec940941e0bd7db15c5cf7d43df82226e0d849dc
Date: Tue Aug 20 17:03:13 2019 +0200
tdf#119388 add new UNO listener/broadcaster
it appears that we can have more than one listener per shape because
shapes can be in multiple accessibility contexts.
Change-Id: I3724f27d5bfe8b5ab3548d4f062d60b071f3f2af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89500
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
complicated by the effort to keep the non-standard behaviour of
commit f3c68cdf8f6a0273c62b493552f78af0138a44e8
Date: Wed Feb 21 17:27:53 2018 +0100
tdf#115873 sd navigator: allow selecting but not focusing on objects
and the self-dnd code
Change-Id: I29c224739463d1d44690f30ed29db3fe2b16b4a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89045
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I912a023ed77475fc98b74f24ac8bc0ef182ecd8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89554
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
As mentioned in various blogs, like Raymon Chens "The old new
thing", 2008-08-01, "I warned you: The dangers of attaching input
queues", using AttachThreadInput to steal the input from an other
thread, so SetForegroundWindow becomes more reliable, can
deadlock in that call in win32u.dll!NtUserCallHwndLock.
Stackoverflow also has a multitude of suggestions and links in
"Win32 SetForegroundWindow unreliable", to circumvent Windows
focus-stealing prevention mechanisms.
A customer is experiencing these hangs reliably and often when
opening LO windows via Java UNO, because the Window and the UNO
thread are different and trigger this code path. Removing the
calls to AttachThreadInput fixes the problem for them. This has
started lately and nobody really knows why.
I also know other customers with a similar Java UNO setup, which
don't experience them.
For better foreground handling, the calling app eventually should
either use AllowSetForegroundWindow or CoAllowSetForegroundWindow
(for COM servers), to give up the foreground / input handling.
So this just drops the AttachThreadInput calls.
Change-Id: I8de0a17aaaa44c24b1ee728b2ef6ec3aea951c54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89527
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
in vertically merged cells. Hidden paragraph of
the new merged cell inherited numbering of the
previous row, resulting bad numbering of the next
list item.
Change-Id: Ib6b29947caa22747ba8c79725ab6f9ef4db31319
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89537
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
default to "false" and track the parent widget clipping/visibility
instead of "true" which makes it unconditionally visible
Change-Id: I1f8cec2b07ac20c33ff09cc278424d7e20199946
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89552
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7de72c383f11187ec706cd6971ff0431d04db72f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89539
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3311e2e6f013de7adca5b473609b1dd64187a58f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89530
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I242c7281a891a8e52d9fa4e5ee2d20ba56d62fdc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89528
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I04c0987b0b0c8a26ec4ce5517b9be4302b7920ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89506
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
|
|
* Update helpcontent2 from branch 'master'
to f824eb003a9884e2b16ef583664a5d7082d90836
- tdf#130886 update Tools - Macro menu help page
- add Edit Macro command heading (and embed description from sbasic)
- update name of XML Filter to XML Filter Settings
- update access command to XML Filter Settings (and use <menuitem>)
- added "Related Topics" and link to "Basic Editor"
- update XML Filters Setting help page
- move "About XML Filters" to Related Topics
- remove double presentation about optional filters
- add sys-switch for note about installing optional filters
Change-Id: Idefbe7ec56e410a8bc9f0b44077f9f07ce9df25c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89441
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
|
|
Change-Id: I1f0aed734ebb2c1035e06350d3508becb0d68b4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89476
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: Id5c3056f4e4466ccb5ea3654e60869bf7788b7ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89471
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|