summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-27unit-test for tdf#120270Dennis Francis
Change-Id: Icaa547ba5ef210ba721661242b2becd9f559f09a Reviewed-on: https://gerrit.libreoffice.org/71428 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-04-27Fix typosAndrea Gelmini
Change-Id: Id81e8db5a38b4e4a88cc21c50234c2338e9c41bf Reviewed-on: https://gerrit.libreoffice.org/71421 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Resolves: tdf#124984 organize basic macro new added module doesn't show upCaolán McNamara
Change-Id: I422131ab203eba62ed5cf6fb2e19e23325b43f6e Reviewed-on: https://gerrit.libreoffice.org/71433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27lok: handle missing callback.Michael Meeks
Change-Id: I13a200c9c9d8b0a8fde6dd15a71fe1a665d04e8d Reviewed-on: https://gerrit.libreoffice.org/71432 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-04-27tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I79c655a072faff0bdb2af031ed1328e684b83aac Reviewed-on: https://gerrit.libreoffice.org/71430 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-27Resolves: tdf#124975 toggle parent input blocked only in set_modalCaolán McNamara
since... commit e54762baa8019d02cadd311e750f6ff0d276f67b Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 16 17:17:58 2019 +0100 weld ScTPValidationValue and ScValidationDlg the inc/dev modality on show/hide isn't desirable anymore Change-Id: I5bf908871986160de61508c9678495d0d5a8296d Reviewed-on: https://gerrit.libreoffice.org/71426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27tdf#42949 Add filter file to unoidl/Gabor Kelemen
Seems I forgot about this in commit 7f6a5b433988e80f7d404c67d6320116ecb28c06 Change-Id: Ic575292b99836374f179cbc1dbe182858415b63f Reviewed-on: https://gerrit.libreoffice.org/71306 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27tdf#42949 Fix IWYU warnings in include/svx/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9770343f31f882427c9ae13e363b59cd1fb47e98 Reviewed-on: https://gerrit.libreoffice.org/71295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27tdf#62699 Drop pass-through header file include/svx/xtextit.hxxGabor Kelemen
Change-Id: Id48dc67443bbd28b0a7e2987b2546808cac8e8e2 Reviewed-on: https://gerrit.libreoffice.org/71334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27tdf#62699 Drop pass-through header file include/svx/xsetit.hxxGabor Kelemen
Change-Id: Id750f663389be36c669756e4bdd1e4e01be48199 Reviewed-on: https://gerrit.libreoffice.org/71327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27sw: sw_filters_test is quite slow...Michael Stahl
... so remove the slowest files; fdo54724-1.rtf takes 27165ms here and forcepoint-6.rtf takes 23359ms. The files are still tested on crashtesting server. Change-Id: I5177493ed8df690450a41161a233e1d110fdba90 Reviewed-on: https://gerrit.libreoffice.org/71390 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Fix variable nameAndrea Gelmini
Change-Id: I2628e74f0db7275091db2df2d271080367448b28 Reviewed-on: https://gerrit.libreoffice.org/71420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27uitest for bug tdf#123313Zdeněk Crhonek
https://bugs.documentfoundation.org/show_bug.cgi?id=123313#c9 Change-Id: Id72829984affbb1c4ce5bba4704e19a560260357 Reviewed-on: https://gerrit.libreoffice.org/71418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27No need to link gtk3_kde5 with generic vclplugKatarina Behrens
like this since initial commit but prolly just copy'n'pasta error Change-Id: Id61c2d8ef1df496738575e4ee4879d71a40b4934 Reviewed-on: https://gerrit.libreoffice.org/71381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Monitoring document events with Python & Basic -Mutual help pages x-refs -tree addition -new bookmarks for --Advanced Basic Libraries --Appl. Progr. Interface NB: I wish I could create new </img> in gerrit OH: moved new xhp to right position New image Update makefiles several x-ref fixes libO: Added language-driven <switch/> and <case/> tags for 3 different img captures that XHP Editor doesn't propose but that are documented Couldn't validate such switches.. crossing fingers.. OH: Languages are not switchable, as explained in comments. Removed reference to image for good (not l10n full support). fix missing apostrophe. Change-Id: I97c92fc879df19f9e8de73e828cd3324ba2163fa Reviewed-on: https://gerrit.libreoffice.org/70896 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-27ofz#14469 null derefCaolán McNamara
since... commit af84fc9d906626255aaf136eefc5e55236e0e8a6 Date: Tue Apr 23 15:48:41 2019 +0200 lazy image loading shouldn't read the entire .xls file (tdf#124828) nLength is just an unchecked value in the dff stream, it might not be sane so limit it to the max len of the stream Change-Id: Ia8a2830478952afe1317b5cd795f35059d9b380a Reviewed-on: https://gerrit.libreoffice.org/71412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#99517 help for CONCAT, TEXTJOIN, IFS, SWITCH CONCAT, TEXTJOIN, IFS, SWITCH Change-Id: Ic1d74ac8b810bd0c0d4b4f570baab1d1e270f912 Reviewed-on: https://gerrit.libreoffice.org/71339 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#123803 Add release info in Calc functions Change-Id: I0476c79fe5407c3e7252ef16da4110a026b29fa8 Note: some Calc functions still lack help pages. Reviewed-on: https://gerrit.libreoffice.org/71331 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-27Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' - tdf#124198 Impress & Draw ImageMap menu entry was moved to Tools Also renamed the file describing Edit Menu to edit_menu.xhp. Most of the files are touched to update the links due to rename. There is no context menu entry for ImageMap, so removed mention of it. Note that in Writer and Calc, ImageMap remains under Edit, because it is only enabled when an image is selected. Change-Id: Ic57ee11dd2ab9c637f00e5328f1575c323fb8c43 Reviewed-on: https://gerrit.libreoffice.org/71397 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-27Use AutoTimer for SystemDependentDataBufferJan-Marek Glogowski
This cache eviction timer is periodic, so just use an AutoTimer, to prevent the "expensive" Start() calls. This will instantly re-schedule the task again. OTOH Stop() is really cheap, as it just sets a bool. Same for IsActive(), which just checks that bool. We do lazy cleanup of stopped tasks in the scheduler. This patch also changes the logic to just start the AutoTimer, if it's not already running and just stops it in the timer handling function, if there is nothing more to do. This way we can save allmost all the previous Start() and Stop() calls, but eventually have a single unneeded wakeup a second later. Change-Id: Iae05483f557b94e07e51c4baae25315596923c9c Reviewed-on: https://gerrit.libreoffice.org/71376 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-04-27tdf#124997: only skip parsing non-empty cells for unallocated columnsMike Kaganski
Otherwise, not-yet-allocated columns have STD_COL_WIDTH (1280), while normal columns have widths like 82 (pixel), making the oversized grid look as if the columns not having vertical lines at all. Also, we need to consider default attrubutes here, to properly render cell properties like borders and background for unallocated columns. Regression after commit 7282014e362a1529a36c88eb308df8ed359c2cfa Change-Id: Ibb37c0c621d009bda2c5c0176cf5d3b238c45964 Reviewed-on: https://gerrit.libreoffice.org/71408 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-27tdf#123750 gtk3_kde5: Show removable devices in file dialogMichael Weghorn
Do the same for the gtk3_kde5 VCL plugin as commit 2c69c93fdb871809825fe8b9aff40b7afb093be8 does for the kde5 one. Change-Id: I6fc91d1dbe133bd905c033c9fce7d48c0b6464a0 Reviewed-on: https://gerrit.libreoffice.org/71384 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-04-27weld cluster of change tracking dialogsCaolán McNamara
Change-Id: I42ca7acb41699df91b91a9f59fc68cd30972a397 Reviewed-on: https://gerrit.libreoffice.org/70988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27remove comment in light of fix for tdf#120797Caolán McNamara
Change-Id: I3093f764a26abdbdb651596352ba74b7fa1c3306 Reviewed-on: https://gerrit.libreoffice.org/71399 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27Resolves: tdf#124980 drop dangling timerCaolán McNamara
Change-Id: I05ec394ee83f0422ecccf3ae3377818af6feb1d1 Reviewed-on: https://gerrit.libreoffice.org/71398 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-27uitest for bug tdf#124722Zdeněk Crhonek
Change-Id: Iec8dcde8090058d2d3c93c8eb7e9cbf32acd51e8 Reviewed-on: https://gerrit.libreoffice.org/71391 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-27uitest for bug tdf#124816Zdeněk Crhonek
Change-Id: I658e7eb6eef88a23f3e86acd616d26c3fe793a82 Reviewed-on: https://gerrit.libreoffice.org/71393 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-27uitest for bug tdf#124822Zdeněk Crhonek
Change-Id: Ia856b58c868e49ce2b293e95fd9503f1296bdcab Reviewed-on: https://gerrit.libreoffice.org/71392 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-27tdf#101760 Rename "Follow text flow" as "Keep inside text boundaries"Roman Kuznetsov
Change-Id: I6c602b80be566ad2b1af66715b660a561ac5ff2d Reviewed-on: https://gerrit.libreoffice.org/71407 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-04-27Removed executable permission on source filesAndrea Gelmini
Change-Id: Iaafc0f45282b0351c24b4ddc433ed1086177ff73 Reviewed-on: https://gerrit.libreoffice.org/71400 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-27osl/diagnose.h and diagnostics.h are used when OSL_DEBUG_LEVEL >= 2Tomoyuki Kubota
Change-Id: I004ee1a56b0d4c63db82106c516e19753ad2a0f5 Reviewed-on: https://gerrit.libreoffice.org/71405 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-27tdf#85482 FILEOPEN: very slow loading of .ODSNoel Grandin
On my machine, this takes the loading from 21s to 8s. We can delay doing line height calculation till after load, since we run the calculation over all rows after load Change-Id: I5c0d02297fb10bada28105a82da10c498ce8f6cf Reviewed-on: https://gerrit.libreoffice.org/71378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-27Colibre icon theme updateandreas kainz
Change-Id: I511c5fb9c1c79a111b5686d43168b157e6fa4b02 Reviewed-on: https://gerrit.libreoffice.org/71403 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-27Decouple reading/writing of Color into GenericTypeSerializerTomaž Vajngerl
This adds GenericTypeSerializer, which is now responsible of serializing the Color into a stream (other types will follow), but only for the older version of the binary format. The new version we just write the sal_UInt32 mValue directly. This is a start of decoupling the serialization of generic types in tools and vcl module from the actual type, so we can in the future replace those with basegfx variant. Change-Id: I92738e7c178cac5cbca882dcbe45c80cc8269466 Reviewed-on: https://gerrit.libreoffice.org/71404 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-27clenup storinfo.hxxTomaž Vajngerl
Change-Id: Ib5e965c9b217d2df5111f1ce696bd75c107672ce Reviewed-on: https://gerrit.libreoffice.org/71353 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-27docx export: implement text-input field exportVasily Melenchuk
It is expected that <text:text-input> will be converted to {FORMTEXT} MS field, but practical implementation was missing. Change-Id: Ifd17a523e253555a240f853bea5f21572d90d853 Reviewed-on: https://gerrit.libreoffice.org/70786 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-26tdf#124658 - Improve text for the tip-of-the-dayheiko tietze
All strings reviewed Change-Id: I7c9b2460b86576c67221c874bd9f99ea43db17d4 Reviewed-on: https://gerrit.libreoffice.org/71365 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-04-26Fix typosAndrea Gelmini
Change-Id: I693355a38f5bea33346d988015851d3a9cf8d1d4 Reviewed-on: https://gerrit.libreoffice.org/71387 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-26Fix typoAndrea Gelmini
Change-Id: Ib1b8341776ed79c85cd1f8287c06a9fe8ed8ca3d Reviewed-on: https://gerrit.libreoffice.org/71389 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-26tdf#120797: Apply transformation also to the extents of damageKatarina Behrens
since 7034311dce663c895577267110baadbec312d491 affine transformation is passed down to drawPolyPolygon and drawPolyLine functions. The transformation was correctly applied to cairo context, but not the extents of damage so those had old, untransformed coordinates and were therefore not redrawn Change-Id: I61ce005ef8770ce5c4560a9d953cd92f440043be Reviewed-on: https://gerrit.libreoffice.org/71383 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-26Don't use std::function in scope guard for performance reasonsMike Kaganski
Change-Id: I1d2f0307c0bf9ff5abde74d3326899a1aaa69c40 Reviewed-on: https://gerrit.libreoffice.org/71346 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-26Removed executions flags on source filesAndrea Gelmini
Change-Id: I165d417a8e28d5732945722158b83e2ac5edb402 Reviewed-on: https://gerrit.libreoffice.org/71388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-26ofz#13491 SvxRTFItemStackType dtor excessive recurse depthCaolán McNamara
ofz#13491 SvxRTFItemStackType dtor recursively calls the dtor of its m_pChildList. The recurse depth can grow sufficiently to trigger asan. So breadth-first iterate through the nodes and make a flat vector of them which can be iterated through in order of most distant from root first and release their children linearly Change-Id: Icc7d7130935a27595dae7b55cea41c6a53aed956 Reviewed-on: https://gerrit.libreoffice.org/71386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-26Avoid manual malloc/freeStephan Bergmann
Change-Id: I7420dfde91ab52316139b446ea5c5aac79ed2350 Reviewed-on: https://gerrit.libreoffice.org/71380 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-26Avoid division by zeroStephan Bergmann
These areas are zero when you start to draw a 3D object with the mouse. Change-Id: I003ec06b42351b5c4b2b59b9f908fb82ab6e9b35 Reviewed-on: https://gerrit.libreoffice.org/71373 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-26remove unnecessary separate function objectsNoel Grandin
which just makes the code harder to read Change-Id: Id9269554b4e29a2562cbdd06f42a143c2f028795 Reviewed-on: https://gerrit.libreoffice.org/71360 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-26Fix a copypaste error in commentMike Kaganski
Change-Id: Ic5272fe2e7226c5d6ccbb42c0b22635c2360200c Reviewed-on: https://gerrit.libreoffice.org/71394 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#122548 copy bascode and pycode to clipboard This will allow easy testing of coding examples. Change-Id: I30fc53642b1579744591f2de0c84a615d1755352 Reviewed-on: https://gerrit.libreoffice.org/71385 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-26Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - topic tag correction mispelled link Change-Id: I34ecbbfca31285efe9af3eaa9ab0d2c1ee7b7b64 Reviewed-on: https://gerrit.libreoffice.org/71377 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-26cleanup files in SOT, not changeTomaž Vajngerl
Change-Id: Ie3a2390a40214e61b05a57ebd5fbfa5f49a5e1fd Reviewed-on: https://gerrit.libreoffice.org/71351 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-22 23:04:53 +0000