summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-05-16Make --with-latest-c++ support future C++26Stephan Bergmann
...as already supported by <https://github.com/llvm/llvm-project/commit/b763d6a4ed4650c74c6846d743156468563b0e31> "Add C++26 compile flags." Change-Id: I0e7b55138222c0f0a81d4aec9a20da7922c51df2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151825 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-16xmlsecurity: do not run the test with HAVE_FEATURE_PDFIMPORTXisco Fauli
The test is meant to test PDFiumLibrary Change-Id: Ib99d1aef4857df09fa3e73a9cfdf130c7660619d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151761 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-16tdf#155349 std::move of a std::optional leave behind a set std::optionalCaolán McNamara
unlike std::move of a std::unique_ptr which leaves behind an empty std::unique_ptr so if HasPaintRegion was true before TakePaintRegion it was still true after TakePaintRegion Change-Id: I6569f5ccd8081cbcec42190c474a98c4e28030a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-16Simplify the code by introducing a new functionHossein
There were a lot of repetitions in the code of the function SvxConnectionPage::Reset(). This patch Simplifies this function by introducing SvxConnectionPage::lcl_SetMetricValueAndSave() to do the repetetive instructions. Change-Id: I337ccf2281fd8d1bd9b1948beb6d31b2306eb339 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151820 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-16tdf#155179 Improve Solver symbolsBogdan B
Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Change-Id: I608330f175ebf41f282d07752d593661138963b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151623 Tested-by: Jenkins Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-16Removed constant concatenation macros from txtprmap.cxxVojtěch Doležal
Removed concatenation from the macros, because due to them I wasn't able to find anything relevant with grep when searching for them. Change-Id: Ic22d711d9e93bb89b402d141aa1ca3293bba866e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151819 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-16tdf#141440 - Do not delete notes when pasting contentsAndreas Heinisch
Contents include cells with values, datetimes, strings, formulas, outlines, and sparklines. Change-Id: I9acf3a33c7723300d6b85f0abe468db28de6ebcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151759 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-05-16Fix typoAndrea Gelmini
Change-Id: I006c882aacf316dda0ecb3302835ca021d45ecc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151812 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Ibbf9a267bbfba02c119fa1995c6b2ae90f391031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151813 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Id590b13237bc148dac955d6f4d56092f86d1dd16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151817 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Ibb3cbd37e04beed410c61f93f35be51a59bdc10b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151808 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: I77c647c513c4b605917888bd9054385b2f7f7bf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151814 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16sw floattable: disable UI if the frame is chained alreadyMiklos Vajna
TextFrames can be chained and we look at those fly frames as shapes. In this case, we should not offer the "split fly" functionality, which makes sense only when the fly frame is considered as a floating table. The combination of these two features have no use-case and it would just cause trouble when exporting to Word formats. Fix the problem by making SwFramePage::Reset() more strict: it already only allowed fly split for the case when the content was a single table, but now it also requires no chaining. The other way around (split fly -> no chain) still needs doing. Change-Id: I06c240209a3a26519a5df953e22c9ee1b54aed34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151822 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-16Fix typoAndrea Gelmini
Change-Id: I126f38c126c3f541d451cdafa074d2b8c0248d05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151815 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: I5701a1fdfe9e4f139049ed6c0de1748ec7c06e07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151816 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: I77c5760a38b07541eaceae765cd0e14eaddb6d11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151818 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Idce8a85c80c21ee4667810ec6f397389077432d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151810 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Related tdf#155070 - Tooltips moved from container to controlsHeiko Tietze
* Save log button disabled if Skia is off to prevent error message Change-Id: Iccd757fb15b347cf9d048115d4b048543814bd99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151764 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Ib9150f390574dc9467335451f42a10749bd915d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151811 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Id6f8a07f62e5861c4ad37b4537436632243b1a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151809 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16sw: document SwFormatURL and SwTextINetFormatMiklos Vajna
SwFormatURL is special, it has its won SwTextAttr subclass, instead of going via the usual SwFormatAutoFormat. Change-Id: Ibe06abcb486b6bf6037006e727be4ce750d489a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151806 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-16Resolves tdf#155278 - Adjust minimum statusbar height according iconsHeiko Tietze
Change-Id: I7dbcf35f338bfe87702afb45651cd99630efe875 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151768 Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-16tdf#63130 make B2DHomMatrix a flat objectNoel Grandin
instead of using COW for its data. This takes the load time from 1m29 to 1m12 Also fix a bug in ImplHomMatrixTemplate::operator= which never triggered before because the usage of o3tl::cow_wrapper means it very seldom gets used. Change-Id: Ib0a7bdddf6c014f583e06d15e8dce5025e67e4a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-16tdf#153789 sifr icons for Watched Expressions and Call StackRizal Muttaqin
Change-Id: I9bd81878f931f78ed0b7d73a03cbc89d3d8347c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151797 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-05-16tdf#154956 sw: delete bookmarks at end: fix crashtestingJustin Luth
This fixes LO 7.6 commit 21b1dd42e9a817ae9b68e9e13ea57ce2491940c6 wget https://bugs.documentfoundation.org/attachment.cgi?id=124859 \ -O ~/tdf99692-1.odt ./instdir/program/soffice --headless --convert-to odt ~/tdf99692-1.odt sw/source/core/crsr/pam.cxx:268: void SwPosition::SetContent(sal_Int32): Assertion `nNode.GetNode().GetContentNode() && "only valid to call this if we point to an SwContentNode"' failed. Change-Id: Ic8280bf56f1e7f339fdff3e9591470bc74aa0d5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151639 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-16tdf#79542 xls: applyGroupBox to radiobutton groupsJustin Luth
A group box control links radiobuttons together, and so does a sheet. No matching unit tests were found. make CppunitTest_sc_subsequent_filters_test4 \ CPPUNIT_TEST_NAME=testLegacyOptionButtonGroupBox Change-Id: Ib5b03c68b5218649268f283d11981cc03fe4850a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137838 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-16tdf#144362 doc/x export: different columns mean new sectionJustin Luth
The situation causing this may have become more likely in 7.4.0. I think that tdf#149313 might have caused a regression in the unit test that I found that exhibited the problem, so I am adding another one. make CppunitTest_sw_ooxmlexport9 CPPUNIT_TEST_NAME=testTdf97648_relativeWidth make CppunitTest_sw_ooxmlexport9 CPPUNIT_TEST_NAME=testTdf144362 Change-Id: I8e668ac7bfb01a8704634a3e16243be7298bd1ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151731 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-15tdf#140226: use StaticWhichCastMoazAlaa
Change-Id: If5eab003a732264522ff1b1fe55a6a2c876c22db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150794 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-15tdf#154782 Fix scrolling in a11y sidebarSamuel Mehrbrodt
Doesn't need its own scroll handler anymore, Sidebar has a generic scroll handler. Change-Id: Ic56d1cfd7cde8ed81bf36f3302a128aa03ff6f27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151769 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-05-15[API CHANGE] Drop unused ToolboxStyle config keyGabor Kelemen
Unused since 2020 commit a0eab90bd1f7fc31978da3f7be0ec86781baf8bc Change-Id: Id03396022d7481ce85356207d468f5b1201df44c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151407 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15[API CHANGE] Drop unused Dictionaries config groupGabor Kelemen
Its use was removed in 2020 by commit acb1c390539730957fb509f18f469fc7f6133082 Change-Id: I48a10ab13de9fcdb1b1c5721a9be648250166f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151058 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15[API CHANGE] Drop unused config key EmojiFontGabor Kelemen
Its use was removed in 2022 by commit 5f1eb2a12b6e6ee646b5e9536822531ad0bd3259 Change-Id: Ifc7e3f645422a478571aaa9dcbcd9ebe9a811b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151061 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15[API CHANGE] Drop obsolete group PersonasEntry and set PersonasListGabor Kelemen
Its use was removed in 2020 by commit e1e9e2aa16f08a8fd9e38db706d63e8eceeda8d1 Change-Id: I1271c3a1d0dc9c1b294f9d93753196609a85a245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150988 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15tdf#153789 Colibre icons for Watched Expressions and Call StackRizal Muttaqin
Change-Id: I0cbe5df13e49a6bdbdcf7aa93472c24e331b5576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151804 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-05-15tdf#153789 Sukapura icons for Watched Expressions and Call StackRizal Muttaqin
Change-Id: I0445f256680d5a88b99ac777ac7c65aaf507f232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151803 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-05-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 08e07a280483ca2db507cc9d06848d53f64f7d12 - tdf#155309 - Base Form link to right Help page + Add bookmark to right Help page + refactor + pretty-fy table. Change-Id: I7832bb3732bb96232f8bd644311c1336e2e491bd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151791 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-15tdf#142978 Grab focus to document when clicking "Go to" buttonSamuel Mehrbrodt
Change-Id: Id671c0f2e31435a09f6945d5065384cae49c37c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151790 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-05-15tdf#142978 Automatic a11y is required for this sidebar panelSamuel Mehrbrodt
So enable it while using the panel; and restore the original state afterwards. Change-Id: I15d1d266454d6bf7595956880b646bc047e8be0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151767 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-05-15Avoid unnecessary, wrong downcastStephan Bergmann
...in test code added with 61f3c796702f725f2c65b53b79ab7e190d39b6b8 "sw floattable: fix UI / property dialog for shape containing table", causing CppunitTest_sw_core_frmedt CPPUNIT_TEST_NAME=testTextBoxSelectCursorPos::TestBody to fail with > sw/qa/core/frmedt/frmedt.cxx:152:34: runtime error: downcast of address 0x506000892f40 which does not point to an object of type 'SwDrawContact' > 0x506000892f40: note: object is of type 'SwFlyDrawContact' > 00 00 00 00 90 6c 59 73 ce 7f 00 00 00 6d 59 73 ce 7f 00 00 00 00 00 00 00 00 00 00 50 2b 06 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SwFlyDrawContact' > #0 in testTextBoxSelectCursorPos::TestBody() at sw/qa/core/frmedt/frmedt.cxx:152:34 Change-Id: I1c669d0ed3e2a4055db28c9fc4676b6e7c8520b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151795 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-15related tdf#136536 sw: don't copy useless char escapement to next node on splitJustin Luth
This was clearing ANY single direct formatting attribute, not just char escapement. While that might be desireable in certain contexts, limit the hack to its intended subscript/superscript only. Change-Id: I0d503af826635c4325332cc985964957ee0b065d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151796 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-15tdf#155143: blacklist 3 Nvidia cards for Skia hardware renderingJulien Nabet
GeForce GTX 1660 SUPER (516.376.0) GeForce GTX 970 (531.272.0) Quadro P400 (516.376.0) Change-Id: I2ba3cc33dabcbd821459493ae94bdfbb130653de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151801 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-15tdf#154927: Crash when a11y toolbar is visible and try to insert a math objectJulien Nabet
Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=403ea882af35337431e0f67aa973c5f046deb630 tdf#142978 Add a11y check sidebar Change-Id: I5d3ba05ffd8089b7a9ab509ae248fc84da52f870 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151802 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-15sw: fix crashtesting assert on ooo34309-3.odtMichael Stahl
frmpaint.cxx:804: SwTextFrame::PaintSwFrame: Assertion `!oTaggedLabel' failed. This is even more special, the numbering contains a ' ' space followed by '\t' tab and the space becomes a hook-char and then somehow disappears completely, while the tab becomes a SwTabLeftPortion. So SwFieldPortion::Format() needs to predict that 2 of the SwNumberingPortion follows will be deleted by hook-char magic. (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd) Change-Id: Ica2b303f7f098c2b85720d7ae7c5c7bbf078e1b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151800 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-15Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' to 0c13b980b88e691ff48f69c1b65f0abb5246a208 - Gradual Improvements All changes are tested with own builds on different builddirs (Windows) Main: - add alt text to icon(s) - moved paragraphs to where they belongs Further: - removed " xml-lang="en-US"" - removed empty lines - new indentations for better readability - inline <tablecell> for better readability Change-Id: I0dde6eb6f23a77c215d26dd6129cac100029bc13 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147537 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-15MCGR: consolidations/cleanups for changes so farArmin Le Grand (allotropia)
Change-Id: I85cf40e4803b0485bb40349d8e81adc8123666c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151706 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-05-15tdf#104005 Don't allow changing finalized propertiesSamuel Mehrbrodt
Change-Id: Ic9e42ba6aed2fadd0f28dfc6be0a639cdd16bb34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151660 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-05-15ofz#58991 Heap-buffer-overflowCaolán McNamara
Change-Id: I44661cb2f9b2f44118140ae2fbcf86fe12cd282c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-15sw: prefix members of SvXMLAttrContainerData, XMLDashStyleExport, ...Miklos Vajna
... XMLDashStyleImport and XMLEventExport See tdf#94879 for motivation. Change-Id: I203cc1c789a1a33721b27754412da35c3ca8a56a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151755 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-15ofz#58942 tweak so fuzzing uses the same defaults as real world writerCaolán McNamara
I have a looping document which loops in layout in the fuzzer but not in writer but we want easy to reproduce findings rather than load document, ctrl+a, format paragraph and set widow control to 2 Change-Id: I7739a5ebf4eaeac2152afcf8b431c42362374f2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151741 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-15tdf#153789 elementary icons for Watched Expressions and Call StackRizal Muttaqin
Change-Id: If83566c4aa0111c2fd2bd6ad6b216b7a2ca61b2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151756 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-15 15:57:49 +0000