summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-05-14Fix typoAndrea Gelmini
Change-Id: I305e152b6d6e71eba8d568b66c80b53e3bf27db0 Reviewed-on: https://gerrit.libreoffice.org/72262 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-14tdf#90297 use field colors for math's edit engineJan-Marek Glogowski
This adds a maTextColor to the EditEngine, which will override the default AutoColor. There is also a NOCOLORS mode and I thought about using it instead, but it defaults to COL_BLACK and overriding this seems wrong. Since the EditEngine does the whole drawing and now has the explicit FieldColor() and FieldTextColor() for background and text, my guess is we don't need an ApplySettings implementation. Change-Id: I6c2ecc843a3e07de98f97c86fc00a3b83cb78d97 Reviewed-on: https://gerrit.libreoffice.org/72197 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-05-14Switch everyone to stricter GetColorErrorJan-Marek Glogowski
This replaces the variant in Color with the stricter one of BitmapColor. I couldn't find any reasoning for the lazy variant used in Color. Change-Id: I6dab3ab94a7f24ef5e80299d64267e3be8df888c Reviewed-on: https://gerrit.libreoffice.org/72234 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-05-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix typo Courtesy of Cathy Crumbley Change-Id: Ie2796bebed2007545d2214d8af8e52f3b69cb759 Reviewed-on: https://gerrit.libreoffice.org/72263 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-14Add more %PRODUCTNAME here and thereOlivier Hallot
Change-Id: Ib4a1516cd57f165a072afad3505e3442714b2ff9 Reviewed-on: https://gerrit.libreoffice.org/72235 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-13Fix emfplus.cxx cppcanvas/qaJulien Nabet
/home/julien/lo/libreoffice/cppcanvas/qa/extras/emfplus/emfplus.cxx: In member function ‘void testFdo77229::TestBody()’: /home/julien/lo/libreoffice/cppcanvas/qa/extras/emfplus/emfplus.cxx:79:46: error: ‘class BitmapColor’ has no member named ‘GetColor’; did you mean ‘getBColor’? Color aColor(pAccess->GetPixel(142, 140).GetColor()); ^~~~~~~~ getBColor Change-Id: I7db2e678ddfadcbd55b3cb87613eeecb79d12ad5 Reviewed-on: https://gerrit.libreoffice.org/72253 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins
2019-05-13fix up GtkToolButton imagesCaolán McNamara
Change-Id: I68d3fac978531e780c16e4a41a619d7a6c00cabb Reviewed-on: https://gerrit.libreoffice.org/72248 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-13Fix typoAndrea Gelmini
Change-Id: I130839cbd400aad3f9f0691652df19e680346481 Reviewed-on: https://gerrit.libreoffice.org/72252 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13Fix typoAndrea Gelmini
Change-Id: I93cefdcf044854bb20a9524351548bb9721d393e Reviewed-on: https://gerrit.libreoffice.org/72242 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13Fix typoAndrea Gelmini
Change-Id: I81d227fa99058ea0d13576d36897f186164b6ad6 Reviewed-on: https://gerrit.libreoffice.org/72251 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13Fix typoAndrea Gelmini
Change-Id: Ie7861296de4d70dc03889212a359537d45a0c7bd Reviewed-on: https://gerrit.libreoffice.org/72250 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13fix uno::Reference flags in sc/perfcheckNoel Grandin
after commit a361231b1363d072d737e9b1d411b71aa9550d84 Date: Fri May 10 10:13:12 2019 +0200 fix wrong SET/QUERY flags passed to uno::Reference Change-Id: I1c01f185883b63294f190a147d5ca09a4f7c33e7
2019-05-13sizing button wrong in ListBox::ResizeNoel Grandin
Passing a right edge co-ordinate to a width param, ever since commit 4849fb6d668f6cf8fa7e6bf33c15db4696355001 Date: Mon May 10 14:47:20 2004 +0000 INTEGRATION: CWS nwf (1.25.36); FILE MERGED Probably only works because the button is on the right edge, and consequently the width will be clamped to the widget area. Change-Id: I28a88cd298bc5beb20162f457c7cc125e1d0303a Reviewed-on: https://gerrit.libreoffice.org/72231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13tdf#122293 qt5: Use "alien widgets" by default on WaylandMichael Weghorn
As described in QWidget doc [1], calling 'QWidget::winId()', implicitly enforces a native window, i.e. one that has a native window associated with it. For this reason, avoid calling 'QWidget::winId()' for the Wayland case. Quoting QWidget doc: > Introduced in Qt 4.4, alien widgets are widgets unknown to the windowing > system. They do not have a native window handle associated with them. > This feature significantly speeds up widget painting, resizing, and > removes flicker. This in particular avoids tdf#122293/QTBUG-75766, which led to 'mousePressEvent's not being emitted unless a mouse button was pressed, causing non-existent reaction to hovering over objects. As a consequence to widgets being non-native by default on Wayland, 'Qt5Frame::windowHandle' needs to be adapted to make sure that the widgets handled in there are native ones, otherwise no window handle is associated with them. Probably more needs to be done here to make video playback via GStreamer work under Wayland, s.a. commit c0d4f3ad3307c ("implement wayland handle passing for gstreamer") for how it was done for gtk3. With and without this change, slideshows with videos are currently not handled properly with kde5 on Wayland (s. tdf#125219). [1] https://doc.qt.io/qt-5/qwidget.html#native-widgets-vs-alien-widgets Change-Id: Id46678e0ea594220a1765c3e59d39c41cb8bfe25 Reviewed-on: https://gerrit.libreoffice.org/72164 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-05-13ooxml import: supprt cropping to shapeTamas Bunth
Change-Id: I7bdc959921ecb0cbf19037a78b63eaeb8fc52814 Reviewed-on: https://gerrit.libreoffice.org/72206 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-05-13Fix typoAndrea Gelmini
Change-Id: If9587bcf6b45dc7398d029171fdd018116dfa9b4 Reviewed-on: https://gerrit.libreoffice.org/72238 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13Fix comment to match realityTor Lillqvist
lo_runLoop() *is* used in the "Unipoll" case (i.e. current Online and mobile apps). Change-Id: I01ef3d8bc8140531f697952ef142150fc905a8d4
2019-05-13Update git submodulesKatarina Behrens
* Update helpcontent2 from branch 'master' - More detailed help of Calc's Sheet > Link to external data Make it more clear there has to be at least 1 named range in Excel of Calc documents Change-Id: I782c4d2c10ee52320bfdf147652883f5e7b4751a Reviewed-on: https://gerrit.libreoffice.org/72076 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-13Fix typo in codeAndrea Gelmini
Change-Id: Iae494674972ced3d4808f57440757ae4ae6988f1 Reviewed-on: https://gerrit.libreoffice.org/70632 Tested-by: Jenkins Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-05-13bump product version to 6.3.0.0.alpha1+Christian Lohmaier
Change-Id: Ib43e7349bce04e42b247af3c87e0128350e6c1c1
2019-05-13gla11y: whitelist GtkTreeViewColumn as not needing labellingSamuel Thibault
and remove corresponding suppressions. Change-Id: I0dd88082ee0af4c5ee82590e894305fa53574c6b Reviewed-on: https://gerrit.libreoffice.org/72133 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-13Removed executable bit on xlsx fileAndrea Gelmini
Change-Id: Iedaa319b7a51bb5fdee7e57907cca61d2c70af2c Reviewed-on: https://gerrit.libreoffice.org/72233 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations and force-fix errors using pocheck Change-Id: I2afa34705cebda561eb974fedf7a921666089f2b
2019-05-13Make BitmapColor inherit from / merge into ColorJan-Marek Glogowski
BitmapColor itself is kept to distingish the Color usage as part of a color palette, which continues to store the offset in the blue value. The original special mbIndex handling is long gone since commit 1fefdd6f3b41 ("Alpha channel in BitmapColor - change bIndex to alpha"), so there is no data difference. This also results in the following changes: * now has a basic_ostream<charT, traits>& operator<< (that was my actual starting point... for an other bug fix) * there is a minimal difference for GetLiminance BGR(29,151,76) => BGR(28,151,77) * no more return values for Merge and Invert (previously returning *this) * replaces all GetBlueOrIndex with GetIndex This leaves one "problematic" part: the GetColorError handling. At first glance it should probably be virtual. The Color variant is less strict then the BitmapColor one - for whatever reason. BitmapColor is always used to search for the best match in a Palette. Currently I'm simply leaving both variants. Would be nice to have an explict for functions here. Change-Id: I251ba3024a1d60f2a9d9fde9cd0a60f08e8322a7 Reviewed-on: https://gerrit.libreoffice.org/72181 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-13tdf#125215 Assertion when closing Database/Advanced SettingsNoel Grandin
This showed up as a segfault for me. Sometimes we have sortable items, for which we store duplicates (because those items are not poolable), in which case comparing by operator== means that we sometimes end up deleting the wrong one. Change-Id: Ic7dff0357d3c5a7a74bf0b4e87fa02f2f5857f30 Reviewed-on: https://gerrit.libreoffice.org/72222 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13Typo in UI (Sentence style)heiko tietze
Change-Id: I2013f36e5ccb2dda39ae2d1aa2e47eab8e072532 Reviewed-on: https://gerrit.libreoffice.org/72221 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-13configmgr: workaround GCC9 -Werror=sign-compare in static_assertMichael Stahl
... which is quite unhelpful; any cast would have to make assumptions about the size of types anyway... Change-Id: I5f35d82eb35d1af36b5a572166cf863babf23d41 Reviewed-on: https://gerrit.libreoffice.org/72223 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-13drop some unneeded includesCaolán McNamara
Change-Id: I3c9a3b73c099b70bdbd6b16688e83ee01231a27e Reviewed-on: https://gerrit.libreoffice.org/72204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-13tdf#107592 Impress PPS save to ODP slowNoel Grandin
Takes the time from 20s to 5s on my PC. Change-Id: Iea7a94ee9fbe068b69a770fd9201e73646be59b9 Reviewed-on: https://gerrit.libreoffice.org/72140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13tdf#100084 XLSX import: fix missing chartsBalazs Varga
caused by case-sensitive path handling of relationship files. OOXML documents contain case-insensitive file paths, for example, uppercase "Sheet.xml" can have a lowercase "sheet.xml.rels" in the ZIP archive, as in the case of the XLSX documents generated by IBM Cognos. Change-Id: I4210e3b96fb512d61e1687ec8d41a3c77292ec0c Reviewed-on: https://gerrit.libreoffice.org/72100 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-05-13weld imapmenuCaolán McNamara
Change-Id: I0cc79534112ae8897a9887942238ff1236c4a3eb Reviewed-on: https://gerrit.libreoffice.org/72217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-13drop some more unneeded includesCaolán McNamara
Change-Id: Iec71ca870db5f6aaf317e23db369dfc1fa04bcc1 Reviewed-on: https://gerrit.libreoffice.org/72205 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-13Auto-redact - First stabMuhammet Kara
Add a SfxRedactionHelper::autoRedactPage method which searches for the given term through the gdimetafile which has the whole content of an xPage (a Draw page), and draws redaction rectangles at proper positions with proper sizes. The search is case sensitive, and finds only the first occurences on a line. Will switch to a proper search provider via a follow-up patch. Change-Id: If3db62e50994670143785b6727fdcf1ccd4c6f8e Reviewed-on: https://gerrit.libreoffice.org/68597 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-05-13Qt5 handle theming-based change eventsJan-Marek Glogowski
Qt generates three change events when changing the KDE theme: FontChange, StyleChange and PaletteChange. LO has two: SettingChanged and FontChanged. And like Qt LO will inform all widgets / windows independently. To prevent several redraws, this patch just collects all Qt's change events and notifies LO once a bit later via a Timer. Change-Id: I9b45f543f13a84e39247a642a0e33c9ec008a46a Reviewed-on: https://gerrit.libreoffice.org/72196 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-13Make it more obvious that there are no named rangesKatarina Behrens
and thus the selected doc can't be used as the source of external data for this sheet. In other words, help the user figure out why is OK button disabled Change-Id: Ie1b999c9c3640397e9f6f6ee321d3a5a5d63fa3b Reviewed-on: https://gerrit.libreoffice.org/72075 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-13tdf#124743 TipOfTheDay: Next tip should not be randomJustin Luth
A user pressing "next tip" will expect to cycle sequentially through the list of tips, and not get a random one each time. Change-Id: I331d35d623b6449a9daef407a498b4ba08eaff6f Reviewed-on: https://gerrit.libreoffice.org/72099 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-05-13get-bugzilla-attachments-by-mimetype: fix get_through_rss_queryMichael Stahl
This URL results in an error message and 0 results because "Changed" in the UI translates to "delta_ts", not "changed" apparently. Change-Id: I2bfdd682bb7fca229039970c209e7e409532059c Reviewed-on: https://gerrit.libreoffice.org/72219 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-13tdf#83722: don't recycle frame with unmodified templateKatarina Behrens
a frame that contained valid but unmodified document opened from template or explicitly opened by the user (File > New) was treated the same as blank document i.e. it was reused and the content was overwritten by newly opened document (even if it already had non-empty content provided by the template). So let's not do that and let's open a new document in a new frame instead Change-Id: I10252d114e8cc5fcad3c98194ef07fd59873d6da Reviewed-on: https://gerrit.libreoffice.org/71919 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-05-13tdf#42949 Fix IWYU warnings in sw/source/core/inc/[g-S]*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4ebebbbbad31b29c1e63a30685493042462bb52f Reviewed-on: https://gerrit.libreoffice.org/71832 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-13sw: prefix members of SwViewMiklos Vajna
It has a number of static members, use m_ prefix only for non-static members. Change-Id: I312b1eaadd1a7d312d4679028446cf69362e4740 Reviewed-on: https://gerrit.libreoffice.org/72215 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-05-13Update config.{guess,sub}Caolán McNamara
...to latest versions from <http://git.savannah.gnu.org/gitweb/?p=config.git; a=blob_plain;f=config.guess;hb=HEAD> and <http://git.savannah.gnu.org/gitweb/? p=config.git;a=blob_plain;f=config.sub;hb=HEAD> but retain... commit 25a09c8776cc6088a5b2bf13dc84eb386c26bb7e Date: Wed Jun 7 12:23:17 2017 +0200 iOS, add support for arm64 Added general support for arm64 Removed experimental/prototype from normal build Change-Id: Ic36a9fb9d20344ff0ddc6b293ed3bd48cf140a31 Reviewed-on: https://gerrit.libreoffice.org/72200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-13Remove ContainerHelper.hxxArkadiy Illarionov
Use comphelper::sequenceToContainer instead of ContainerHelper::SequenceToVector Change-Id: I4834255a1349ac7a29127a84a54fcfa98d678d00 Reviewed-on: https://gerrit.libreoffice.org/72186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13Remove java mouse/keyboard event testsSamuel Mehrbrodt
These tests has been implemented as a UITest in sw/qa/uitest/writer_tests5/xwindow.py Change-Id: I0c1ae6d086a5a7d6e15b89bb3e810b49434da01e Reviewed-on: https://gerrit.libreoffice.org/71950 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-13nlpsolver: This is considered internal codeSamuel Mehrbrodt
Change-Id: Icd8566c2fce1a0ff3fb9471afd71858ec2f91bc5 Reviewed-on: https://gerrit.libreoffice.org/71982 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-13handle empty tools::Rectangle in vclNoel Grandin
Change-Id: I64b5c3c5a19408febe7753db6ea403b91f7f5c83 Reviewed-on: https://gerrit.libreoffice.org/72188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13handle empty tools::Rectangle in svtooolsNoel Grandin
Change-Id: Ia6c4d56e8019fd92ac69499b9902f8bd8ca27fec Reviewed-on: https://gerrit.libreoffice.org/72187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-13Handle *link return value in sfx2 testJan-Marek Glogowski
Change-Id: I63008858558312b5fb7378249c56fbc3729c9a19 Reviewed-on: https://gerrit.libreoffice.org/72180 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-13tdf#104204 Keep selection when context menu is opened on extended rowJim Raykowski
Change-Id: I5a94f7bcf90e5831fc63d3f8ad83278e425417eb Reviewed-on: https://gerrit.libreoffice.org/72159 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-13NBandreas kainz
Change-Id: Iab4d40da76478d6341b4ea057996b9328e73d8c2 Reviewed-on: https://gerrit.libreoffice.org/72190 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-27 01:18:59 +0000