summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-12Add Handler for ISectRectClipRegion Writepanoskorovesis
The handler separates MetaISectRectClipRegionAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I999fa1baa4e3c34f3f83dc1d3973f961857f89d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120308 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-12Add Handler for ClipRegion Writepanoskorovesis
The handler separates MetaClipRegionAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: If3f4682dbdef6a2a0bd11a51c4a4eb3a6ab8b0d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120307 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-12Add Handler for Wallpaper Writepanoskorovesis
The handler separates MetaWallpaperAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: Icfbb4ab5cf3d7ea803cb55405e82dc262f3958c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120306 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-12tdf#76310: subsequent_filters: Add unittestXisco Fauli
Change-Id: If39bb4e3c7e767f273351cb381ea055e3934de2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120338 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-11Resolves: tdf#143809 "INF" may be a named expression or DB area nameEike Rathke
... to not be caught by rtl::math::stringToDouble() handling XMLSchema-2 "INF" and "NaN" and set as error. Change-Id: I9bf7aad416a69d4c3c0d49d6c80168097040a3e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120337 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-11tdf#44278: sw_ooxmlexport16: Add unittestXisco Fauli
Change-Id: I31de23db13083ce98e75d3ec1d65d970161b3b92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120335 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-11gtk4: add a separator between toggle and menu buttonsCaolán McNamara
Change-Id: I00e9245801529ce817781e65fb75fa59cd3d7f79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-11xmloff: work around LD_LIBRARY_PATH breaking odfvalidatorMichael Stahl
Validator calls ResourceBundle.getBundle("com.sun.msv.reader.Messages") which can't find the com/sun/msv/reader/Messages.properties in its jar. bootstrapfixture.cxx:241:Assertion Test name: testBibliographyLocalUrl::TestBody forced failure - /lo/master/schema/libreoffice/OpenDocument-v1.3+libreoffice-manifest-schema.rng[-1,-1]: Error: Can't find bundle for base name com.sun.msv.reader.Messages, locale en_US This is triggered by gb_CppunitTest_CPPTESTPRECOMMAND. No idea how this happens, or why it started to happen sometime during the last ~4 weeks, but propagating the same workaround of commit e854abe076155fc085b56549ced50b3ee9a095d2 to more tests seems to fix it. Change-Id: Iaef2b41f81c4a659e66cfb7a40f7b1a4517552c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120322 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-11gtk4: fill menu MenuToggleButton menuCaolán McNamara
Change-Id: I512846cda2c8f06838a499043a4cd08314fd7b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-11gtk4: get startcenter MenuToggleButton menu appearingCaolán McNamara
though still without contents Change-Id: Ieb7048a74f33fe65ededd1ff8730b2d061ae325f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-11tdf#139734 Remove redundant asserts after MacrosTest::loadFromDesktopKaran Abrol
Change-Id: Ia1b63a38b6522ecf52cc2e923e93d6bf0a41ea86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120319 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-11add some --disable-scripting fixesCaolán McNamara
Change-Id: I28c4d38a035201acc2b0e5acc5908c4e74ae80e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-11gtk4: get startcenter MenuToggleButton workingCaolán McNamara
the button parts, not the menu part yet Change-Id: I016d2c2160a4e8c0c4d1e096f49d0e518b89a55b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-11gtk: use explicit GtkBox instead of generic GtkContainerCaolán McNamara
cause gtk4 doesn't have GtkContainer anymore Change-Id: I32893716654ba308277ee34ecd8c3c944a9bc575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-11tdf#143148: Use pragma once instead of include guardsZeynep Yavuz
Change-Id: I483d494a11b951fd415a314fddd4823db11dcb44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120295 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-11sw: fixed regression from [1] - OLE height in mm instead 100th mmTomaž Vajngerl
OLE height is 3cm, but converted to 30 (mm) where the Size is expected to be in 100th mm. This uses the correct value of 3000, which correcponds to 30mm and the expected 3cm. [1] 0d356f93e4d5ca073a6e866168f76103c60c6a45 Change-Id: I77cab1641b948a8839da543c12835c5c64825a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120316 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-11Drop convertMm100ToTwip in favor of the new o3tl::toTwipsMike Kaganski
Step by step, duplicates from <tools/UnitConversion.hxx> may go Change-Id: Id4c03ff8adc120ae06dbfdbdfb4f5ff0bb51f489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120315 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-11tdf#143583 DOCX import: fix lost empty paragraphs of footnotesLászló Németh
Last empty paragraphs of footnotes were removed (except in the case of the first footnote), related to the double call of RemoveLastParagraph() during footnote load and later during its copying. Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357 "tdf#76260 DOCX import: fix slow footnote import". Change-Id: I61d9aa6765f3af1893451684dde12c199251d06b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120270 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-11no need to allocate KeyedValues separatelyNoel Grandin
Change-Id: If28471436d224e88dfee07f3b8465648867197fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120291 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-11gtk4: use monitor size for workareaCaolán McNamara
which is better than nothing now that gdk_monitor_get_workarea is gone Change-Id: I8e691f733ec05d981a621f17efa5c968fd078193 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120311 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-11no need to allocate the lookupTableItem separatelyNoel Grandin
Change-Id: I43919a002df01c6329ee483bf69f04669cdce1f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-11no need to allocate changedValue_ separatelyNoel Grandin
Change-Id: Ibda7c7a055790f6eb87ac6bd62554e745181cea7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120292 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-11tdf#143769 don't crash on null XFillColorItemCaolán McNamara
use same solution as: commit 5ee0e6ab93ad791f5e79506efafd16cb7364ffb1 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Tue Jul 21 19:01:26 2015 +0200 avoid crash with color listbox for now Change-Id: I36ac6513546961ec8d8d1e9437a8ef88574acbf4 Change-Id: I46c55461e5867431a6e9c838b5ef462f9581eb28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120297 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-11backendtest:Irregular HalfEllipse test via various drawing methodshomeboy445
Change-Id: If1a6f224f6ff4118617128630077a81da4c469a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118656 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2021-08-11tdf#135247: sw_uiwriter3: Add unittestXisco Fauli
Change-Id: I4f78b42600c0b7316aee9e6c106a25cc8cff983a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120285 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-11Add Handler for Hatch Writepanoskorovesis
The handler separates MetaHatchAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I29587d4a9e9129c5425792e2f8873ee7414bdaa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120264 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-11Add Handler for GradientEx Writepanoskorovesis
The handler separates MetaGradientExAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I984e21b7d4b19b16432cabe9709d41f07187f268 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120263 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-11Add Handler for Gradient Writepanoskorovesis
The handler separates MetaGradientAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I31ae5f5331f780e095caaf200ea289332233fb52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120259 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-11Add Handler for MaskScalePart Writepanoskorovesis
The handler separates MetaMaskScalePartAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I3c881495c013e6827c91027319a9cedcea7f96c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120258 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-11Add Handler for MaskScale Writepanoskorovesis
The handler separates MetaMaskScaleAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I1fee84e7c79da96755d20611a36b58f92349585f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120257 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-11Add Handler for Mask Writepanoskorovesis
The handler separates MetaMaskAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I8c204d767e8474fbf67fc5b8f610f4b8e5244903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120256 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-11svx: cleanup formatting of svdglue.hxxTomaž Vajngerl
Change-Id: I4aa4d25a5097813feeb7d6ebb654b9b0ce0c1c14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120302 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-11sw: preserve the value in original units to minimize conv. errorTomaž Vajngerl
Not really an big issue but let's preserve the values in original units as long as we can without conversion so that the error is minimal. Change-Id: I96981eaecac74b591803dbc93e487c1d106ab23c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119490 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-11no need to allocate AllSettings separately in ImplSVAppDataNoel Grandin
Change-Id: I16b21d2bec8de9e5f4e8402c838c99d73637fe99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120290 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-11CppunitTest_sw_ooxmlexport2..5: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I7b48ff2427b8c544db07323a98a236cfd8904df8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120284 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-11Deduplicate number read/writeMike Kaganski
Change-Id: I58808e208ac8b3406497a4e512ec3372434d2ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120246 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-11tdf#143577 check node is a text node before use as suchJim Raykowski
Change-Id: I337c94aa90ed906c5b744171728022ba5f9c64b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120191 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-08-11convert some LogicToLogic calls to use o3tl::convert insteadTomaž Vajngerl
If a LogicToLogic uses fixed units, we can use o3tl::convert instead. We can also do the same for all other cases where LogicToLogic is used, but that needs additional investigation to determine if it is safe to do so. Note: MapUnit::Pixel is converted to o3tl::Length::pt because it assumed 72 PPI for a logical pixel, which corresponds with the conversion rate of a point (72 PPI). Today, 96 PPI is standard, which is also used for o3tl::Length:px. Change-Id: I29126df38bfcfda74b5d83d4cb880a378aecd18b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120230 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-11There is no LANGUAGE_ENGLISH {en} locale but LANGUAGE_ENGLISH_US {en-US}Eike Rathke
The known fallback locale is en-US so this worked by chance.. Change-Id: I81ee2aff0cc35b4c8d501dfb6846f0709f1417ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120301 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-10No need in this functionMike Kaganski
Change-Id: I391183753e4fad800b7c69aef2e76a3780ce52a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120244 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-10tdf#136610 Add Clone/Clear Direct Format buttons to LO Draw tabbed interfaceRafael Lima
Currently LO Draw only shows the "Clone" and "Clear Direct Format" buttons in the tabbed interface when a text object is selected (in the Text tab). With this patch, LO Draw will now show these buttons in the "Draw" tab when shapes are selected, as well as in the Home tab (as it is shown in Impress). Change-Id: I9acf577cc5322d43c18acc366788a5eadda67ff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119183 Tested-by: Jenkins Tested-by: Andreas Kainz <kainz.a@gmail.com> Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2021-08-10add some --disable-scripting fixesCaolán McNamara
Change-Id: I45f08bce8e067ead82f4c73c8150b7027c083172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-10tdf#143148 Use pragma once in sdextYildiray
Change-Id: I0ba29599509b875494f4021948192d2d447b9e6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120277 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-10embeddedobj: implement XServiceInfo in the various embedded obj implementationsMiklos Vajna
This gives UNO clients a reliable way to detect e.g. OSpecialEmbeddedObject, where it's expected that double-clicking on the object doesn't do anything. Change-Id: I595453490b157b64214cd7359da1e3a3c959191d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120274 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-10Use boost::make_sharedStephan Bergmann
Change-Id: I2c842d6198d79dcc3f5c85ab65c8f57357aa2a79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120289 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-10Clean up remaining uses of boost::logic::triboolStephan Bergmann
obFitShapeToText and obRelFlipV can just as well be modelled with std::optional<bool>, and obFlipH and obFlipV apparently only need two states anyway (as for a boost::logic::tribool x, bool(x == true) is true iff x has the value true) Change-Id: Ic35e33ffa4ee30d1c2cdf9f8d4aa3bae29ece2af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120281 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-10tdf#143148:Use pragma once in storeEmircan Agac
Change-Id: Ia12dd3d7b69a8fdfbdfa6503e1ce2ee46c9446d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120075 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-10Use nStringSize instead of nStringOffMike Kaganski
nStringSize is the actual size of the string block, and is the correct end position to use to calculate last string length. nStringOff is not updated during load, so using it makes no sense here. It was this way ever since 039dbbcb9688971a85b1791f60a55693ff3ba261. Change-Id: I4fad1bdd6ed4af9dd7d29b5438ec23db0b815806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120243 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-10gtk4: remove training wheelsCaolán McNamara
Change-Id: Ib52a4cc56fafc23ced1ce4f27d2c69977471d1d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118491 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-10use o3tl::hash_combineCaolán McNamara
Change-Id: I0d6cd4313652669939cdbdc8e4ae7c62dae3022b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120280 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-08 07:48:20 +0000