summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-03tdf#126206 DOCX: add rejection of character formatting changesLászló Németh
using imported change tracking data, instead of clearing only direct formatting in the modified text range. See commit 9c4eef7d809ad7d283860c7b47b0f561aa240906 "tdf#52391 reject/clear formatting of format-only changes". Change-Id: Ie27d5c5bca6d9f30681e8f542f95417e9bb4c266 Reviewed-on: https://gerrit.libreoffice.org/75011 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-07-03sw comments on frames: delete comment of frame when deleting frameMiklos Vajna
Also group the two actions together, so only 1 undo action is visible to the user, not 2. Change-Id: Idba5a63b1653e96db4f9567a38b3f4ca740eb1df Reviewed-on: https://gerrit.libreoffice.org/75045 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-03sw: fix moving of at-page anchored flys to different pageMichael Stahl
The problem is that some flys are anchored at a page with Y pos 35k and are moved to a page with Y pos 17k, while retaining mbFrameAreaPositionValid=true and their existing Y position. The flys will never be painted or even invalidated again because their position is off-page. This is somehow a regression from commit 0b53f794ffb2550288610b9488f11fd21ab85aae - without the new mutation of an empty-page to a normal page due to at-page flys by resetting m_bEmptyPage in SwPageFrame::UpdateAttr_() on it the problem didn't happen. Due to the above commit, the page 3 is not an empty-page any more as it has 2 flys anchored on it; previously those flys were moved (only in the layout, not in the model!) to page 4 by some funny code in SwRootFrame::AssertPageFlys(), which at first glance seems like an improvement. Change-Id: Ia071931b26e64245f90233232dd2ac0d64365ce6 Reviewed-on: https://gerrit.libreoffice.org/75009 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-03sw: remove useless local pMarkBase in makeMark()Michael Stahl
Change-Id: I26ae1a8a33e0d7822975abdfd5c74a2ef5ac45e9 Reviewed-on: https://gerrit.libreoffice.org/75034 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-03sw: remove dynamic_cast to MarkBase in MarkManagerMichael Stahl
Forward port of https://gerrit.libreoffice.org/#/c/74851/ and much smaller because the shared_ptr has been removed in commit 9ff648c691f003a11eba9a22ac37032d72b4b642 The MarkManager always has MarkBase instances in its vectors, so abstract the vector better in the IDocumentMarkAccess interface by exposing only a wrapper iterator that converts from MarkBase to IMark. There is an unexpected pitfall here in that forward iterator's operator* is required to return a reference, but at least for a const_iterator it appears to work to just return a value instead. The dynamic_cast of every element in some MarkManager functions is quite expensive and shows as 10-15% in callgrind. In bubli's measurements, in the 6.1 branch this speeds up loading the bugdoc by ~40s of the initial 3min 50s. Change-Id: I65d974bea0301bf7b4cfa25ad6daae10b6768202 Reviewed-on: https://gerrit.libreoffice.org/75033 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-03Drop unused MOC4 exportJan-Marek Glogowski
Was missed when the kde4 VCL plugin got removed. Change-Id: Ia6e7fb87577572d450c7851b5559041dea68d19e Reviewed-on: https://gerrit.libreoffice.org/75023 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-03sw comments on frames: fix DOC handlingMiklos Vajna
The export part didn't use HasFlysAt() to decide what to do with empty annotation marks. Regarding the import side, the only problem was that the start of the annotation range wasn't adjusted to cover the comment anchor, similar to what the UI and the UNO API already does. Change-Id: Ibcbaafa9f3f70de95a70b424aca31ebdc9df099d Reviewed-on: https://gerrit.libreoffice.org/75025 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-03tdf#74702: OutputDevice:InitClipRegion followupChris Sherlock
Followup to commit 3a99d7f621036, which did a good job of removing use of GetOutDevType() in OutputDevice initialization. Commit changes ClipRegionIntersectionRectangle() to ClipToDeviceBounds(). ClipRegionIntersectionRectangle() takes a region and clips it, however it breaks the contract in Printer and PDFWriterImpl where it does a noop - any caller on these classes will expect the region to be clipped to an intersecting rectangle. Instead, I have renamed it to ClipToDeviceBounds(), which is what the bClipBounds check shows it is doing in the original code. I have made it return the new clipped region as this seems more logical. I have also moved the comment to a doxygen comment on the function signature in OutputDevice. Change-Id: I64276920bb452839df04c16f0efc3d5581162673 Reviewed-on: https://gerrit.libreoffice.org/74967 Tested-by: Jenkins Reviewed-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-03tdf#126177 XLSX export: fix hyperlinks to documentsTünde Tóth
After export hyperlinks to documents didn't work, because the the hyperlink relationship targets contained also the anchor. Change-Id: I0bfc5bd1ef2b37f769d6a6b97e31c1b4bbfcb9aa Reviewed-on: https://gerrit.libreoffice.org/74988 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-07-03sw: document what "physical" meansMichael Stahl
Change-Id: Ia2e626668a5d45187a0531a8b2743533b28ec33e Reviewed-on: https://gerrit.libreoffice.org/75008 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-03tdf#125706 and tdf#125665 writer, speed up RDF, take2Noel Grandin
second attempt at this - modify the existing API so we cache all queries. This slow things down slightly from 6.9s to 7.2s Change-Id: Idb20f90be346fb1e3d7271132337ab14b49a814b Reviewed-on: https://gerrit.libreoffice.org/74992 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-03Revert "tdf#125706 and tdf#125665 writer, speed up RDF"Noel Grandin
This reverts commit 47e04cf31c6165dd55dc20962ad9c72962b958bd. Because we are going to do this a better way. Change-Id: Ic92d6fc471578973a141b6fd2be49fc38a9f55a5 Reviewed-on: https://gerrit.libreoffice.org/74991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-03Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Bookmark fixes for Chart Data table page and clone description for some new buttons Change-Id: Ie173ce3fd2deec89ce60ba373e799a2110243b05 Reviewed-on: https://gerrit.libreoffice.org/75007 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
2019-07-03tdf#126180: EndTextEdit on all views before delete/cut slideXisco Fauli
This also reworks the fixes tdf#125824 and tdf#111522 to use EndTextEdit instead of blocking the undoing Change-Id: I73c2289a9d950465f020f684e9e736148380f5c5 Reviewed-on: https://gerrit.libreoffice.org/74989 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-03tdf#42949 Fix IWYU warnings in include/svx/x*Gabor Kelemen
New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I5b91a82d25601041b73444f602d033ef62484ba8 Reviewed-on: https://gerrit.libreoffice.org/74563 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-03Remove some unused includesMiklos Vajna
See tdf#42949 for motivation. Change-Id: I89c082d62409b40c8472b865cc60b0d10923c9c1 Reviewed-on: https://gerrit.libreoffice.org/75015 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-03UI tests opening all dialogs in calc and see if it crashesArtur Neumann
Open a dialog, close it by the given button e.g. "cancel" or "close". If the dialog has an enabled "OK" button open the dialog again and try to close it also using the OK button. For every dialog a complete new document is opened to ensure test-separation, otherwise one action could hamper the next action. E.g. ".uno:Protect" would hamper any edit action. For dialogs that already have other tests a "cancel/close" test was added to the previous test. As far as possible opening new documents was avoided in those cases. And in some cases a simple check was added to check if the "cancel" button does not change anything. Change-Id: I727cad43603770245f27baf752a1985f9a754847 Reviewed-on: https://gerrit.libreoffice.org/74333 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-07-03Fix typoAndrea Gelmini
Change-Id: I3c7f3d8af44ab003ca1d421716f6df21c1e93eef Reviewed-on: https://gerrit.libreoffice.org/75020 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-03Fix typoAndrea Gelmini
Change-Id: I7f23790e11a674693ab5a10fba0eba801f0b4636 Reviewed-on: https://gerrit.libreoffice.org/75017 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-03Fix typoAndrea Gelmini
Change-Id: Ie42676093d67751bcc52cd27638505493e59012b Reviewed-on: https://gerrit.libreoffice.org/75018 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-03Fix typoAndrea Gelmini
Change-Id: I54e2f1e63ed33121537e77e9a172575509d29adc Reviewed-on: https://gerrit.libreoffice.org/75021 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-03Fix typoAndrea Gelmini
Change-Id: I1aa00b948d76ee3a5b7b1fcd7968ceb0946dab2f Reviewed-on: https://gerrit.libreoffice.org/75019 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-02tdf#113448 Export font used for checkbox markThorsten Behrens
Related tdf#93853 make sure we use the opensymbol nice checkmark (0x2713) to compel viewers to use that. Change-Id: Id5028b0d062e0491b1cc9c36e2d9d4e4a7ab14a1 Reviewed-on: https://gerrit.libreoffice.org/74995 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-02tdf#113448 don't export any font for radio buttonsThorsten Behrens
Change-Id: Ie84b19a3dfaec32184bb825b7593ec33a5c4145c Reviewed-on: https://gerrit.libreoffice.org/74994 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-02sw comments on frames: fix DOCX handlingMiklos Vajna
We used to ignore annotation marks which just cover the comment anchor since commit fff019debf14a0bf8cd358591a686191347f1542 (MSWordExportBase: ignore empty annotation marks, 2014-09-17), but this means comments on images are lost. Pass around SwWW8AttrIter, so we can decide if we have a relevant at-char anchored frame in MSWordExportBase::GetAnnotationMarks(), without iterating over all frames in the document, which would be slow for large documents. Regarding the import side, the only problem was that the empty comment range resulted in a loss of annotation marks; fix that by using a marker while inserting. Change-Id: I385677d74423bc05824dac4a12d1a991bb3983c4 Reviewed-on: https://gerrit.libreoffice.org/74996 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-02Fix typo in codeAndrea Gelmini
Change-Id: I5b3f9df553da1d4ad76d1b914b4d39601ee0ae55 Reviewed-on: https://gerrit.libreoffice.org/74999 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-07-02SmartArt: make if-node functions relative to current presentation nodeGrzegorz Araminowicz
* maxDepth calculates maximum depth of associated data node children (instead of per-diagram max depth) * cnt counts children of associated data node (instead of looking up presOf node and if not found counting presentation node children) Change-Id: Ifb50510acb9e6a3d2655197102060ec1c207075b Reviewed-on: https://gerrit.libreoffice.org/75000 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-07-02Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Fix typo Change-Id: Ia277377ea5329d26717c80a0aeb8c393ba87cff3 Reviewed-on: https://gerrit.libreoffice.org/74998 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-07-02NB update UI'sandreas kainz
Change-Id: Iece18df3c1ed2e066e6820e67755d52a30d63b27 Reviewed-on: https://gerrit.libreoffice.org/74990 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-02Access2Base - MsgBox and InputBox methodsJean-Pierre Ledure
Convenient functions to be called from Python
2019-07-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add Help for FOURIER calc function and analysis Refactor sample tables, Mute l10n for numbers FOURIER function Fourier analysis Sample file Change-Id: If5361fe009ec380e9cdd6f3e24184471c1451421 Reviewed-on: https://gerrit.libreoffice.org/74914 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-07-02bundle external: qrcodegenShubham Goyal
The bundle helps to generate QR code in LO. Change-Id: Iaa9225a72d15806c929d30951cefd3f3fee8960e Reviewed-on: https://gerrit.libreoffice.org/73302 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-02Access2Base - Addition of SetSelected method in Control classJean-Pierre Ledure
... to workaround the limitation of Basic on Property Let + SetFocus i.o. setFocus (typo) + Tabstop i.o. TabStop (typo)
2019-07-02sw: remove hacky liveness check in lcl_RecalcRow()Michael Stahl
Crashtesting didn't find any assert there so now revert most of commit e4400f4c4e267f8528df3a7d5a09623c888bd10c. Change-Id: I6e990b76af0d047b50115cb019a352f1a04a65ed Reviewed-on: https://gerrit.libreoffice.org/74954 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-02update clang sharedvisitor.cxxLuboš Luňák
This should have been included in 9fbedb792993. Change-Id: I3b8b1a463c3f85d6cd4a4db14edcfedf01d7e5a9 Reviewed-on: https://gerrit.libreoffice.org/74956 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-07-02Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Fix ahelp HIDs in form control Data pages Change-Id: Iec13edc72bc5b1dbc83f73be142662917a6505cf Reviewed-on: https://gerrit.libreoffice.org/74982 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
2019-07-02Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Fix ahelps on form/form control event description pages Change-Id: I421a0d038432df1a1a36fb4c889740d56885497a Reviewed-on: https://gerrit.libreoffice.org/74983 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
2019-07-02Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Add more ahelp bookmarks on Trend Line page for active UI items Change-Id: I58daac7d38bf2e63a32dbaaa767a58d17cef81da Reviewed-on: https://gerrit.libreoffice.org/74984 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
2019-07-02tdf#74702: cleans OutputDevice::DrawHatchLine upAdrien Ollier
Change-Id: Ie90e0f75018edee178f1f02056e59b35956c4142 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/74464 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-02tdf#42949 Fix IWYU warnings in vcl/source/[a-e]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I386e913f9002eed164c26137a0e184993d010b86 Reviewed-on: https://gerrit.libreoffice.org/74090 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-02tdf#125554 PPTX export: handle gradient transparency for gradient fillMiklos Vajna
Regression from commit cfc1f4ea4889f768d689a0df71519e9bcb707bc0 (oox: disable gradient fill grab-bag for PPTX, 2019-02-05), the problem was that in the past grab-bag roundtrip worked (in some cases) for this shape fill case, but true roundtrip did not. So when the commit disabled grab-bags (since their color pointers in the theme don't work in the PPTX case), a previously not implemented feature now started causing a real problem. Fix the bug by adding support for transparent linear gradients on the exports side. This means that in case the import creates both a fill gradient and a transparency gradient, then now the export creates markup based on both, not only based on the fill gradient. Change-Id: I99fa3caba2b2884c2acb7e0704bbeb0b6cffd4a4 Reviewed-on: https://gerrit.libreoffice.org/74968 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-02tdf#125655 disbale quick edit mode for iOS and AndroidTomaž Vajngerl
When clicking (tapping) on text in text based objects (shape with text or a text frame), it automatically enters editing mode, which is not a desired behaviour in a touch based environment. This behaviour comes from a quick edit mode, which is enabled by default on the desktop. For Andorid and iOS this is now disabled when LOK is initialized. For online this change might also make sense (if the user would use a mobile device), however this is not implemented now as this would require more than just changing the global configuration, as it needs to behave differently depending on the view/user. Change-Id: Ib4a71cba0aeb4238a5d5b708801a07b39fb5f316 Reviewed-on: https://gerrit.libreoffice.org/74986 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-02Slight reformattingAndrea Gelmini
Change-Id: I0f372656e58338f5292938576f40822061338e70 Reviewed-on: https://gerrit.libreoffice.org/71631 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-02Remove accidental newline from ui contextSamuel Mehrbrodt
Change-Id: I4ccd844e21ddd3052d0380d4ca98eda30cbeb49d Reviewed-on: https://gerrit.libreoffice.org/74959 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-02Fix typoAndrea Gelmini
Change-Id: I0a9a39b1dba9f430bb54e852ec65979acde08dba Reviewed-on: https://gerrit.libreoffice.org/74971 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-02Fix typoAndrea Gelmini
Change-Id: I230929d37b9649f58856e1b424966765f6e96f11 Reviewed-on: https://gerrit.libreoffice.org/74970 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-02Fix typoAndrea Gelmini
Change-Id: I97c3e85c6fc027dc11c4ada4b4c15385288b733f Reviewed-on: https://gerrit.libreoffice.org/74973 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-02Fix typoAndrea Gelmini
Change-Id: I8319b83bd2688d8e115270fcfab5ab3d59c528dd Reviewed-on: https://gerrit.libreoffice.org/74979 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-02Fix typoAndrea Gelmini
Change-Id: Ie31c61a30ecb114c1a46144503b7b9c395dea172 Reviewed-on: https://gerrit.libreoffice.org/74972 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-02Fix typoAndrea Gelmini
Change-Id: Ide36f04f99766bbc6002d86b4a976ab11ffdc906 Reviewed-on: https://gerrit.libreoffice.org/74974 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2025-02-01 03:23:11 +0000