summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-08-07 tdf#162351 tdf#130857 qt weld: Implement weld_widget_for_responseMichael Weghorn
... for `QtInstanceMessageDialog`. This fixes the crash reported in tdf#162351 due to a nullptr deref in `OSQLMessageBox::impl_addDetailsButton` that was seen with the base class implementation `QtInstanceDialog::weld_widget_for_response` that just returns nullptr. Clicking the "More" button in that dialog doesn't yet show the corresponding dialog, but that will be implemenated separately. Change-Id: I8cd4fac4fd57be993dba1713bb2e19860dfc334b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171551 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-07tdf#162351 tdf#130857 qt weld: Extract helper function to get buttonMichael Weghorn
... for response code. The new helper method `QtInstanceMessageDialog::buttonForResponseCode` will be reused elsewhere in an upcoming commit. Change-Id: Ie7ee065fb68f936b79ac96ba70dc85ffa18c9859 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171550 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-07tdf#162351 tdf#130857 qt weld: Add basic QtInstanceButtonMichael Weghorn
Add a very basic native Qt implementation for `weld::Button`. It currently doesn't really implement many methods and just triggers an assert when they get called. Change-Id: I7a15266e978ca3bb030c847822a82d8d58c4c189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171549 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-07Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 4f15160e46f503beb4c8d0f6442be2a2bc6cf036 - Don’t localize file extensions Change-Id: I73b2200c8a2a2069b2fe799181b524674c6a6442 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171576 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-08-06Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 1544cc6acf3c32f80d5cb76c90aeef04e1e5265f - Remove unnecessary comma and add missing article Change-Id: Ie6d2eba45357e55d3b8c564213b43661d5f4afff Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171574 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-08-06Ref: TDF#157930 Refine conditionaleasydialog.uiOlivier Hallot
+ Add Help button + Add extended tips + reword labels Change-Id: Ic1b24aedc3eb4c43fc1cf19f6bbcb8b3b72c94e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171210 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-08-06cid#555593 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555849 COPY_INSTEAD_OF_MOVE cid#1555936 COPY_INSTEAD_OF_MOVE cid#1555951 COPY_INSTEAD_OF_MOVE cid#1555955 COPY_INSTEAD_OF_MOVE cid#1555960 COPY_INSTEAD_OF_MOVE cid#1555964 COPY_INSTEAD_OF_MOVE cid#1555965 COPY_INSTEAD_OF_MOVE cid#1555975 COPY_INSTEAD_OF_MOVE cid#1555979 COPY_INSTEAD_OF_MOVE cid#1555987 COPY_INSTEAD_OF_MOVE cid#1555990 COPY_INSTEAD_OF_MOVE cid#1555991 COPY_INSTEAD_OF_MOVE cid#1556002 COPY_INSTEAD_OF_MOVE cid#1556008 COPY_INSTEAD_OF_MOVE cid#1556011 COPY_INSTEAD_OF_MOVE cid#1556015 COPY_INSTEAD_OF_MOVE cid#1556017 COPY_INSTEAD_OF_MOVE cid#1556023 COPY_INSTEAD_OF_MOVE Change-Id: I8ab99d8e52a1780173a4272c59d408432c29de9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06cid#1615230 silence Overflowed constantCaolán McNamara
Change-Id: Iffa09b68794ff7942c1d2780097f0021c070ed96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171571 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06cid#1607096 silence Overflowed constantCaolán McNamara
Change-Id: Ifa89ef67ffd7f5842c60a34f6705365f3de94770 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171570 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06tdf#160786 sc: Fix repeat char format code inaccuracyJonathan Clark
Number format codes allow arbitrary repeat characters. These repeat characters are inserted while formatting numbers to pad strings to the width of the containing cell. For example, this is used in some default format codes to left-align currency symbols with right-aligned digits. Previously, Calc determined the number of repeat characters to insert based on the assumption that the pixel width of a string containing N of the repeat character would be N times the pixel width of a string containing 1 of them. This is not a safe assumption. This change updates the algorithm to instead look at the average width of a repeat character when used in context as part of a padding string. This approach is still not entirely correct - it doesn't account for ligatures around the padding sequence, for example - but in practice it is a reasonable compromise between cost and accuracy. Change-Id: I240cf38ec0376ee2d2896e7a7da6760a374b3034 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171548 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-08-06cid#1606751 silence Overflowed array index readCaolán McNamara
Change-Id: I92dd8fb7212bbf8935ed6f312ef7bd3775b5b8e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171569 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-06Avoid excessive progress updates unconditionally.Michael Meeks
This may make short lived progress bars somewhat more 'blocky' and less smooth - but inevitably make loading faster, particularly for loaded machines with ultra-beautiful, slow to render themed progress-bars. Change-Id: I5a7e43690f5e7eff35c980cae4991376204eb5fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-06tdf#162370: check if nNext is valid, tooMike Kaganski
0xfff is a special value for a style slot on MS formats export: see MSWordStyles::GetSlot and BuildGetSlot. The slot in nNext must be checked the same way as nBase and nLink around it. Change-Id: I94836bc3f624eb99655e005217707e0ea7210c8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171547 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-06CairoSDPR: Support TextBackgroundFillArmin Le Grand (Collabora)
Change-Id: Ifa00a230ad88d49ccda7c7f47b3d87870d4dfc3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171489 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2024-08-06tdf#135710 - Add Unit testAdam Seskunas
Change-Id: I17189845ba273f1843a922e5b8aa521a8580dcb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171467 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-08-06Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to c289e0b3649626a7b88aa88c0106f2f9b2251c8a - Place find toolbar in 02 folder. (folder 02 has most of toolbars help pages) Change-Id: Ib5c4dadc3c2be386ff105e60081912904f25a7ce Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171488 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-08-06tdf#122452 - Add Unit TestAdam Seskunas
Change-Id: Ifce16dd9ec093c515e61f65b58e0414b1a157a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171126 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-08-06use more concrete UNO type in writerfilterNoel Grandin
Change-Id: I468f3b4b6e3ccf2221ad1f5088f2b4a009966c0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-06Simplify a bitMike Kaganski
Change-Id: Iffc22c60572f230e3c13d6e4de89856d50244eec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171521 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-06ofz#70966 use final upstream fixCaolán McNamara
Change-Id: I8423be9fdcd0c224d5d7993a4d982176c404035d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171520 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06reduce use of dynamic_cast in marksNoel Grandin
which is hit quite hard during import of documents with lots of marks, mostly because of the resorting that occurs in ContentIdxStoreImpl::Restore Change-Id: I1e5e3d8cfc0e65f9bf74449df8e048cd061022ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171522 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-06tdf#133941 tdf#161909: Label the "Certificate Manager" with "GPG".Moritz Duge
Change-Id: I74a7349ece014f7bf26dd8d75723751b344f1b87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171499 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-08-06cool#7710: Make Slide Properties Dialog in Impress AsyncSven Göthel
How to reproduce the synchronous dialog: - Build in debug mode - Click on 'Format' menu, then sub-menu 'Slide Properties' - The sync-dialog warning shows up This commit updates the dialog from synchronous to asynchronous processing. How to manually test the asynchronous dialog: - Apply patch - Build in debug mode - Click on 'Format' menu, then sub-menu 'Slide Properties' - The 'Slide Properties' modal dialog box opens and is functional. Tested manually within COOL 24.04 (online) with - Changing aspect-ratio and background color FuPage's lifecycle is extended by wrapping itself into rtl::Reference<FuPage> and passing a copy to the async-action lambda-capture, as it is being called from FuTemporary and managed as rtl::Reference<FuPoor>. Otherwised resources are passed to the async-action simply using std::shared_ptr<>. Signed-off-by: Sven Göthel <sven.gothel@collabora.com> Change-Id: I692204403e8a6ee526e7b463c8bf8a41c1416489 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171393 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171508 Tested-by: Jenkins
2024-08-06Related: tdf#162295 DOCX import: optimize copying headers/footersMiklos Vajna
The original DOCX bugdoc has 150 sections on 88 pages, which means that copyHeaderFooter() in the domain mapper is a significant cost. Setting a property on a page style involves making a copy of the SwPageDesc, working on that copy and then copying it back. Which means that setting UNO properties one by one vs working via setPropertyValues() is a big difference. - old cost: 11984 ms - new cost: 7764 ms (65% of baseline) Change-Id: Iea99fb3ad9d3e61494c9f012c4c7fa10cc7ab09d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171519 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-06Fix typoAndrea Gelmini
Change-Id: Ia32b0224be6cda50ece367b9bc30813ce62f5655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171504 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-08-06ofz#70966 Integer-overflowCaolán McNamara
Change-Id: If91c4db8e1180f6408ef72031299f0b88e3c9a64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171510 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06Resolves: tdf#141398 auto-select first entry of filtered resultsCaolán McNamara
apparent regression from: commit c403c86c6da4db0a6f2864ad4e13def9a3898cd4 Author: Caolán McNamara <caolanm@redhat.com> AuthorDate: Sun Mar 17 19:22:08 2019 +0000 weld SwFieldRefPage Change-Id: I5ae3965aa681ea1f5a005fbc8dad4d0ce36af1b3 Reviewed-on: https://gerrit.libreoffice.org/69373 Change-Id: Icb868403d31e1a6b57ae957f4eb98deafcc7f940 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171514 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06cid#1555415 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555430 COPY_INSTEAD_OF_MOVE cid#1555497 COPY_INSTEAD_OF_MOVE cid#1555542 COPY_INSTEAD_OF_MOVE cid#1555543 COPY_INSTEAD_OF_MOVE cid#1555564 COPY_INSTEAD_OF_MOVE cid#1555593 COPY_INSTEAD_OF_MOVE cid#1555602 COPY_INSTEAD_OF_MOVE cid#1555610 COPY_INSTEAD_OF_MOVE cid#1555667 COPY_INSTEAD_OF_MOVE cid#1555693 COPY_INSTEAD_OF_MOVE cid#1555719 COPY_INSTEAD_OF_MOVE cid#1555757 COPY_INSTEAD_OF_MOVE cid#1555795 COPY_INSTEAD_OF_MOVE cid#1555826 COPY_INSTEAD_OF_MOVE cid#1555847 COPY_INSTEAD_OF_MOVE cid#1555851 COPY_INSTEAD_OF_MOVE cid#1555863 COPY_INSTEAD_OF_MOVE cid#1555865 COPY_INSTEAD_OF_MOVE cid#1555867 COPY_INSTEAD_OF_MOVE cid#1555869 COPY_INSTEAD_OF_MOVE cid#1555879 COPY_INSTEAD_OF_MOVE cid#1555890 COPY_INSTEAD_OF_MOVE cid#1555893 COPY_INSTEAD_OF_MOVE cid#1555900 COPY_INSTEAD_OF_MOVE cid#1555922 COPY_INSTEAD_OF_MOVE cid#1555925 COPY_INSTEAD_OF_MOVE Change-Id: I5d362a09e80eecd282e63c745bfe26eac2631a0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171492 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-06Do not assert TableRef inner reference for dumb sequence, tdf#159343Eike Rathke
... of FormulaToken that's only created to extract a range from an expression because that OOXML import part doesn't know to operate on a ScTokenArray. Change-Id: I4011723b682c3eae0e1c8d8e768553154c024061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171516 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06simplify IMark hierarchy (8)Noel Grandin
we can declare the fieldmark methods with better type-safety now, and with much less dynamic_cast Change-Id: Ia515050967afdee191b96dd81b139d89be9179df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171474 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-06tdf#162340: handle target column scale in setObjectWithInfoMike Kaganski
In commit f1121362f3dd4287577dd7952c6f00a524a81111 (tdf#156530: fix OPreparedStatement::setString, 2024-07-03), I misused the method's 'scale' argument, as the number of decimals in the target column. It seems that the method was modelled after JDBC's setObject taking four arguments [1], which use is also unclear to me, but it likely is intended to describe input data. Anyway, all our implementations either pass the scale to next implementation, or ignore it. The problem was when 'x' was a string like '0.1370', and 'scale' was 0. The passed 'scale' was used, instead of the target column's; and that incorrectly truncated the number to 0. [1] https://docs.oracle.com/javase/8/docs/api/java/sql/PreparedStatement.html#setObject-int-java.lang.Object-int-int- Change-Id: Ib507d32706551517cc0a8a3cba351093549d7026 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171506 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-06tdf#150397 vcl: Don't select SalInstanceTextView text on focusMichael Weghorn
Disable selecting the text view's text when receiving keyboard focus (see `TextWindow::GetFocus`) for the `SalInstanceTextView` implementation. This aligns this with the GTK implementation (`GtkInstanceTextView`) that also doesn't do that. This e.g. prevents selecting the full license text in the license dialog when installing a new extension when the qt6 or gen VCL plugins are used on Linux. Change-Id: I2f57848f441387fe03abb6d6163416c830cebc4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171438 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-06Fix off-by-1 errorMike Kaganski
Regression after commit af5a1b5925dbc816dced8813282d953fd5adbaaa Drop uses of css::uno::Sequence::getConstArray in dbaccess, 2024-04-30. Change-Id: Ifaecdeb2898f2e9089b1f893a1e9ba46352cc353 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171505 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-06tdf#159146 Fix layout after resizing commend width in WriterRafael Lima
This patch ensure that resizing the comment sidebar will update the entire layout. Change-Id: Ia3c805569525c558191b253d694ac1f2e99f2ace Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171039 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-08-05Fix CURLSHOPT_UNLOCKFUNC function signatureStephan Bergmann
(cf. <https://curl.se/libcurl/c/CURLSHOPT_UNLOCKFUNC.html>; I noticed this with an experimental Emscripten --enable-curl --with-webdav build that failed with a "RuntimeError: null function or function signature mismatch" during the call to > rc = curl_easy_setopt(m_pCurl.get(), CURLOPT_SHARE, g_Init.pShare.get()); in the CurlSession ctor) Change-Id: Iec4bd5a263484e2e615d0b7bb08928feb7dc4658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171487 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-08-05Resave with newer Glade versionMoritz Duge
Change-Id: I225dba56297d8b8022eb02ea296cda72c57cd306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171496 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-05cid#1616049 Use of auto that causes a copyCaolán McNamara
and cid#1616044 Use of auto that causes a copy Change-Id: Idb8e7abb72c5a3b2492f48bd617c0f297bb200da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171478 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-05fix @since tagsNoel Grandin
after commit 1bbcc3fdf312971ffb681b332f47369739d95dde Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue May 14 14:56:47 2024 +0200 O[U]String overloads that return view for rest parameter Change-Id: Ie1d844f4286a14aa9d7cbb3831460c17103582c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171477 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-05Fix typoAndrea Gelmini
Change-Id: I38f2c4a86ac65e3e7014108153b937eb6f755371 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171495 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-08-05lok: avoid excessive progress updates.Michael Meeks
Perhaps for desktop 40 updates per second can provide a nice smooth status experience for a full screen-width progress bar in some cases; but it seems likely that five per second over a remote protocol might be better. Change-Id: Ic77b3b76d680771cb766984bdbcd9c8af4af303d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171407 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2024-08-05vcl: Drop obsolete CUPS version checkMichael Weghorn
This CUPS >= 1.7 version check was was introduced back in 2017 in commit 7fbf98d99737ac916cc2dc374f3139e2ea81e47b Date: Thu Jul 27 08:11:34 2017 +0530 Add Common Printing Dialog Functionality and is obsolete by now. According to [1], our AlmaLinux baseline has CUPS 2.2.6 by now. Replace by a simple check whether CUPS is enabled for the build. (`pwg_media_t` used in that conditional code block is from a CUPS header and e.g. not available in the Android CI builds, see [2].) [1] https://pkgs.org/search/?q=cups [2] https://ci.libreoffice.org/job/gerrit_android_x86_64/40875/console Change-Id: I4683c86c2c9e44ff41ee8093d8f045bc955cba99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171485 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-08-05Fix typoAndrea Gelmini
Change-Id: I5cef95873cd6a67ba2994dcb6c2c8ed231c0b2ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171494 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-08-05tdf#155228 vcl: appease Adobe Acrobat Pro, always produce /TabsMichael Stahl
Reportedly Adobe Acrobat Pro complains if any page is missing "/Tabs" even though ISO 14289-1:2014 requires it only for a page with annotations. Change-Id: I84d750da12ca55519aa61c196d2d93aa33f1abad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171486 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-08-05tdf#162345 Allow splitting, when we have columnsMike Kaganski
This makes a similar exclusion as above in bLoneAsCharAnchoredObj case. I don't know exactly why should this depend on columns, but this works (so this is basically a monkey programming here). Change-Id: I6f15da77a16629d9146076e0a4ef50f82ebdc04c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171481 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-08-05tdf#162065 Fix format paintbrush in draw/impressOliver Specht
With tdf#160069 the format paintbrush was disabled outside of text selection and with tdf#160069 target selection was reduced to text only. The change of tdf#160069 is mostly undone with this patch. Change-Id: I8e23ef56206c6749913e2c95870537c3e378f946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170672 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-08-05sw: fix missing includes for the SwXStyle headerMiklos Vajna
It's a bit easier to navigate while code-reading when the header is not full of syntax errors, due to missing headers. Change-Id: If8417d17e6180b6a9679aade3893733fc47956c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171490 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-08-05tdf#153866: fix .uno:IndexMarkToIndexBjoern Michaelsen
- sw::FindContentFrameHint send by SwTOXType is handled by SwTOXBaseSection - SwTOXBaseSection/SwTOXBase is still an oldschool SwClient to SwTOXType - thus we need CallSwClientNotify() for now - once SwTOXBase is switched over to register at the Broadcaster, we can revert this Change-Id: Ia471a5785f49dc85c9777ae4681616842c1addf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171440 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2024-08-05tdf#162314 sw: Fix hang while laying out bidi portions with underflowJonathan Clark
Regression from 04184aa7e3aada8f4d938d20dfdb54b3a7dd3896 (tdf#157829 sw: Implemented line break underflow for bidi portions) Change-Id: If5d550bd6e0f1099bc37532b2172436c12805104 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171432 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-08-05simplify IMark hierarchy (7)Noel Grandin
drop the iterator wrapper, no longer necessary Change-Id: I41697c062805c3fadd0210cffbc8f7beffe01f2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171472 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-05ofz#70675 XML_ERR_FATAL not ending parseCaolán McNamara
Change-Id: I3b07ff6e208bf33053540548176a06f28138a6a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171479 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-22 23:18:15 +0000