summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-08-09tdf#113278 tdf#115884 tdf#161909: Add X.509 in static labels for PDF signing.Moritz Duge
PDF signing only supports X.509 and not GPG. Change-Id: Ic49e82ebc0c4c2aa69b801e275b9ab7ad6bddaa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171498 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2024-08-08update creditsChristian Lohmaier
Change-Id: I5619e8dcc9670ea09f6f27bc15a5b248e83378d9
2024-08-08Fix typoAndrea Gelmini
Change-Id: I3f4abdeed10c659ec49a6d4601ccef28a991b4dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171646 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2024-08-08Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 45533a00382950d51c74afc962e9c35d1dea5515 - update translations for 24.8.0 rc3 and force-fix errors using pocheck Change-Id: Ib855d52b14ef3d675be15e941d8eba65eed1a814
2024-08-08fix build on armhf with gcc 14Rene Engelhard
/uno2cpp.cxx: In function ‘void {anonymous}::callVirtualMethod(void*, sal_Int32, void*, typelib_TypeDescriptionReference*, sal_uInt32*, sal_uInt32, sal_uInt32*, sal_uInt32, double*)’: /<<PKGBUILDDIR>>/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx:278:5: error: ‘asm’ operand has impossible constraints or there are not enough registers 278 | __asm__ __volatile__ ( | ^~~~~~~ make[2]: *** [/<<PKGBUILDDIR>>/solenv/gbuild/LinkTarget.mk:338: /<<PKGBUILDDIR>>/workdir/CxxObject/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.o] Error 1 Just removing them makes it work, they are mentioned before anyway, too (thanks Caolan) Change-Id: Ibb9118b268a587ebdcfce343e2ee2605ac979915 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171650 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-08tdf#162398: InsertItem_ may modify itemsMike Kaganski
... which would invalidate the iterators of the for loop. Change-Id: I4962441e75a304a46d6f8ef5bc44fae1f4e03cc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171642 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-08simplifyNoel Grandin
Change-Id: I771e78413022d0e8ff1ac842d6f6ee38ae3b68f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171630 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-08CairoSDPR: Support ColorPolygon with AlphaGradientArmin Le Grand (Collabora)
Cairo can render RGBA gradients directly and the CairoSDPR supports that. If we have a PolyPolygon filled with single color combined with a gradient alpha the renderer could map RGB to that color and combine with the real alpha gradient steps. To support that I added another Primitive called PolyPolygonAlphaGradientPrimitive2D. It decomposes as needed (TransparencePrimitive2D if needed), so no other renderers have to be touched. The Cairo renderer supports it directly, though, what makes it much faster. Change-Id: Ie90c8bd84d6458d12443db815ced55bdea93c15c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171628 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-08-08tdf#161909: mention that keys/certs preselection is for ODF onlyMoritz Duge
ODFs can be signed with GPG or X.509, so both key types are listed for selection as a permanent setting in the options. PDF signing doesn't respect the preselected key/cert. And that makes sense, because PDFs can only be signed with X.509. So a preselected GPG key wouldn't work. Change-Id: I1b5dc36e40a9a2c82ca9044bf1b481968982befd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171636 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-08-08ONLINE: Add Invert document background color command.Gülşah Köse
Change-Id: Ia8868a80e4eba9a9a1c0b31077d9eca0c5b00466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171633 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-08use more concrete UNO type in writerfilterNoel Grandin
Change-Id: I46e94d5329cab5922e4a254277d47519076744ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171603 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-08use more concrete UNO type in writerfilterNoel Grandin
Change-Id: Ib2c6277f8398e223060440a3844b6d322572d11a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-08use more concrete UNO type in writerfilterNoel Grandin
Change-Id: I25af4b33b1a1a98e93ff9564175ec4d067b0aae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171601 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-08tdf#162211 revert "tdf#160077 writerfilter: shape vertRelation is FRAMEJustin Luth
... for layoutinCell" This reverts my 24.8 commit d210667c72ff821b8cb50b386a83ed55d65ae9bf because I'm finding that PRINT_AREA is a better fit than FRAME. Plus, add a few bits in addition to the revert. Restrict killing layoutInCell to shapes where the vertical offset is based on the paragraph too. (If it is based on the page, then treating as FRAME only works correctly if the shape is anchored to the first paragraph.) Also, just make clear this only makes sense to do if layoutInCell is not already false, and if isInTable. Existing unit tests affected were not interesting: -tdf151704_thinColumnHeight.docx [two off-paper textboxes] -tdf92157.docx [sync-separated textboxes, not seen in Word2010] make CppunitTest_sw_ooxmlexport21 \ CPPUNIT_TEST_NAME=testTdf160077_layoutInCellC Change-Id: I25e9a68f2bc096bddec6ba9d0dc1bb13a226999e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171339 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-08-08cid#1607356 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1607117 COPY_INSTEAD_OF_MOVE cid#1607089 COPY_INSTEAD_OF_MOVE cid#1606977 COPY_INSTEAD_OF_MOVE cid#1606899 COPY_INSTEAD_OF_MOVE cid#1606785 COPY_INSTEAD_OF_MOVE cid#1606769 COPY_INSTEAD_OF_MOVE cid#1606740 COPY_INSTEAD_OF_MOVE cid#1606738 COPY_INSTEAD_OF_MOVE cid#1606675 COPY_INSTEAD_OF_MOVE cid#1606533 COPY_INSTEAD_OF_MOVE cid#1558100 COPY_INSTEAD_OF_MOVE cid#1558098 COPY_INSTEAD_OF_MOVE cid#1558083 COPY_INSTEAD_OF_MOVE cid#1558077 COPY_INSTEAD_OF_MOVE cid#1558074 COPY_INSTEAD_OF_MOVE Change-Id: Ica17dec2c2102ef85283fd883a0a4e64aec307c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171620 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-08slideshow: change transition drawing view to icon viewJaviya Vivekkumar Dineshbhai
Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com> Change-Id: I109d2268824d3be233c5c7b560c1777b95aa4276 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171385 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2024-08-08cool#9735 sw lok: take LOK vis area into account when deciding idle layoutMiklos Vajna
E.g. paste into a paragraph that is part of an Arabic numbering in the bugdoc (or perform any other action that invalidates all pages), the desktop case does a synchronous layout of the visible page and does the layout for the other pages in idle. The LOK case is worse, there we do the entire layout synchronously, which can result in a 274 ms hang for the bugdoc. The root of this is that the visible area in Writer is used both to decide if invalidations are necessary for that area (this is wanted in the LOK case) and also to decide if the layout has to be done synchronously (this is not wanted in the LOK case). Fix the problem by taking the LOK visible area from SwViewShell and work with that if possible. This reduces the time spent in the synchronous layout to 4 ms. This should help the interactive editing of large Writer documents in general, but pasting into a numbering is a good example, because there you can precisely measure if just 1 page is laid out instantly or all pages. Change-Id: Ia423079c76f8d93263a023da4bfbf2a9a5ccbf33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171619 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-08-08tdf#161909: Show key type in CertificateViewer.Moritz Duge
Change-Id: I4277e342c573525dd668d0365b1d686fe33fd914 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171500 Reviewed-by: Moritz Duge <moritz.duge@allotropia.de> Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de> Tested-by: Jenkins
2024-08-08UBSan CppunitTest_sw_writerfilter_misc needs the SwXTextFieldMasters nowStephan Bergmann
...presumably since 85b2d335a4ec0af84ca4801ba04f45f0ed5a7c10 "use more concrete UNO type in writerfilter", > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_writerfilter_misc.so > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsw_writerfilterlo.so: undefined symbol: _ZTI19SwXTextFieldMasters" (<https://ci.libreoffice.org//job/lo_ubsan/3266/>) Change-Id: I312cad93ec81546bbd7c67ec725815a07378b462 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171617 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-08-08test: Refactor pixel assertionSkyler Grey
When a test fails, the line the assertion failed on is printed. Unfortunately, in the case of this assertion, it was always inside the same function. If we instead change the function to only return the pixel color, and perform the assertion inside the test, assertion failure error messages are more helpful Change-Id: Ia56da1b245882c8ddbf21ad98f69facc36d3ec3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171593 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-08-08tdf#162358 Fix missing fallback run inside grapheme clusterJonathan Clark
This change fixes an issue causing certain diacritics to be rendered as the replacement character. The root cause was failing to consistently populate fallback runs for the first grapheme cluster, when a layout begins inside a grapheme cluster. Change-Id: I7ce368c815d33b26fc05d726d4f4efd050ed9a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171607 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-08-08tdf#162211 layoutInCell: clean-up unit tests and make some pre-emptiveJustin Luth
These unit tests look good with FollowTextFlow killed. Ensure the layout, so it still looks good when FollowTextFlow is restored. make CppunitTest_sw_writerfilter_dmapper \ CPPUNIT_TEST_NAME=testLayoutInCellWrapnoneColumn make CppunitTest_sw_ooxmlexport20 CPPUNIT_TEST_NAME=testTdf128646 I tweaked tdf128646.docx's distance of the "FROM TOP" to emphasize the problem (that Microsoft mistakenly maps "page" to cell margin instead of cell frame). Change-Id: Ie7f535e4cc516411c57d5658f2b5d146b0925e16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171094 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-08-07use more concrete UNO type in writerfilterNoel Grandin
Change-Id: Ib9b78a7759b783d207fcd0f6db86ca8f95d2e7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-07cid#1557545 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1557556 COPY_INSTEAD_OF_MOVE cid#1557583 COPY_INSTEAD_OF_MOVE cid#1557587 COPY_INSTEAD_OF_MOVE cid#1557591 COPY_INSTEAD_OF_MOVE cid#1557598 COPY_INSTEAD_OF_MOVE cid#1557600 COPY_INSTEAD_OF_MOVE cid#1557653 COPY_INSTEAD_OF_MOVE Change-Id: I050bed7c088678e1d767d6edbe656eab2aee235d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-07ScriptForge - Optimize process synchro between Python & BasicJean-Pierre Ledure
Tests with non-modal dialogs and sleeping (time.sleep) Python processes show a more fluid reactivity when a Wait 0 statement is inserted before returning to Python, and this at a minimal cost. Change-Id: I6d69d0e8f2970c7e4bf440fdfa11f2ad7593ac15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171599 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2024-08-07I finally understand why we need that hackStephan Bergmann
...that 77129fbb74bcefde4551d494f029169e7c6026e3 "Emscripten: Add hack to prepare for --enable-wasm-exceptions" was puzzled about Change-Id: Iba54a77e3c2a71fe45b97795ca2da0606c3adf41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171594 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-08-07ScriptForge - Upgrade to version 25.2Jean-Pierre Ledure
Change-Id: Icc7cbdeed7685118408896c52b0415310d7b20fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171590 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2024-08-07sw a11y: Add a11y names for bg settings in side barMichael Weghorn
Set a11y names for UI elements related to the page background in Writer's "Page" sidebar deck, section "Styles." Some of those combo boxes/menu buttons are reused for multiple background types, so set an a11y name depending on the currently selected background type in C++ code instead of a static one in the .ui file for these. This allows screen readers to announce what those comboboxes/menu buttons are for when they receive focus. Lack of some of those led to gla11y failures in pending Gerrit change [1], but is actually a preexisting issue as mentioned in [2]. (The gla11y issue even showed up after simply resaving pagestylespanel.ui with glade 3.40, see CI failure for [3], a previous change doing that in preparation for this commit, but now squashed into this commit.) [1] https://gerrit.libreoffice.org/c/core/+/171430 [2] https://gerrit.libreoffice.org/c/core/+/171430/comments/6fac1506_50ddcce5 [3] https://gerrit.libreoffice.org/c/core/+/171582 Change-Id: I4e78c61cfd5d5b9f198887eec53be368cb6a0716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171583 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-08-07tdf#162121 sw: fix tab stop position in columned ToXMichael Stahl
There is a SvxTabAdjust::End but this only exists in the definition of index entry templates, it is not possible to set this on a tab stop on a text node. So the ToxTabStopTokenHandler converts this into a SvxTabAdjust::Right tab stop with a fixed position. DefaultToxTabStopTokenHandler::CanUseLayoutRectangle() has inverted condition but that doesn't matter because there are no layout frames at that point. (regression from commit 3aca57fb9c7c979d971cae6bb3ad73c6dc412685) The main problem is that getting the with from the layout rectangle never works because there's no layout frame, and the alternative only takes into account the page dimensions and not any margins of the section, columns, or gap between columns, not to mention that the ToX could also be in a table etc. Refactor this so that the tab stops are set only after all the layout frames are created. An unfixable problem remains in case the ToX has columns of different width. The wrong tab positions are problematic if TabOverMargin is enabled since commit 10d753b8aadb50ec4309551b97d4cf2163ea3e3d Change-Id: Ia712c9bf42b2518e396f1b9e7efd65869ebc5ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171585 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-08-07tdf#130857 qt weld: Implement newly added 'escape_ui_str'Michael Weghorn
Implement actual Qt-specific handling in `weld::QtInstanceWidget::escape_ui_str`, newly added in commit ee749f4b43fea3b666c9c3613b232bc8fecf73fa Date: Tue Aug 6 16:47:30 2024 +0200 add polymorph function for VCL/ui specific string escaping For a sample use, see also commit fb56e1e284925937eff4386a7e3655c0f3182640 Date: Wed Jul 31 22:25:01 2024 +0200 tdf#161909: Escape filepaths for password dialog. (See also `vclToQtStringWithAccelerator`, but which would result in the accelerator character '~' to be preserved/converted as an accelerator, which is unintended here.) While at it, also fix a typo in the doc. Change-Id: Ic557a1aa8c6b46257a231627d817f1f7e1d101cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171586 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-07sw: fix typo in SwLayAction::InternalAction()Miklos Vajna
Went wrong in commit d491791dad8c3a946dac8c4dfd28ef0c4cb65ce5 (Fix infinite loop in sw_ooxmlexport17 unit test on macOS Intel, 2022-12-13). Change-Id: I4e35702e69016c854d7a17d64c71f07be8d09705 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171588 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-08-07no need to do lookup hereNoel Grandin
when we have just created the object, we already know what it is Change-Id: I79ccc178219ff32a1c88ce7a0b2f4948a6bd4dbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171567 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-07cool#9654 fix: Skip invalidation if it won't go throughSkyler Grey
On Android, we often hit this condition where we should get an invalidation. Unfortunately, the invalidation is skipped due to being in LOK Tiled Painting, leaving us to deal with whatever tile was rendered on this go-around... ...Also because of this condition, the tile rendered here is broken. pFrame->PaintSwFrame is never called, leading to a tile which renders without things like its text. Normally, this wouldn't be a problem as it's about to get invalidated, and is more of a nice performance optimization... ...However given we don't invalidate it, we really see that tile without any text. Similar workarounds were considered (such as skipping the condition in another case that appears to be true on Android or rendering the tile anyway, even if we're about to invalidate it) but this seems to be the safest bet to avoid something like this happening on other platforms... ...The true solution is still elusive. It probably includes figuring out why this happens on Android without happening on other platforms, and fixing that, as well as perhaps figuring out what to do about this condition if we *do* genuinely trigger it on Android - as the previous solution of invalidating everything nearby won't work Change-Id: Id58f5bae8ae357d116c5f2345e88ec3364cb2172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171578 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-08-07simplify bookmark name calculationNoel Grandin
Change-Id: I19a55158b50ac8b8a66e74484d0dc4b531729de2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-07simplify IMark hierarchy (11)Noel Grandin
The only thing using findFirstBookmarkNotStartsBefore is code that is only interested in Bookmark's, so change the name and return type, and use the m_vBookmarks vector, which is much more efficient. Change-Id: I7f7e6f98b9b7851756c06e57f1cd18cee98713d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171565 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-07simplify IMark hierarchy (10)Noel Grandin
use more type-safe container for AnnotationMark, which also avoids some dynamic_cast Change-Id: I1b1d44f81f2a3d626a1f13fbe952eecd1ea0390a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-07tdf#161909: Escape filepaths for password dialog.Moritz Duge
For example needed for underscores which are removed by VCL=gtk3 when interpreted as mnemonics. Change-Id: Ic80b64efc81ab5a219b1db1395974a4b59c46833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171497 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-07add polymorph function for VCL/ui specific string escapingMoritz Duge
Change-Id: Ie896a1050158acc85f66b8705812e5f6b9717070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171509 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-08-07simplify IMark hierarchy (9)Noel Grandin
use more type-safe container for Bookmark, which also avoids some dynamic_cast Change-Id: I0d2d94e1f6d4129a6e5edde797c042cab6230bac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171563 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-08-07cool#9704 calc jsdialog autofilter send disabled entry informationJaume Pujantell
Added the code necessary to disable already filtered entries on jsdialog autofilter, like it is done on desktop UI. Change-Id: I095b7fe0054efcaff2717d05a2ab7bd1d8248b29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171246 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 2815d11bb608a933e14b799cc802825423426d28) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171530 Tested-by: Jenkins
2024-08-07use more concrete UNO type in writerfilterNoel Grandin
Change-Id: I2b8519f3b07e825ad236cca2cd4028f93c1cb168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-08-07tdf#130857 qt weld: Implement QtInstanceWidget::get_clipboardMichael Weghorn
Like the gtk3 implementation, simply return the system clipboard. Change-Id: I643b31163954f2648b3bbee74397fc23c616ddef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171561 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-08-07tdf#130857 qt weld: Implement {s,g}et_tooltip_textMichael Weghorn
Change-Id: I02ab861a9e82840c62bbb61ba53a699881519796 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171560 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-07tdf#130857 qt weld: Implement QtInstanceWidget::{show,hide}Michael Weghorn
Change-Id: I557ef20ef0a4d173e5a54a4a568f1ebb127c072e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171559 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-08-07tdf#130857 qt weld: Implement QtInstanceWidget::has_child_focusMichael Weghorn
Change-Id: I97ac73943969ecb8f1f189adc1cf4b5c4b052fd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171558 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-07tdf#130857 qt weld: Implement QtInstanceWidget::is_activeMichael Weghorn
For now, let it be the same as `QtInstanceWidget::has_focus` as there seems to be no direct equivalent, and the comment in weld.hxx also questions whether there is much value in having two different methods: // return if this widget has the keyboard focus within the active window // TODO: review if this has any practical difference from has_focus() virtual bool is_active() const = 0; Change-Id: If90377d734a6c721c369a2d206c0e6122ac61853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171557 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-07tdf#130857 qt weld: Implement focus-related methodsMichael Weghorn
Change-Id: I064ff205ceb9d008667cf3a3a6e73047ea5ca3e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171556 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-07tdf#130857 qt weld: Implement QtInstanceWidget::{get,is}_visibleMichael Weghorn
Implement according to the comments in include/vcl/weld.hxx: // return if this widget's visibility is true virtual bool get_visible() const = 0; // return if this widget's visibility and that of all its parents is true virtual bool is_visible() const = 0; Change-Id: Ic3a6193b04094331ec3818620c078269409c4fad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171555 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-08-07tdf#130857 qt weld: Implement QtInstanceWidget::{g,s}et_sensitiveMichael Weghorn
In a quick test, this makes the "More" button in the dialog from the tdf#162351 use case to become insensitive (i.e. greyed out) as expected with this additional local change applied for testing: diff --git a/dbaccess/source/ui/dlg/sqlmessage.cxx b/dbaccess/source/ui/dlg/sqlmessage.cxx index 07891f773cfd..ad06210c8149 100644 --- a/dbaccess/source/ui/dlg/sqlmessage.cxx +++ b/dbaccess/source/ui/dlg/sqlmessage.cxx @@ -509,6 +509,7 @@ void OSQLMessageBox::impl_addDetailsButton() m_xDialog->add_button(GetStandardText(StandardButtonType::More), RET_MORE); m_xMoreButton.reset(m_xDialog->weld_widget_for_response(RET_MORE)); m_xMoreButton->connect_clicked(LINK(this, OSQLMessageBox, ButtonClickHdl)); + m_xMoreButton->set_sensitive(false); } } Change-Id: I0b7a21364eddb707435a796c54b274ff438f8063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171553 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-08-07tdf#162351 tdf#130857 qt weld: Handle button clickMichael Weghorn
In `QtInstanceButton`, connect the `QPushButton::clicked` signal with a newly introduced slot that calls `signal_clicked` from the `weld::Button` base class, which calls the click handler. With this in place, clicking the "More" button in the dialog shown when following the steps from tdf#162351 now actually results in an "Error Details" dialog with more information to show up. Change-Id: I6df43af3ad3bf35b94e712aaaf0158bd7ab57907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171552 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit (git 2.34.1) at 2025-02-22 08:01:37 +0000