summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-03tdf#116815 Draw UI: remove presentation-only stuffJustin Luth
These items are not saved or imported into Draw, so remove them from the UI interface. They are just inherited from Impress. Specifically: -Display Master Background -Display Master Objects -Master Elements This patch removes these 3 elements in Draw from: -sidebar page properties -main traditional menu -Tabbed Notebook bar's layout tab, and the tab's Layout menu, and when viewing master - context tab -Compact Notebook bar's layout tab, and the tab's Layout menu, and when viewing master - context tab -Single Notebook bar's master context view -Compact groupped bar's Page menu (even though it isn't visible.) Change-Id: Ibae57bfec18cd44e9a76e6847a4c5215945b64ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107002 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-03Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 37d03e7d61caa560373268675ad87d91242bce05 - tdf#131416 Basic Syntax Diagrams - the end + Beep + MkDir + RmDir + Stop + With Note: Basic functions are not provided with a syntax 'diagram' as their syntax is conventional. Change-Id: I36e37947f8982dd0f27241e6a76edc84572bc636 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/106947 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-12-03Related: tdf#138360 Use approxFloor() in rtl_math_round()Eike Rathke
Ditch mostly but not always working correction value and use approxFloor() instead which yields better results. With this we now have one single place approxValue() in case more fine grained tuning is needed. Unfortunately all numeric spreadsheet function tests use ROUND() in a manner such that they mostly blindly do a ROUND(...;12) regardless of magnitude, sometimes effectively rounding to the 14th significant digit that may fail in cases like for 14.2040730851385 ^ where the constant (rounded) value is stored as is but the calculated value is 14.204073085138471 and the old round() yielded 14.204073085139 for both but the new round() more correctly results in 14.204073085139 and 14.204073085138 so the spreadsheet test case sources had to be changed to ROUND(...;11) in such places. Change-Id: I211bb868a4f4dc9e68f4c7dcc2a187b5e175416f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107135 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-12-03There is nothing called "Quartz layer"Tor Lillqvist
We mean CGLayer, so say so. Change-Id: Iaa24471ce790114dc5cf2bbf353f9aa4a1d59893
2020-12-02tdf#138596: sw: Add UItestXisco Fauli
Change-Id: I59b78fe12e1c95e23ac3f7145ca802375ba98cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107081 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-02SwTableBoxFormat: Modify no moreBjoern Michaelsen
Change-Id: I02775fa3ac4cdc01ed89e969449ec96427de30db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107008 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-12-02ToD previews resize to 150px to fit into preview areaandreas kainz
Change-Id: Ia0f4215d82348f96856364710fbfef87d54eb960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107054 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-12-02tdf#138596 don't destroy SfxItemSet that are still in useCaolán McNamara
update the existing ones instead Change-Id: I67fd6c4ecb5d4294efae0262d558281e6840b5dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107079 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02tdf#46579: fix form fields 'Image Button' in FormsJulien Nabet
urls have this form: .uno:FormController/moveToFirst .uno:FormController/moveToPrev etc. So we must use these links for hyperlinks + interceptor with ControlFeatureInterception Change-Id: I9cff19833d859624239ca6c76152cc88f9cbb278 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107037 Tested-by: Jenkins Reviewed-by: Lionel Mamane <lionel@mamane.lu> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-02tdf#137576 Improve cell anchored measure line in CalcRegina Henschel
Measure lines do not always have a logic rectangle. It might be empty or the 1cm x 1cm default square. But Calc needs it to calculate NonRotatedAnchor. The latter is needed for cell anchored shapes when saving in ODF. Always generating a logic rectangle in class SdrMeasureObj is difficult (I got crashes in Draw) and not necessary. Calc now forces the calculation of the logic rectangle where it is needed by Calc. Change-Id: I8689bc95985db1619eb5e72df99901bd52086cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106990 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-12-02external/firebird: Fix checks for null HANDLE in Windows-only codeStephan Bergmann
Change-Id: I428bbdae91eaf69df43ae054a95e8da3fb1aa7dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107056 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-02Remove odd comment about MINGWSTRIP from m4/READMEStephan Bergmann
...which had been added with 4aed4f436cf8e4b0f3f034dfb1d1025b05a61f0a "add a README files", at a time when there was a m4/mingw.m4 file (even though that did not mention any "MINGWSTRIP") that has meanwhile been removed with 8646ab97dc37c0606b19057686bf3d610f9c15ee "Remove MinGW support" Change-Id: Icd94a9a971f425125a23b692a43f8a958ca3a2c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107078 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-02cid#1371301 silence Missing move assignment operatorCaolán McNamara
and cid#1371215 Missing move assignment operator Change-Id: Id19cccd50b2cf378cc3b645d5a16d233f8985550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02cid#1470369 Uninitialized scalar variableCaolán McNamara
and cid#1470372 Uninitialized scalar variable cid#1470364 Uninitialized scalar variable cid#1470363 Uninitialized scalar variable cid#1470359 Uninitialized scalar variable cid#1470357 Uninitialized scalar variable cid#1470355 Uninitialized scalar variable cid#1470354 Uninitialized scalar variable cid#1470353 Uninitialized scalar variable Change-Id: I4a28f0f375f9108f4c43da7074f85d1fdbb3ebff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107070 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02tdf#66043 sw: fix spell checking of word with deletionLászló Németh
Correct words were underlined as spelling mistakes, if they contained tracked deletions, related to the unwanted CH_TXTATR_INWORD characters (result of removing tracked deletions) at calling spell checking API functions. Fix it by checking the "invalid" words without CH_TXTATR_INWORD characters, too. Change-Id: I6d8a8d619a571dfb613991cb8cf67faab57de4c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106988 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-02related: tdf#127086: PPT: export custom shapes as BitmapXisco Fauli
this way the cropping is kept after roundtrip found while working on fix for tdf#128501 Change-Id: I5cf023b469407d5a70d83cbb5b499b2a1d6310e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107051 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2020-12-02tdf#128501: DOC export: fix lost bitmap fill for OOXML custom shapesXisco Fauli
this fix is based on 7032be2e9edd82dad2d67f1582aaa57676bda4a1 which fixes the same problem for PPT filter Change-Id: Id62c29892dd3fce42d27e2e46a7933154cb973f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107003 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-02tdf#129961 svx: add rendering for table shadow as direct formatMiklos Vajna
There was already shadow support in ViewContactOfTableObj::createViewIndependentPrimitive2DSequence(), but the UNO API and UI could only set the shadow properties on a shape style, so shadow-as-direct-format is new. One difference between the PowerPoint shadow and our shadow is that we draw shadow for table text as well, while PowerPoint only does it for the borders / cell fill style. This means we're either backwards-compatible or compatible with PowerPoint. Solve this problem by leaving the style case unchanged, but render direct formatting like PowerPoint. Change-Id: I2bc64fea8062f9d8162b95d1eaccb49c3466b5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107073 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-02Resolves tdf#137481: Changes the "Formula" labels in Writer/Calc/Draw/ImpressRafael Lima
Change-Id: Id64be29854dd23b8022861dd9fb0b97f5fc34603 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105813 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-02Resolves tdf#137547 CharmapCtrl label depending on recent charsShyamPraveenSingh
Label shows now "No recent characters" if none has been used Change-Id: Ica3e4da077758ce848775eaa9b658f8322278b47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106557 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-02ofz#27839 TimeoutCaolán McNamara
use sal_uInt32 and truncate to limit instead of using sal_uInt16 Change-Id: I454fcf23ff272069f8e4499b1ce9674cfb8e4564 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02cid#1470356 silence Dereference null return valueCaolán McNamara
Change-Id: I3df9ce0695531714236025a041c1f4cd46cf7d1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02tdf#138540 formula popover in the wrong placeCaolán McNamara
since... commit e087e25f05e689091cbf1c4f91b6e93878ac17ec Date: Mon Oct 5 14:19:05 2020 +0100 weld InputBar Change-Id: Ib19aa088e9f593046e611d8ec4afe33b65c1b7fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02Doubled code correctiondante
Change-Id: I391cb0f51788034e358889bb4aaf38c3824cac2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107010 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02Update git submodulesAyhan Yalçınsoy
* Update helpcontent2 from branch 'master' to 845da7694bd6e444db9cea206ccd15bd21e97921 - tdf#137720: Help files-Page Setup replaced with Page Properties Change-Id: I131e80d08076fd2d7d198a65e4fb7cb77acc16f8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107029 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-12-02fastparser in XMLTableHeaderFooterContextNoel
Change-Id: I739ed833e8a23173561f2f843909a0eedb6b87ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-02Add copyright blurbTor Lillqvist
Change-Id: Icd77587590103eef44f7ec41fcba280b7ce2a473
2020-12-02Add a script to merge two single-arch macOS app bundles into a universal appTor Lillqvist
Change-Id: Ifb2a7382a38d207878c901bdaab51bc1c00e3891 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107071 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-02tdf#136957 Use bigger dots for better handling in presentation mode.Gülşah Köse
3 pt bigger dots are used. Human eye can't catch this change so we will see same dots in edit mode and presentation mode. Change-Id: I4a56406f4eb7a6832075a09a4d2f092bd689e9cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106855 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-12-02mariadb-connector-c: enable WNT-only pvio_npipe/pvio_shmem pluginsMichael Stahl
They were already compiled in some way. Change-Id: Ic1b8563a53bad5be03bce2c0d3d2cf841e303f02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107007 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-02Fix placement of @since tagStephan Bergmann
...following up on e3f8e1260ac42b680e79bf50b2645957916d34e0 "Corrections on xfasatparser IDL file." Change-Id: I9f8ca5d38cc085256fe264ad6aedb5e15a80a213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107052 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-02fastparser in SvxXMLTextImportContextNoel
Change-Id: I702a77ea17ee80270d257e10f56a91b026800e1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107048 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-02tdf#138345 ms formats Char highlight: no import into char-styleJustin Luth
MS Word ignores w:highlight in character styles, so don't import it. RES_CHRATR_HIGHLIGHT only exists in LO in order to support Microsoft's terrible idea of allowing two different attributes to define char background colour. So it should be safe to remove it from UNO. Change-Id: Ia2ee0bd61ee59dfa864e946024c8184747aa2b40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106183 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-02make debug output for vcl::Region also print tools PolyPolygonLuboš Luňák
I implemented operator>> for tools PolyPolygon in 5553bb974a44721e, so it can now be used here instead of printing "unimplemented". Change-Id: I7542ab2e24613eee464eb8086142fd596ca7aad3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106998 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-02Typo in rounded digit string, tdf#138360 follow-upEike Rathke
Change-Id: Ic436d3e9f0c93cb36c5e4377519f2aeb6b7fbd5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107034 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-12-02Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 256943b5885310416bf7422e132dc94ce1d78f7f - tdf#138389 improve Y-M-D pattern and add two-digit year explanation Change-Id: I677899a9a439a49aedbdf794a5a058d9595da2f9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/107020 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-12-02tdf#135202 mariadb-connector-c: enable native_password pluginMichael Stahl
... and remove dialog authentication plugin; it quite uselessly defaults to asking for a password on stdin, unless a function symbol is defined by the library that links the connector static library. There are more authentication plugins but no idea if those are needed. Change-Id: I88ee9629e4763fb548c3f294b552cff3d739e6cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107006 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-02pdfium: add width/height/format wrappers for bitmapMiklos Vajna
Change-Id: Ic8c85c4224b89d1e7bb8ded1a11c5fd8139f5701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107044 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-02Partially resolve: tdf#113286 Add https:// to URL in Crash ReportSeth Chaiklin
Also: "Don't" --> "Do Not" in another button label Change-Id: I320a2f3fbe1ad1d2ac3efff94c0195be15335a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107018 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-02tdf#138427 focus set to wrong input boxCaolán McNamara
Change-Id: I4c1d3aa720f280f0ec1a3764d55f1d95ebd3180d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02tdf#138471 wrong adjustment used for spinbuttonCaolán McNamara
resulting in one adjustment used by two spinbuttons Change-Id: I939b00301699288fd8516cb7d6b8cd11c53c9573 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106992 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02move the callbacks to be privateCaolán McNamara
Change-Id: I75a786d379ce1ea80acef90b9574d2901e046f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106993 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-02pdfium: introduce an enum class for path segment typesMiklos Vajna
Towards not including fpdf_edit.h in PDFiumLibrary client code. Change-Id: Iffdd11b0613399f31a3ed383c22b7a91059b83de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107011 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-02fastparser in XMLChangeElementImportContextNoel
with the help of a fallback method for CreateTextChildContext Change-Id: Ic74ad8e74a4763906ae58a9064ecd54c5b9075ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107043 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-02Guard against sysconf(_SC_OPEN_MAX) returning LONG_MAXTor Lillqvist
That seems to happen in a sandboxed process on macOS, at least. This caused an apparent hang when invoking Python, for instance simply through Tools > Macros > Run Macro... . Change-Id: I6bc055b44f298251ed596084538b98442c215fce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107013 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-12-02Removed triplicated includesAndrea Gelmini
Change-Id: I91af264306ac7a61c90bf46df0560448b7d2285d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106981 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-12-02external/python3: Silence UBSan errors with --with-pydebugStephan Bergmann
...that happen when building ExternalProject_python3 itself after 12142490cd43f8568ab29e0ddfa75b334d6d39d5 "Enable Python Py_DEBUG setting when built with --enable-dbgutil on Linux": For one, silence > Modules/posixmodule.c:14395:9: runtime error: left shift of 34 by 26 places cannot be represented in type 'int' > #0 in all_ins at workdir/UnpackedTarball/python3/./Modules/posixmodule.c:14395:9 where at least my kernel-headers-5.9.9-200.fc33.x86_64 /usr/include/linux/memfd.h has > #define MFD_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB and /usr/include/asm-generic/hugetlb_encode.h has > #define HUGETLB_FLAG_ENCODE_16GB (34 << HUGETLB_FLAG_ENCODE_SHIFT) For another (and as predicted in 29d47d22c43e6adc1850b7db5880028dcd07d1b3 "Fix passing --disable-optimized into external/python3": "in a Linux UBsan build, making ExternalProject_python3 would have started to cause some 'applying zero offset to null pointer' failures, but which would have been easy to fix"), silence > Objects/listobject.c:551:24: runtime error: applying zero offset to null pointer > #0 in list_concat at workdir/UnpackedTarball/python3/Objects/listobject.c:551:24 Change-Id: I0523cd35e393000c8e67629a0522b2db1d8c16f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106984 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-02simplify SvtDynamicMenuOptionsNoel Grandin
just use the struct instead of passing around sequence of sequence of PropertyValue Change-Id: Ic03c066962a10daac6f83f30413a5ab09e1bfd5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106915 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-02We should mention product name here together with version, tooMike Kaganski
Change-Id: Ia0da1511c242bb4638c7853e043f96895a65fcbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107019 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-12-02Corrections on xfasatparser IDL file.dante
- Removed uneeded include - Added @since tag Change-Id: I8afd7b59afe6af3dc8cc0bd482c0017611671424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107035 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>