summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-09loplugin:constfields in sdextNoel Grandin
Change-Id: Ief438d98b8117a7759282323e47c8b5283d6762a Reviewed-on: https://gerrit.libreoffice.org/61552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09Related: tdf#83128 support translation of plural formsCaolán McNamara
Change-Id: Id3d41099a895ca5423be2ac3d497851bc65eaff7 Reviewed-on: https://gerrit.libreoffice.org/61426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09tdf#120318: remove autofilter for the momentJulien Nabet
Before adding it the entry again, please implement it and test it. See comments of the tdf. Change-Id: I64a5729baf589dbd188b6e8fcd5075112e5a7da7 Reviewed-on: https://gerrit.libreoffice.org/61558 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-09tdf#120341 OOXML export: fix export of Pie Chart Wall BorderlineBalazs Varga
Export LineStyle_NONE instead of default linestyle of PlotArea border, because LibreOffice make invisible the Wall shape properties in case of PIE/NET/FILLED_NET charts. Or other solution in the future is set the default LineStyle of these charts to LineStyle_NONE. Change-Id: I59e6f18058713f4a0d4c77da8760a319f9c25152 Reviewed-on: https://gerrit.libreoffice.org/61547 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-09tdf#119993 sw: clear the font cache text glyphs on table col changeMiklos Vajna
This helps not storing pre-computed vcl text layouts which are most probably never re-used anymore. Approximate numbers for memory usage with 10 column resizes for the bugdoc: - old: 310MB -> 454MB - new: 309MB -> 310MB Change-Id: Ifb88b88e1bffe2c2670089930fc2d22ff19576ce Reviewed-on: https://gerrit.libreoffice.org/61562 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-09cppcheck: useInitializationList in editeng ...Jochen Nitschke
and remove some indirections Change-Id: I94088030084683c1a24f904da1c42a01f24f47ce Reviewed-on: https://gerrit.libreoffice.org/61561 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-10-09loplugin:constfields in scaddins,sccompNoel Grandin
Change-Id: I4d21cfcc65c099fbddbe5146fc1b8a6257971e32 Reviewed-on: https://gerrit.libreoffice.org/61555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in sdNoel Grandin
Change-Id: Ia072401c71dacf089b9f5213957c2cd25bb1a1b3 Reviewed-on: https://gerrit.libreoffice.org/61553 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in shellNoel Grandin
Change-Id: Ib30c45bddcc58fcd0fec8b160eb925349e801df7 Reviewed-on: https://gerrit.libreoffice.org/61551 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in sfx2Noel Grandin
and we find that bSplitable in SfxDockingWindow is always true, ever since commit 4bd28a2fee0d36c67911019eeb7d934838e27cad Date: Tue Jan 29 15:27:40 2008 +0000 INTEGRATION: CWS fwk82_SRC680 (1.45.138); FILE MERGED so we can remove all of the non-splittable code there. ` Change-Id: Ia7fe607ed02d1a7c69a92bab57e220b19f0e6e87 Reviewed-on: https://gerrit.libreoffice.org/61550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in smoketest..sotNoel Grandin
Change-Id: I59ceda8ff85cc7b348882a6e1c62491b74297801 Reviewed-on: https://gerrit.libreoffice.org/61549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in slideshowNoel Grandin
Change-Id: Ieeda808ad8e7fe500a2142c779529ca190725f6a Reviewed-on: https://gerrit.libreoffice.org/61548 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09use unique_ptr in SdrUndoGroupNoel Grandin
Change-Id: I569c56b6114e07b2a227ad0f906c1a5188a94af4 Reviewed-on: https://gerrit.libreoffice.org/61528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09use unique_ptr in ParaPortionListNoel Grandin
Change-Id: I3d730007ba25740282091f0f3db8ffb90d5de367 Reviewed-on: https://gerrit.libreoffice.org/61527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09Qt5: fix build with Qt 5.11Jan-Marek Glogowski
And while at it annotate Qt5Font fall-throughs. Change-Id: I31a73407f3228f303236983df17c66bc88eef6c5 Reviewed-on: https://gerrit.libreoffice.org/61557 Tested-by: Jenkins Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-09tdf#55361 fix result of showing RTL text in the animation.Mark Hung
Call drawTextArray with SalLayoutFlags::BiDiRTL if the text direction of a TextLayout is RTL. Change-Id: I1a3bfaee5521eea77b44350c21c104cbf72fac97 Reviewed-on: https://gerrit.libreoffice.org/61460 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-10-09tdf#55361 adjust leftmost position for RTL text while animation.Mark Hung
Set the leftmost position correctly based on logical advancement values of XTextLayout to render the substring of a RTL text. Change-Id: Ib65b433105274f6ebfd251e92d831f1b28516294 Reviewed-on: https://gerrit.libreoffice.org/61459 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-10-08tdf#120061 Enable Navigator multiple headings selectionJim Raykowski
...on document reopening when Navigator window was previously in Headings/Outline Content Navigation View mode Change-Id: I169df15e81c4e9acf24c0e76d7f720af598c5b93 Reviewed-on: https://gerrit.libreoffice.org/60910 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-10-08cppcheck: variableScope and fix index typesJochen Nitschke
Change-Id: I045b4d84e0ad07a98523b91fc7203bfd422b3529 Reviewed-on: https://gerrit.libreoffice.org/61541 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-10-08replace double-checked locking patterns with thread safe ...Jochen Nitschke
local statics. Change-Id: Iab4963a04d15f06e9b1a36079a36d32453e09c8f Reviewed-on: https://gerrit.libreoffice.org/61538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08tdf#58944 DOCX import: workaround for hidden table headersLászló Németh
Repeating table headers consisted of more than 10 table rows switch off table header repetition during DOCX table import to fix non-visible table content and broken tables. Repeating header lines are not visible in MSO, if there is no space for them. OOXML (and ODF) standards don't specify this exception, and unfortunately, it's easy to create tables with invisible repeating headers in MSO, resulting OOXML files with non-standardized layout. To show the same or a similar layout in LibreOffice (instead of a broken table with invisible content), we use a reasonable 10-row limit to apply header repetition, as a workaround. Later it's still possible to switch on header repetition or create a better compatible repeating table header in Writer for (pretty unlikely) tables with really repeating headers consisted of more than 10 table rows. Note: This workaround could help to create standard and more portable OOXML files in a mixed environment. Change-Id: I17fbc0173ec1c4f188a46227b99dde5726530da3 Reviewed-on: https://gerrit.libreoffice.org/60689 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-08Missing includeStephan Bergmann
Change-Id: I5cb4fad28312e3ab28f26d7e12169d6db25e3758
2018-10-08tdf#120271 related: Allow finalizing of LastTimeGetInvolvedShownMike Kaganski
This avoids abort() on modifying the setting in case it's finalized Change-Id: I5982a4d7bf867301d7ba0e7e0dbb3f7c87013134 Reviewed-on: https://gerrit.libreoffice.org/61430 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-08desktop: move font initialization into preloadDataAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/57160 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit bbba0902fc1f1c6bb2a7f1e6ff2b682e2fbd3cc9) Change-Id: I66840512b45e987cc7b08b07b65bdb24f2023a41
2018-10-08desktop: move dictionary preload before font initAron Budea
spell-checker is initialized during font init since e7f65920b12517b31f0c5cbfd0dcb8df96d20ba4 Change-Id: Ia5b5223aa8cc00d0e80451142ae18a7046ad00d4 Reviewed-on: https://gerrit.libreoffice.org/57064 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2018-10-08desktop: initialize fonts in pre-initAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/56573 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit e7f65920b12517b31f0c5cbfd0dcb8df96d20ba4) Change-Id: I5a3acc41196c7e0672514fa2dae00e5fc0f76a1f Reviewed-on: https://gerrit.libreoffice.org/61492 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-10-08Run GarbageCollect() for freetype fontsJan-Marek Glogowski
Restores wrong hunk removed in commit dd36db168c65 ("UNX use font cache based glyph rect cache"), so we actually run the font based garbage collect. Just the glyph based one is gone. Change-Id: I30b4f9987d21764398ac00cf24968aa65aff8fc0 Reviewed-on: https://gerrit.libreoffice.org/61536 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-08cppcheck: variableScopeJochen Nitschke
Change-Id: I56b06b4c69bdb501535a43780b6a10d5ceb0c7da Reviewed-on: https://gerrit.libreoffice.org/61524 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-10-08Fix loplugin:useuniqueptr for libc++ (macOS)Stephan Bergmann
...after 05a337e297eb0cfe88c99503d760bd9eaf495b7d "loplugin:useuniqueptr look for deleting in loops with iterators", where it didn't emit the warning for Foo24 in compilerplugins/clang/test/useuniqueptr.cxx during CompilerTest_compilerplugins_clang, because in the initialization of HTMLAttrs::const_iterator it = m_aSetAttrTab.begin(); the HTMLAttrs::const_iterator CXXConstructExpr happens to have a second, defaulted argument. Change-Id: I882a6dfb5cab1b147f790072f2545b13172c0f9a Reviewed-on: https://gerrit.libreoffice.org/61530 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-08Fix emfio_wmf_test VCL dependencyJan-Marek Glogowski
This unit test sometimes fails on Windows with the message: "no suitable windowing system found, exiting." Currently the test just depends on desktop_detector and manually sets up VCL duplicating a lot of code and even library symbols. The original Gerrit change describes a lot of failures in its comments (change 28322, version 16). Now that Windows and MacOS were converted to VCL plugins, depending on desktop_detector is not sufficient anymore. This reverts a lot of VCL test setup from commit 20f6a6b159c6 ("tdf#99402: fix Metafile Font handling"). Seems now a simple gb_CppunitTest_use_vcl is enough. Change-Id: Ia941ded91358231021741ff4a5d96e2014ac6c80 Reviewed-on: https://gerrit.libreoffice.org/61497 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-08Added date time transformations - follow-upVikas Mahato
Change-Id: I130feda7c835b067a542736ad6fadc79cabc4f41 Reviewed-on: https://gerrit.libreoffice.org/59413 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-08tdf#108064 OOXML export: convert LO preset dashes to equivalent MSO presetsAdam Kovacs
Change-Id: I967dfdc6a49cf04d98ea9fa9b57bf4669126a585 Reviewed-on: https://gerrit.libreoffice.org/61417 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-08tdf#120363: try to avoid asking user to enable JVM when looking ...Mike Kaganski
... for a provider for an operation. When another provider actually handles an operation, it's useless to ask user to enable disabled JVM just to learn that it doesn't handle the request. So, this patch does the MasterScriptProvider operations in two steps: first with "Enable JVM" interaction disabled, and if failed, again with the interaction enabled to try disabled providers. This shouldn't typically give performance penalties in case when JVM is enabled, and when it's disabled and the operation is addressed to another provider. A context class designed to disable "Enable JVM" interaction is moved from cui/source/customize/cfgutil.cxx to a new comphelper header, which is supposed to hold similar helper context classes in needed. Change-Id: I21be922bfd80a276d9c8f1215d62a47bb3c225f5 Reviewed-on: https://gerrit.libreoffice.org/61468 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-08Fix undefined css::uno::Reference<css::uno::XComponentContext> dtorStephan Bergmann
...when compiling desktop/source/app/crashreport.cxx, after 2a962cb122f796aef9a10252ab224f5cd70569cf "tdf#42949 Fix IWYU warnings in include/comphelper/[m-z]*" Change-Id: Icefe8f8d0a10ed6357daf0530afc01598dd99e22
2018-10-08cppcheck: duplicateExpressionTernaryJochen Nitschke
HTML_FRMOPTS_MULTICOL_CNTNR is the same as HTML_FRMOPTS_MULTICOL since commit 7b0b5cdfeed656b279bc32cd929630d5fc25878b Date: Mon Sep 18 16:15:01 2000 +0000 initial import in htmlfly.cxx Change-Id: I54d04b77f4f281205d3ca89f36c12ff34ba12c12 Reviewed-on: https://gerrit.libreoffice.org/61522 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-10-08cppcheck: knownConditionTrueFalseJochen Nitschke
Change-Id: I245a353b69af7dcedf4c0f3f1271f1fdf86fd09c Reviewed-on: https://gerrit.libreoffice.org/61523 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-10-08Try to manage without curl on non-desktop platforms (iOS, for me)Tor Lillqvist
We don't build curl for iOS. (Don't remember why exactly, but anyway, this persona thing is surely a feature relevant for desktop platforms only, and certainly not a good reason to start building curl.) Change-Id: Ia2acebe77a0acb9dbf5858e6524c444e772ac8c8 Reviewed-on: https://gerrit.libreoffice.org/61520 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-10-08tdf#42949 Fix IWYU warnings in chart2/source/model/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic4fdbad7469d506d7cf308cb96f069b781dd1f58 Reviewed-on: https://gerrit.libreoffice.org/61488 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-08Fix typoAndrea Gelmini
Change-Id: I204fb88d7c5e45efd97dc8e3f6e584b12fba879b Reviewed-on: https://gerrit.libreoffice.org/61521 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-08Work around odd macOS 10.14 graphicsContextWithWindow failureStephan Bergmann
When running on macOS 10.14, both master and libreoffice-6-1 (at least) started to fail CppunitTest_vcl_bitmap_render_test with > /Users/stephan/Software/lo2/core/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx:90: Assertion > Test name: BitmapRenderTest::testTdf113918 > equality assertion failed > - Expected: mcBlueOrIndex: 255, mcGreen: 255, mcRed: 255, mcAlpha: 0 > - Actual : mcBlueOrIndex: 1, mcGreen: 112, mcRed: 15, mcAlpha: 0 in --enable-debug/--enable-dbgutil builds. I tracked that down to the OSL_DEBUG_LEVEL>0--only call to Scheduler::ProcessEventsToIdle in test::BootstrapFixture::setUp (test/source/bootstrapfixture.cxx). If that call is also included in non-debug (i.e., OSL_DEBUG_LEVEL=0) builds, or if it is removed from all builds and instead an unsuspecting [NSApp nextEventMatchingMask: 0 untilDate: nil inMode: NSDefaultRunLoopMode dequeue: NO]; is added directly before the call to pVDev->SetOutputSizePixel(Size(2480, 3508)); at the start of BitmapRenderTest::testTdf113918 (vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx:76), the test always fails. What happens is that, after such a nextEventMatchingMask call done, the call to NSGraphicsContext graphicsContextWithWindow in AquaSalVirtualDevice::SetSize (as called from the SetOutputSizePixel call in the test) returns nil, for unclear reasons. Until those underlying reasons are understood, change the code of SetSize to "fall back to a bitmap context" also in case the graphicsContextWithWindow call returned nil. Change-Id: I604ebd2c444b58610e4ed73ec70af87b0a08e864 Reviewed-on: https://gerrit.libreoffice.org/61519 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-08tdf#120362: Don't ask user to enable JVM when enumerating scriptsMike Kaganski
Since it wasn't an explicit user's intention to run something that requires JVM, asking to enable it in case it's disabled is nonsense, and it happened every first time in a LO session when user wanted to start e.g. Basic macro using Tools->Macros->Run Macro... tool. Change-Id: I5afae804e183c185472d41a2d419ec80b7955110 Reviewed-on: https://gerrit.libreoffice.org/61465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-08compilerplugins: the useuniqueptr clang plugin test fails on 5.0.1Miklos Vajna
I'm not sure what is the first version that passes it, let's go with 6.0 for now. Change-Id: I7a150fbc2a722a6a47d91de4b00893303add5cc8
2018-10-08tdf#42949 Fix IWYU warnings in include/comphelper/[m-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I04c5ba277d5b3398c07de6ae66713d977636088d Reviewed-on: https://gerrit.libreoffice.org/61347 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-08find-unneeded-includes: warn about fw decls in namespaces tooGabor Kelemen
This regex parsed unneeded fw declarations reported by IWYU in the form of: class foo; But not ones inside namespaces, e.g.: namespace foo { class bar; } namespace com { namespace sun { namespace star { namespace foo { class bar; } } } } Change-Id: Ie2962b9fb1cf9382e8da45903f3716d0311dd58e Reviewed-on: https://gerrit.libreoffice.org/61485 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-08Related: tdf#120287 sw layout, TabOverMargin: fix left margin handlingMiklos Vajna
The old code only worked when left and first margin was 0; feed the relevant margin to SwTextFormatInfo, so SwTextFormatInfo::GetLineWidth() can compare against the right rectangle. This way TabOverMargin compat flag results in layout that matches the Word behavior for all 3 bugdocs from the bugreport. Change-Id: I6f81ad33b14e95ba4213c8956b3a9790ba6eee84 Reviewed-on: https://gerrit.libreoffice.org/61518 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-08use more std::unique_ptr in ScDBCollection::NamedDBsNoel Grandin
Change-Id: I5825208435fd179e9515e731a24a6e5bf1c94431 Reviewed-on: https://gerrit.libreoffice.org/61436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08use more std::unique_ptr in ScDPCollectionNoel Grandin
Change-Id: I7d76704ba76b0d47544456047bc699b12fa7c288 Reviewed-on: https://gerrit.libreoffice.org/61435 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08The UnitTest app needs the MobileCoreServices frameworkTor Lillqvist
(No idea why it complains about that only now. I did upgrade the Mac where I am building this to 10.14, but not sure how that could have an impact?) Change-Id: Ifaf56dbbe380694049d4957cc3fa8174c602bc67
2018-10-08Define a dummy GlyphCache class here for nowTor Lillqvist
Change-Id: Ib26ed91ca90cc2f38e21cce54c093795b1059877
2018-10-08No cairo used on iOSTor Lillqvist
Change-Id: I2fc713be404e68ea2fd0db43d0e93dfd62279da8
generated by cgit (git 2.34.1) at 2024-07-12 06:40:54 +0000