summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-31tdf#126511 Show only icon names instead of full path.Gülşah Köse
This commit shows only icon names insead of the full path of icon on Bullet and Numbering dialog graphic case on Impress. Change-Id: Iba72bf7c413993bad88add669035765aae521a59 Reviewed-on: https://gerrit.libreoffice.org/76716 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-31mysqlc: Support reading blob as stringTamas Bunth
Change-Id: I1ef0c3817bc255e7f0c38aca73c475b19d5d7d9b Reviewed-on: https://gerrit.libreoffice.org/76600 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-07-31Revert header guardAndrea Gelmini
Thanks Stephan for explanation, read it here: https://gerrit.libreoffice.org/#/c/76543/ Change-Id: If6c4d3b71ef2df69afe0404b9f445a62af9eadd3 Reviewed-on: https://gerrit.libreoffice.org/76714 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-07-31Always pair openTable/closeTable callsStephan Bergmann
`--convert-to epub doc/ooo24702-1.doc` (i.e., attachment 4 SMS SPECIFICATIONS.doc at <https://bz.apache.org/ooo/show_bug.cgi?id=24702#c1>) issues some calls to XMLTableContext::startElement and XMLTableContext::endElement without any matching calls to XMLTableContext::CreateChildContext, so closeTable was called without a matching openTable call, ultimately causing > soffice.bin: sax/source/expatwrap/saxwriter.cxx:1184: virtual void (anonymous namespace)::SAXWriter::endElement(const rtl::OUString &): Assertion `aName == m_pSaxWriterHelper->m_DebugStartedElements.top()' failed. to fire. Change-Id: I41c3071ace0934143881c77e4b00c23e79ff7ea2 Reviewed-on: https://gerrit.libreoffice.org/76618 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31Avoid out-of-bounds string accessStephan Bergmann
...as happens when loading doc/ooo112635-1.doc (i.e., attachment justified_chinese_paragraph_issue.doc at <https://bz.apache.org/ooo/show_bug.cgi?id=112635#c1>): > soffice.bin: /home/sbergman/lo/core/include/rtl/ustring.hxx:689: sal_Unicode rtl::OUString::operator[](sal_Int32) const: Assertion `index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())' failed. > #4 0x00007fff80397994 in rtl::OUString::operator[](int) const (this=0x61400027fdc0, index=68) at /home/sbergman/lo/core/include/rtl/ustring.hxx:689 > #5 0x00007fff80393283 in i18npool::BreakIterator_CJK::getLineBreak(rtl::OUString const&, int, com::sun::star::lang::Locale const&, int, com::sun::star::i18n::LineBreakHyphenationOptions const&, com::sun::star::i18n::LineBreakUserOptions const&) (this=0x613000281480, Text=" 本篇即在于指出十二宫反应的一些重点。学者若能参考上篇《星曜论》所言的星曜性质，当别有会心之处。因为事实上没有可能将一切星曜组合的", nStartPos=68, bOptions=...) at /home/sbergman/lo/core/i18npool/source/breakiterator/breakiterator_cjk.cxx:109 > #6 0x00007fff803942fa in non-virtual thunk to i18npool::BreakIterator_CJK::getLineBreak(rtl::OUString const&, int, com::sun::star::lang::Locale const&, int, com::sun::star::i18n::LineBreakHyphenationOptions const&, com::sun::star::i18n::LineBreakUserOptions const&) () at /home/sbergman/lo/core/instdir/program/../program/libi18npoollo.so > #7 0x00007fff803aed0f in i18npool::BreakIteratorImpl::getLineBreak(rtl::OUString const&, int, com::sun::star::lang::Locale const&, int, com::sun::star::i18n::LineBreakHyphenationOptions const&, com::sun::star::i18n::LineBreakUserOptions const&) (this=0x60e0004163e0, Text=" 本篇即在于指出十二宫反应的一些重点。学者若能参考上篇《星曜论》所言的星曜性质，当别有会心之处。因为事实上没有可能将一切星曜组合的", nStartPos=68, rLocale=..., nMinBreakPos=35, hOptions=..., bOptions=...) at /home/sbergman/lo/core/i18npool/source/breakiterator/breakiteratorImpl.cxx:243 > #8 0x00007fff803aeeca in non-virtual thunk to i18npool::BreakIteratorImpl::getLineBreak(rtl::OUString const&, int, com::sun::star::lang::Locale const&, int, com::sun::star::i18n::LineBreakHyphenationOptions const&, com::sun::star::i18n::LineBreakUserOptions const&) () at /home/sbergman/lo/core/instdir/program/../program/libi18npoollo.so > #9 0x00007fff4d209e09 in SwTextGuess::Guess(SwTextPortion const&, SwTextFormatInfo&, unsigned short) (this=0x7fff9ae398c0, rPor=..., rInf=..., nPorHeight=304) at /home/sbergman/lo/core/sw/source/core/text/guess.cxx:407 > #10 0x00007fff4d5be607 in SwTextPortion::Format_(SwTextFormatInfo&) (this=0x604000a2f950, rInf=...) at /home/sbergman/lo/core/sw/source/core/text/portxt.cxx:310 [...] Change-Id: I51d4bbecce4e929752a9f561f72acef446be21cb Reviewed-on: https://gerrit.libreoffice.org/76550 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31Avoid -fsanitize=float-cast-overflowStephan Bergmann
...during `--convert-to pdf doc/ooo111446-1.doc` (i.e., attachment DirAppLaunch.docx at <https://bz.apache.org/ooo/show_bug.cgi?id=111446#c1>), when aNew is "fig figFuncBlocks=fig figFuncBlocks+1" causing aCalc.IsCalcError() (whether legitimately, or because there is some prior error importing that formula): > sw/source/core/fields/expfld.cxx:912:34: runtime error: 1.79769e+308 is outside the range of representable values of type 'unsigned int' > #0 in SwSetExpField::SetValue(double const&) at sw/source/core/fields/expfld.cxx:912:34 > #1 in SwSetExpField::SetValue(double const&, SwRootFrame const*) at sw/source/core/fields/expfld.cxx:922:9 > #2 in sw::DocumentFieldsManager::UpdateExpFieldsImpl(SwTextField*, SwRootFrame const*) at sw/source/core/doc/DocumentFieldsManager.cxx:1254:34 > #3 in sw::DocumentFieldsManager::UpdateExpFields(SwTextField*, bool) at sw/source/core/doc/DocumentFieldsManager.cxx:924:9 > #4 in SwViewShell::CalcLayout() at sw/source/core/view/viewsh.cxx:1024:46 > #5 in SwEditShell::CalcLayout() at sw/source/core/edit/edws.cxx:110:18 > #6 in SwXTextDocument::getRendererCount(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sw/source/uibase/uno/unotxdoc.cxx:2595:25 > #7 in PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at filter/source/pdf/pdfexport.cxx:911:59 [...] Change-Id: I585bb9831212390b2c28248c3ff0904093b48783 Reviewed-on: https://gerrit.libreoffice.org/76520 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31tdf#126508 Fix crash when changing icon styleSamuel Mehrbrodt
Regression from b58aa94f1f365c746135470bceb97cc182c289bc Change-Id: I253447c197d8b333e26f243e26794e775f3edcee Reviewed-on: https://gerrit.libreoffice.org/76589 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-31tdf#121599, tdf#123099: ignore migration dialog whenXisco Fauli
1. a new HSQLDB database is created 2. the HSQLDB database is not opened interactively Change-Id: I7287e467e06be5eec1e5c661123e1332cdaeef9b Reviewed-on: https://gerrit.libreoffice.org/75643 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-31tdf#123591: truncate and round to 'scale' number of decimal placesXisco Fauli
otherwise the number will be incorrectly converted to OUString if scale < number of decimals See https://bugs.documentfoundation.org/show_bug.cgi?id=123591#c25 Change-Id: Ie32c9c6ab339d6907e9a4e2645d6f19bad9e67c8 Reviewed-on: https://gerrit.libreoffice.org/75727 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-30Fix typosAndrea Gelmini
Change-Id: Ia5fba032635adbf85bdfcb1eb0b3ffb9cf9d4a6a Reviewed-on: https://gerrit.libreoffice.org/76548 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-30Removed duplicated includeAndrea Gelmini
Change-Id: I2b1b7bb2cd88be4be518d045d54a0f0ee8583b8b Reviewed-on: https://gerrit.libreoffice.org/76713 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-30Fix typo in codeAndrea Gelmini
"connectr" Please look at: https://gerrit.libreoffice.org/#/c/76543/1 Change-Id: I3862780f92b8ce4583d642e3f653389a4ef3cc22 Reviewed-on: https://gerrit.libreoffice.org/76575 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-30bFirst means 1st vs 2nd column, and needs to alternate on each loopCaolán McNamara
this went wrong at... commit f423ac2d3bdba4263f1f41e31e7e2b7715afdd6e Date: Tue Mar 5 15:16:16 2019 +0200 remove sal_IntPtr in OfaMSFilterTabPage2 and just use a scoped enum Change-Id: I74bcca9ffee9faf4600da64b3c409dbf19a1290e Reviewed-on: https://gerrit.libreoffice.org/76619 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30remove newly unused SvxCheckListBoxCaolán McNamara
Change-Id: I6a5f4dfea9fbb34f02c1752140e04d1d0a8a67a7 Reviewed-on: https://gerrit.libreoffice.org/76617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SwCompatibilityOptPageCaolán McNamara
Change-Id: Id66751642a631d033385c3da9ba5cd484ba9dcf6 Reviewed-on: https://gerrit.libreoffice.org/76616 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30Fix typosAndrea Gelmini
Change-Id: Ib737ff364f627b9e4d0dc2a9903a07a0af36a8ae Reviewed-on: https://gerrit.libreoffice.org/76551 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-30sfx2: Enable sidebar on calc and writer, but not in impressAshod Nakashian
Added by Noel to this commit: And add a special deregister mode to doc_registerCallback so we can unregister stack-based callback objects in the presence of multiple views. Reviewed-on: https://gerrit.libreoffice.org/71715 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit fba6d4267b3f827269d6550dcb003cc56b31e493) Change-Id: I8d846bc1f794cf16fd45486fd83ef87f43fd52c7 Reviewed-on: https://gerrit.libreoffice.org/76555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-30tdf#126605: Do not end TextEdit when changing an attributeXisco Fauli
otherwise, pTextEditOutlinerView becomes nullptr in svx/source/svdraw/svdedxv.cxx:2184 Regression from e6c7a018a0cfee395ce2886d41c908a2447ef5cc Change-Id: I9d0645f637dc92b50d01682d119c0db60238e921 Reviewed-on: https://gerrit.libreoffice.org/76606 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-30svxlo-SvxCheckListBox doesn't exist, svxcorelo-SvxCheckListBox doesCaolán McNamara
Change-Id: I2aca664de328381e5beda5fb70bd58aa40f68abf Reviewed-on: https://gerrit.libreoffice.org/76612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30tdf#125800: accessing cond format props in UNO throws errorAron Budea
These conditions were always evaluated to true: OR should become AND when negated. Regression from 8c637b47d9de4b3a64c33a9c2ffe7ed220be2467 Change-Id: I87038319ed27eff2bed2412da49e01f73ec0a79c Reviewed-on: https://gerrit.libreoffice.org/76493 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2019-07-30tdf#125642 Fix layout issues for Bullet dialog.Gülşah Köse
Change-Id: Ieacd060a8bfe4e2123e6973e30789e029ab02ca6 Reviewed-on: https://gerrit.libreoffice.org/76587 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-30drop newly unused SvxRadioButtonListBoxCaolán McNamara
Change-Id: Idb80fa73fad6e4bb2a1eaa3d55d7fe90e86c8965 Reviewed-on: https://gerrit.libreoffice.org/76605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxPersonalizationTabPageCaolán McNamara
Change-Id: I5240fc4237d8b471b2c23a8bc776cffa46a53285 Reviewed-on: https://gerrit.libreoffice.org/76607 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxJavaOptionsPageCaolán McNamara
Change-Id: Ib37f6f554a890bd6397ae7b6c56f1615cd12b6b1 Reviewed-on: https://gerrit.libreoffice.org/76604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30tdf#126524 Use shorter default name for unnamed data seriesGabor Kelemen
Change-Id: I2c67a50c36f6b09dc15d70ec44b95d47792b33e2 Reviewed-on: https://gerrit.libreoffice.org/76298 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-07-30unordf: oops, and we forgot to amend with <= instead of <Michael Stahl
... in 751a5ad9c4e75fd1019bd4bca940d8a9e73f171a Change-Id: I81fb9e12b02eedd0fc6f4deccc392543cf2c14da Reviewed-on: https://gerrit.libreoffice.org/76614 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-30unordf: restore thread safetyMichael Stahl
(regression from f2c513e686536dc308609c56fa9354d4d10b072c) Change-Id: I620d726555172fbaec3d468bcf21c0c1101cdc70 Reviewed-on: https://gerrit.libreoffice.org/76601 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-30tdf#126597 don't use modeless dialog for senddoc.exeJan-Marek Glogowski
There is already a large comment in initAttachmentList about problems with MAPI_DIALOG_MODELESS. Using MAPI_DIALOG_MODELESS with Outlook 2016 and multiple attachments sometimes produces a MAPI_E_FAILURE, but most times it crashes for me. And it's not a problem with the removed temporary files, as uncommenting that shows the same problem. And there seems to be many more problems: https://social.msdn.microsoft.com/Forums/en-US/5d8fece6-9d93-490c-9331-625c17e3291d/mapisendmailhelper-and-mapidialogmodeless But actually I don't see any blocking of LO, if I switch to using MAPI_DIALOG, as senddoc.exe already runs in the background. So this switches MAPI_DIALOG_MODELESS to MAPI_DIALOG. This reverts commit 5874c76371562c3e2d8564b1fb04df1997091d27 ("tdf#116074: Use modeless dialogs with supporting mailers"). Change-Id: Ie0f8f22196d1a174dfeada2bc4aabb1717ee16a7 Reviewed-on: https://gerrit.libreoffice.org/76155 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-30tdf#126611 ShowDataNavigator in swxformandreas kainz
Change-Id: I8997ca84434f49b6e9dadd7e283455e40b90892e Reviewed-on: https://gerrit.libreoffice.org/76593 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-30[pt_PT] Added 14 words to autocorrectMarco A.G.Pinto
Change-Id: Iaae705b469463e302059c4be7b9f1c7968011824 Reviewed-on: https://gerrit.libreoffice.org/76577 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-07-30weld OfaLanguagesTabPageCaolán McNamara
Change-Id: Ib0938f0c9d810c0f851dd0180093aabb4babdc19 Reviewed-on: https://gerrit.libreoffice.org/76594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30tdf#125568: We need the selection string also when not "in selection mode"Tor Lillqvist
Apparently being "in selection mode" has nothing to do with whether we have a selection that we are enlarging by dragging the end marker? Change-Id: I546a1685bd3a0102e16c1f8bc6e721819ed986e2 Reviewed-on: https://gerrit.libreoffice.org/76588 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/76591 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-07-30NB Extension support for tabbed_compact and groupedbar_compactandreas kainz
Change-Id: I00265a60f5a66c044bf2eafb627dd3af1c09e3ca Reviewed-on: https://gerrit.libreoffice.org/76570 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-30weld SvxSecurityTabPageCaolán McNamara
Change-Id: I4cace9417f1f036921b3e95d946f431ec072ce3a Reviewed-on: https://gerrit.libreoffice.org/76586 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxProxyTabPageCaolán McNamara
Change-Id: I34651fc7c56da5205b349a83276d5efa536c4301 Reviewed-on: https://gerrit.libreoffice.org/76582 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30Simplify Sequence iterations in scaddins, sccomp, scriptingArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I836422a1c81a3dc9585687ed2e506eb59bb4ec91 Reviewed-on: https://gerrit.libreoffice.org/76484 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-30sw_redlinehide: remove obsolete ExperimentalMode in layout testMichael Stahl
Change-Id: Ibf2a0ccf80209e81587982d2bac9f83f763a6270 Reviewed-on: https://gerrit.libreoffice.org/76560 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-30weld OfaMSFilterTabPageCaolán McNamara
Change-Id: Ie711d8624995027578f79389972c6fa26b3189a2 Reviewed-on: https://gerrit.libreoffice.org/76569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxOnlineUpdateTabPageCaolán McNamara
Change-Id: I0043ba0b088f0b9ae8e5716c64e424419993cb96 Reviewed-on: https://gerrit.libreoffice.org/76568 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxEMailTabPageCaolán McNamara
Change-Id: I039564a53fe4b9c20f34efcb9e59f57528a1f5da Reviewed-on: https://gerrit.libreoffice.org/76561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SwRedlineOptionsTabPageCaolán McNamara
Change-Id: Ic901356d399e8d758747f0fea07d3656fbf89aab Reviewed-on: https://gerrit.libreoffice.org/76559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld OfaViewTabPageCaolán McNamara
Change-Id: I259e10ad8bdf3d1630ab1d24590c43919a351a86 Reviewed-on: https://gerrit.libreoffice.org/76567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30weld SvxCTLOptionsPageCaolán McNamara
Change-Id: I7b891e1a1d0ffc52cfd91a33fd01b3ec8ac2cd65 Reviewed-on: https://gerrit.libreoffice.org/76562 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30tdf#62699 Drop (now) pass-through header include/vcl/salbtype.hxxGabor Kelemen
Change-Id: I2e2093ac3c8c6833b70d4932bc12a82a4483bde5 Reviewed-on: https://gerrit.libreoffice.org/76499 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-30Fix typosAndrea Gelmini
It passed "make check" Change-Id: I50c3639ec258c7fb6d73104f8e777f96995aa8e3 Reviewed-on: https://gerrit.libreoffice.org/76543 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-30tdf#112535 DOC import: fix handling the have contour but no polygon caseMiklos Vajna
In case a graphic has contour enabled, but there is no wrap polygon, that means auto-contour in Writer, and no contour in Word, so handle this difference during DOC import. Regarding the DOCX import -> DOC export -> DOC import scenario, this fixes a regression from commit 628a0f313ed05db0149db680837c99267a77ea3c (DOCX drawingML import: handle SurroundContour shape property, 2014-08-11), though the DOC import part was always broken, I think. Change-Id: I6049fcf5df20736b702de901aef7068826d43f18 (cherry picked from commit 5b7b269c5e32abf4fbb6a664453e422e3667f4a3) Reviewed-on: https://gerrit.libreoffice.org/76566 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-30Fix typoAndrea Gelmini
Change-Id: Ie1d5b87b4d02faac560bf64cb11a31082189e7a5 Reviewed-on: https://gerrit.libreoffice.org/72575 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-07-30tdf#125609 c14: vcl button: don't modify style directlyJustin Luth
LO 6.4/6.3 commit d35171456bc230efdaa9426da1398b2db7fa0df8 could cause a recursive loop. ImplInitStyle RETURNS the suggested style, while ImplUncheckAll MODIFYS the actual style. Since the call to set WB_TABSTOP was already redundant in this case (and many others), I provided an option to avoid that direct modification. An example crashing document is attached to the bug report, which will eventually find its way into automatic crash testing. For this particular example document, it also requires LO 6.4 commit 5cf057c3365a0feafc8f2e4f4a9e24d69a581999 in order to trigger a crash. Change-Id: I26dddca27471dec10650f848f787363505b16c0f Reviewed-on: https://gerrit.libreoffice.org/76186 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2019-07-30tdf#126306: Add UItestXisco Fauli
this is possible after Jim Raykowski added accessible support to the autofilter popup ( tdf#122774 ) Change-Id: I9b503f8260fd914e7b5794b837d2661c63c7d21b Reviewed-on: https://gerrit.libreoffice.org/76563 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-29mysqlc: Fix query of cursor position in result setTamas Bunth
Fix queries like "IsAfterLast" in result sets of prepared statements in the mysql driver. Cursor position is stored in the driver, since the mysql C driver does not support the query of the cursor position. The cursor position works the following way: - 0 means the cursor is on "BeforeFirst". In that state calling of getXXX() methods is user error. - 1 means the first row is already fetched. - n means the last fow is fetched, where n is the total number of rows in the result set. - Everything bigger than n is "AfterLast" Change-Id: I131f2042606897019cc0f868dbc4151faf4850ac Reviewed-on: https://gerrit.libreoffice.org/76549 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-31 04:34:52 +0000