summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-05-10Fix row deletion bug.Gökay Şatır
When multiple users are editing a Calc document: * If one user selects a whole row and another one deletes a range of rows including or above the selected row, app crashes. * This PR fixes the crash. * Also when multiple rows are deleted, other user's selected row is moved only one row. This PR moves the selected row according to the deleted row count. * The cursor position was also causing a crash, fixed. Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: Ie4b893fee7192492efacbb167b747434336384e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158650 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167374 Tested-by: Jenkins
2024-05-10Fix column deletion bug.Gökay Şatır
When multiple users are editing a Calc document: * If one user selects a whole column and another one deletes a range of columns including or on the left of the selected column, app crashes. * This PR fixes the crash. * Also when multiple columns are deleted, other user's selected column is moved only one column to the left. This PR moves the selected column to the left according to the deleted column count. * The cursor position was also causing a crash, fixed. Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: Ib00488f387a91aa0109bcc30feacad52e1b14a30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158503 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167220 Tested-by: Jenkins
2024-05-10odk/README.md: easy way to build examples on Linux and macOSIlmari Lauhakangas
Change-Id: Ib511e81830a3e4b83f391d3f2d771dc657ee12b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167333 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-05-10odk/examples: grammar and comment fixesIlmari Lauhakangas
Change-Id: I86174573d9f59135865496a4f3ee5efb86141ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167410 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-05-09workaround segfault in compiler on macos-clang-intelNoel Grandin
Change-Id: I291599cd35d3f8be44949a57514bab5ac9f1a7e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167411 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-09tdf#49885 BreakIterator rule upgradesJonathan Clark
This change re-bases the BreakIterator rule customizations on top of a clean copy of the ICU 74.2 rules. Change-Id: Iadcf16cab138cc6c869fac61ad64e996e65b5ae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166273 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-09Fix missing UNO<->C++ argument/return value conversionsStephan Bergmann
Change-Id: I5ac6013d6c0bd72fe840a592628fd0d5b265b8ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167391 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-05-09workaround segfault in compiler on macos-clang-intelNoel Grandin
Change-Id: Ic4ee6c80eb340c1a6db50b9176fcbffcb6419483 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167393 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-09workaround segfault in compiler on macos-clang-intelNoel Grandin
Change-Id: I4327849c2c58c1656b82ea43fdc218dd7b9578c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167392 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-09document why GatherFields messes up sorted orderJustin Luth
Of course, UNO gets a list of fields through some esoteric broadcast system. This answers the big question in qa swfields about why the sorting order is stable, but wrong. An earlier version of the patchset has the code that would keep the sorted order for at least comments. But it isn't as efficient, and who knows what the implications would be, so I have no intention of making such a generic change. Change-Id: I178fdba7def8522ab5d94bdd61526af77f42c903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166767 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-05-09Embind: Fix uno_Any.get for null interface valuesStephan Bergmann
...which had caused an additional getNull/isNull check for a469aea9c0b532d928cd41e389c9c51de1af06f0 "Emscripten: Towards a working C++ UNO bridge" to fail Change-Id: Ibe87ca05f795253c9ede8cab6f96da8fe4496f87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167344 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-05-09loplugin:ostr in javaunohelperNoel Grandin
Change-Id: I641f2d107e3a8aaabdd2f8ede10e7e6b13078602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-09loplugin:ostr in lingucomponentNoel Grandin
Change-Id: I1910fd2a7cba63404c37b7bb80b77de2443dd7a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167386 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-09loplugin:ostr in jvmfwkNoel Grandin
Change-Id: Ie21df5b25d15a15ba7a1660970ff7064bb8ec1d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167385 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-09Revert "tdf#160706 speed up loading conditional formatting rule in XLS (3)"Noel Grandin
This reverts commit e1268721d4266ed1254da99581a7c2c3dfb72ba6. caolanm: With the old "bForceName" of true then previously if the style name existed it was renamed to something else and then a fresh style with the requested name created. While now we just reuse it. I'm not very clued in to what calc does, but in writer we might do something like this if we are inserting into an existing document and don't want to clobber existing styles. Except here we sort of did clobber existing styles by renaming them. So I'm unsure of what on earth the original idea was. So I wonder about a "insert into existing calc document" scenario? noelg: Caolan, I was operating under the assumption that this comment here is the desired behaviour. But now that I read it again, I am not so sure. This commit should probably be backed out. Change-Id: If503efa9fa1a7886eb57bb62d1327f81e4410981 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-09lokit: Properly handle state update for .uno:ToggleSheetGridHubert Figuière
This is a follow up on cool#8066 Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I7d6ce4c9dfe7c2e9a2dda110e587c8c825c4df2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167370 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 9bbe40cc2d39f89ffcae57875d4c7ef7688d83d7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-09svx: a11y check entry box - provide accessible name and descriptionTomaž Vajngerl
If the accessible name and description is not set in the .ui file, the code will look into help for accessible description, which will always return an empty string as the widgets are added dynamically. Searching in help takes some time (2ms), which can add up and is "felt" in accessibility check sidebar in online when the documents has a lot of accessibility issues (it can add up to seconds). To avoid this cost and for better accessibility info, it is better to provide some general description for this widgets. Change-Id: I91c5a091781532068c517be937d225fc9345dc5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167346 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 31b3d5a1062366a7ab0cf0fa42359b90d1ed3c4b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167316 Tested-by: Jenkins
2024-05-09lok: don't try to search for legacy label from/toTomaž Vajngerl
Searching for legacy label from/to can take quite some time in complex hierarchies (wallclock timed to 100ms) and this quickly can add up. In case of accessibility checker sidebar with many entries it could add up to 10s or more (depending on the amount of accessibility issues found in the document). The legacy label from/to is not used when we load from .ui file so it is not relevant for online currently. It is only relevant for ui found in extensions or starbasic ui. Also avoid making a copy of the vector of mnemonic label for no particular reason. Change-Id: I72002e6440a06f6e8548b7bddb46c3ab283ea283 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167347 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit 1353ae001ed83c1f20b81df1708f694427c587a4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167315 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-05-09loplugin:mergeclasses updateNoel Grandin
(*) remove some debugging code (*) loosen constraints a little so I can see if there are more interesting opportunities (*) rename some local vars to make it read better (*) strip const/& modifiers from types before comparing (*) ignore vars/fields that are references, they do indicate that a class was instantiated Change-Id: I66014b8f0aa24c2e3ca34af75b75e6cd6c939ea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167383 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-09Fix typelib_TypeDescriptionReference -> typelib_TypeDescription conversionStephan Bergmann
Change-Id: Idfe74f1523ec866ed9926d3385a1605ad8a5547e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167352 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-05-09loplugin:ostr in hwpfilterNoel Grandin
Change-Id: If99a50251332e89e09ad97bb74178c4651cde44e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167377 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-09loplugin:ostr in ioNoel Grandin
Change-Id: I68bb665798edf464020c8c3a6f7d9c9f5e85869e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167379 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-09loplugin:ostr in i18npoolNoel Grandin
Change-Id: I0176d93b38788e28fa42baad293597f98eaa7a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-09tdf#154581 tdf#157411 tdf#158549: sw_htmlimport: Add unittestXisco Fauli
Change-Id: I0bf120b4761447a0acc9286e7181f7cf7c40c65b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167380 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-05-09tdf#58038 - chart: make available format characters toolbar forBalazs Varga
text boxes or shapes *inside* charts (as created with the Drawing toolbar). follow-up commit: 4f994cec388377cc5c2bddb804bd92eb4cd7dc8d (tdf#39052 - Chart: make characters formatable in editable chart textshapes) Change-Id: Iccc5ee350ea0a37d8bda9652e09d3d61339f1d71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167366 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-05-09tdf#160984 sw continuous endnotes: add a way to find the endnote section startMiklos Vajna
Existing code with endnotes on separate page at the end of the document works by searching for a current or next page that is an endnote page in SwFootnoteBossFrame::AppendFootnote(), and in case none is found, then an endnote page is created. Add similar infrastructure for the inline endnotes case: here we want to find the first page that has an endnotes section, which also requires being able to tell if a section is an endnotes one. The newly introduced SwPageFrame::GetEndNoteSection() is not yet used in SwFootnoteBossFrame::AppendFootnote(), though. Change-Id: Ib08267f9bf6c7b06576624e3fa8e90e8b8b1b232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167371 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-05-09tdf#158447 Use PyConfig for setting Python home directory with Python >= 3.8Ilmari Lauhakangas
Change-Id: Ic5b7c60613b22f5215cb1a2a13fecf3e0946ca49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161089 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-05-09WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I6ef2f39cca9e657a05b9b55d8ff87607261dd1ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167369 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-09update crcs for --enable-cairo-rgba caseCaolán McNamara
Change-Id: If0588a018564a708361b0246b294520ac5d2d1db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167368 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-09WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: I37166c03ffd0f8f76ddc03ce556b6e6341a02b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-09Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 761a64f3ca3e8f66c711bcadaa8c5ced105a99cd - fix row/column type of labels in description of their recognizing Change-Id: I4b9dcd95b432aea717eeb017fc94fa02a3bc84d5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167247 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-05-09Use less SdOptionsLayout->IsHandlesBezier in favor of officecfgGabor Kelemen
Change-Id: Id2f005413f255b4a0f0e0cd240cb8700c27ee204 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166598 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-05-09Use less SdOptionsLayout->GetMetric/SetMetric in favor of officecfgGabor Kelemen
Change-Id: I12c9f69e0db1bf3e726b7d642e9a6855b031d3b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166597 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-05-08loplugin:ostr in fpickerNoel Grandin
Change-Id: I891d31ae35419fb26d7070c8a9e3437b86e124d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167338 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-08tdf#160906 use SfxPoolItemHolderArmin Le Grand (allotropia)
to avoid handling already deleted SfxPoolItems. Change-Id: I1f1f8f93cae8db7f7c8df66c2c7f3c02b59a39c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167274 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2024-05-08tdf#126573 Add Excel2021 array function RANDARRAY to CalcBalazs Varga
Add new function called RANDARRAY to the function list. (TODO: dynamic array in separate patch, oasis proposal) Change-Id: I34bad3b7e8d631d649a0350d7c1170b26161331d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167003 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-05-08loplugin:ostr in frameworkNoel Grandin
Change-Id: I2fdc32aa5de6a1315fe69997f9b531259aa78605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-08Revert "tdf#150037 Writer: text fieldmark behaviour changed"Justin Luth
This reverts 24.8 commit 96323a10d3a55d212c350886e2a1344c0cd2ba95. A mouse click selects the fieldmark to be able to overwrite the field with the next text input. But I did not revert: Additionally the EN SPACE (0x2002) character is visualized by the DEGREE symbol when 'View/Formatting Marks' is active. The problem was that the field itself was also selected, so not only was the placeholder text overwritten, but so was the entire field. Additionally, it is ONLY placeholder text that should be selected, but this was also selecting non-placeholder (i.e. custom user-entered text) that was being pre-selected which is NOT what happens in MS Word. The whole point of the patch in the first place was to emulate MS Word's response to placeholder text, so we should also be emulating what happens to non-placeholder text. That would require tracking whether the field's text was placeholder or not, which is not currently track in legacy fields. Change-Id: I0a1a22f82827cd5f9d9abfb52cd562dff4651b29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167139 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-05-08WaE: C6011 Dereferencing NULL pointer warningsCaolán McNamara
Change-Id: Ia64d863baa72a2d32a8bee40968af4f6aacd88bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167332 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-08Move call code out into a function of its ownStephan Bergmann
...so that it can be reused in the future for attribute getters/setters Change-Id: I3dde796eb0c2f3812b7aee1a2c000bad31b33158 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167345 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-05-08gtk3 a11y: Drop superfluous checkMichael Weghorn
If `nStateSet` is 0, no states will be set int the loop anyway, so the extra check is not needed. Change-Id: Id26f2210c51cb6bf952720f9a84696a327992df6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167330 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-05-08gtk3 a11y: No longer manually add focused state for focus objectMichael Weghorn
No longer manually add `ATK_STATE_FOCUSED` to the ATK focus object. The focused object should should have the `css::accessbibility::AccessibleStateType::FOCUSED` state set on UNO level, in which case this is already mapped to the focused state in the lines above the newly removed code, so explicitly addding it again shouldn't be necessary. If the state is missing, that most likely needs to be fixed in the underlying `XAccessibleStateSet` implementation. Therefore, remove what looks like a workaround. If any issues show up after this, let's rather take a look at the underlying issues and try to fix things there. Change-Id: Ie7252c4b2dd2ec15c7a3bbc6a1a5e2830cdd39a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167309 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-05-08Emscripten: Towards a working C++ UNO bridgeStephan Bergmann
...by making the general UNO -> C++ function call case work (modulo handling exceptions, which I'll look into later). Wasm call_indirect unfortunately needs to statically know the call target's signature, so we statically need to know all possible signatures. So introduce wasmcallgen helper to scan the existing UNOIDL API upfront and generate the relevant callvirtualfunction-wrapper.cxx and callvirtualfunction-inst.s code. (The good thing is that the number of different signatures is somewhat limited, each parameter can only be one of i32, i64, f32, or f64. So even if 3rd-party extensions bring along new UNOIDL interface methods, chances are relatively high that the signatures needed for them would already be covered by the existing ones.) Testing this can nicely be done in unotest/source/embindtest/embindtest.js via css.script.Invocation (which internally exercises the relevant code). (Instead of adding individual org.libreoffice.embindtest.StructLong/String etc., it would be nicer to introduce some polymorphic StructOne<T>, but the Emind UNO binding does not support polymorphic structs, so the embindtest.js code would not work.) Change-Id: If829c9e3772bfd27561f3ad743d38a71d11545b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167308 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-05-08tdf#160984 sw continuous endnotes: introduce an endnote sectionMiklos Vajna
Word lays out endnotes at the end of the document inline after body text, Writer puts them on one or more separate endnote pages. There was already an attempt in the past to resolve this difference, see commit 4814e8caa5f06c4fe438dfd7d7315e4a2410ea18 (tdf#124601 sw: add ContinuousEndnotes layout compat option, 2019-09-30). The approach back then was to map such endnotes to footnotes, so the extra, unwanted page doesn't appear. This turned out to be not working too well, the compat option is only enabled for DOC, and even there commit dc11f5b151e1a2ea2623fc8cf806a400763955d9 (tdf#143445 DOC import: limit the usage of the CONTINUOUS_ENDNOTES compat flag, 2023-05-23) limited the usage of the compat flag to 1 or 2 endnotes only. Coming back to this, try a new approach: create a section that more or less exists only at a layout level and put endnotes into that section. This allows reusing all the complex logic on how to lay out endnotes inline, on one or more pages. The plan is that this new approach is more robust, can replace the old continuous endnotes layout code and then can be enabled for DOCX as well. This commit just introduces the backing section format and SwSection for that special "endnotes section" (it's special because SwSection is usually owned by an SwSectionNode, but here there is no doc model node for the SwSection), SwFootnoteBossFrame::AppendFootnote() doesn't try to use the new SwEndNoteInfo::GetSwSection() yet. Change-Id: Ib32f04ceb6f46c682a5d36bdcea206d2c4017227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167305 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-05-08return early on empty ORelationTableConnectionData*Caolán McNamara
we test for pData existing, but it it doesn't then we continue and will typically dereference it, so test looks inverted Change-Id: Iddcab25d5620942bb617bd1e9985322f5e497839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167331 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-08drop requirement for rtl_random_getBytes to have "Pool" argCaolán McNamara
Seeing as since: commit e9531b792ddf0cfc2db11713b574c5fc7ae09e2c Date: Tue Feb 6 14:39:47 2024 +0100 sal: rtlRandomPool: require OS random device, abort if not present Both rtl_random_createPool() and rtl_random_getBytes() first try to get random data from the OS, via /dev/urandom or rand_s() (documented to call RtlGenRandom(), see [1]). we don't use the initial arg to rtl_random_getBytes anymore, drop the requirement to have one. Then simplify our usages of that, and addtionally deprecate rtl_random_createPool and rtl_random_destroyPool. Change-Id: I13dcc067714a8a741a4e8f2bfcf2006373f832c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-05-08loplugin:ostr in formsNoel Grandin
Change-Id: Ifee5d86b54aa746dbd3b17ff966794f32fbc23bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167303 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-08loplugin:ostr in formulaNoel Grandin
Change-Id: Iac66906636e64c0547122ac413bee494631c7c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167304 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-08loplugin:ostr in filterNoel Grandin
Change-Id: I9468cb2bf7b3614e5ee2e1ca6969282041699371 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167302 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-08flush CallbackFlushHandler queue via PostUserEvent instead of Idle+TimerCaolán McNamara
Looking at when Invoke was called from Idle (or from auxiliary Timeout if there was no chance to run the Idle within 100ms) and when duplicate merging and modification of the queue is done before getting dispatched and cleared; Then the pattern is that duplicates are collected and merged during the current block of events to be processed, and dispatching the flush via PostUserEvent instead gives the same results. During startup, scheduling via PostUserEvent drops the need to have the aux timeout, and while the number of messages seen in the first queue flush (now via PostUserEvent instead of 100ms Timer) remain the same as before, subsequent queue flushes can get processed earlier while smaller, though typically at the same time as before once the document is fully loaded. Change-Id: I64c6bbc3dea9fb3a512c2a9521303a8f143d4a89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167064 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2024-12-28 23:19:58 +0000