summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-05-27Fix typoAndrea Gelmini
Change-Id: I989d9a915c61186b4fd9132f70b916b3dfd7f202 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152338 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-27Fix typoAndrea Gelmini
Change-Id: I99ef22d0062b3e9573abd3c60078e72472681c32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152339 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-27Use getXWeak in ureMike Kaganski
Change-Id: I5d76890ca1165b74e204b38c5ca9675d40a80823 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150884 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-27tdf#148756: Fix document type in option dialogBaole Fang
Change-Id: I16ef2adbb5c77960c18426ef6b2211d230adf410 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151455 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-27xmloff: add color-type attribute to complex colorTomaž Vajngerl
We need to identify what the color type of the complex color is. For now we mostly use "theme", but in the future we can also have other types like "rgb",... when the infrastructure for that is built. Change-Id: I38c91d294a191ca3124be4e99050977c9815d23e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152253 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-05-26tdf#154131 Add Detect scientific number optionLaurent Balland
Add a sub case of Detect special numbers for import CSV (SC_IMPORTFILE), paste unformated text (SC_PASTETEXT) and text to columns (SC_TEXTTOCOLUMNS). Following cases are treated: - If "Detect special numbers" is true, then "Detect scientific numbers" must be true and all special formats are treated (date, time, scientific notation) in addition to basic decimal numbers. - If "Detect special numbers" is false and "Detect scientific numbers" is true only scientific notation is treated in addition to basic decimal numbers. - If "Detect special numbers" and "Detect scientific numbers" are both false only basic decimal numbers are recognized as numbers. It is the new case treated by this change The new option bDetectScientificNumber is append to ASCII options Change-Id: I73dff9f75d2c7b07ce155daa29dcc4ca9f288664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152072 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-05-26Fix typoAndrea Gelmini
Change-Id: I7d6dd38b15df7e18775bc94a64aec215d2106c46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152307 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-26Fix typoAndrea Gelmini
Change-Id: I3e63b18e94b26c671d140009db97d82efc346028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152306 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-26tdf#60683 tdf#55946 doc import: use style's anchor infoJustin Luth
make CppunitTest_sw_ww8export CPPUNIT_TEST_NAME=testBnc787942 Change-Id: Ie1dc179fc3954b5eed73f3ee1f6dc95f4785f3e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152331 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-05-26use more TypedWhichIdNoel Grandin
Change-Id: Iaa7ce9165da835a638bcc1d633bed0a2ff2c4108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152308 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-26tdf#155190 svx,sw: PDF export: don't tag SwNoTextFrame as ArtifactMichael Stahl
The problem is that inside of the Figure tag, in SwNoTextFrame::ImplPaintPictureGraphic(), ViewContactOfSwNoTextFrame and ViewObjectContactOfSwNoTextFrame are used to create and process another primitive sequence. ViewObjectContactOfSwNoTextFrame does not have access to a SdrObject, because that was already processed by the outer layer of code that called the SwFlyFrame painting code. Avoid running the code that assumes anything without an SdrObject is an artifact by disabling PDF tags altogether in ViewObjectContactOfSwNoTextFrame. (regression from commit 81ef84648515965bf67afaced946227d0f63a71e) Change-Id: I9fabe7f7e5296f8d850448ac44865f87cd164591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152335 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-26vcl: PDF export: stop adding pointless circular RoleMap entriesMichael Stahl
... for standard roles; no idea what these are supposed to be good for. Change-Id: Ie2ccf394631a2bccb496b2f93e26a571ba84d58d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152334 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-26ScriptForge (SF_Dialog) new CloneControl() methodJean-Pierre Ledure
Duplicate an existing control of any type in the actual dialog. The duplicated control is left unchanged. The new control can be relocated. Args: SourceName: the name of the control to duplicate ControlName: the name of the new control. It must not exist yet. Left, Top: the coordinates of the new control expressed in "Map AppFont" units. Returns: an instance of the SF_DialogControl class or Nothing The method is available from Basic and Python user scripts This change will require an update of the SF_Dialog help page. Change-Id: I5c2a5404a14ad60b2d4df2ac7eabbf0ddd843170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152333 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-05-26tdf#150028 Treat decimal separator after [SS]Laurent Balland
Only decimal separator after S or SS was treated This change adds [S] and [SS] to treat formats like [SS].00 Update: correct export to XML Add QA unit tests Change-Id: I97ce4084d3caab2fcd18f1c70cd4221596290563 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151823 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-05-26Related: tdf#155507 disable HeaderFooter menu for tiled renderingCaolán McNamara
Change-Id: I3fa87dc40c8e68d00f2f2fa82a0e6c4179466429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152332 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-26Related: tdf#155507 Only need this invalidate if using header/footer controlsCaolán McNamara
which is implied from the IsUseHeaderFooterMenu option Change-Id: I0f9a32ed1a3e0e5e277c33c45206757d133d92e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152330 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2023-05-26Related tdf#153317: extra check since we deal with signed integersJulien Nabet
Thank you Michael Stahl for having spotted this! :-) Change-Id: I4e643b562e6dc653a511109531837c228f0e0e0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152305 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-05-26tdf#133504 doc import: set the correct wrapJustin Luth
Umm, I'm amazed that 1.) this hasn't been a bigger, burning issue, and 2.) that no one has ever investigated or fixed this. It was super easy. The code is mind boggling though. "Auto" and "Not Beside" are NONE, but around, none, tight, and through are "Optimal"? How about auto is optimal, around/tight are parallel, none is none, and through is through. Lets try that and see how it works. Prior patchsets submitted searched for existing examples. They suggest that MS Word's UI only allows for notBeside and around, but I kept the others there just in case something can trigger them. Change-Id: I893dfd66737bcc3148b48c68cb6df778d3f528c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152286 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-05-26SwViewShell::ToggleHeaderFooterEdit already calls GetWin()->Invalidate()Caolán McNamara
so this is a duplicate call, drop it Change-Id: I4d332217594f7e1ceb4692ea31a6718ecd44d1ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-26tdf#155507 don't redraw numbering when cursor enters it, if...Caolán McNamara
"field shadings" are turned off and so the new output would be the same as it already is. Which removes a potential source of whole document invalidations in a multi-user collaborative scenario where participants may be casually clicking around the place with an expectation that it has limited effect on the other participants Change-Id: I2fb51ba3358bfc920aa2bff3593a0dd46f287100 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152301 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-26use more TypedWhichIdNoel Grandin
which flushed out an inconsistency in how SID_NUMBER_TYPE_FORMAT was being used Change-Id: Ib59ae4c4950136703d18d7485db432a39e3dc39c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152300 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-26ofz#59338 Abrt failed_throwCaolán McNamara
Change-Id: Ib70dfef2c4ecce024162409ffd8c210d6feef1eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152297 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-26Suppress variable not used warningHeiko Tietze
Change-Id: Ie154c9ad2d187adf735590da2e23420572dd5de4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152294 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-05-26Related tdf#145080 - Less obtrusive col/row header color on macOSHeiko Tietze
Change-Id: I4821643148afa205d94fe2f6178091c2acfb5bc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152299 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-26replace find_if by none_ofDr. David Alan Gilbert
A set of cases where find_if is used just to test if there are no matches; use none_of as per tdf#153109 Change-Id: I6c705ab7a8289914743199722a444ee40d11d746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152200 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-26use more TypedWhichIdNoel Grandin
Change-Id: Icc1cbd2717034c87bdaea1b62253b001243c6652 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152290 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-26sal_uLong->sal_uInt16Noel Grandin
Change-Id: I5e62c090978cabe3cc9b065fdd2b0e2a235557f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-26tdf#155436 svx: PDF export: fix crash on SdrMediaObj without URLMichael Stahl
Both sw and sd don't call CreateScreen() if there is no URL. (regression from commit e84b310b59825fd572d79def98c3d21566aac603) Change-Id: I087511bb6ed41b0e39321f6ca8684f60261f01cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152282 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-26external/libxml2: Fix missing external symbols needed by xmllintStephan Bergmann
After 5b42f148e206cda19467e76c2f9915fc2b6fa5f6 "ExternalProject_libxml2 still needs to build the xmllint executable" (which I had happened to prepare on macOS, so didn't originally notice the issue addressed here now), Linux builds like <https://ci.libreoffice.org/job/lo_callgrind_linux/13374/> started to fail with > CCLD xmllint > /opt/rh/devtoolset-11/root/usr/libexec/gcc/x86_64-redhat-linux/11/ld: xmllint-xmllint.o: in function `testSAX': > /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/libxml2/xmllint.c:1646: undefined reference to `xmlNewSAXParserCtxt' > /opt/rh/devtoolset-11/root/usr/libexec/gcc/x86_64-redhat-linux/11/ld: xmllint-xmllint.o: in function `myReallocFunc': > /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/libxml2/xmllint.c:357: undefined reference to `xmlMemSize' > collect2: error: ld returned 1 exit status > make[2]: *** [Makefile:1007: xmllint] Error 1 > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/external/libxml2/ExternalProject_libxml2.mk:37: /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/ExternalProject/libxml2/build] Error 1 Turns out that those two functions have been introduced after the previously used libxml2 2.10.4. No idea how things are supposed to work (given that workdir/UnpackedTarball/libxml2/libxml2.syms starts off with "Retained for backward compatibility. Don't add new symbols.", it appears that there should be some other mechanism at play to make xmllint on Linux find the libxml2.so symbols it needs, but which doesn't work as intended in our build), but just add those two symbols to libxml2.syms for now. (With a new version named LIBXML2_2.11.4, even if the symbols can actually have been introduced in some other version between 2.10.4 and 2.11.4, but who cares.) Change-Id: Ib9d5c7901fe94b8014a87b049fc27ef5658fd954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152292 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-26sw floattable: handle fDontBreakWrappedTables in the DOC filterMiklos Vajna
This is the binary DOC import/export for the functionality added in commit 08fa2903df1a7cf9a1647fcf967e4c8b57dad793 (sw floattable: add a DoNotBreakWrappedTables compat flag, 2023-05-24). Change-Id: I91c29b9049e8e9079ed16b1beeefddfa2f6e9a6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152291 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-26MCGR: Border restoration supportArmin Le Grand (allotropia)
Due to tdf#155362 I added code to be able in case we would need it to convert a BGradient using added tooling from having offsets in the GradientSteps and no border to adapted GradientSteps and border. This is preferrable due to our GradientStyle_RECT (and GradientStyle_ELLIPTICAL too) use that 'non- linear' paint aka move-two-pixels-inside, someone else called it 'frame-paint'. This does not bode well with the border being applied 'linear' at the same time (argh). Thus - while in principle all is correct when re-importing a GradientStyle_RECT with a border after export to pptx, it looks slightly better ('correcter') wen doing so. That is because when being able to and restoring a border at least that border part *is* applied linearly. I took the chance to further apply tooling, move it to classes involved and instead of awt::Gradient2 use more basegfx::BGradient since it can and does host tooling. This is also a preparation to be able to adapt (restore) border in case of turn- around in ODF where the importing instance is before MCGR existance and has to handle Start/EndColor. Needed to take more care with using BGradient instead of awt::Gradient2 for initialization, also better dividing/organization of tooling, already preparation to use for other purposes. Change-Id: I2d3a4240a5ac6fff9211b46642ee80366dc09e3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152194 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-05-26tdf#155496: Export list header to (X)HTML using 'display: block' styleMike Kaganski
This re-implements commit 013a4f1f5c9ea5fb511568c53a7e76d1b365a65d (sw XHTML export: fix handling of list labels, 2021-05-13), and instead of not putting headers (ODF 'text:list-header' elements) into lists, this adds 'style="display: block"' attribute to the respective list items. This makes sure that the items use proper list indentation, and produces correct markup. Change-Id: I900e4aebbe562830dc2ce5400e3e33b38c2f2faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152280 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-26tdf#153317: direct SQL: try to detect Bit field in Mysql/MariaDBJulien Nabet
Change-Id: I462cb28c15a0cd1d3c93f2335bcac02ca09c78e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152289 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-26sw layout xml dump: extract SwRowFrame::dumpAsXml() from SwFrameMiklos Vajna
Ideally SwFrame should not really know anything about row frames. Change-Id: I31e7cbec7466f9d0677755adb631b63c156b55c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152283 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-26Fix text in IDL fileOlivier Hallot
+ Copy&Paste is evil... Change-Id: I11352ec41d96cfbc7d4176773789066aee292a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152281 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-25Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 9b8794b4b681e2c4f148ca626c766d961e0e3078 - Add Sheet Events Help page, update command paths Change-Id: I90d0b82c143d467e48aed65bb422c0323875ece2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152285 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-25Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 027d282ebbf0cd889772eb646b756f7ee374105b - Refactor - no contents changed. Change-Id: Ic8492fff71c310a2dc054683ea16338254500afe Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152284 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-25use more TypedWhichIdNoel Grandin
Change-Id: I6c54c1276b36cbc71417486ffcee2ef9ef0cff7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152270 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-25CppunitTest_sw_uiwriter4: disable part of test on all platformsXisco Fauli
Sometimes Jenkins also fails on mac and linux Change-Id: I198a30bfbe1dd0952e69ef8066feccc78ea11d15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152278 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-25merge some stringaddsNoel Grandin
found with a lightly tweaked version of the loplugin:stringadd and some hand-holding. Change-Id: I146aadcaf665e98fea89a9cad2df4dc3935622f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-25desktop: check getDialog()Xisco Fauli
it might return nullptr See https://crashreport.libreoffice.org/stats/signature/dp_gui::TheExtensionManager::ToTop() Change-Id: I4023529aec0ba2c72b4e7db5449d235c208ee30b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152268 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-25Fix identical copypaste errorsMike Kaganski
Change-Id: Ic3d93c9141fcf407493ebb9b7cfc40d1598368ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152221 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-25Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 31fe3777cb0dc69a3badc026f4de55c096af48d9 - tdf#154996 Add tabbed UI commands in Help page + refactoring Change-Id: I404321de45f8d4c4621a64d2f30a48421f65f86e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152249 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-25Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to c26935e97327fd87907d41dd07f60bdf71ef8067 - tdf#154996 Tabbed Interface command in Help pages + review the Hide / Show sheet command Change-Id: I5dd3e9fe40f06c006282c1b62de38daadd01d2a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152248 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-25tdf#107965: partially revert fix for tdf#91312Xisco Fauli
This commit partially reverts 8a11d34c7e08218b5ff9da4870c460297f312332. tdf#91312 is not reproducible after the revert because the conditional format logic has changed since then and now conditions are grouped. Change-Id: I5ae86c8c3b8611e3fdfed6adbcac7b481bc7217f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152273 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-25Related tdf#155443: MySQL/MariaDB direct connect, use more of the new functionJulien Nabet
...getAlterTableColumnPart(). getName() and getTableName() don't deal with database/schema prefix + backticks Change-Id: I31cc9dc98de0449dfe2f6f24305290d4edb9ecb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152276 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-05-25Allow bootstrap variables in Java user classpath settingsSamuel Mehrbrodt
This allows for relative paths to be configured as Java class path. Change-Id: Ie3e6bc3836fb316457e5c9f11dfb77d2fcd49ad4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152271 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-05-25sw: fix crashtesting assert on forum-mso-en-13115.docxMichael Stahl
itrpaint.cxx:436: SwTextPainter::DrawTextLine: Assertion `!roTaggedParagraph' failed. The problem is that there are 2 SwNumberPortion, and the 1st one doesn't have the m_bHasFollow flag set. The numbering suffix is 5 consecutive ' ' spaces, which is oddly enough considered a hook char in SwFieldPortion::Format() but not in SwTextFormatInfo::ScanPortionEnd(). This inconsistency appears to cause the problem, and was already there in initial CVS import, but nothing bad seems to happen when it is resolved. (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd and commit df5328ff1e472af9c69d4ff83fa13c71d644ddec) Change-Id: I602d9adb63220cb63ce8a477b617e9aeae45fb8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152274 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-25tdf#152048: Fix underline width for Kashida-justified textKhaled Hosny
Fix GenericSalLayout::GetTextWidth() again, this time doing away with using linearPos as it is wrong, the glyph’s position is not directly related to how much it contributes to the text width (for example, combining marks have zero advance width yet their position is different from the base glyph they apply too). This is a followup to: commit ce7c1c608fa99c86c8f2380cd8b82d02123f514e Author: Khaled Hosny <khaled@aliftype.com> Date: Wed Aug 31 07:07:54 2022 +0200 vcl: Fix GenericSalLayout::GetTextWidth() Additionally, inserted Kashida should have its origWidth and newWidth both set to zero, since it does not add to the text width, all additional width is already added to the glyph the Kashida is applied to. With both fixes, the text width of Kashida-justified lines is correctly calculated and the underline no longer extends beyond the text line. Fix test expectation now we are reporting the real text width. Change-Id: I0de93f955929cf3030cf420cb4f4e94df974fb79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152267 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-05-25more TypedWhichIdNoel Grandin
Change-Id: I2536f09fc48ff641c0e5c646ca7127f293ae5db4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152259 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-04 11:09:00 +0000