summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-05-30Resolves tdf#140091 - Tooltip to add sheets should be more informativeHeiko Tietze
Change-Id: I03ae5d11b80472839e2654ff43eb391b5396f026 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152383 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-30sw floattable: handle \nobrkwrptbl in the RTF filterMiklos Vajna
This is the RTF import/export for the functionality added in commit 08fa2903df1a7cf9a1647fcf967e4c8b57dad793 (sw floattable: add a DoNotBreakWrappedTables compat flag, 2023-05-24). Change-Id: I3c458cbe1f4b0947a94651cc205f2a7660d2ec2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152377 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-30sc: avoid crash in ScHorizontalCellIteratorXisco Fauli
At least do not crash with release builds as seen in https://crashreport.libreoffice.org/stats/signature/ScHorizontalCellIterator::ScHorizontalCellIterator(ScDocument%20&,short,short,long,short,long) Change-Id: If253e950bbb709b585dc9398beddd1303dcb1b57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152000 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-05-30Fix gray shade for NBSPsVojtěch Doležal
28675af broke field shading for NBSPs, showing it only when non-printing characters are enabled. This commit reverts the behaviour to the original state, where field shade is independent on whether the non-printing characters are enabled. Change-Id: Ica44937a82d6c3742716e9aa934ab87e7f8b5168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152349 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-30tdf#155542: Fix crashtesting assertKhaled Hosny
When cloning an RTL glyph range, we might end up cutting in the middle of a cluster e.g. between a base character and a combining mark since both with have the same charPos() after: commit 09c076c3f29c28497f162d3a5b7baab040725d56 Author: Khaled Hosny <khaled@aliftype.com> Date: Wed Oct 5 21:00:46 2022 +0200 tdf#151350: Fix extraneous gaps before marks (which changed how HarfBuzz sets up clusters back to the default where marks form clusters with their bases, before that a mark formed its own cluster). This leads to the cloned glyph range to include the glyph for the combining marks, while it is not included in the text string. Change-Id: I83031e0e0ffc7c5932101649a9cc2bf953a6347d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152380 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-30sw: prefix members of XMLEventsImportContext, XMLFontStylesContext, ...Miklos Vajna
... XMLMarkerStyleExport and XMLMarkerStyleImport See tdf#94879 for motivation. Change-Id: Ief48236f16c5525c6bd49d78e6ba4f9643ef1214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152376 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-30merge expwrap into sax libraryNoel Grandin
there is no need for 2 shared libs for such a small module Change-Id: Id28c9038f3e16931bfb8af3532eca172998da1aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152374 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-30use more TypedWhichInfoNoel Grandin
Change-Id: I406c5d070e3dd197b2cf819d63212d5a40a8eadc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152309 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3ffbf68223b981335abdfede5dc5f86c30269c13 - tdf#154996 Add tabbed UI commands in Help page + refactoring Change-Id: I7db22fb77cd690cfadb8b0fda4776ddb0a1ff0df Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152373 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-29avoid some invalid Fraction objectsNoel Grandin
when loading spreadsheet with embedded OLE objects Change-Id: Ib8fe88f0ffec03e8b92d8d8b69c8763164f4dd05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-29tdf#89288: Insert space between CJK and non-CJK text onlyKhaled Hosny
When “Apply spacing between Asian and non-Asian text” option is set (which is the default), Writer inserts text between any two script changes which is not desired. Change-Id: I9abb672b761a5f25f714cf60cf06c7dab5441af3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152369 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-05-29tdf#36711 doc import: special case when DyaAbs is zeroJustin Luth
One existing unit test found, but the frame was non-functional. Noted in an earlier patchset. make CppunitTest_sw_ww8export CPPUNIT_TEST_NAME=testTdf36711_inlineFrames Change-Id: I9bc4064b6564b327614e44112304adef59490078 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152346 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2023-05-29ReqIF: 'ol' elements must have no 'type' attributeMike Kaganski
Change-Id: I62098bac9dc3751f7b939cbf94f1561b4539a294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152368 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-29Remove recently unused CTLScriptType codeKhaled Hosny
This is now unused after: commit 98f7ec383db74a6491e925e30125d3fbf270afc2 Author: Khaled Hosny <khaled@libreoffice.org> Date: Sun May 28 16:28:52 2023 +0300 tdf#139863, tdf#155514: Don’t split COMPLEX text portions The code is also broken as it doesn’t handle surrogate pairs. The UNO API now throws an exception. Change-Id: I454ed741e3834e762a2731d671c21a3e73515da3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-05-29tdf#149297: Fix Y position of vertical glyphs on macOSKhaled Hosny
Remove the Y position offset that became redundant and now double shifts the glyphs after: commit dd0d0b44fd1c6c0292d7b2eb3f5cf2baa21e4481 Author: Mark Hung <marklh9@gmail.com> Date: Sun May 2 15:12:46 2021 +0800 vcl: adjust LayoutText() for vertical writing. Change-Id: Iac7abfa69acfe75860d05800f446c25ed622bb95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152366 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-05-29cppunit/timer: Use a range based loop and cleanupDr. David Alan Gilbert
Use a range based loop in testDurations re tdf#145538 which also nails a SAL_N_ELEMENTS tdf#147021 and takes out a sal_uLong tdf#114441 while here, clean out the rest of the sal_uLong's in that file to be sal_uInt64 to match timer.hxx which was changed by 9c7016b5b5 way back in 2015. Change-Id: Ie065885939a340d9a73af797fb4d7d6f76530242 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-29replace find_if by any_ofDr. David Alan Gilbert
A few cases where find_if is used just to test if there are any matches; use any_of as per tdf#153109 In document3 we can merge two identical loops. In langbox we can optimise the arg capture (Arkadiy's suggestion) Change-Id: I480b80ec1b859980b651c6d727e7fb5d01d390e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152201 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-29use more TypedWhichIdNoel Grandin
Change-Id: If7b4320e199a01f2614e3bf582e5d96fade22aa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152353 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-29tdf#155515 tdf#155528 crash on exitNoel Grandin
regression from commit 3b7db802731826b6cc3b55100470b0c61c1f2dfa Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 4 10:06:14 2023 +0200 tdf#105404 [API CHANGE] add index to accessiblity change event Fix a handful of things related to accessibility objects being destructed later than they should and consequently trying at access other stuff that has already been destructed. (1) AccessibleControlShape::disposing check the window still exists (2) DocumentFocusListener::notifyEvent, handle INVALIDATE_ALL_CHILDREN (3) hold DocumentFocusListener by weak reference in GtkSalData, so that it dies when the related UI widgets die Change-Id: I38bf68a748b37e6abc4a8cfcc961436728e081bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152365 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 921da60c0a7bf06943277d27dad3e10b19d7d5bd - tdf#154996 Add tabbed UI commands in Help page + refactoring Change-Id: I8d16368723426d6c7f9be66f8000fbe79e4e4e57 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152364 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-29Revert "Script that adds "com.apple.security.get-task-allow" entitlement to ↵Patrick Luby
soffice" This reverts commit ff95984c8e3475b7ff7832683d621bd09896852e. Reason for revert: The script was just a quick hack that I whipped up during other development work and I didn't know how to integrate it into debug builds by default. @Christian Lohmeier reviewed the script and noted the existing build scripts that add entitlements based on build type where I can put this new entitlement. Change-Id: I4246639e99a62c63fb1ba38b19cac0442c71c0a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152031 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-05-29Related tdf#tdf155376 fix minor memory leaksPatrick Luby
Change-Id: I9cdc5fb38ffba113e3d069d9d766dbe1a82c492d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152352 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit 7ae89a2ad89c9e7702fbd2b31269ee4c61fe5bcb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152316
2023-05-29Partial fix tdf#146626 Catch uncaught DisposedExceptionPatrick Luby
Fix crash due to an uncaught DisposedException thrown by SwAccessibleParagraph::getTextRange() by using the same try/catch block in -[A11yWrapper accessibilityAttributeValue:] in -[A11yWrapper accessibilityAttributeValue:forParameter]. Change-Id: Ifcaec3eb2d76f32bddc56a1242f6d86f8b90f782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152361 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit f8cc6f960e8aeb37547d447fed2b2c6e6ddc02e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152317
2023-05-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to f527d4cfc5f65bb6fec477f540da3794e9fa744d - tdf#154996 Add tabbed UI commands in Help page + refactoring Change-Id: I9fc6a419fbe838015dd991716b5dea682b99dbaf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152362 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-28Typo: aCatlog->aCatalogJulien Nabet
Change-Id: I875e94e47d44101a840b711de174f38ad4b85b4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152357 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-05-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to bb49f8d719951c9a1dcef0953e8b213def056f21 - tdf#154996 Review Common File menu entries Change-Id: I397d3ce8a0a0f89c835bcf31245dfef3ea8a745f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152358 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 98d5ed689681c18a27e8f03824a47cde3c376639 - Reformat table for Index Help page + refactor (no contents change) Change-Id: I02ac63520bdf3930129f6c1ccca725ea072740a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152355 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-05-28tdf#139863, tdf#155514: Don’t split COMPLEX text portionsKhaled Hosny
When a COMPLEX text portion contains more than one script, it gets split into multiple portions. This is broken into more than one way: * ScriptTypeDetector::endOfCTLScriptType() does not handle surrogate pairs, so it split the portion in the middle of a surrogate pair, causing tdf#139863. * If a combing mark of a different COMPLEX script is used, it gets split into its own portion, causing tdf#155514 This was supposedly done to fix https://bz.apache.org/ooo/show_bug.cgi?id=28203, but testing the documents from this bug report with this change does not show recurrence of any of the kashida issue, so this split is unnecessary. Change-Id: I9bd60efe3023b96ee74f861a5dc15a2229c27d79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152354 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-05-28Resolves: tdf#155453 formatting lost when formula bar edited via IMCaolán McNamara
do like we do for simple key strokes and forward to the ScModule InputHdl Change-Id: I2d99c23e8ac03b6de2498c6378a0dc5d11530248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152351 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-28tdf#154547: Improve Hebrew font preview sample textKhaled Hosny
The Hebrew font preview sample text include Nikkud (vowel marks) which are optional for modern Hebrew and not all Hebrew fonts have them, and for fonts lacking them we use a much shorter preview text. The inclusion of Nikkud is unnecessary and we don’t include vowel marks in many other scripts (e.g. Arabic where they are more used). This patch drop the Nikkud marks and leaves the sample text otherwise unchanged. Change-Id: Ie4e5abcd74599d25db41c4cdf7e1d3bf997a998c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152350 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-05-28[3.0] external/openssl: add patch for CVE-2023-0464Taichi Haradaguchi
this issue should be fixed in release 3.0.9 Severity: Low Security Advisary: https://www.openssl.org/news/secadv/20230322.txt Change-Id: I8d34acd72ac8eb7e9e83b241eb1235a93111884a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149639 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-28Use getXWeak in vclMike Kaganski
Change-Id: I665c9dc8c4f9cc4a996d9bf990cbfa33822bd07f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150885 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-28Use getXWeak in basegfxMike Kaganski
Change-Id: I650a8fcefd179937bdcbb6088658aa960008794d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150834 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-28Use getXWeak in embedservMike Kaganski
Change-Id: If50010a2b2ba18623bcf7c049e8f31091a9a46a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150847 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-28Use getXWeak in eventattacherMike Kaganski
Change-Id: I5f10d1404f28d3a16301bbfd755bdbc3886b16a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150848 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-28Use getXWeak in binaryurpMike Kaganski
Change-Id: If1891fc180126aa5d5ac92772cbca9b485619f46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150836 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-28Factor out DateTime::NormalizeTimeRemainderAndApply(tools::Time& rTime)Eike Rathke
Change-Id: Ie520b10baaeb4c94973c44435c3241e5d2254968 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152345 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-05-27cid#1448540 Dereference null return valueCaolán McNamara
Change-Id: I72fd7c1a38cb870d99ee085f4f511f2fb9d8d7af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152343 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-27cid#1531780 Dereference null return valueCaolán McNamara
Change-Id: I4aa66284b0a9948cd947cc99a119ce4ea2bbf26e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152342 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-27ofz#59362 aPardMap returns 0 'Which' for SID_ATTR_BORDER_OUTERCaolán McNamara
since: commit 839c5010241842835a1c066be0838df4a8a53dc7 Date: Wed May 24 16:40:59 2023 +0200 use more TypedWhichId in editeng cause operato[] is just a getter now Change-Id: I2c5cc21131dffd0e9840b65185c2491ed6183bd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-27Use getXWeak in testtoolsMike Kaganski
Change-Id: Iee8f1314fc3d924376b5b6ad6c683c7d451ab900 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150876 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-27Use getXWeak in ucbhelperMike Kaganski
Change-Id: I6bdc3acf86854fe3f91aa09cb52d67a2b11ca8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150879 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-27Use getXWeak in ioMike Kaganski
Change-Id: If2b40ecdca67c6d82ff1a87443cb8533401e9ae8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150856 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-27Use getXWeak in fpickerMike Kaganski
Change-Id: Iedeb452d49718b6e73a526da132bc0fc9b165fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150852 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-27Use getXWeak in UnoControlsMike Kaganski
Change-Id: I4e1deaffb3c6926bf57715cb10fc38bf59f791a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150880 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-27ReqIF: do not write 'align' attribute to 'div' elementMike Kaganski
To keep the alignment information, use 'style' in this case. Maybe it makes sense to unify on 'style' also in normal case in a later change. Change-Id: I6e07acd46fbabeaa47ae9dbe71c00e1b1abc6b73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152340 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-27Fix typoAndrea Gelmini
Change-Id: Id0d9335df80539877d1ee27e57e98b0a6aae75db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152337 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-27Use getXWeak in unoxmlMike Kaganski
Change-Id: I141bad0d1b244bd801f613f159b79c4518fdf252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150883 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-27Use getXWeak in unodevtoolsMike Kaganski
Change-Id: I71c8c7f26dac1ce97f29818c73f3268d948d57a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150881 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-05-27Unify Concat2ViewMike Kaganski
Change-Id: Idb0a0fc620ece33e7ed6bcec3cbd8a0a833b1e38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152314 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-01 18:28:12 +0000