summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-16do less copying when constructing 2d sequence (tdf#105575)Noel Grandin
instead of constructing a child sequence, and appending that a parent sequence, just pass the parent sequence down the call hierarchy, so we end up doing less copying. Change-Id: If39a0779e543c6aa01f5e2e3ae63d395e0c85f7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-16tdf#143896: FILESAVE XLS(X) 1001+ rows are lost after saving new fileJulien Nabet
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2bf3e0d00e3bccb5b250642ee0d3fdbe6cae8ecc tdf#104502 sc: skip hidden columns at printing pages Page calculation counted the hidden columns, resulted printing blank pages by accident. Extend GetPrintArea() and GetTableArea() to count pages without the hidden columns, too. Change-Id: I77e7d6d893967a3ddac4c7c4e225769b38b44649 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120552 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-16Rename setX/setY to SetPosX/SetPosY, to align with SetPosMike Kaganski
Change-Id: I856194f26fefad993f416d7b92b57a9417a3c0a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120546 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-16remove unnecessary captureNoel Grandin
Change-Id: Ib6f4b62601c68d04269eba66f3f68a7a62022aeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-16related tdf#134569 writerfilter: negative means table endJustin Luth
TableManager's EndParagraph uses mnTableDepthNew - mnTableDepth to identify that a positive is startLevel, and a negative is endLevel. So it doesn't make much sense to have this function return a huge unsigned int in case of a negative. As expected, an assert proves that LN_CT_TcPrBase_tcW can happen for both positive and negative, so the equivalent test is just a non-zero. An assert proves that startLevel always has a positive difference, so that clause can stay as is. Change-Id: I1b49dfae7087258e4ceed5fb45da0e62fd1f3b50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120525 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-08-16use tools::Json for cursor messagesNoel Grandin
and tweak the JsonWriter to produce output more like the boost propertytree, to make the cypress tests happier. Change-Id: Ia2062508ae9f14a5f89306042c33884ff300f478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119936 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d46c7bd597e51453ac420db97fd898ed2f3b26bf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120433 Tested-by: Jenkins
2021-08-16improve documentation for comphelper::OMultiTypeInterfaceContainerHelper2Noel Grandin
Change-Id: I7ac6cf075f2f143bf080d9ee2f74840c3f56d61a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-16tdf#126879 - Drop obsolete DOCTYPE HTML 4.0Andreas Heinisch
and use the HTML5 DOCTYPE declaration Change-Id: I00a769f2c8da876fd9435343c72f4d7685bc0cb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120378 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-16Resolves: tdf#142980 Special-case the very first listener added during actionEike Rathke
Change-Id: I8bc3475581d9525db8e83bc1551326c474e752bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119275 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-08-16tdf#130924 : replace debugging printf calls with SAL_INFO/SAL_WARNEmircan Agac
Change-Id: Iafe15a9ab48f1c0e09b5e6c176ecda3d5b4ce1bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120479 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-16no need to make a local copy hereNoel Grandin
Change-Id: I54891bccd13ee3e63a6c737c47754ffaea354692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120539 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-16Related tdf#143895: Mysql MEDIUMINT is DataType::INTEGER not DataType::SMALLINTJulien Nabet
Change-Id: I324b18cc164cb2f38b7b8411c557c6c208e8d69d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120536 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins
2021-08-16Drop tools::Rectangle::getX/getY, which are just duplicates of Left/TopMike Kaganski
The change allowed to simplify many places where previously this API was used, to avoid inefficient calculations (e.g., moving rectangle keeping its size, and then immediately changing the size). Change-Id: Ica2dc594d91cae83e2c2740c1f4fb23f44998916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120461 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-16tdf#143656: Tools > SQL : add a checkbox to enable Direct SQLJulien Nabet
Change-Id: Ib3902d031777643f4814e5cfb11fdd2e0d39fce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120535 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-16sc: lok: avoid selection jumps with multiple usersDennis Francis
In LOK case, avoid spurious "leavingwindow" mouse move events which has negative coordinates. We later use these coordinates to compute the cell address corresponding to the event to extend the selection which will be wrong in this case. Such spurious events occur for some reason when a user is selecting a range, (even when not leaving the view area) with one or more other viewers in that sheet. The root cause of these bad coordinates seems to be in vcl in winproc.cxx, ImplHandleMouseEvent() in the code block starting ``` // test for mouseleave and mouseenter VclPtr<vcl::Window> pMouseMoveWin = pWinFrameData->mpMouseMoveWin; if ( pChild != pMouseMoveWin ) { if ( pMouseMoveWin ) { Point aLeaveMousePos = pMouseMoveWin->ImplFrameToOutput( aMousePos ); ``` This needs more investigation. Meanwhile this interim patch fixes the issue of selection jump by avoiding those unhelpful mouse events. Conflicts: sc/source/ui/view/gridwin.cxx Change-Id: I01fb3ae6a3903ada2a44a8b3d2b4a46b0122326b Signed-off-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120317 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> (cherry picked from commit 7eb8a1d6c5697fd89ff75d3b116bbbf6c2de6950) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120443 Tested-by: Jenkins
2021-08-16tdf#50447 sw: track changes of character formattingLászló Németh
Only range of the formatting change was tracked, but not the original direct character formatting of the text. Now rejection of the tracked change of a text portion resets the original direct formatting. Note: nor ODT or DOCX export hasn't been supported, yet. See also commit 5322663f8234836a6a4aaaed025c158fd7e8b67a "tdf#126206 DOCX: add rejection of character formatting changes". Change-Id: I6e94a797605187cff232c3d7dd505c769b70601b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120466 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-16backendtest: Asymmetrical Filled Drop Like Shape testhomeboy445
Change-Id: Iacf121483aefa71d6f24e14782fcaf22c0d5d56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118859 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-16Revert "tdf#143114 Avoid StartDrag on TreeListBox when CaptureOnButton"Julien Nabet
This reverts commit ca7dab5d96e73b7b4b045e2460e0b2ee150757db. It created tdf#143749 + the dup tdf#143865 Change-Id: Ibd68c45213491b0df7dc36f0418de307412499c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120531 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-16ofz: log with date -uCaolán McNamara
Change-Id: I9e85ee0f98c3b7cfab15db5e93f65a053996bf00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120534 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-16ofz: use system curl .a and system glm headersCaolán McNamara
Change-Id: Idf4aa5f8d76afb3f0842830c2c874a10241ecc3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120528 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-16pass OutlinerParaObject around by valueNoel Grandin
since it uses o3tl::cow_wrapper, so it is really just a wrapper around a pointer, no point in allocating it on the heap Remove assert in SdrText::SetOutlinerParaObject, which was bogus anyhow, because it was comparing pointers, not deep equality. And since we are now being more efficient and avoiding copying of the internal data in OutlinerParaObject, we hit this assert. Change-Id: I6dbfaab5ee2ca05b2001baf63110041e469df9c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120510 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-16Use o3tl::toTwips to define MINBODYMike Kaganski
This changes its value from 56 to the proper 57. See 9be17c52b7c565758088b8020a543d7b840e31a7, which had changed the previous 5-mm value to the incorrectly rounded 1-mm value; and cefce1a247a4674c5726a31b61571eab16328a0b, which had unified the other places mentioning i19922. Change-Id: I7186320b4c1a2a65a6f728ed8bafcbf0eb45c4cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120441 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-16LOK: freemium: added new parameter in the APIPranam Lashkari
Added new parameter in the freemium API to make it consistent with other APIs Change-Id: Ieb73fd1f97e1886051b1de44a93ba87622862e2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119974 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120484 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2021-08-16sfx2: fix uninitialized SfxViewShell::mbLOKIsFreemiumViewMiklos Vajna
Introduced in commit 1b9fe58acb7b5bbbc83ecca30e17663fff7f0db4 (LOK: introduced Freemium LOK API, 2021-06-02). Change-Id: Ifdd6c13a64a167fa00b0305441c52340167f3809 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118632 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120483 Tested-by: Jenkins
2021-08-16LOK: introduced Freemium LOK APIPranam Lashkari
also block the uno commands from deny list Change-Id: Iee994411891b73b865e6496403682f996d5e9321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116384 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120482 Tested-by: Jenkins
2021-08-16Cleaning up decleration and initialization of unique_ptr variablesHossein
Cleaning up decleration and initialization of unique_ptr variables pPageSizeItem, pPageLRMarginItem, and pPageULMarginItem according to the request: https://gerrit.libreoffice.org/c/core/+/120456 Change-Id: I0cf5149308fe06c10403bfb82ca6a1786096bf3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120520 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-16tdf#132739: sw_htmlexport: Add unittestXisco Fauli
Change-Id: I69a5b0659d8b9a13b662ee1e7612e056f9d3ce4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120512 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-15crashtesting: failure on export tdf87915-2.odt to docxCaolán McNamara
in this example ConvertToPolyObj returned a SdrObjGroup* so cast to SdrPathObj* goes wrong. new since commit 61ef73bb9e06ac7325abc26698314d7e35c164cc Date: Sun Aug 8 01:05:09 2021 +0200 tdf#143432 and more, improve wrap contour export Change-Id: I80312971fbe7e5b6e17e7ae41f2afbbb05f21d76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120515 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-15tdf#142760: sw_ww8export3: Add unittestXisco Fauli
Change-Id: I82a1e8b8ddf5e392b9c2b578247a2364864a0970 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120513 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-15tdf#143860 non-primitive needs custGeom not prstGeomRegina Henschel
Error was, that for a custom shape with type 'non-primitive' method DMLPresetShapeExporter::WriteShape() was called. For such shapes the method GetOOXMLPresetGeometry() returns preset type 'rect' and in case the shape had no handles, that preset geometry was written. In my solution I exclude shapes of type 'non-primitive' from using DMLPresetShapeExporter, because such shapes never belong to a OOXML preset shape. Change-Id: I714f69c98fe15c2b7e70dc0a474a7f85ad757034 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120511 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-08-15Fix typosAndrea Gelmini
Change-Id: I3b75c0b8500bebe3025e038dba02a0d6f444bce6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120181 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-15rtl::Static -> thread-safe static localNoel Grandin
Change-Id: Iac0501e6aa35cc3d8e62f6b6e68b76cf70233aae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120459 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-15Simplify tools::Rectangle a bitMike Kaganski
1. Simplify/delegate ctors 2. Simplify getWidth/getHeight 3. Simplify expand 4. Simplify operators += / -= / + / - Change-Id: I023aa1bb2905394fbbd29adc7c544d629f9ae2d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120476 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-15Add the possibility to check if a mathml attribute is manually setdante
Change-Id: I9c5eaee8e2cce47d9286306031e807ca2c0eed57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120473 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-15Add the Form attribute to modante
Change-Id: I4f64460e15c707fa8ecdcfdfbea460b2f1410947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-15Avoid computing LanguageTag fallbacks several hundred timesEike Rathke
... over and over again even for known and present locales for each and every localizable config item. Change-Id: I19974c56169f45a7c53ed6b0eede47365e1365dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120496 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-15Resolves: tdf#137742 Workaround cheesy Google Docs writing language-only tagsEike Rathke
Change-Id: I2dc85abb70d53769d2e36102070e30ed71e8d888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120495 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-14upgrade to openssl-1.1.1kCaolán McNamara
Change-Id: Ibd930ab4f97e2f74868b73163d7f2f46fb466749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-14cid#1490212 silence Untrusted divisorCaolán McNamara
"The divisor could be controlled by an attacker, who could cause a division by zero." but this division can only happen if the divisor is either 8 or 4 Change-Id: I7cae93f48d84e023912b8613be89cf9db5589d4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120489 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-14ofz: build with system libexttextcatCaolán McNamara
Change-Id: I1dd2c49bfc5577a8502eb42721f3ef9b08f8fdb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-14tdf#142605 use frame size in oox export of BezierCurveRegina Henschel
The export had used the bound rectangle of PolyPolygonBezier. But that contains control points. Use API position and size instead. I have not incorporated the changes into existing WritePolyPolygon, but have made an own version for SdrPathObj, because I find it easier to read and maintain, than having a lot of case distinctions depending on the shape type. Change-Id: I2e646c4f5fa37174c4979855212ca72f2dfa447e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120407 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-08-14tdf#143148: Use pragma once in sdextYildiray
Change-Id: Ic626b9064d9bcd024f938bbd43375bc3fff5838f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120178 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-14Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to a5ea0c841f16a2cfaa8b00ca15aecae1b59e9d1b - Create help page for the "Search Commands" feature Change-Id: Ic62e9671575709ca3ac788495edaf4b2753499ee Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120245 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-14Fixed documentation references to the custom shape generate scriptHossein
* Fixed references to the custom shape generation script in the oox/README.md to use generate.sh instead of README.md * Added README.md to oox/source/drawingml/customshapes folder * Moved documentation parts from the script to the README.md The README script was renamed to generate.sh before in the commit 59577dbb84fae18a3216d57ffec6008af157ce9b Change-Id: Id167b32c7a101806c33126ea1642a0194d693231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119376 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-14flatten svt::table::DefaultInputHandlerNoel Grandin
Change-Id: Idba4039bbedd7c276505c5e9763b559d505cf7a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120467 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-14flatten OFlowChainedTextNoel Grandin
Change-Id: I0836d1f850c71700f8691cf8847e4f4d30d4dbb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-14tdf#140226: use StaticWhichCastEmircan Agac
Change-Id: I5eb25fdfd629e397582cd49e3fa4acab32c05bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120456 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-14tdf#140226: use StaticWhichCastEmircan Agac
Change-Id: I54f898d3341155d88b6b9599995b9e5001de71c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120406 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-14formatter maps can use unordered_mapNoel Grandin
Change-Id: I733537e98cccc1a5dcb2c275b3baeb56af5f15c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120468 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-14tdf#140226: use StaticWhichCastEmircan Agac
Change-Id: I013b6ff371992a31a1ee11f93072eeb49566fe52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120401 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>