summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-09-18tdf#130857 VclBuilder: Move class/id/custom prop extraction to helperMichael Weghorn
Extract parsing of these attributes from `VclBuilder::handleObject` to a new helper method `BaseBuilder::extractClassAndIdAndCustomProperty` in the base class. Change-Id: I248448407db446fd61bf91bf13c9bc187e0706d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162918 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-18tdf#119785 Implement the EMF TA_RTLREADING alignment flagJonathan Clark
EMF has two ways to indicate that text should be treated as RTL: - The ExtTextOut ETO_RTLREADING flag - The SetTextAlign TA_RTLREADING flag Previously, only the former was implemented. This change implements the latter. Change-Id: If1023b4a0a3b6eb2ce47d2b764edbfd1a5c0dd5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173579 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-09-18Correct grammar in strings for A11yDione Maddern
In cui/inc/strings.hrc - Ensure that strings for A11y options use correct English grammar. Change-Id: I80a6fbc07d6c34b52d674c3650905a2865ce3e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173565 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-09-17tdf#162988 - A11Y sidebar: fix hyperlinks false warningBalazs Varga
Better to check the SwpHints of the textnodes then iterate through on the xParagraph's xTextRanges to search for a11y hyperlink warnings. Change-Id: I19a3eddd53f122bd4290e5b93e4784b89f65427d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173560 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-09-17tdf#163006: fix keep-together rows height calculationMike Kaganski
In commit dcb682563b24bf487a40a9fe7710b4d500850a52 (INTEGRATION: CWS swnewtable (1.92.14); FILE MERGED, 2007-02-28), a code was introduced in sw/source/core/layout/tabfrm.cxx, that considers the rows having m_bIsRowSpanLine set. In SwTabFrame::CalcHeightOfFirstContentLine, when getting pFirstRow, such a RowSpanLine was skipped when counting the keep-together rows. However, it was implemented incorrectly: the resulting number of rows, excluding the RowSpanLine, then used in a call to lcl_GetHeightOfRows, which didn't skip the said row, and thus calculated its (zero) height instead of an actual keep-together line. This fixes the said calculation, and also another place in the same file, where the same calculation is done, where RowSpanLine's weren't checked at all. Change-Id: I125a8f6de389d6b7600f3e13343594ac82249d29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173559 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-17wina11y: Drop CAccImage::GetXInterfaceMichael Weghorn
Just use the `m_xImage` member directly, as already happens just a few lines above. Change-Id: I00f7e871a2cb5eb301ba033944d8d529cc10bbae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173536 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Just assign the ReferenceMichael Weghorn
Change-Id: Ibe0e9f1c8c6838044355db987d08298b267bed64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173535 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Rename CAccImage::{pRXImg -> m_xImage}Michael Weghorn
Adhere to naming conventions to make clearer this is a class member, and a uno::Reference. Change-Id: I804bb66d88675d1f5e7e0ee31f9244db5abf0125 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173534 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Check reference in CAccHyperLink::get_startIndexMichael Weghorn
Check the reference is valid in this method as well, just like in all of the other API methods. Change-Id: Ibb1a6a8b290ffefc502966ed0372c4e421fe68fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173533 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-17wina11y: Drop CAccHyperLink::GetXInterfaceMichael Weghorn
Just consistently use the `m_xHyperlink` member directly. Change-Id: If2ac4150b5b733005b916d0c5f11e8c711d95c7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173532 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-17wina11y: Just assign the ReferenceMichael Weghorn
Change-Id: I8ca9cd55723b1775284b23e13db409fc5d47005c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173531 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-17wina11y: Rename CAccHyperLink::{pRXLink -> m_xHyperlink}Michael Weghorn
Adhere to naming conventions to make clearer that this is a class member, and a `uno::Reference`. Change-Id: I29caf6ad2d0adcfca430df72c2638dbd4ee06f1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173530 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-17wina11y: Drop CAccEditableText::GetXInterfaceMichael Weghorn
Be consistent and just use CAccEditableText::mxEditableText directly, as already happens in each of the methods just a few lines further up. Change-Id: I70637714623f0410a60778e7bc1f4b007e034ddf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173529 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: Just assign the referenceMichael Weghorn
operator= knows what to do, no custom handling needed. Change-Id: I9a64cc371e5b14c146e311364d1b4212d519d746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173528 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-09-17wina11y: Rename CAccEditableText::{pRXEdtTxt -> m_xEditableText}Michael Weghorn
Adhere to naming conventions and use a less cryptic name. Change-Id: I13ff9f515351fbbf0c749522edfb739e15626a67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173527 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17wina11y: clang-format CAccEditableText sourcesMichael Weghorn
This in particular ensures that try/catch blocks are indented by an additional level, improving readability. Change-Id: I7fd538434bd8edb5748bb551fdfd2d4966293bd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173526 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17Colibre: fix typehistogram_16.png iconIlmari Lauhakangas
Change-Id: Iebbe9f31d9c42dc2af82a9afefdae1fd711a4677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173562 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-09-17Avoid -Werror,-Wcast-function-type-mismatchStephan Bergmann
...as seen when building LOWA (i.e., --disable-dynloading) with a recent Clang with <https://github.com/llvm/llvm-project/commit/999d4f840777bf8de26d45947192aa0728edc0fb> "Split -Wcast-function-type into a separate group (#86131)", where -Wcast-function-type-mismatch generally warns about casts between incompatible function types... > cppuhelper/source/shlib.cxx:294:23: error: cast from 'void *(*)(void *, void *)' to 'ImplementationConstructorFn *' (aka 'css::uno::XInterface *(*)(css::uno::XComponentContext *, const css::uno::Sequence<css::uno::Any> &)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch] > 294 | = reinterpret_cast<ImplementationConstructorFn *>( > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 295 | map[i].constructor_function); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ...but not for the special case of casting from/to void(*)(void). (Using the correct function type > css::uno::XInterface * (*)(css::uno::XComponentContext *, css::uno::Sequence<css::uno::Any> const &) throughout would be even better, but doesn't easily fit into this C code that is included in low-level places that don't know those UNO types and is shared between LOWA and Android etc.) Change-Id: Ic4dbabbff0f772b34cf692db968c3ad257c37cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173463 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-09-17Fix missing quotationStephan Bergmann
...that appears to be broken ever since 9892af3cbf85e9793f21683aa16c84354d866ad5 "Modernize wasm debug symbol generation" and to have gone largely unnoticed, but now happened to cause > ./configure: line 14652: -gpubnames: command not found > checking whether ccache emcc supports ... configure: error: no in an odd Emscripten build of mine where I accidentally used a broken emcc (so that autogen.sh started to draw bogus conclusions and get into otherwise untested code branches) Change-Id: Idff3a52d61464f00f2c811b207c5a214672b5b42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173480 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-09-17ofz#71606 use extended upstream solutionCaolán McNamara
Change-Id: Id4c511572792da1edd7ebbe15c1fb994ac30bdd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173561 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-17This should iterate over the thesaurus languages, not the spelling onesCaolán McNamara
Change-Id: I94410274f7afbc0a6bc33fe43beb9810a905dfe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173467 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173556 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-17cid#1607992 silence Overflowed constantCaolán McNamara
Change-Id: Ib5ceaa4f8f42c897dba8f941e4b094d9f522b3bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173555 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1608032 Overflowed constantCaolán McNamara
Change-Id: I4b74a139483ff932e71102ec73ab6d352e533245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173554 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 74180ce0f912f7a432f509b8c5ac9239e4f74d9a - tdf#163012 Add description of \w and \W to regex page Change-Id: I11dc5b3eee4af0447a7450fa71fa25f8c1327a03 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173571 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 589c8137e03b1bbb7647cbfaf0a6585d60fbfc9b - tdf#162847 Resize icon in page. + refactor partially Change-Id: I9e547dcab48fe5413f92076c365bf7db952c06c7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173570 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-09-17tdf#130857 VclBuilder: Turn extractOrientation into static helperMichael Weghorn
Turn the `extractOrientation` helper function into a static helper method `BuilderBase::hasOrientationVertical` for reuse in the pending WIP Gerrit change to implement a `QtBuilder` [1], which currently duplicates this method in patch set 18. [1] https://gerrit.libreoffice.org/c/core/+/161831/18 Change-Id: I8255188ae66727d0832e8d6b41952649de07a679 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173546 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-09-17Resolves tdf#152440 BOOK VIEW: Switching page view to book viewJim Raykowski
or from book view results in a switch to a semi-random page Change-Id: I2e3e63430fb2ed04d2f71cf2e716844b85f440f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173510 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-09-17cid#1608125 Overflowed constantCaolán McNamara
Change-Id: Iec74e8824eab7d9e49ebe4d46912a717a3990c92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173553 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-09-17cid#1608157 silence Overflowed constantCaolán McNamara
Change-Id: Ie19c388b983800b514ed3b309955968eccd24efb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173550 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17use more concrete UNO types in swNoel Grandin
Change-Id: I0f84ce7116441abb2359ee756c912ae663baa2fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-09-17cid#1608165 Overflowed constantCaolán McNamara
Change-Id: Ie360d3c479e639c3b97ab532d5f0778809ca2d44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173549 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1608224 Overflowed constantCaolán McNamara
Change-Id: I6a76e85754120ef0bc9d3b357a622d312362a72c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173548 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1608244 Overflowed constantCaolán McNamara
Change-Id: Ia96ff4eb0840c6136cb6cd0eefee1cc487bce355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173547 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1608322 silence Overflowed constantCaolán McNamara
Change-Id: I23229d2bb29c926f9840f11b09ebc591f1b0047f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173544 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1608561 Overflowed constantCaolán McNamara
Change-Id: I3115263da1c76f635d544e41c3cf96e068b34324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173543 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1608578 Overflowed constantCaolán McNamara
Change-Id: Id7f5b94208f75a0fdc8ebb769b5a8265312c0995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173542 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17ofz#71606 use better upstream solutionCaolán McNamara
Change-Id: I088db3a8defd4cddee657c25d35724932339b983 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173541 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17these can be constCaolán McNamara
Change-Id: Id560175cc69162b362e8f96b2dc0255118387f8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173539 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17Output what languages are handled by LanguageToolCaolán McNamara
to explain the absence of languages that are listed by 'Preloading' because the languages handled by a remote LanguageTool are removed from the languages handled with local data. Change-Id: I203657f68a7b9399e39ebf9ab9447c7ae56efe68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173448 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit c5fc86e770901eb90356cb31d4ac71ac7dad9ce6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17move setLanguageToolConfig out of extern "C" zoneCaolán McNamara
no logic change here Change-Id: I29153a11e1b841fa078d29a6431cd5af1179672e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173450 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 26e433e0e3c6dfbf2569c3b6f0a14249dc4d0c1f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173537 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17unoxml: move checkSPARQL from Java to CppUnittestXisco Fauli
Change-Id: Id8adaec00b9920966c91471fdd32720337a8c414 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173462 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-17unoxml: move checkRDFa from Java to CppUnittestXisco Fauli
Change-Id: Ife5cd7398bdbacbd8189c8451dab6351590052e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173484 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-17lok: sd: slideshow render improvementsMarco Cecchetti
Changed the slide layer message layout. Sometime some text field layer was missing. Try to skip empty layers. Change-Id: I52f00e637da7ab705a1fcb52a70af88cf619c8f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173540 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-09-17sc: use SAL_RET_MAYBENULL() in GetViewBindingsXisco Fauli
Change-Id: I67e3e7921869a22d2bf6ce713fd581a9c3881aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173521 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-09-17Related tdf#161657 Define default Comments style attributesKira Tubo
* Line spacing = Single * Indents/Margins = 0 * Top/Bottom spacing = 0 * Font color = COL_AUTO * Highlight = None (COL_TRANSPARENT) Change-Id: Idd0d4d896a0cc6021c99c7c13280ef6e18ae2602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173507 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-09-17cid#1607476 Overflowed return valueCaolán McNamara
Change-Id: I38c72db66e47b0e09a53413457f167159c599202 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1606987 silence Overflowed integer argumentCaolán McNamara
Change-Id: I77380d12a5d51c3debb1365a5fc9b57c33299eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 614dd5fba24a70bc5b5a4cb43eb431fc4dacd3c0 - tdf#162607 disambiguate hid2file.js, InsertAuthor + moved insert author to shared/ + Document access command, delete old command paths Change-Id: Ic2ce72a47f842b6bdaf8cdb7469beaded3f43f06 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173483 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-09-17cid#1608367 silence Overflowed return valueCaolán McNamara
Change-Id: If60d9607678ac9193923cad63895d654b8283ae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173522 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-17cid#1608226 Overflowed integer argumentCaolán McNamara
and cid#1607920 Overflowed integer argument cid#1606589 Overflowed integer argument cid#1606576 Overflowed integer argument Change-Id: I2b1c0e871e7f7a913e0f14128fb13fc04d993ca1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173520 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-10 22:39:57 +0000