summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-10-07xmerge: reuse the value of node.getNodeName() and remove duplicated constantsRobert Antoni Buj i Gelonch
Change-Id: Ia835139496ab8e5230a09df2caf23637a5559ba4 Reviewed-on: https://gerrit.libreoffice.org/11836 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-07fdo#81475 Finalizing new layout of Writer formatting toolbarYousuf Philips
Change-Id: I0d65c96d8d0447ab2191c441acfd5bd9ce8015b8 Reviewed-on: https://gerrit.libreoffice.org/11817 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-07I shouldn't be shy, just assert()Tor Lillqvist
Stephan dislikes "defensive programming" and I trust him. Change-Id: Ic4864de98a5155129179eb89873f3ffdc8921614
2014-10-07Don't call comphelper::rng::uniform_real_distribution(a,b) with a==bTor Lillqvist
Change-Id: I95a3ac8da83e02001de13af8d31a04fe0d654dc0
2014-10-07Handle incorrect usage of uniform_real_distribution()Tor Lillqvist
uniform_real_distribution(a,b) should be called with a < b, otherwise the result is undefined. Currently, when called with both zero, it gets stuck in a loop. Not sure if a blunt assert() would be the right thing here, so I just return a if a >= b. Change-Id: I769688c7192bd02bad24ad597948984db56dd4fc
2014-10-07Use constants for ST_Em valuesMiklos Vajna
No need to adapt dmapper/rtftok for this one, as those do not handle <w:em> ATM. Change-Id: I88da1d0dae804e3d054b7d4158a81cb64cc4b600
2014-10-07-Werror,-WuninitializedStephan Bergmann
Change-Id: I91333f5290c84c6317b85572824be065da9cf64b
2014-10-07~SdUnoPageBackground() gets a SolarMutexGuardMichael Stahl
Change-Id: I76582bb6a1a8dee56611f1463d3e63246eefb310
2014-10-07fdo#79604: sw: fix clicking on hyper-links in Draw objectsMichael Stahl
The URL is dispatched in MouseButtonUp(), but this relies on MouseButtonDown() not selecting the drawing object when the cursor is over an URL field. (probably regression from commit 7e2f98d0a0c4a0f36a94353a256e7cc5caa3113b and commit 5ed14025645200c77249da364870f5772c01df17) Change-Id: Ib1504baff5d1fffd6ce53b41d3ff726d8e4d5c9d
2014-10-06-Werror,-Wnon-virtual-dtorStephan Bergmann
Change-Id: I8fa5c345760185baf1f0fa83c94898b2a5a86719
2014-10-06Remove pointless commented-out 'virtual' keywordsTor Lillqvist
Nobody knows any more what such a metacomment was supposed to mean, if it had any deeper meaning at all. Change-Id: Iefb4fedc7b833c09ee0e39b3eb28202229323ef2
2014-10-06avoid use of ref. to possibly deleted objectDavid Tardon
Change-Id: If5977b280fed8d8b053f59852d3984a59ce61a69
2014-10-06Revert "ADO driver: don't override a virtual method just to call the one of ↵Lionel Elie Mamane
the parent" This reverts commit 220deb0a0ed7b3efa14088acdab0520709309105.
2014-10-06Revert "ADO: don't override a virtual method to call the one of the parent"Lionel Elie Mamane
This reverts commit fa8f2fdf45c168a25dd955ebd24780b4863d6cde. Change-Id: I252e29648fb59a15379ba2f3b63d6914a7fc3a93
2014-10-06ADO: don't override a virtual method just to call the one of the parentLionel Elie Mamane
Change-Id: Ibae309ffbb7b2500c9113a95ca3fc508de378976
2014-10-06mozab driver: don't pretend to implement an interface one does notLionel Elie Mamane
Change-Id: I8ab2e2691ecf35e00283bd3144b2f4c8203adc3a
2014-10-06ADO driver: don't override a virtual method just to call the one of the parentLionel Elie Mamane
Change-Id: I39020452e8ff4b17b0c1cfb9ff54bf650ab97fc3
2014-10-06ADO driver: don't pretend to implement an interface one does notLionel Elie Mamane
Change-Id: I6234974cfc1b7650a35b8f7b9a4132acf797c91b
2014-10-06warning C4101: unreferenced local variableStephan Bergmann
Change-Id: I526e68b93f9665db25a824cc44ff231bcef29277
2014-10-06loplugin:unreffunStephan Bergmann
Change-Id: I00240e0d17e40e187b82875bbd25a0630120c4d7
2014-10-06encrypt sf_508f4e1..rtf to avoid it triggering virus detectionCaolán McNamara
use name CVE-pseudo-2009-0238-1.rtf to record its detected as Virus:Trojan.Mdropper and pseudo because its just a fuzzed file from some random .rtf and not an original reproducer for CVE-2009-0238 Change-Id: I85f6a72e0d32c14ea27cbe03bc4da3c2306fd1f5
2014-10-06Resolves: fdo#80101 inserting non-chart as chart -> unhandled exceptionCaolán McNamara
Change-Id: I4d5438292d9a5c49f1336304ebd3dc4e155dd212
2014-10-06Resolves: fdo#84588 loop in TableInfo::getNextNodeCaolán McNamara
Change-Id: I5bb44dc94041c3b3cd9d80ba125594a48c9c921f
2014-10-06cast to size_t altogetherCaolán McNamara
Change-Id: I93cb374bd9743c45c4f3a98799a5f448dbb46fd8
2014-10-06Related; #i125163# rename IsAdaptedToNewFillPropertiesCaolán McNamara
to supportsFullDrawingLayerFillAttributeSet so as to rename our equivalent solution of d3de12fcfc85feb36eda3b0495807ef11d8fe772 "Resolves: fdo#81277 missing table cell background color in doc/html import" with that of 36cc153d32bc262c2285d333a1369f6ca36a7fba "i125163 Corrected FillStyle handling for tables in Writer" Change-Id: If8ecbc712e01d823d034ff3771bf38a4df16368d
2014-10-06SwTxtNode::Update: don't move anchors at insert positionMiklos Vajna
Use cases: 1) User of the XTextAppend API's uses appendTextPortion(), then appendTextContent(), then appendTextPortion() again. It's expected that the text content will be in the middle of the paragraph, but before, it was at the end of it. It's possible to work this around by inserting the text contents only at the end of the paragraph (like it's done for ODF import in XMLParaContext::~XMLParaContext()), but probably it's not a good idea to copy&paste this workaround in all the import filters. 2) User types some characters in a new document, then inserts a picture, and sets anchor type to at-char. Now the anchor point is set to the end of the paragraph, but it's impossible to type anything after that character. To be fair, now it's not possible to type something *before* the anchor point, if it's at the first character, but hopefully that's less of an issue, since setting the anchor type to at-char sets it to the end of the paragraph, not at the start of it. Change-Id: Ia8b33e8880aae86f62fae09cd5ac1cf82c83320f
2014-10-06Missing includeStephan Bergmann
Change-Id: I47ddb95018109e5e771324b699dfdc10f529dfc4
2014-10-06Resolves: fdo#84649 can have negative values from ConvertToModelPositionCaolán McNamara
Change-Id: I570ee54e15a4cd4b11da26004164d9e6a1d8cdb9
2014-10-06when size_t == unsigned intCaolán McNamara
Change-Id: If8cd3632d69f6456b0e1351efac0e428e0093e3b
2014-10-06Refactor giant SwDocTest::testModelToViewHelper() into smaller testsMatthew J. Francis
This is to clear the way for following bugfixes which will add to / amend these tests Change-Id: Ie97aba72f1a4c7b1be37577b9bcab2b2f0750d17 Reviewed-on: https://gerrit.libreoffice.org/11808 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06scripting: line break (code formatting)Robert Antoni Buj i Gelonch
Change-Id: Ib1a8d7e4bdaad2f4eae822d9af280fd5b6f9dd7b Reviewed-on: https://gerrit.libreoffice.org/11794 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06fdo#75757: remove inheritance to std::vectorTakeshi Abe
from PptSlidePersistList. This also puts in assertions that every entry in a PptSlidePersistList is non-null. Cf. 9536a28ede89e8c29940e8ba225215a45667062c Change-Id: Iea35532ed668e58a3f02d3f3433a66c2d4e1fe2a Reviewed-on: https://gerrit.libreoffice.org/11807 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06fdo#71248 Excel VBA: ActiveDocument is not tracking currently selected DocJustin Luth
Change-Id: I86606646206ec26e2822a6e27888537d44351b7b Reviewed-on: https://gerrit.libreoffice.org/11725 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-06Resolves: fdo#84698 crash in autoreplacementCaolán McNamara
Change-Id: I44d5dacb21870f77ca993b24f3a31433edb17c6d
2014-10-06drop connectivity testmoz workbenCaolán McNamara
Change-Id: I09b387606dee76605ad60dcf8cfb3fc68057d7be
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-06Related: coverity#704049 Unchecked return valueCaolán McNamara
surely this should be IsLess not IsEqual, i.e. see commit 86a3fe47a66950e26d23d7d7f2680fa7d4fb0839 Date: Sat Oct 4 21:36:27 2014 -0500 coverity#704049 Unchecked return value and commit 3edb1dcdc82304c418fc32212bb0bdf2c92e414e Date: Wed Jun 26 08:32:38 2002 +0000 #99877# Phonetic sorting for Asian languages Change-Id: I6c78e388e986577c34b37643a877ab7f5c17b173
2014-10-06convert to floating point before divideCaolán McNamara
Change-Id: I0328ca6594b3809210ea124dcb744bad3b5eb92e
2014-10-06gbuild: enable -Wnon-virtual-dtor for all GCC platformsMichael Stahl
It was disabled globally at a time when GCC did not yet support #pragma GCC diagnostic. Change-Id: I062f6b437e6119203f2b0824a25238b45b4f4e79
2014-10-06gbuild: -Wnon-virtual-dtor and strict aliasing workaround for GCC < 4.6Michael Stahl
... is obsolete, remove that. Change-Id: I541de32ac4389d8049c25c98b63a69d084d1594d
2014-10-06configure: another GCC version check that is always trueMichael Stahl
Change-Id: Iafbc0dadc1aba4267414e2c6653bf306e4d84f4c
2014-10-06configure: for C++11 support, at least GCC 4.6 is requiredMichael Stahl
Change-Id: I0b61d738a85fc0d874fa9e18b4af4ebde5a40385
2014-10-06Related: fdo#58277 if the SwFrm is not IsValid so are its portionsCaolán McNamara
i.e. they don't necessarily match the SwTxtNode anymore, e.g. content deleted from node, SwFrm is invalid, old portions refer to old offsets not new ones yet Change-Id: I755051cd647aa7bb203a6e1f815193fb6ec39191
2014-10-06fdo#84658 on reexec, cancel modification before resetting IsModification stateLionel Elie Mamane
Change-Id: I878bff4d36ca1c2dd9474c937b03d0b366a6e911
2014-10-06It is "template library", not "tools"Tor Lillqvist
Change-Id: I5ca7b0a0374a9ed0090413e8c6045e5d13097301
2014-10-06Add guess at what o3tl meansTor Lillqvist
Change-Id: I69c8ce10140e92714e9d5c4b4173ade59d36be08
2014-10-06Don't unintentionally unload the tk libraryTor Lillqvist
Fixes the root cause for the crashes in vcldemo and ui-previewer that indirectly were fixed by 0b7631bccb2a47ab71a0c1edbabe8a5892ff5f9c and f5cfed29b05184894ec6ad2d14f73bff0b5a2783. Those two commits are now reverted. Change-Id: If5dac37f032d2b74c977562c339e9799bbc4454c
2014-10-06fdo#39468 Translate German comments - sw/source/core/Philipp Weissenbacher
Change-Id: I64743b4f6b7bfd44b410d63ab13298a000a47221 Reviewed-on: https://gerrit.libreoffice.org/11821 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-06Improve Denglish and reformat commentsPhilipp Weissenbacher
Change-Id: Ieb0d47240209f35a0558cb788a21ab45b405eb47 Reviewed-on: https://gerrit.libreoffice.org/11820 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-06Remove unused macrosStephan Bergmann
Change-Id: Id76b285d70acb4de3ab27dbf2f0f0bb4b46735c7