summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-27mysqlc: Fix issue by freeing result setsTamas Bunth
Change-Id: I8a5f886306e028f06243768376b2a6c55df6063c Reviewed-on: https://gerrit.libreoffice.org/59210 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-08-27libreofficekit: update lloconv git URLMiklos Vajna
Change-Id: I3a1699efe5335c43f79a15c3487f8deb7d1be5c6 Reviewed-on: https://gerrit.libreoffice.org/59635 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-27tdf#42949 Fix IWYU warnings in sd/source/ui/inc/[n-s]*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also a bit of fallout management overreaching into include/ Change-Id: I99bd4527ecf34e5193602f0e9dcb33b504e8c9e1 Reviewed-on: https://gerrit.libreoffice.org/58808 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-27uitest interpreter: some improvementsSaurav Chirania
Change-Id: I7b768694ba5a82f7273fd7641fae5c3fc84233a6 Reviewed-on: https://gerrit.libreoffice.org/58340 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
2018-08-27bump to latest cairoCaolán McNamara
Change-Id: I001da359569d37afe482cdbb50e9c8b3ced24aff Reviewed-on: https://gerrit.libreoffice.org/58134 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-27Resolves: tdf#118382 crash on paste of rtfCaolán McNamara
into an existing document since.... commit deaa16bd24fba4a3a6b072ab2b94542a7dbd41c6 Author: Serge Krot <Serge.Krot@cib.de> Date: Mon Jan 29 12:17:06 2018 +0100 tdf#72942 Do not overwrite styles from the inserted doc During inserting of the text from the external document we should not change original default styles in currently opened document. because missing styles aren't created, so there's exceptons thrown on their use. I see that the m_bIsNewDoc flag is already checked for since... commit 5ebe826caf75e8d00656b3333385bf0bbc05cb27 Author: Miklos Vajna <vmiklos@collabora.co.uk> Date: Fri Oct 4 11:02:59 2013 +0200 fdo#69384 fix impress -> writer copy&paste Regression from 2ade07126971b79c92f729fae5709f2e2e2b495c (fdo#62044 RTF import: don't overwrite existing styles when pasting, 2013-06-04), during paste, if existing style was found, then the intention was to skip that style, but instead we tried to create one. in the body of the following loop, which should mean that existing styles are left alone and only missing styles created if we remove this hunk of the tdf#72942 commit Change-Id: Ia4aedb5e309c991490656061aa20d11ff24f4f9e Reviewed-on: https://gerrit.libreoffice.org/59519 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-27--enable-ext-mariadb-connector was removedStephan Bergmann
...in 26b40fcfc67480e75bd9959b0c5cb9db10fdf6a1 "Moving mysqlc into connectivity as a library", apparently without replacement Change-Id: Ia1d32f98bd90efe2fcd4441dd84cd1862a4daa70
2018-08-27-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I8c71fe9a5ae0d228313b6b66752ee93aae72f539
2018-08-27svl: Avoid unnecessary indirection in SfxItemPropertySetInfoTakeshi Abe
Change-Id: I56db3db23361590b5d2c09bc8f6f23a02ccd7f60 Reviewed-on: https://gerrit.libreoffice.org/59570 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-27rename ENABLE_HEADLESS option to DISABLE_GUINoel Grandin
since it has nothing to do with the headless command line option, so use the name it has in the configure.ac file Change-Id: Ibf0615ed02695d6e48a797f5632e4f417c010c70 Reviewed-on: https://gerrit.libreoffice.org/59611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-27directly use malloc/free in sal, instead of rtl_allocateMemory/etcNoel Grandin
now that those functions are entirely malloc/free based, we can skip a function call layer. Change-Id: Ib091de0bdf4cdd58cee45185df17d96d3e8af402 Reviewed-on: https://gerrit.libreoffice.org/59576 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-27tdf#90376 revert the dock windows' Idles to TimersJan-Marek Glogowski
The dock windows' Timers were converted to Idles in commit eef25e0e7c03 ("changed timers to idles"). Since the Idles poll the mouse buttons, they starve all lower priority events. From the comment in ImplDockFloatWin2::Move, this is a hack to get the mouse release event from the window decorations in X11. Change-Id: Ibba3c58dd8b3d95dbd9296cc111ab32968bee230 Reviewed-on: https://gerrit.libreoffice.org/59590 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-27Add task count to Scheduler debug infoJan-Marek Glogowski
Change-Id: I60c00a40f119260ea34fb48efab72f1da8ae4e53 Reviewed-on: https://gerrit.libreoffice.org/59587 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-27Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' - style previews can be now disabled by checkbox and expert config in not needed for that anymore Change-Id: I82ba2dc1f867ec50924326c8fed0e25f3e19b4c2 Reviewed-on: https://gerrit.libreoffice.org/59599 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-26Checkboxes don’t use title case, only section headings and menusAdolfo Jayme Barrientos
Change-Id: If54fdd732d05a99fb06ea5dd8d31345dc0f6192a
2018-08-27Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' - fix menu path to image properties Change-Id: Ic4ea128ba4d995c6adec288a6b47a19dfd118799 Reviewed-on: https://gerrit.libreoffice.org/59593 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-26mdds 1.4.1 is now a minimum requirement.Kohei Yoshida
Change-Id: I647bcfbdd8e0417990ed93b25c1bca00f60df709 Reviewed-on: https://gerrit.libreoffice.org/59614 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-08-26rely on forward declare of boost::optionalCaolán McNamara
Change-Id: Ic3718290944b813b5ac2712fd4006dc97f5b68a0 Reviewed-on: https://gerrit.libreoffice.org/59613 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26boostrap->bootstrapCaolán McNamara
Change-Id: I3082130a39a55609fa38fbf9a667fb95fe6d60ea Reviewed-on: https://gerrit.libreoffice.org/59612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26Update mdds to 1.4.1.Kohei Yoshida
The largest change in 1.4.x relevant to the calc code is that the multi_type_matrix::walk() methods now take a copy of the function object rather than a reference, to allow for it to take an inline lambda function. Instead, it does return a instance of the input function object, similar to how std::for_each() behaves. In case the function object contains a large data member, try to make it a moveable so that it will get moved rather than copied when going through one of the walk() methods. Change-Id: Ifd08fc4a2ed75039e5292a35ff08726e0126c77f Reviewed-on: https://gerrit.libreoffice.org/59584 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-08-26drop unnecessary SYSTEM_MYSQL_CONNECTOR_CPPCaolán McNamara
Change-Id: I41cfbf41247270d29e08e5125adc05aac198b175 Reviewed-on: https://gerrit.libreoffice.org/59608 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26don't need dangling Library_mysqlcppconn.mkCaolán McNamara
Change-Id: I18fbe9feead3d48d9437cc7372eb1373ffb67c3e Reviewed-on: https://gerrit.libreoffice.org/59607 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26presumably should be mysqlc hereCaolán McNamara
Change-Id: I328cb639cf1e190e745aa20e0f83b0e3e4fd2f60 Reviewed-on: https://gerrit.libreoffice.org/59606 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26MYSQL_CONNECTOR_CPP not built anymoreCaolán McNamara
since... commit 26b40fcfc67480e75bd9959b0c5cb9db10fdf6a1 Author: Tamas Bunth <tamas.bunth@collabora.co.uk> Date: Thu Aug 16 16:35:17 2018 +0200 Moving mysqlc into connectivity as a library Additionally I erased the remains of the old mysql C++ connector. Also update the code where the clang plugins were unhappy after moving the mysqlc module. Remove mysql-cpp-connector external. so we don't need the source to it Change-Id: I0436e9f5a9cce87d0294cf3163a97a19566df1f4 Reviewed-on: https://gerrit.libreoffice.org/59605 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26CPPCONN_LIB now unusedCaolán McNamara
since commit 26b40fcfc67480e75bd9959b0c5cb9db10fdf6a1 Author: Tamas Bunth <tamas.bunth@collabora.co.uk> Date: Thu Aug 16 16:35:17 2018 +0200 Moving mysqlc into connectivity as a library Change-Id: Iafc4fb685d8f7b97f8be83dbf26945f9af976f1a Reviewed-on: https://gerrit.libreoffice.org/59604 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26get rid of aEndItr entirelyCaolán McNamara
Change-Id: Ib95ca628457d7330ac1e1001ab13a00a764c9bad Reviewed-on: https://gerrit.libreoffice.org/59598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-26tdf#106260 Fix invisible pasted urlsPaul Trojahn
UpdateFields() was never called after pasting a field. Change-Id: I91f3eb183a0545d8735c0844f1e864a287101d22 Reviewed-on: https://gerrit.libreoffice.org/59339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-25crashtesting: cached deque::end invalidatedCaolán McNamara
e.g. import of ooo101471-3.odf Change-Id: Ie1d83077cf91f2291c74390c24b7f36808e32562 Reviewed-on: https://gerrit.libreoffice.org/59597 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-25ofz#10056 Null derefCaolán McNamara
Change-Id: I9ea0f272d0a8b13fb51fec55ac57adca47cafc77 Reviewed-on: https://gerrit.libreoffice.org/59596 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-25Fix typoAndrea Gelmini
Change-Id: I7cef050ea84607118bacfe25acc83bc164668379 Reviewed-on: https://gerrit.libreoffice.org/59594 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-08-25Access2Base - Add Location to Database objectJean-Pierre Ledure
File location is known by URL property for non-registered databases Effective Location now available for all databases Change-Id: If1551f2644c82dbb4a4128c647810aa6a755f1ab
2018-08-25Build fix, make install: mysql-connector-ooo extension is goneEike Rathke
Since commit 26b40fcfc67480e75bd9959b0c5cb9db10fdf6a1 CommitDate: Fri Aug 24 17:19:51 2018 +0200 Moving mysqlc into connectivity as a library Was used in #ifdef WITH_EXTENSION_MARIADBC Change-Id: Ib95d81fbd79f253c4490dd3afdfd67962b5f1563
2018-08-25Access2Base - Fix typoJean-Pierre Ledure
Typo error in commit f903dd5e21265e0b520c312bc41cd65a1ab74851 Change-Id: I3c770296d1d4063c6bd3190eb90df0389ecf8f26
2018-08-25Access2Base - Fix flush method when closing databaseJean-Pierre Ledure
The "flush" method is not always present in com.sun.star.sdbc.drivers.OConnectionWrapper or com.sun.star.sdbc.XConnection objects. => Test presence before executing Connection.flush Change-Id: I5ab4968ba6fdd0e23352e0cfe18907260c46b7b0
2018-08-25loplugin:useuniqueptr in ScMoveUndoNoel Grandin
Change-Id: I622a0f37866c5ea1f4ec5f4475d784682a0179c2 Reviewed-on: https://gerrit.libreoffice.org/59560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-25tdf#70195 docx export: default header/footer at 720Justin Luth
This only impacts MSWord, which otherwise suggests a new header start at 0. LO ignores that 0 and uses a sane default. Change-Id: Id9790038086de1e20918d4ab498a0ce93ca53b5c Reviewed-on: https://gerrit.libreoffice.org/59523 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-08-24ofz#10045 Null derefCaolán McNamara
Change-Id: If9c8edd94b02240510325d6c9c0fc7584ba89b5f Reviewed-on: https://gerrit.libreoffice.org/59571 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24Resolves: tdf#118572 ensure basic error dialog blocks any other dialogCaolán McNamara
if a dialog is already running, disable input to it until this error dialog is acknowledged. The other dialog might be running from the script which has the error. Change-Id: I10c437a25bd7c91d37eeb8241bef10709767e499 Reviewed-on: https://gerrit.libreoffice.org/59567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24Related: tdf#118572 set parent of basic error dialog to basic ideCaolán McNamara
Change-Id: I2e9dfd354dce114af9a2933255a991c29619b8a5 Reviewed-on: https://gerrit.libreoffice.org/59566 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24Remove redundant loop, tdf#96099 follow-upArkadiy Illarionov
Change-Id: I6318a526c8ea73ef32c18038c9bb5feeffc07b52 Reviewed-on: https://gerrit.libreoffice.org/59583 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Honor colspan and rowspan in tablecells Previously not implemented Change-Id: I8867d82bc12a6c4312fcc6aa49c6b31e360a524e Reviewed-on: https://gerrit.libreoffice.org/59580 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-24Fix typosAndrea Gelmini
Change-Id: Ie6e3f3edabcd1ef9b44aefeb81ea84ca28654606 Reviewed-on: https://gerrit.libreoffice.org/59578 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-24Moving mysqlc into connectivity as a libraryTamas Bunth
Additionally I erased the remains of the old mysql C++ connector. Also update the code where the clang plugins were unhappy after moving the mysqlc module. Remove mysql-cpp-connector external. Change-Id: I771cc7afacf5012fc349afb6b36828fb0fee5a66 Reviewed-on: https://gerrit.libreoffice.org/59200 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-08-24Access2Base - Fix OutputTo of null stringJean-Pierre Ledure
Basic builtin function IsDate returns True for a null-length string. Intercepted to avoid conversion to date giving "00:00:00" Change-Id: Ie917574043ea743e43cd79c5d95d023c8ccab38a
2018-08-24document that nEndPos of -1 is all textCaolán McNamara
Change-Id: I4646e1ef09db3a637248cff53cbbafb214219cf8 Reviewed-on: https://gerrit.libreoffice.org/59542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24loplugin:useuniqueptr pass ScDocument by unique_ptr in the undo codeNoel Grandin
Change-Id: I85188a4b3da4bc7f1a8a83870c8888be18bc1053 Reviewed-on: https://gerrit.libreoffice.org/59559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24loplugin:useuniqueptr for ScOutlineTable in the undo codeNoel Grandin
fixing what looks like a couple of leaks on some paths Change-Id: Idc851b8ffca8e5ed1bd54c9195442709ed310d40 Reviewed-on: https://gerrit.libreoffice.org/59558 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24loplugin:useuniqueptr in ScEditFieldObjNoel Grandin
consequently fixing potential leak in InitDoc Change-Id: I50885f32d2465b41ede5dcf6653d7d8d30a3aeba Reviewed-on: https://gerrit.libreoffice.org/59557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24Blind fix for -Werror,-Wunused-functionStephan Bergmann
...on Android tb24 Change-Id: I3119a660d6d38d3bff15b3a32a98b188ea06fdbd
2018-08-24tdf#118786 WIN just assert in YieldJan-Marek Glogowski
This reminds me - again - that Jenkins doesn't run make check. It turns out InSendMessage() also returns true, if you process a nested SendMessage in the same thread. Therefore we have to remove the SalComWndProc assert and just keep the one in the Yield call. Why? Because there seem to be no way to get the information ReplyMessage has access to, so we could detect the caller / origin of the send message and implement proper nested call checks. The alternative would be to change all call sites of SendMessage to: if ( !pSalData->mpInstance->IsMainThread() ) SendMessage(...) else SalComWndProc(...) which is the same SendMessage already does. Change-Id: I991d68a64952dc5d47ba51edd8635c9e8c46614c Reviewed-on: https://gerrit.libreoffice.org/59538 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>