summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-06make some classes module-privateNoel Grandin
Change-Id: I00ab3a3f6a8bbc85320e7b4fd1aa13af798e7e4c Reviewed-on: https://gerrit.libreoffice.org/82062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06loplugin:indentation find broken if statementsNoel Grandin
so I don't read the "then" block as being a sequential statements Change-Id: Ib2004acd3518bd4ebd2246f02a26c2c0a8bbab4c Reviewed-on: https://gerrit.libreoffice.org/82069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06Impress Sidebar Tabledesign updateandreas kainz
Change-Id: I54bc3e8a7d7a059311e72bb47b9945359dd32d0e Reviewed-on: https://gerrit.libreoffice.org/82114 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06Impress Options Dialog General updateandreas kainz
Change-Id: I019cba1f1e0031ea16b4c69f3ed2f41a1bd6a39f Reviewed-on: https://gerrit.libreoffice.org/82110 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-06sc lok: cope with non 100% zoom better.Michael Meeks
Do the tile rendering and alignment ourselves. More work required to get cleaner conversion between view and document twips (view twips being rounded to produce nice round pixel sizes when re-converted). Change-Id: I51edb186cfd2dc434005cc074f4ed8de19c85cb3 Reviewed-on: https://gerrit.libreoffice.org/82092 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06Revert "lok: sc: make hi-dpi/zoom compatible with retrieving cell cursor"Michael Meeks
This reverts commit e3ff84aed5be8e0d2780d80b178fa8fc0e388859. Change-Id: I174dd54cf7b44f12c90c61882814b6dee9be9b7c Reviewed-on: https://gerrit.libreoffice.org/82089 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06Revert "sc lok: Implement hi-dpi and zoom for spreadsheets."Michael Meeks
This reverts commit 498dceb43f870bf9e380f1f87e99c6ccadf1963c. Change-Id: Iadb9da47cf8c9a57385530ab888d55169db7639a Reviewed-on: https://gerrit.libreoffice.org/82088 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-05Drawing calc grid misses pixels on bottom and right.Michael Meeks
Change-Id: I2ac7911b35d942b7167a3243d04e1b5710ed367d Reviewed-on: https://gerrit.libreoffice.org/82091 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-05Remove unused devsnapshotbuild codeStephan Bergmann
...which had been introduced, already unused, with 1e4422a4b4c443c286c90853f50b739a67ce5d1f "re-base on ALv2 code. Includes:" Change-Id: I5a26d7365c510e861bd25e0882cfe7292695107c Reviewed-on: https://gerrit.libreoffice.org/82108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-05lok: tilebench: implement zoom tests.Michael Meeks
Change-Id: Ieffc89b8119c2baf56383ac8b5d3cb54dc9d0d2d Reviewed-on: https://gerrit.libreoffice.org/82090 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-05tdf#128288: Use DS_Store_Langpack even for --disable-release-buildStephan Bergmann
(cf. ScpAction scp_Copy_Ds_Store in scp2/source/ooo/scpaction_ooo.scp making use of this feature) Dev builds overruling the .DS_Store file for language-/helppacks appears to have been broken ever since dab79744767c05fd5268866937e225b74e658cea "Give Mac master builds a nice background .dmg image, too". Change-Id: I7473d1b0b35fe0b435e7d26c0639e26ed157245d Reviewed-on: https://gerrit.libreoffice.org/82107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-05weld SwSyncChildWinCaolán McNamara
Change-Id: I23eef815ba05e07f50f86ec375c5dff3ef759d55 Reviewed-on: https://gerrit.libreoffice.org/81746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05ensure maEndDialogFn is unset after std::moveCaolán McNamara
Change-Id: I9809cc082157bd18562f812155a9ed68f522a703 Reviewed-on: https://gerrit.libreoffice.org/82084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05Looks like UBSan still needs SdrObjGeoData's RTTI for some reasonStephan Bergmann
After c02c4df9414ed2bef96565522238ca05013d3ac3 "make some classes module-private", CppunitTest_services failed in my Linux ASan+UBSan build with > .../postprocess/qa/services.cxx:318:(anonymous namespace)::Test::test > forced failure > - instantiating "com.sun.star.comp.oox.xls.ExcelFilter" via "com.sun.star.comp.oox.xls.ExcelFilter" caused com.sun.star.loader.CannotActivateFactoryException "loading component library <file:///.../instdir/program/libscfiltlo.so> failed" due to > info:sal.osl:1711464:1711464:sal/osl/unx/module.cxx:162: dlopen(.../instdir/program/libscfiltlo.so, 257): .../instdir/program/libscfiltlo.so: undefined symbol: _ZTI13SdrObjGeoData Change-Id: I2838b01df9886d4d2093d79cad94a21ad76bab96 Reviewed-on: https://gerrit.libreoffice.org/82083 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-05Looks like UBSan still needs SdrDragEntry's RTTI for some reasonStephan Bergmann
After c02c4df9414ed2bef96565522238ca05013d3ac3 "make some classes module-private", CppunitTest_sd_uimpress failed in my Linux ASan+UBSan build with > DynamicLibraryManagerException: "Failed to load dynamic library: .../workdir/LinkTarget/CppunitTest/libtest_sd_uimpress.so > .../workdir/LinkTarget/CppunitTest/libtest_sd_uimpress.so: undefined symbol: _ZTI12SdrDragEntry" Change-Id: I923e3bc18644117738b628bcc25b9071bb31f893 Reviewed-on: https://gerrit.libreoffice.org/82079 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-05aControlPos is unusedCaolán McNamara
Change-Id: I55ecd0a820f4c620e516679d27c5cca461aa77bd Reviewed-on: https://gerrit.libreoffice.org/82071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05vcl PDF export: fix re-exporting PDF images for dict obj resource sub-keysMiklos Vajna
Re-exporting PDF images works by tokenizing the PDF image, identifying which PDF object is the page object and then copying that over to the PDF output, together with the dependencies of that object. This involves copying the resources of the page object. Previously we assumed that the sub-keys of the resources are always inline dictionaries, but the bugdoc shows that they can be references as well, which point to dictionary objects, so add support for this scenario. Change-Id: I78ee1c726e6ecd958232e9fab64773595e5b9c86 Reviewed-on: https://gerrit.libreoffice.org/82076 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-05tdf#108065 tdf#128609 OOXML chart export: fix transparent color gradientBalazs Varga
Linear and axial color gradients keep their solid or gradient transparencies. Change-Id: I37dfe016864bded49c767cea5c8c865455281de0 Reviewed-on: https://gerrit.libreoffice.org/81308 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-05restore accessibility relationsCaolán McNamara
that went astray in... commit d3f9ff5202c72220ef3bc7d84d149f9beeb1d290 Date: Tue Nov 5 09:25:39 2019 +0100 Impress update Presentation Dialog Change-Id: I5dafc0a86d42be726d6c4ab5dc14877f4d6eb733 Reviewed-on: https://gerrit.libreoffice.org/82067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05Fix option to disable macrosSamuel Mehrbrodt
so that it indeeds disables any macro execution. Before, you could still add macros to the toolbar and execute them from there (and probably many more places). Now, if this option is set, any macro will no longer be executed. This includes Javascript, Beanshell and Python scripts Change-Id: Icfa845e836782c8e1b670a67694f79a60ad74fad Reviewed-on: https://gerrit.libreoffice.org/82052 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de>
2019-11-05Impress Effects Dialog updateandreas kainz
Change-Id: Ifa9a4c60038cd86e286e7bc1cf9fe97b0eceb5cb Reviewed-on: https://gerrit.libreoffice.org/82064 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05Connector Dialog updateandreas kainz
Change-Id: I16fd1c8b06c91c6d8dd88313756f8d85249e7236 Reviewed-on: https://gerrit.libreoffice.org/82063 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05Impress update Presentation Dialogandreas kainz
Change-Id: I31d959bad05844adf77287ef5089cfa8bce5aa3e Reviewed-on: https://gerrit.libreoffice.org/82053 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05Resolves: tdf#128599 null derefCaolán McNamara
Change-Id: If71a32b15b5ffab11185e2ce253ab65faf7e6ac3 Reviewed-on: https://gerrit.libreoffice.org/82056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05make some classes module-privateNoel Grandin
Change-Id: Ice9a57eedb166672dbdfae6da2a172ab77566a19 Reviewed-on: https://gerrit.libreoffice.org/81983 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-05jsdialogs: .uno:ChartBackColor with string argumentSzymon Kłos
Change-Id: I2f28a0ba957548b020eacf3d630dccef6ebbf5ed Reviewed-on: https://gerrit.libreoffice.org/82057 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-05Impress update Header Footer Dialogandreas kainz
Change-Id: I2662399692b18be511511020b66942c91699dc92 Reviewed-on: https://gerrit.libreoffice.org/82054 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05tdf#127759 Writer: add table row/column insert modeLászló Németh
using enhanced table selection. When the table rows or columns are selected by enhanced table selection, ie. clicking in front of them, next Cut operation cuts the selected rows or columns completely without leaving empty cells. Pasting them results insertion before the actual row/column instead of overwriting the actual and the next rows/columns. This greatly speeds up moving table rows and columns, like in MSO. Change-Id: I6d82ca8aad4888ab37bdb9a89d37102763fcd6c6 Reviewed-on: https://gerrit.libreoffice.org/81503 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-05ofz#18653 slow and uninterestingCaolán McNamara
Change-Id: I9043de56063caec225850eb1103435b44640781e Reviewed-on: https://gerrit.libreoffice.org/82043 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05jsdialogs: .uno:Color with string argumentSzymon Kłos
Change-Id: Ifdc95ff8c6a71340de3ed66cf58bc937e3730810 Reviewed-on: https://gerrit.libreoffice.org/82038 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-05tdf#42949 Fix IWYU warnings in sw/source/core/d*/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Id33b8c1e0c02c21591b167a8b3f0ea288fac63bd Reviewed-on: https://gerrit.libreoffice.org/81689 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-05tdf#128335 sw textbox: fix crash on deleting multiple shapes with textboxesMiklos Vajna
This was introduced in commit 33141f999b22ce10cdbfbd76081fff211c4b5067 (SwDrawView::DeleteMarked: delete textbox of shape as well, 2014-06-23), the problem is that in case one shape+textframe pair is anchored in an other textframe, which is also part of a shape+textframe pair, it matters what order we use for deleting these objects. What happened is that the anchor position of a 2nd textbox was updated on the deletion (cut) of the 1st textbox, and this was not properly restored on paste. Fix the problem by deleting in reverse order, assuming that the container is ordered by anchor positions. Change-Id: I62bc12a5064ce397234999e8fd7b108f79de3c24 Reviewed-on: https://gerrit.libreoffice.org/82042 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-05tdf#109135 Don't handle Ctrl key in SvTreeListBox HandleKeyInputJim Raykowski
This patch allows shortcut keys to work when focus is in tree list box Change-Id: Id47e004276c5f56f44c404c2d39d62dacbe234ee Reviewed-on: https://gerrit.libreoffice.org/82049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-05typeinfo fix for x86Tomoyuki Kubota
Change-Id: Ic0a9dcb97cfda4155f33d9ad07a96db8960b57a0 Reviewed-on: https://gerrit.libreoffice.org/82023 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-05Position Dialog updateandreas kainz
Change-Id: I2dcffd1d95e259e0c348aca037ba3c41e3b9b6ab Reviewed-on: https://gerrit.libreoffice.org/82048 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-05line dialog alignment updateandreas kainz
Change-Id: I656885dfd158a114c5ec61551aedfb6c625c1971 Reviewed-on: https://gerrit.libreoffice.org/82046 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-04tdf#128257 Bullet Dialog update 2andreas kainz
Change-Id: Icf52eed719172960c3c7e0dc257f11e0b5f8eb4f Reviewed-on: https://gerrit.libreoffice.org/82037 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-04tdf#121963 apply GridOffset in isPrimitiveVisibleArmin Le Grand
Need to take evtl. GridOffset into account for Controls in ViewObjectContactOfUnoControl::isPrimitiveVisible to get same coordinates inside adjustControlGeometry_throw Change-Id: Id6f0d1c7a4de4ee5908b50ee1a2217a0b078ecf5 Reviewed-on: https://gerrit.libreoffice.org/82031 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-11-04lok: share conversion of OUString to C strings.Michael Meeks
Change-Id: I0178f673dc1e59d9fba8f3daae532f19b46e4d36 Reviewed-on: https://gerrit.libreoffice.org/82036 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-04lok: avoid ILibreOfficeKitNotifier null ptr de-reference on shutdown.Michael Meeks
Change-Id: I79c8fa3ebf7ed457b7bebb4da536eb83f5cac567 Reviewed-on: https://gerrit.libreoffice.org/82035 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-04loplugin:redundantcast: Don't warn about cast from nullptr_t to function ptrStephan Bergmann
See comments at <https://gerrit.libreoffice.org/#/c/81958/> "Only initialize function pointer once" for a case where such a false warning caused trouble (in a lambda with deduced return type and multiple return statements). Change-Id: I64b0b8c45bd3d2a6075e336c361ec778fa0da481 Reviewed-on: https://gerrit.libreoffice.org/82034 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-04ProgressBar now only use in vcl and toolkitCaolán McNamara
Change-Id: I5d56a4df155806e41cafa6f65a3a030e8443b8f7 Reviewed-on: https://gerrit.libreoffice.org/82005 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04readme not a sufficient indicatorCaolán McNamara
Change-Id: Idd5cd004b873280e202b16c182356977045bdab4 Reviewed-on: https://gerrit.libreoffice.org/81993 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04improve pivot table dnd highlightingCaolán McNamara
unhighlight row when widget is unhighlighted and only highlight a row if the widget is highlighted Change-Id: I415207b4b263c5125f52abd57efe3543e2411b36 Reviewed-on: https://gerrit.libreoffice.org/81999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04move VCLXProgressBar to toolkitCaolán McNamara
Change-Id: I3aa21aff97346a9a43ad7b25621e8a8733fc4041 Reviewed-on: https://gerrit.libreoffice.org/82004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04FixedHyperlink now only used in vcl and toolkitCaolán McNamara
Change-Id: Id1eacb01ab7ed985d1495d3949bc185556246e3a Reviewed-on: https://gerrit.libreoffice.org/82003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04Merge in Flatpak improvementsStephan Bergmann
...from <https://github.com/flathub/org.libreoffice.LibreOffice/>: commit e31ae281213d5921c3704737a43da864c3e82d8e Author: Erick555 <37542552+Erick555@users.noreply.github.com> Date: Fri Oct 4 17:48:12 2019 +0000 Update to freedesktop 19.08 commit 5b49a9e3ca243910a094f9865e2cdda9e2cda098 Author: Erick555 <37542552+Erick555@users.noreply.github.com> Date: Fri Oct 4 18:36:52 2019 +0000 Add krb5 It's no longer available in runtime commit a0f49157b0774929974f04f8747adf5ff5686287 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 11 10:35:44 2019 +0200 gperf 3.1 is available in the Sdk now ...according to <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/commit/ caef17cbb3cdad5c111eda8eb83a140bfacc380a> "NEWS: Update for freedesktop-sdk-18.08.22" Change-Id: Ibb0cd4bbd68bd4180f7f9af3afbf8638dd2be9e8 Reviewed-on: https://gerrit.libreoffice.org/82011 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-04cid#1455213 sc: rowcol: tdf#50916 check pDoc for MaxCol() or MAXCOLEike Rathke
Change-Id: I1038209998632dd0746a01d4ab3961c6b017e373 Reviewed-on: https://gerrit.libreoffice.org/81997 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-11-04fix ODR violationNoel Grandin
only shows up with --enable-mergedlibs and --enable-lto Change-Id: Id769c8ed5781724835bc7e532185263964237dab Reviewed-on: https://gerrit.libreoffice.org/82000 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-04move VCLXFixedHyperlink creation to toolkitCaolán McNamara
Change-Id: I3aa47a194f2b10b15faaa142c7dc6d57dffff96e Reviewed-on: https://gerrit.libreoffice.org/82002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-02 18:23:16 +0000