summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-31Address data source wizard: fix most a11y warningsSamuel Thibault
Change-Id: I7992bee3cf88c670d932cd6d6873339ac5f0c104 Reviewed-on: https://gerrit.libreoffice.org/59817 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-31sw: fix inconsistent bookmark behavior around at-char/as-char anchored framesSerge Krot
Added unit test for Added fix for Change-Id: Ic1f173c85d3824afabb5b7ebf3a8594311eb9007 Change-Id: I38444587d00b96d52ff725dc7c5852e057bc6bd9 Reviewed-on: https://gerrit.libreoffice.org/59828 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-31sw: add unit test for the XHTML part of tdf#109202Thorsten Behrens
Change-Id: Ifb1b5b30e1c3586be75ff01f7bc0612a6b8b1f8d Reviewed-on: https://gerrit.libreoffice.org/59785 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-31sd/pptx export: refactor WriteAnimationNode.Mark Hung
to get rid of function pointers. Change-Id: Iaea4782274c655484559118183397a3340d1d7cb Reviewed-on: https://gerrit.libreoffice.org/59734 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: remove unnecessary using caluses.Mark Hung
Change-Id: I836766e308fb198f4f081837731ba1854c770f06 Reviewed-on: https://gerrit.libreoffice.org/59733 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31sd/pptx export: move animation related static member functionsMark Hung
of PowerPointExport to anonymous namespace. This allows cleaning up PowerPointExport and later moving other non-static member functions caller outside PowerPointExport to become a new class. Change-Id: I174337896db68307d7859dc9cf8bb9a9648f90eb Reviewed-on: https://gerrit.libreoffice.org/59732 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-31tdf#118993 - Missing new Insert Special Character in WebRizal Muttaqin
Change-Id: Icbe68ac5f1ddb5ad59e0615ad1d558b829c6977f Reviewed-on: https://gerrit.libreoffice.org/59832 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-31tdf#119390 Don't focus the toolbar when closing a floating windowMaxim Monastirsky
Toolbar popup windows have the toolbar as their direct parent. This causes problems when such window is teared-off and later closed, as Window::dispose will attempt to move the focus to its parent which is the toolbar, instead of what users expect to have the focus back in the document area, or in whatever was the last focused control. As a solution reparent the window before dispose, similar to what happens with floating toolbars. Also return the focus to the main window when popup mode ends, so we can keep track of the last focused control. This is also a good thing by itself, as WB_OWNERDRAWDECORATION windows don't get the focus by default, which results in neither the floating window nor the document have focus after tear-off. Change-Id: I060b8c45a64db9c612da58b7c35478bab41a4558 Reviewed-on: https://gerrit.libreoffice.org/59811 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-30Combine mysqlc and connectivity.mysqlc log areasStephan Bergmann
Change-Id: I2d13401dc21548018235bab715d54eb3ae81b51b Reviewed-on: https://gerrit.libreoffice.org/59807 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-30Use INPUTSTRING_PRECISION to enable input of fraction of secondEike Rathke
This got lost when SvNumberFormatter::INPUTSTRING_PRECISION was introduced but not all places changed using the previous hard coded number 300, so input of fraction of second in time clock and duration was either truncated or not available at all, already since commit 0ce0dd5863208500d8d4658f1f68f34e254ab015 CommitDate: Tue Dec 1 16:58:07 2009 -0500 #i46511# Fixed one bug where the standard percent format incorrectly got unlimited precision. Change-Id: I9e4dd867b07090db16b23639fd01fb2cebb3f5d0 Reviewed-on: https://gerrit.libreoffice.org/59815 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-08-30Support buffering SystemDependent GraphicDataArmin Le Grand
This is a first step to allow buffering of system dependent data, especially (but not only) for the system-dependent implementations of graphic output. For example, for B2DPolygon and Win output, it allows buffering the Gdiplus::GraphicsPath instead of re- creating it all the time. To support that, the change includes forwarding the current transformation to the renderers in SalGraphics. The current state in VCL is to transform all and everything to device coordinates at every single paint. I have currently started to do this for ::drawPolyLine implementations. The fallbacks for all systems will at the start of that method just transform the data to device coordinates, so all works as before. This may also be done for FilledPolygon paint in a later step, but most urgent is FatLine painting. An arrangement of shared_ptr/weak_ptr is used so that either the instance buffering (in the example B2DPolygon) or the instance managing it can delete it. The instance managing it currently uses a 1s Timer and a cycle-lifetime management, but that can be extended in the future to e.g. include size hints, too. The mechanism it designed to support multiple Data per buffering element, e.g. for B2DPolygon at the same time system-dependent instances of Gdiplus and Cairo can be buffered, but also PDF-data. This is achieved semi-automatic by using typeid(class).hash_code() as key for organization. The mechanism will be used for now at B2DPolygon, but is not limited to. There is already a similar but less general buffer (see GdiPlusBuffer) that can and will be converted to use this new mechanism. Added vcl/headless Cairo renderer to support given ObjectToDevice transformation (not to transform given B2DPolygon) Added support for CairoPath buffered at B2DPolygon, seems to work well. Need to do more tests Moved usage to templates suggested by Noel Grandin (Noel Grandin <noelgrandin@gmail.com>), thanks for these suggestions. Adapted Win usage to that, too. Converted Win-specific GdiPlus BitmapBuffer to new mechanism, works well. Checked, the manager holds now a mix of bitmap and path data under Win Added a cleanup mechanism to flush all buffered data at DeInitVCL() using flushAll() at SystemDependentDataBuffer Adapted Linux-versions of ::drawPolyLine to support PixelSnapHairline, for now in a simplified version that still allows buffering. This will also be used (and use buffering) for the Cairo-fallback in X11SalGraphics Change-Id: I88d7e438a20b96ddab7707050893bdd590c098c7 Reviewed-on: https://gerrit.libreoffice.org/59555 Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-08-30sd/pptx export: move animation export code to a single file.Mark Hung
Move animation export functions in PowerPointExport to a single file for further refactor work. Change-Id: I957599bb293fcdda3d51db48334ef5825b1cba64 Reviewed-on: https://gerrit.libreoffice.org/59731 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-08-30Remove redundant asserts after newMike Kaganski
Also remove SlideSorter::CreateController which only calls new; fix a memory leak in osl_Security's MyTestPlugInImpl::initialize Change-Id: I70b6e888984f8543adbf879162e752556d2b3f0e Reviewed-on: https://gerrit.libreoffice.org/59805 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-30sw XHTML export: xml:lang is not relevant for ReqIFMiklos Vajna
I suppose if language is set, that happens in the wrapping ReqIF document, not in the XHTML fragments. Change-Id: I970c3810b7f02bbafc37dd85e095b254cc651330 Reviewed-on: https://gerrit.libreoffice.org/59810 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-30sw XHTML export: improve dummy OLE object handlingMiklos Vajna
It is possible that we not only have a dummy OLE object, but both the replacement image and the native data is missing. Handle these enough so that we don't give up exporting the document and also produce valid output. Change-Id: Ia973ecfbfb7e8fdecdc831b29d3a82c988ed7ea5 Reviewed-on: https://gerrit.libreoffice.org/59806 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-30Fix typosAndrea Gelmini
Change-Id: Ia658776bce8744e7b771559ca12b94a20923fc52 Reviewed-on: https://gerrit.libreoffice.org/59782 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-30Fix typoAndrea Gelmini
Change-Id: Ib7d79f9ea2192e798891ea1c2a9d547c8ddf3574 Reviewed-on: https://gerrit.libreoffice.org/59790 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-30tdf#119579 skip floating windows as potential parent for missing help dialogCaolán McNamara
Change-Id: Ibcee9a6aab0b04bf52f3e75a46f52d98864eee4c Reviewed-on: https://gerrit.libreoffice.org/59808 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30Upgrade to vs2017-ide-integration, since we don't support VS2015 in masterMike Kaganski
This allows to avoid the "(Visual Studio 2015)" labels next to project names in Solution Explorer; and also avoid multiple warnilgs like project-name.vcxproj : warning : The build tools for Visual Studio 2015 (v140) cannot be found. Install Visual Studio 2015 (v140) to build using the Visual Studio 2015 (v140) build tools. in IDE's Output pane in case VS2015 is absent locally. Change-Id: I53b68ac810cbf2a31667c35dd549310e7209e010 Reviewed-on: https://gerrit.libreoffice.org/59797 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-30Silence bogus -Werror=redundant-move (GCC 9)Stephan Bergmann
Change-Id: Ia078fb8e1e497edfa08e2a61d1659100461fc52e Reviewed-on: https://gerrit.libreoffice.org/59720 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-30weld SvxHeaderPage/SvxHeaderPageCaolán McNamara
Change-Id: I86f14a38c32baf46ccb5674005192fea2665719d Reviewed-on: https://gerrit.libreoffice.org/59801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30Revert "On macOS Library_mysqlc needs _iconv{,_close,_open}"Michael Stahl
This reverts commit a191075ee1bd103a57c935e47026337a5e2340e9. This fix was superceded by commit 13a05eec7377c013d9c13deeee6473a9e863c897 which is better abstracted. Change-Id: I3b8ba735d279a50f5548a26fcc8fa6f790b2ea42
2018-08-30tdf#119577 Ignore escape key press on sidebar toolboxes not handled byJim Raykowski
...focus manager. This prevents escape key press on More Options tool box in some panel title bars from sending focus to doc view. Change-Id: Iaac9bf31494e4e35f30350580acaa9f42ead49a0 Reviewed-on: https://gerrit.libreoffice.org/59783 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-30tdf#115670 vml shadow: shadow is off unless explicitly set onJustin Luth
The absence of "on=" is treated in Word (tested 2003) as off. Change-Id: Ibc6b0e5ca0f25a9c3ca1b9505fa24c4d821bfd0 Reviewed-on: https://gerrit.libreoffice.org/59457 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-30solenv: fix markdown issues in mkdocs.shMichael Stahl
- Fedora 28 has python3-markdown2 package containing /usr/bin/markdown2-3 - the "alias" doesn't work at all because it's not exported to the sub-shell in $(markdown) so use variable instead Change-Id: Icf2af1e66750269e0660f3897a91734cadf5d978
2018-08-30RepositoryExternal: mariadb needs iconv on MacOSMichael Stahl
Change-Id: I78928baab2ea3accfdd7db62240e39e486c2f52c
2018-08-30Resolves: tdf#119572 addressee/sender formatting swappedCaolán McNamara
Change-Id: Icdb2ca0362711e87edcb952fb52117502d80d328 Reviewed-on: https://gerrit.libreoffice.org/59793 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30Drop --with-system-mysql-cppconnKacper Kasper
Not needed since 5061663ce052087c6d5d0910d6f99358e26dbbd1 "drop unnecessary SYSTEM_MYSQL_CONNECTOR_CPP" Change-Id: I6ca1869edcfb42a1ffa77b791527e53d774117f5 Reviewed-on: https://gerrit.libreoffice.org/59781 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-08-30Translate German commentsJohnny_M
Change-Id: I8e3b98e1ddc3f4f9826aa14383908d6b77f4827a Reviewed-on: https://gerrit.libreoffice.org/59592 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-30tdf#117823 Save mail merge config item in new viewIlhan Yesil
The config object is now saved in a newly created document. Regression from commit id 00fa85e701d4a8984cfa3a24c9b7a3963b031fa0. Change-Id: I2265de1dd69038d447e28dfda2e85c7cf89903c6 Reviewed-on: https://gerrit.libreoffice.org/59728 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-30tdf#119562 Fix export of AutoFit property of shapes to XLSXBalazs Varga
With this patch the "Resize shape to fit text" property (TextAutoGrowHeight) will be exported correctly to XLSX format. Change-Id: I488ceead452aef9096e7766f957de425c8486f85 Reviewed-on: https://gerrit.libreoffice.org/59778 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-08-30pass ScRefUndoData around by std::unique_ptrNoel Grandin
Change-Id: I317a0c7665f4c146fc34bcffdae8835cf674ff61 Reviewed-on: https://gerrit.libreoffice.org/59787 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30tdf#113848 Sidebar: Get user-defined sizes while changing orientationIlhan Yesil
If the orientation of the page is changed, the user defined page sizes are now accessed directly to swap the sizes correctly. Change-Id: I91d256d35dcd910a8c3151a3f9e669413c9a57db Reviewed-on: https://gerrit.libreoffice.org/59577 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-08-30Update sidebar panel title decoration expand/collapse bitmapJim Raykowski
...when panel title has focus and space key is pressed Fixes sidebar panel title decoration expand/collapse bitmap not updating when keyboard space key is pressed. This has been present since at least ver 5.1.6.2. Seems trival enough to not have go through the report process. May be why I could find no bug report for it :-) Change-Id: I7c0dfe511a780eb2bdc5ab8d1064549645cc30ae Reviewed-on: https://gerrit.libreoffice.org/59680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30loplugin:useuniqueptr in registryNoel Grandin
Change-Id: Ia2f9340183e76e6d46ea51ca62c7a731264f621c Reviewed-on: https://gerrit.libreoffice.org/59773 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30tdf#114441 Convert sal_uLong to other types in ./sc/source/ui/appBijan Tabatabai
Change-Id: I9648d54f75d7ed5cb68ec7d678bc61c46df18acf Signed-off-by: Bijan Tabatabai <bijan311@yahoo.com> Reviewed-on: https://gerrit.libreoffice.org/59602 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-08-30rename GetMarkedObjModel to CreateMarkedObjModelNoel Grandin
and return std::unique_ptr Not that it helps much, the ownership quickly becomes complex once it hits the TransferableHelper. Change-Id: I3c6bd72072e092b71b32e4105fe859fdcea956af Reviewed-on: https://gerrit.libreoffice.org/59777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30no need to allocate a new string in parseDurationNoel Grandin
just parse the incoming string in-place with boost::lexical_cast Change-Id: Ie165a80ea3cd10ca883afdff1ad1289edda3e9ab Reviewed-on: https://gerrit.libreoffice.org/59770 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30xmlsecurity: use comphelper::containerToSequence()Miklos Vajna
Allows not iterating the certificate chain twice. Change-Id: I3993f8af24b28bef505d0e8c24bce8065580c2cf Reviewed-on: https://gerrit.libreoffice.org/59780 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-30the 0 default for EndDialog means RET_CANCELCaolán McNamara
Change-Id: I41b01719d147b0ae6899f8323dfa13326f480b4a Reviewed-on: https://gerrit.libreoffice.org/59767 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30add SfxStyleDialogControllerCaolán McNamara
Change-Id: I5b55b8adb46d894f87dcf68c97f6fd56059354a2 Reviewed-on: https://gerrit.libreoffice.org/59768 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-30loplugin:useuniqueptr in InverseColorMapNoel Grandin
Change-Id: I04801a912397ca0081201f52b756c37f83538be5 Reviewed-on: https://gerrit.libreoffice.org/59776 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30use realloc instead of malloc+memcpyNoel Grandin
Change-Id: Ia69be8db2b735c28cc69f478efcff3b6a2cdbbf2 Reviewed-on: https://gerrit.libreoffice.org/59775 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30loplugin:useuniqueptr in PDFObjectNoel Grandin
Change-Id: I605dd193f4fd32b07762208766db5f529adf7998 Reviewed-on: https://gerrit.libreoffice.org/59774 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30loplugin:useuniqueptr in idlc::compileFileNoel Grandin
Change-Id: I9f634466a084f8565aab4843f53702500014a133 Reviewed-on: https://gerrit.libreoffice.org/59772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30use std::vector in AstStackNoel Grandin
instead of a hand-coded equivalent. Note that I can't use std::unique_ptr, because the parsing code appears to just randomly leak AstScope Change-Id: Idc56dfe1f084db55c9d5a7558ac44ddab53b98e3 Reviewed-on: https://gerrit.libreoffice.org/59771 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30don't declare allocation operators for internal codeNoel Grandin
since they just call into malloc/free now, we can ignore them. Should have some nice side-effects like letting the compiler allocate temporaries on the stack. Change-Id: I2500abe19acf9b5bcc676604393c498d4e0dce58 Reviewed-on: https://gerrit.libreoffice.org/59658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30tdf#45904 Move _XCellCursor Java tests to C++Rahul Gurung
Change-Id: Iebada370e4fa58c5e21dd724789b5f05357a0faa Reviewed-on: https://gerrit.libreoffice.org/59610 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-30findreplacedialog: Set a11y role of hint text to staticSamuel Thibault
Since this is not a label for another widget, but some text that screen readers should speak. Change-Id: Iddc2840e60c8a55caf2e6581831024e2658e084e Reviewed-on: https://gerrit.libreoffice.org/59668 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-30tdf#101856 Handle properties of nested bookmarksSerge Krot
Change-Id: I1a92d2001e58751c5bbe41f6480f4c46dcc8c9e7 Reviewed-on: https://gerrit.libreoffice.org/59766 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2025-01-18 00:48:04 +0000