summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-06-30ofz#35504 clamp input values in cgm filterCaolán McNamara
Change-Id: I96712b8dc8f8eaad3fb8fa6710d0f07fff61b592 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118137 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-30fix a size warningLuboš Luňák
d7855213ae60d79f converted this incorrectly, the code right above may set the size as (0,0), and before the commit the invalid size was only negative. Change-Id: I198d025f5c02780ae509f97782bc41ac77fa3407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-06-30XLSX export: improve handling of checkbox (form controls)Miklos Vajna
This builds on top of commit fd238380ae7820f12ac1f7c52d0f7180a93f3ba3 (tdf#106181 XLSX export: output form controls, 2020-05-13) and adds the missing VML version which seems to be mandated by Excel 2019. It is not perfect (e.g. there is still an unwanted border around the checkbox), but the checkbox has a correct position and its label is readable, while it was just lost previously. Change-Id: I08198d068a0eb85061d138719cfc60d73c46398e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118168 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-06-30sfx2: try to fix lifecycle of SfxOfficeDispatchMichael Stahl
This can be created either from the global SfxApplication, or from a SfxViewFrame. Particularly in the latter case, the SfxDispatcher and SfxBindings members are owned by SfxViewFrame, so in case that is destroyed, the SfxOfficeDispatch must clear its pointers. It looks like the member pointers are checked before access already everywhere, so just listen at the SfxViewFrame. Change-Id: If08825734e94dd54e32cb77546684fd583c336ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118162 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-30reduce cost of allocating and copying SvxNumRuleNoel Grandin
by using std::move to avoid copying unnecessarily Change-Id: I940b57c9a05c8d75b9a16291fc4f05756fdeea12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118164 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-30tdf#135316 optimise SwCharFormats::FindFormatByNameNoel Grandin
reduces load time by 10% Change-Id: Ic5c90588825592245d09f8ebe03b13e34676496a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117699 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-30StylePresets: set bacground color for ValueSetTomaž Vajngerl
Change-Id: Ifbaab139235dbe2fdcebf278bce2c91c2b744aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118150 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-30swap text and background colors in colorsetsTomaž Vajngerl
Change-Id: I1e1da85d6c58e3ed5ab4c44c2ab0ae7c3b080251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118149 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-30uitest: combine create_doc_in_start_center methodsXisco Fauli
Change-Id: I59ea0d0dbd203590e7cedec51d0481c953e5172b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118155 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30indexing: add indexing export as an export filter for WriterTomaž Vajngerl
Change-Id: I26157a8ffeee80b03866569d3d3cec2a34fe377d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118144 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-30Fix potential (but unlikely) overflowJan-Marek Glogowski
warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow] while( nPos < nLen ) ~~~~~^~~~~~ Change-Id: I95e3bb4a131eaf4e82fbc74cc0bea92930b6afe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118159 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-30tdf#135316 cache propertysetinfo in SwXShapeNoel Grandin
shaves 3% off loaad time Change-Id: I6541f94553d862787566672d91e2a87902835664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118158 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-30tdf#135316 make regex object static constNoel Grandin
so we only compile it once, shaves 1% off load time Change-Id: I8e6e20205659582901ffb8d4496ce44906146204 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-30tdf#140431 XLSX export: fix double file:// prefixTünde Tóth
Regression from commit: fc58d7d65b9683db7b7632137126680b8483f6c5 (tdf#129969 XLSX export: file URLs need IURI encoding) Change-Id: I5bfb0ef9ba7fe82cd3f4d0e0b3fdcf8f705cba64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118090 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-30exclude more UNO type and crypto leaksNoel Grandin
that I don't want to try fixing just yet Change-Id: I18fc427ef7d2ed652bb7ffb911fc892833cbefd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-30uitest: guard the remaining create_doc_in_start_centerXisco Fauli
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I2a6149b318d1fdaa36efe5d65af4c238827eaaf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118154 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30uitest: guard create_doc_in_start_center in scXisco Fauli
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I9392c56e6efccde958f0cdd497376b3939b75be4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118152 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30uitest: guard create_doc_in_start_center in swXisco Fauli
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I513c76fe3536ce2d541b3588ce3f23990a0771be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118145 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30uitest: guard create_doc_in_start_center in sdXisco Fauli
Mostly done by a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: I314f3e2245bf57538073499f60528a455cba1a91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118138 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30tdf#132421 - don't URL encode filename for the import ASCII dialog titleAndreas Heinisch
Change-Id: Ia2cb7b6b355f640a525c41606da25ba35771499b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118148 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-06-30fix failure in JunitTest_unotools_complexNoel Grandin
Temp files created from OTempFileService are always opened with StreamMode::SHARE_DENYALL. So normally you can't open them twice. But the JunitTest_unotools_complex unit test used to work because it exploited a pessimisation in OTempFileService, where that code would close the file when we read to the end. Which meant that the unit test could open it again and read it. However, in commit 218f36dd614cf828e949f605faaf6a6fd615da26 Date: Sun Jun 20 18:51:12 2021 +0200 tdf#135316 remove OTempFileService pessimisation I removed that pessimisation. So make the share mode a little more permissive. Change-Id: I297a5c9c0505816b399fad29414077d03231ec72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-30tdf#139301 tdf#141933 (related) Translate new preset dash namesGabor Kelemen
Change-Id: I9cd7ad0eca1a6fb471a284fb2828a7ad12816337 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117024 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-30Add Portuguese support to ScriptForge library (l10n)Rafael Lima
Change-Id: I04341059becb36467795a2aa1d5c2f573fe1bc6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118092 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-06-30WinFloatRound has the same content as FRoundCaolán McNamara
Change-Id: Iaf1565d937ded7ab675ab216aef0100dd7af92e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-30Purge out rtl::math::setNanBaiXiaochun
Change-Id: If8794c105e279afd4437517d3e61f2f900eb6490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-30Avoid accumulating a huge number of Trace Events before calling the callbackTor Lillqvist
Don't use only the five second timer to flush the buffer. Set a limit on the number of accumulated events, too. Change-Id: I075028ce653d89cf099d91ce0d4d97c1361a3bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118089 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-30sw: rework to avoid DECLARE_SW_IMPORT_TEST() in CppunitTest_sw_txtimportMiklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Ic272bbecada260d22fa30e6e39a92be3d503d403 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118133 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-06-29Simplify expresionBaiXiaochun
Reduce operation count by space / speed tradeoff. This expression is widely used in LO. Then needs to be fast. Change-Id: Ic88cf15d451ec95a8ad6da88cd9f601cf2876871 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117954 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-06-29Extend and fix Scheduler GDB printerJan-Marek Glogowski
Adds a pretty printer for the whole Scheduler context and fixes an off-by-one error when dumping the ImplSchedulerData singly-linked list. Change-Id: I94129fc164986b379f33854651ff6df766eff97f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118075 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-29uitest: try harder to close the dialog when it fails...Xisco Fauli
... and close_button is None. Change-Id: I01318fd3eff5c9d8775443529ad1a7b18d537968 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118117 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-29uitest: simplify code with execute_dialog_through_actionXisco Fauli
Change-Id: I84cee48c7f7b450e00fed4f70b6c0c41e03dea9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118116 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-29gtk4: add some more known working dialogsCaolán McNamara
Change-Id: Ie6794832ac1c836b25761240dc4e563d896c36f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118128 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-29Drop old MSVC workaroundStephan Bergmann
Change-Id: Ifbbbad0bf837533d36fdeddcb0184baa5b789ca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118118 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-29Fix JavaVirtualMachine::disposeStephan Bergmann
...which must call derived-from JavaVirtualMachine_Impl::dispose (explicitly, when overriding it), but which got lost with 951a9342631129832e647bd8a303a959308bad65 "use single-use attribute for JavaVirtualMachine" Change-Id: I0ca581ae10400f430c24a04b056afbb45a5c1445 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118121 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-29Fix typosAndrea Gelmini
Change-Id: Ic943746614b894690768d0d6109123c1af819c52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118081 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-06-29gtk[3|4] add a catch-all AnyInput for under X tooCaolán McNamara
which is needed for gtk4, enable it for gtk3 as well, if that turns out to be a problem for some reason then that's easily fixed Change-Id: Ie3a1875d7930f4db4ff03d085bae07f1646f6e36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-29gtk[3|4] AnyInput wasn't doing anything useful under waylandCaolán McNamara
which is going to be the case for all backends under gtk4 at least detect if there is evidence that the VCL_INPUT_ANY condition is true to curtail the idle spellchecking (etc) writer loop in favor of user interaction Change-Id: Id1cefd720a921e3a0d1d403769c544c15c6360e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-29gtk3: match VCL_INPUT_ANY with or without TIMER if there's pending gdk eventsCaolán McNamara
Change-Id: Ia3ab9993569a5eac8a1811c0187c4256dce72d50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-29tdf#142589 Impress UI: fix Start button of Custom Slide ShowsTibor Nagy
This button started the selected custom slide show only by changing the (already) selected custom slide show, and enabling the checkbox "Use custom slide show". Otherwise it started always the full show. Remove the redundant checkbox "Use custom slide show" of the dialog window "Custom Slide Shows" (Slide Show->Custom Slide Show...) to avoid inconsistent behavior of the Start button (which could start the full show instead of the selected custom slide show). Now Start button of the dialog starts the selected custom slide show only once, i.e. it doesn't modify the global slide show settings for all the next slide shows (that is already handled by Slide Show->Slide Show Settings->Range->"Custom slide show:" and Slide Show->Slide Show Settings->Range->"All slides"). Change-Id: I6e97a69c546870199d5a45d9a6ad102e30d820c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117876 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-06-29constructing SaveOptions just to read default versionNoel Grandin
can be a little expensive sometimes, since it loads a bunch of other stuff at the same time. So create a custom method that just loads the version Change-Id: Ic480d95c4d64c68e57faf1b52f1d102141b7e246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118047 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-29tdf#143088 multiple Application::EventListeners is expensiveCaolán McNamara
use a Window level Listener and a WindowChild Listener instead An example for the need to listener to children is the calc conditional formatting dialog where clicking on any subentry of an collapsed entry is expected to expand that entry Change-Id: Ifead2fc1b75457d3ad314fdf15d343395afae6d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-29tdf#136435 extended tips for outline foldingOlivier Hallot
Change-Id: I29ec108c4227a921b36f4de023a9a4e8d3ed3a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117904 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-06-29maShowPageBreaksTimer.Stop() in ScGridWindow::dispose(), tdf#124983 follow-upEike Rathke
Stop this timer when the ScGridWindow is to be deleted, together with the underlying document. See https://gerrit.libreoffice.org/c/core/+/90101 comments from Miklos Vajna on 2021-06-29 14:08/14:10 CEST Change-Id: Ia1f39c406d391abd78a57c1d92616dbff788ec63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118112 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-06-29Enable JVM also on macOS ARM64Stephan Bergmann
My previous attempts of `make check` and running a --with-java build against various Azul JDK 13--17 have always crashed with SIGBUS that smelled like our uses of pthread_jit_write_protect_np in bridges/source/cpp_uno/shared/vtablefactory.cxx colided with corresponding calls in the in-process JVM, randomly(?) causing some attempts of running generated code to SIGBUS. (See the email thread starting at <https://lists.freedesktop.org/archives/libreoffice/2020-December/086490.html> "Using Java on macOS ARM64".) But at least with the recent <https://cdn.azul.com/zulu/bin/zulu17.0.63-ea-jdk17.0.0-ea.27-macosx_aarch64.zip> on macOS 11.4, this appears to work reliably now: Multiple `make check screenshot` as well as some manual use of LibreOffice did not run into any such issues. Change-Id: I2b1327e7e877ed71420c174c1d88e68a96b3532e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118114 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-29Enable flushing accumulated Trace Events when their number reaches a limitTor Lillqvist
Change-Id: I99ecf56b0faa5c444dbe9e22b8cce035f240c35c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118088 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-06-29Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to dbd32aead45fef14e81d3b1ca0a1973f1a856607 - Minor Change-Id: I8784fd6f43f5568db739e50a421bfff8184fd5d3
2021-06-29sc: don't require ctrl-click when clicking on internal links of shapesMiklos Vajna
Excel doesn't require such additional actions, and Writer doesn't require ctrl-click for internal links (e.g. cross-references), either. Also suppress the tooltip hinting ctrl-click in this case. Change-Id: If2fbec533f5c2a57268a22cf96464e724922ff7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118085 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-06-29Related: tdf#143088 listen to DefaultWindow for Settings changedCaolán McNamara
having multiple Application::EventListener are expensive while a Window::EventListener is cheap and in this document there are thousands of comments so having thousands of EventListeners is problematic. under gtk with start center open use gnome-tweaks to toggle in/out of a dark theme and the branding logo should continue to switch dark/light variants Change-Id: I64fd12e4bcb8e4fd131effe94e6882e54cfcaf19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-29Related: tdf#143088 return early on notification from frozen editengineCaolán McNamara
processing EE_NOTIFY_PROCESSNOTIFICATIONS from an EditEngine with an UpdateMode mode of false will just to on to cause AccessibleTextHelper_Impl::GetTextForwarder to throw an exception as a Frozen EditEngine is considered Invalid so return early instead Change-Id: I86f9647b7bf839cf3c7cf2f029be8c7c5aeef1f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-29remove pimpl from SwXTextCursorNoel Grandin
this class is only included from a small part of writer, so no real need for a pimpl pattern, and the alloc shows up on my perf profile, so reduce one of the allocs here Change-Id: I2ecb1bff5c06167fce8f53ffea18cb30d8df2dbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-14 22:39:24 +0000