summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-19ofz#5991 limit num of qpro tabs for fuzzingCaolán McNamara
Change-Id: Ifa205912ee0970657debdc17339e3df0c581a18f Reviewed-on: https://gerrit.libreoffice.org/49998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19Add export of the side wall for 3D chart, during .xlsx exportBartosz Kosiorek
LibreOffice doens't distinguish between sideWall and backWall. It is controlled by the same Wall property. Change-Id: If1919cf0a9bad3e80544cc5b2ae0f40f606febeb Reviewed-on: https://gerrit.libreoffice.org/49429 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-02-19Fix specific targets for UIConfig submodulesSamuel Thibault
For instance, make UIConfig_uui allows to run the UIConfig target for the uui module. Submodules are called for instance modules/swriter, but make UIConfig_modules/swriter was not working only because the main Makefile didn't include the generic target. This adds the generic target, thus fixing the issue. Change-Id: I6825fa5bf0daa4d964bea651841e8fac318fe068 Reviewed-on: https://gerrit.libreoffice.org/49825 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-19apparmor: allow cert9.dbRene Engelhard
... as used by firefox >= 58 Change-Id: I2769020327d3d097f734ab2c152bee2474b99767
2018-02-19ofz#5956 TimeoutCaolán McNamara
Change-Id: I72f7601d88213953997c9f6eef30ee85a486a20b Reviewed-on: https://gerrit.libreoffice.org/49996 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19weld: hook up help responseCaolán McNamara
and keep the current legacy ownership behaviour when welding the legacy backend Change-Id: I7e1f90f2d235abf0e10062b4be11ba5150bbdbfb Reviewed-on: https://gerrit.libreoffice.org/49918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19Remove now unused libgetuid.somichael.weghorn
Some scripts in which it was used have been removed (commit e1082e45361a92a31adedcc3ed0a35c704bca543) and the more reliable 'fakeroot' is now in use at all other places where libgetuid.so was previously used (s. tdf#115554). Change-Id: I638e96e5c8d671e3b145b79f33de718fe34ea514 Reviewed-on: https://gerrit.libreoffice.org/49837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-19ofz#6432 bad-castCaolán McNamara
ofz#6433 head-use-after-free ofz#6435 bad-cast Change-Id: Ic43edbab68d96e852039c3247853074180fd5091 Reviewed-on: https://gerrit.libreoffice.org/49984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19reserve negative responses for internal responsesCaolán McNamara
Change-Id: Iecf7d25340ff751c2984e27fdd303d2162472344 Reviewed-on: https://gerrit.libreoffice.org/49971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19Buildsystem changes to recognize Haiku.Kacper Kasper
Change-Id: I219d556f8e124cfe426cc1ac3c54da34eb7ef790 Reviewed-on: https://gerrit.libreoffice.org/49925 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-19tdf#115569 don't sign or validate text in tablesAshod Nakashian
Both undoing signatures and updating the metafield are causing seg-faults. Clearly more work is needed to support paragraph signing within tables, so disabled for now. Change-Id: Ia20c8b07069689b0e8b7d11a634a2a48ef1f0fa3 Reviewed-on: https://gerrit.libreoffice.org/49722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-19cui: remove dead codeChris Sherlock
Change-Id: I3f27d1b502512a5603110445da7b0c50a5339198 Reviewed-on: https://gerrit.libreoffice.org/47486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-19tdf#114756: fix connector dropdownJulien Nabet
bt: 0 0x00007fffef4738d3 in SdrEdgeKindItem::GetValueTextByPos(unsigned short) const (this=0x5555587ff770, nPos=0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdattr.cxx:1307 1 0x00007fffba50f71b in SvxConnectionPage::FillTypeLB() (this=0x55555c4d2a90) at /home/julien/lo/libreoffice/cui/source/tabpages/connect.cxx:507 2 0x00007fffba50be46 in SvxConnectionPage::SvxConnectionPage(vcl::Window*, SfxItemSet const&) (this=0x55555c4d2a90, pWindow=0x55555c46cc70, rInAttrs= SfxItemSet of pool 0x555557883790 with parent 0x0 and Which ranges: [(1000, 1234), (4003, 4057)], __in_chrg=<optimized out>, __vtt_parm=<optimized out>) at /home/julien/lo/libreoffice/cui/source/tabpages/connect.cxx:98 See https://bugs.documentfoundation.org/attachment.cgi?id=139972 Change-Id: I24ba9e0140668d666da686e3f8a05587b46e923f Reviewed-on: https://gerrit.libreoffice.org/49924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-19use RawBitmap in W_META_BITBLTNoel Grandin
part of making BitmapWriteAccess an internal detail of vcl/ Change-Id: I23393872fca5a924ceb7ca70edd8e6f70a3cfc13 Reviewed-on: https://gerrit.libreoffice.org/49965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19use std::array in createHistorical8x8FromArrayNoel Grandin
to make the assumption about the size of the array obvious in the code. Change-Id: I7ebe0b037e3be38f7e33c0160742f829288bb474 Reviewed-on: https://gerrit.libreoffice.org/49938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19sw: prefix members of SwPostItField, SwRefPageGetField and SwRefPageSetFieldMiklos Vajna
Change-Id: I37f72fd65ff7d9e6c992f92e770f0897f80aaf7b Reviewed-on: https://gerrit.libreoffice.org/49961 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-19use VirtualDevice in CreateDesignPreviewNoel Grandin
part of making BitmapWriteAccess an internal detail of vcl/ Change-Id: I78c5e2b6735c5180c28ab3a5de0d5ebc27f62438 Reviewed-on: https://gerrit.libreoffice.org/49960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19lok IME: underline characters which are being composedPranav Kant
Change-Id: Ibfc35f1668228400f37ec9b0b0350583483f484d
2018-02-19accessibility: Small optimisation in AccessibleTabListBoxArnaud Versini
Change-Id: Idf351923a57cf608dd4945e3ce639ba8011ecdbb Reviewed-on: https://gerrit.libreoffice.org/49922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in filepickerNoel Grandin
Change-Id: I367bea33bdb9ea3132d3ed079a16b516498b4fcc Reviewed-on: https://gerrit.libreoffice.org/49947 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in BibConfigNoel Grandin
Change-Id: I35a75bc9b4bb49dc3505fdc02167a8e62ece2f2e Reviewed-on: https://gerrit.libreoffice.org/49946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in CGMNoel Grandin
Change-Id: Iecd9251f68cd894a14fb6824151768d4cb663e0f Reviewed-on: https://gerrit.libreoffice.org/49944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19use VirtualDevice in createHistorical8x8FromArrayNoel Grandin
part of making BitmapWriteAccess an internal detail of vcl/ Change-Id: I8b3aa2fdd3c26db0e48b228640cd31b0bd31543c Reviewed-on: https://gerrit.libreoffice.org/49937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in swf::WriterNoel Grandin
Change-Id: Ia337bffa45a1949567f70586db480d92bb55b238 Reviewed-on: https://gerrit.libreoffice.org/49936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in SdrTableRTFParserNoel Grandin
Change-Id: I3d0657bcfcb9fca0d7f8c27499c159ddc5ccf47d Reviewed-on: https://gerrit.libreoffice.org/49935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in SvxLineStyleToolBoxControlNoel Grandin
Change-Id: I83e1536a1d45fffbf4fc5ddb611e382568ebf26c Reviewed-on: https://gerrit.libreoffice.org/49934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in FontPrevWin_ImplNoel Grandin
Change-Id: I0919b8e2c58dbe26154e4a7c7c77e8e63f665842 Reviewed-on: https://gerrit.libreoffice.org/49933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in SvxClipBoardControlNoel Grandin
Change-Id: Ib9e3d20680cba684fea8b586a5ca4c5835ca6b42 Reviewed-on: https://gerrit.libreoffice.org/49932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in AccessibleShapeNoel Grandin
Change-Id: I4c91ce6eb47f2802313fed22357e5c960cea50b2 Reviewed-on: https://gerrit.libreoffice.org/49931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in NavigatorTreeModelNoel Grandin
Change-Id: I53e7e4ab0a1533266ce97d5a093a1742808b6215 Reviewed-on: https://gerrit.libreoffice.org/49930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19fix windows build after 61bfc53ee710f9c79ac597888a6ee9dfee165ea4Markus Mohrhard
Change-Id: I5687d54bf2566898116c697f5a760cc0989ac0f6 Reviewed-on: https://gerrit.libreoffice.org/49955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-19starmath: Spare unnecessary assignmentsTakeshi Abe
Change-Id: I8ddc1c04a76475d63a39dc21d36cda7a7aa26b9e Reviewed-on: https://gerrit.libreoffice.org/49921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2018-02-19fix updater on windowsMarkus Mohrhard
Change-Id: Ib6f2334a3f6f3f5c217a71e2967a69e354b0a473 Reviewed-on: https://gerrit.libreoffice.org/49956 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-19ofz#6450 use the rule name, not the rule itselfCaolán McNamara
Change-Id: I62541dc48b7e9d5a906f32791437a86a8283a7bf Reviewed-on: https://gerrit.libreoffice.org/49952 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19ofz#6448 infinite-regressCaolán McNamara
Change-Id: Ie0c082a4b43355e935594f2dda694edfc9cdf315 Reviewed-on: https://gerrit.libreoffice.org/49950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19ofz#6449 Integer-overflowCaolán McNamara
Change-Id: Ia144192a1374615c50fb3574f7a229926e43d7cb Reviewed-on: https://gerrit.libreoffice.org/49951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-18uitest: fix small race condition when launching modeless dialogsMarkus Mohrhard
Change-Id: I44f7af1b44badce6ed09eeca0bb19760b5f22aa9 Reviewed-on: https://gerrit.libreoffice.org/49942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18uitest: call base class Activate in modeless dialogsMarkus Mohrhard
Change-Id: I342e925a5dbc178962f720f1efc9ee001d235718 Reviewed-on: https://gerrit.libreoffice.org/49941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18don't use the global mutex for UI stuffMarkus Mohrhard
This leads to deadlocks if one thread is using the process factory while holding the SolarMutex and another thread is calling the BackingComp::getTypes method. Change-Id: Ib4750aa1ebbfbf4f8dcd09ec2a218202450f4928 Reviewed-on: https://gerrit.libreoffice.org/49940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18uitest: add timeout for blocking actionsMarkus Mohrhard
Change-Id: I796d4ea0034ddae0427418f0d53a00c3dfa66871 Reviewed-on: https://gerrit.libreoffice.org/49939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18sw lok: assign a parent window to property dialogHenry Castro
Change-Id: Ief98b93502c3c69f84e7de47393718370a839208 Reviewed-on: https://gerrit.libreoffice.org/49926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-02-18DocumentSettingsSerializer must be SAL_DLLPUBLIC_RTTI for dynamic_castStephan Bergmann
...in SdXMLImport::SetConfigurationSettings (xmloff/source/draw/sdxmlimp.cxx) to work with instances of sd::DocumentSettings (defined in sd/source/ui/unoidl/UnoDocumentSettings.cxx, derived from DocumentSettingsSerializer), at least on platforms using the strict by-address RTTI equality check form (e.g., macOS). (Cross-casts like this are not detected by loplugin:dyncastvisibility.) Change-Id: I3f8712f9c64852cc8cb17c0c25211963360f117c Reviewed-on: https://gerrit.libreoffice.org/49884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-18Improve diagnostic outputStephan Bergmann
Change-Id: I9513f6516cd665c395f865ea204531bf8efb10b1 Reviewed-on: https://gerrit.libreoffice.org/49883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-18tdf#113907 Remove StartModuleCommands.xcuStephan Bergmann
...now that it's empty after a1eff3100a41f592407916dd4a21d0404f1364e1 "tdf#114206 remove duplication of strings in startmodulecommands.xcu" Change-Id: I46bd0e86a274b65919a4a3f4a4036a7858520376 Reviewed-on: https://gerrit.libreoffice.org/49879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-18Accessibility : cleanup constructors and destructors.Arnaud Versini
Change-Id: I63f94f4bb3865d0c2d211567588343e08878342c Reviewed-on: https://gerrit.libreoffice.org/49282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-18Translate German variable namesJohnny_M
m_xAktItemSet -> m_xCurrentItemSet m_bAktAND_fNumberAcross -> m_bCurrentAND_fNumberAcross in ww8par Change-Id: I1f78120008530b17d2eab508c8649798fc7bedea Note: Other occurrences of "Akt" will be done separately Reviewed-on: https://gerrit.libreoffice.org/49905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18tdf#114817 new bitmap presets for Area Fillandreas kainz
Change-Id: Icc48efc2f6c085ccf0754620dc1cbf5132a7f824 Reviewed-on: https://gerrit.libreoffice.org/49551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-02-18in numbering use "GraphicBitmap" property for image transportTomaž Vajngerl
Change-Id: I43abef3fe4a177f9f7867fe86e18beac812c626b Reviewed-on: https://gerrit.libreoffice.org/49923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-18Fix typosAndrea Gelmini
Change-Id: I3225398aa3d56f76a5e8a60aecb671665d94a717 Reviewed-on: https://gerrit.libreoffice.org/49920 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-18vcl: change mbIndex from sal_uInt8 to bool in BitmapColorChris Sherlock
In 193ec57c the comment not to change this bool was kept accidentally, but memcpy was removed in that commit so this is no longer an issue. Change-Id: I772d60bb940b3327f195707524b124d034f50f64 Reviewed-on: https://gerrit.libreoffice.org/49852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>