summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-04-17Fix typosAndrea Gelmini
Change-Id: If89ec640901253121529c09aef4537c6b13cee1d Reviewed-on: https://gerrit.libreoffice.org/52280 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-17remove ImpBitmapNoel Grandin
it's not adding anything useful, just hold the underlying SalBitmap instead Change-Id: I54852707b2f8af99283b9c882a428a8a7a11c4cf Reviewed-on: https://gerrit.libreoffice.org/52955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17NB Implementation: show menubar in NBShortcuts everywhereandreas kainz
Change-Id: I4a34890c1db282a0db4ce332e0221113dedcd3d2 Reviewed-on: https://gerrit.libreoffice.org/53034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-17coverity#1434889 Uncaught exceptionCaolán McNamara
and coverity#1401334 Uncaught exception Change-Id: Ib2fadd83068cc94c972f6312719081d5ac75d8ce
2018-04-17Only relevant whether mpTestEqualCondition is non-nullStephan Bergmann
...so change it from 'const bool*' to just 'bool' Change-Id: Ibc36058f2faab565162cd05f6e798ecaae094dc1 Reviewed-on: https://gerrit.libreoffice.org/52990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-04-17coverity#1434893 Uninitialized pointer fieldCaolán McNamara
Change-Id: Idaa49b1abc0d50ab50eae35e0f4c015aeeedbd42 Reviewed-on: https://gerrit.libreoffice.org/53019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17coverity#1434900 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ia4758d8e1fb50d25d8efeb9e3e1950e47bf3401c Reviewed-on: https://gerrit.libreoffice.org/53028 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#116725: justify selection to handle right-to-left selectionsMike Kaganski
Change-Id: I6298a87170236059ff08a1f891ead21236be663a Reviewed-on: https://gerrit.libreoffice.org/52979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-17ofz#7729 Null-dereference READCaolán McNamara
Change-Id: I223f4f7fd622822b42d8e7cb342d451c54d6dcbd Reviewed-on: https://gerrit.libreoffice.org/53017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#116812: Revert "The mfFontScale[n] is always 1.0"Khaled Hosny
This reverts commit 1b7e788eb3bf9cbe56ed5cc4a3fa7fa5e70ac40a and followup commit 843c6d6eec95b99e867c28ab27860215d5d72b37. Change-Id: I42d1ab76778466db356f0597c90e1afc2dc9997d Reviewed-on: https://gerrit.libreoffice.org/53013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-04-17Enable new Help to be installed as extensionOlivier Hallot
This patch enables the new help to be installed as an extension The extension must match the locale and LibreOffice version Extension id must be <locale>.help.libreoffice.org Version must match product version Help extension can be packed as Uno package from new help offline build (--with-help=html) To test the patch, use the en-US help in uno package format available in https://helponline.libreoffice.org/Help_en-US_6.1.oxt (To make it distinct from other help installations, the headings paragraphs are in red.) Change-Id: I2ff9eb94ef932c29ff7a93ce0241837213b25f2f Reviewed-on: https://gerrit.libreoffice.org/52700 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-17ofz#7671 Undefined-shiftCaolán McNamara
Change-Id: I84c6e6a3bb97d9949e9833adf14edf6bb89fe073 Reviewed-on: https://gerrit.libreoffice.org/53018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#117017 Make modifier keys not trigger the InputChanged handlerMaxim Monastirsky
Change-Id: Ib05883688ef4143c0b53871c4336920dde6f91cc Reviewed-on: https://gerrit.libreoffice.org/52924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-04-17tdf#116821 Keep row/column buttons enabled even when insert impossibleMaxim Monastirsky
So other commands included in these buttons (like delete or set height/ width), could still be used. Change-Id: If9e96116aebf73b2d20fb8d63ee67da3d17e3d9f Reviewed-on: https://gerrit.libreoffice.org/52909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-04-17weld SwFieldInputDlgCaolán McNamara
and GetWindowState/SetWindowState are unused as it turns out Change-Id: Id1c5dad151e1f3c94189b7bca1a7cf335613d3bd Reviewed-on: https://gerrit.libreoffice.org/53001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#100715 Slide transition sound: Remember remember last folderSamuel Mehrbrodt
Change-Id: I37bfb088a167464cdbd93a1f993a8161d12b379a Reviewed-on: https://gerrit.libreoffice.org/26937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-17weld SwMultiTOXMarkDlgCaolán McNamara
Change-Id: Idff6120f0a04bd94ec8402ae02daa9599f133698 Reviewed-on: https://gerrit.libreoffice.org/53004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17weld SwJavaEditDialogCaolán McNamara
Change-Id: I409e66ed7446ad56933bb806093aa7f7b1d62a4e Reviewed-on: https://gerrit.libreoffice.org/53000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Simplify calls to Menu::CheckItemMuhammet Kara
in cui, dbaccess, vcl, sc, sd Change-Id: I328d81cf6cd5a7e31fb21a758e4b2670e7df1b91 Reviewed-on: https://gerrit.libreoffice.org/52797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-17move the ImpBitmap::GetBitCount logic up to BitmapNoel Grandin
in preparation for removing ImpBitmap Change-Id: I1ca76c645a8e988f6cd9be8a01b0d2853f6d6750 Reviewed-on: https://gerrit.libreoffice.org/53014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17remove no longer necessary operator new/delete overridesNoel Grandin
and use "using" statements for the places where the overrides were resolving ambiguities Change-Id: Icb1d1a41f19e00f28a19947aa2c40bd5778fff94 Reviewed-on: https://gerrit.libreoffice.org/52993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17tdf#42949 Remove unnecessary localization headers from swGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<strings.hrc\> sw | xargs grep -c -e SwResId -e StartProgress -e GetResource | grep :0$ | grep -v /pch Change-Id: I041a4e8b4c4cc7414f83bd08e64a1ff921244b44 Reviewed-on: https://gerrit.libreoffice.org/52919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-17tdf#116848 sw, sections in tables: no split in headers or footersMiklos Vajna
The motivation for split section-in-tables was multiple pages, so disabling it for headers/footers is not a problem, and fixes the layout loop. Change-Id: I3e13690f6e6b50c35417f8a4f7886fd0befe7962 Reviewed-on: https://gerrit.libreoffice.org/53006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-17tdf#115600 Display messages in Findbar for Text Frame, Graphics, OLEJim Raykowski
...object, Drawing, and Control navigation Change-Id: Ic9809e60ae18179f0ea36a4e3c61d09aea3c2929 Reviewed-on: https://gerrit.libreoffice.org/52935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-17Set parent window for print dialogSamuel Mehrbrodt
In embedded LO this dialog sometimes shows up in background. Change-Id: I9b7f423aaa6b2bbe915398287a5f3b955af930b4 Reviewed-on: https://gerrit.libreoffice.org/52962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-17tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu
Change-Id: I3ba75dbe6754b8138f61e223387832a6fb53c1c5 Reviewed-on: https://gerrit.libreoffice.org/52752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17cppcheck: identicalInnerCondition in scJochen Nitschke
and remove a related known condition dpcache.cxx Change-Id: I6069849c33ea03eff61a55eb790ce6a8aad3d915 Reviewed-on: https://gerrit.libreoffice.org/53005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17cppcheck - fix variableScope in some filesGökhan Gurbetoğlu
Reduced the scope of some variables in source. Change-Id: Ib3b521ca5df8b9b254b51eab5f1d7040d6cfd846 Reviewed-on: https://gerrit.libreoffice.org/52974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17loplugin:constparamsNoel Grandin
Change-Id: I3d1b88dbd0ff73fddc08d52f50e0efb42daab89b Reviewed-on: https://gerrit.libreoffice.org/52756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17Clarify checking o_pbLink directly, versus missing dereferencingStephan Bergmann
But given 18ab7abaa9426cd27092125637fdf5fb849b4a04 "MediaWindow::executeMediaURLDialog: add link button" documents that parameter as "if not 0, this is an 'insert' dialog", it looks plausible that all these places indeed want to check the pointer-to-bool for non-nullness, rather than checking the dereferenced bool. Change-Id: Ifbd5e4b711bee97f3ba0b6aab556f533574d21c6 Reviewed-on: https://gerrit.libreoffice.org/52992 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-17external/firebird: Better workaround for Clang alignment expectationsStephan Bergmann
8ea07101c1613d213fd7cea17f094a947b14cd00 "external/firebird: Work around operator new alignment violations" had misused DEBUG_GDS_ALLOC to work around the problem that recent Clang on Linux x86-64 assumes some storage allocated via Firebird's global operator new replacement to be 16-byte aligned, while Firebird only provides 8-byte alignment. This problem now also appears on macOS x86-64, at least with Apple's Clang version "Apple LLVM version 9.1.0 (clang-902.0.39.1)" from Xcode 9.3 (as well as with recent plain Clang trunk, towards Clang 7), when building --enable- optimized. However, while the DEBUG_GDS_ALLOC hack would still cause ICU_convert_init (workdir/UnpackedTarball/firebird/temp/Release/intl/cv_icu.o) to not use movaps on erroneously assumed to be 16-byte aligned memory, it would cause strange failures on macOS (pos being out of bounds in traRpbList::PopRpb, workdir/UnpackedTarball/firebird/src/jrd/rpb_chain.cpp, in the invocation of isql during the build of external/firebird) that I haven't tracked down further. As it happens, the recently added 14955ed91b282ccbb395cb47c6d76e3b42b34748 "external/firebird: Support Clang ASan" provides a different workaround for the underlying problem that appears to work well on both Linux and macOS x86-64, reusing USE_ASAN also in these cases to shut down most of Firebird's own memory management. I assume that affected Clang are plain Clang >= 4 (as I'd mentioned in my <https://sourceforge.net/p/firebird/mailman/message/35671804/> "Re: [Firebird- devel] alloc.h global operator new replacement violating alignment requirements") and Apple Clang >= 9 (for which __apple_build_version__ is defined). Because DEBUG_GDS_ALLOC is no longer passed in from the outside, its setting in external/firebird/asan.patch can be simplified (cf. commit message of 14955ed91b282ccbb395cb47c6d76e3b42b34748). (The given scenario in ICU_convert_init involves an allocation of 24 bytes, where Clang may or may not be allowed to assume 16-byte alignment, see <http://lists.llvm.org/pipermail/cfe-dev/2018-April/057669.html> "Re: [cfe-dev] operator new alignment assumptions". However, as reported at <https://sourceforge.net/p/firebird/mailman/message/35671750/> "Re: [Firebird- devel] alloc.h global operator new replacement violating alignment requirements", Firebird only supports 8-byte alignment, which would definitely be wrong in a similar scenario where the requested allocation was a multiple of 16 bytes.) Change-Id: I48884f9d008eaeaea369850e24f05b8806f9b676 Reviewed-on: https://gerrit.libreoffice.org/52956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-17Remove dummy "Support help number" under Windows' "Apps and Features"dennisroczek
section. The OOO_ARPURLINFOABOUTTEMPLATE is simply missleading as the caption in Windows itself is "Supportlink". As the help states that the product homepage can be used, switch to libreoffice.org, see documentation at https://msdn.microsoft.com/en-us/library/aa367752 Additionally switch some links to https. Change-Id: I8d6d871130d2a50a5ce9aa3e80687601e3038c4e Reviewed-on: https://gerrit.libreoffice.org/52193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-17MoveErrorMarkTo already sets the m_nErrorStart and m_nErrorEndMike Kaganski
Change-Id: I1016a0e6787af7bbf4415356ae565ffc9c1ab0ef Reviewed-on: https://gerrit.libreoffice.org/52967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-17Updated coreOlivier Hallot
Project: help 49375fa3358ea5bf8cb8ba0f1bf4f5ab0ada40c3 Helpcontent2 housekeeping Deleted spurious file in source/ Change-Id: Ia7417413e615635496398c223a0d95911c994123 Reviewed-on: https://gerrit.libreoffice.org/53012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-17Updated coreOlivier Hallot
Project: help 22691f35eea6bf031fe271790d9b19093a12f8f4 Fix index in sidebar The last commit of online_transform.xsl instrpduced a bug in index search on the left. This one fixes it. Change-Id: I8055389a324d1fc5fde90ac2b76ff6f0a4a42493 Reviewed-on: https://gerrit.libreoffice.org/53011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-17tdf#113197 Add MaskPrimitive (clip) to EMF/WMF if neededArmin Le Grand
Added code to quartz vcl implementation that takes care when BitmapPalette.count != (depth^^2)-1 - which may be the case anytime. If then a bitmap value exists that goes beyond that count, a invalid access was executed Change-Id: Iab332c91b8753aab85e9d365323f5c9e531efab2 Reviewed-on: https://gerrit.libreoffice.org/44058 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-16Fix typosAndrea Gelmini
Change-Id: Ife28cd9399cfcb375bad764dac7424eda50d430d Reviewed-on: https://gerrit.libreoffice.org/52198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-16sd lok: Impress: Right-click menu on misspelled word locks up sessionTamás Zolnai
Change-Id: Ib554eea7049c1ea244bc4789ee3d7d2adf87e283 Reviewed-on: https://gerrit.libreoffice.org/52977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-04-16tdf#113624 EMF+ Add support for different units conversionBartosz Kosiorek
With previous implementation only Pixel unit was supported. Other units (eg. inch, milimeters, points, world) was treated as Pixel. With this patch the correct unit conversion was implemented to following records: - FontObject - PenObject - SetWorldTransform As a result records are properly scaled. Tested with DrawString record from: https://bugs.documentfoundation.org/attachment.cgi?id=140287 Change-Id: I77435ad8f1bbac08f298a03d91d0c7f1f1734e5c Reviewed-on: https://gerrit.libreoffice.org/52699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-04-16tdf#55058 Properly close shapes with close shape method.Bartosz Kosiorek
With previous implementation of closing shapes, we are adding new line between last and first point. It was causing wrong border shape during displaying. With this patch proper method was used to fix that. Change-Id: If0a084700401edd9d3b8a57cb27154079828e6ed Reviewed-on: https://gerrit.libreoffice.org/52843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-04-16Defer grammar checker thread creation until use.Michael Meeks
Avoid this thread being started and stranded in the forkit. Change-Id: Ia79cdac729a85960c2b5a83af265d67af07b74aa Reviewed-on: https://gerrit.libreoffice.org/52980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-04-16tdf#117034 right click crashCaolán McNamara
Change-Id: I91aa9f24904948987f31c9df5211c694f943188e Reviewed-on: https://gerrit.libreoffice.org/52976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-16sal_uInt16 -> sal_Int32Mike Kaganski
Change-Id: I756206aacabe53d85b7a6f397bf08abd5892ca76 Reviewed-on: https://gerrit.libreoffice.org/52969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-16Take care of E3DObjListArmin Le Grand
E3DObjList is not needed, remove. Remove memeber from E3DObject, derive E3DScene directly from SdrObjList, some cleanups in SdrObject, too Change-Id: Ifa4620a800c14faf21f8b80fd4dc1d39f71be804 Reviewed-on: https://gerrit.libreoffice.org/52740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-16weld SwInsFootNoteDlgCaolán McNamara
Change-Id: I54849e2336d093e9044d4b32275387fa04e3bab9 Reviewed-on: https://gerrit.libreoffice.org/52963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-16missing mnemonicsCaolán McNamara
Change-Id: I0e28cbd915cd65489965eab6fa35be50de364b13 Reviewed-on: https://gerrit.libreoffice.org/52965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-16tdf#78777 - Keyboard shortcut for number formatting on macOSheiko tietze
Shortcuts moved from MOD2 to MOD3 Change-Id: I5e038916b7c607b7cae06a297f57f7c75b790c4c Reviewed-on: https://gerrit.libreoffice.org/52966 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-16tdf#37074 - Customization of MOD3 missing on macOSHeiko Tietze
Shortcuts added likewise for MOD1 Change-Id: I506897500b4e22349aecdf5231e80c84a0f3a878 Reviewed-on: https://gerrit.libreoffice.org/52964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-16tdf#117033 - Tooltips show the wrong symbol for MOD3 combinationsheiko tietze
Symbol for MOD3 added Change-Id: Idb76199fbff240fe39c96ed837db098a4283d70b Reviewed-on: https://gerrit.libreoffice.org/52957 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-16Use different properties in Upgrade tableMike Kaganski
Change-Id: I7e2cc08a1312da629e4644be97ebc7ed40250702 Reviewed-on: https://gerrit.libreoffice.org/52995 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-30 01:33:12 +0000