summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-09-28loplugin:virtualdead in basctlNoel Grandin
Change-Id: I6a3f74a3c52f3fb97b26de69b20ffd7502968d5e Reviewed-on: https://gerrit.libreoffice.org/79646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28"KWINDOWSYSTEM_DEPRECATED static void setMainWindow" (take 2)Julien Nabet
/home/julien/lo/libreoffice/vcl/unx/gtk3_kde5/kde5_filepicker.cxx: In member function ‘virtual bool KDE5FilePicker::eventFilter(QObject*, QEvent*)’: /home/julien/lo/libreoffice/vcl/unx/gtk3_kde5/kde5_filepicker.cxx:271:51: error: ‘static void KWindowSystem::setMainWindow(QWidget*, WId)’ is deprecated [-Werror=deprecated-declarations] 271 | KWindowSystem::setMainWindow(w, _winId); | ^ In file included from /usr/include/KF5/KWindowSystem/KWindowSystem:1, from /home/julien/lo/libreoffice/vcl/unx/gtk3_kde5/kde5_filepicker.cxx:24: /usr/include/KF5/KWindowSystem/kwindowsystem.h:255:42: note: declared here 255 | KWINDOWSYSTEM_DEPRECATED static void setMainWindow(QWidget *subwindow, WId mainwindow); | ^~~~~~~~~~~~~ There's a new method we could use but it's only possible when baseline will include kwindowsystem >= 5.62 Change-Id: Idd3dca98e15585077c20848613fce72c5daae0e2 Reviewed-on: https://gerrit.libreoffice.org/79781 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-28loplugin:constmethod in ucb..uuiNoel Grandin
Change-Id: I53db381de8e063b6a3aa07051351e655c6f040fa Reviewed-on: https://gerrit.libreoffice.org/79782 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:constmethod in swNoel Grandin
Change-Id: I73c3c6d2165287d2d581a04b23b1d3b48166a488 Reviewed-on: https://gerrit.libreoffice.org/79780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28Hold reference on parent dialog while emitting EndDialog.Michael Meeks
Also cleanup the code. Change-Id: I5f9d562319dc244ee22feb2e3fd64023bc229c4e Reviewed-on: https://gerrit.libreoffice.org/79771 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79777 Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-09-28tdf#126321: avoid flickering in page size popupXisco Fauli
In a Tabbed notebookbar, Layout - Page Size Change-Id: I74ab54e96486de960d1ccc7bcb3c2679e25a6e9e Reviewed-on: https://gerrit.libreoffice.org/79752 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-28Avoid lambda being destroyed while it is being called.Michael Meeks
Also armor against mpDialogImpl going down during EndDialog. This can happen during an insert chart wizard cancel, as out of place embedded dialog cleanup occurs. Change-Id: I1b666f07d4ec72e07fdf6888cea44a5a13976073 Reviewed-on: https://gerrit.libreoffice.org/79772 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79778 Tested-by: Jenkins
2019-09-28Revert "KWINDOWSYSTEM_DEPRECATED static void setMainWindow"Julien Nabet
the function is only available from kwindowsystem 5.62, so more recent that our baseline. This reverts commit 94e22f5a2fcc9f193ce0370805156ad5320d4141. Change-Id: I6957a7d4438cd57c4a0eab29a9c615d45eaa2235 Reviewed-on: https://gerrit.libreoffice.org/79776 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-28loplugin:virtualdead in editengNoel Grandin
Change-Id: I72f9cf62f9daeaed5108ede41dd41544204a9745 Reviewed-on: https://gerrit.libreoffice.org/79643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28loplugin:virtualdead in extensionsNoel Grandin
Change-Id: I953ceaccf6c7d0cfe1f98006a6ed00544399ef97 Reviewed-on: https://gerrit.libreoffice.org/79642 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-28Resolves: tdf#127786 cache Glibc locale string in LanguageTagImplEike Rathke
... for non-simple @modifier strings that are constructed using liblangtag, as loading resource strings needs it over and over and over again. Change-Id: Ib6a74e5ddb44508aa41f101c200a508bfa4a13bd Reviewed-on: https://gerrit.libreoffice.org/79770 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-09-27Add conversion from rtl::OStringNumber to std::string_viewStephan Bergmann
...and revert the relevant part of 2f5f45921b05904a4be1ff633be09c62cb44ff08 "support O(U)String::number() for fast string concatenation", as discussed in the comments of that Gerrit change, now that 89bb0b0dcd8dc4656d0047cd10702d1c471c0fa1 "Deduplicate O(U)StringNumber definitions; add toAsciiUpperCase" paved the way. For consistency, also add conversion from rtl::OUStringNumber to std::u16string_view, even if that remains unused as of now. Change-Id: Ieb64bff0b59c22f3dec05c99fca5676b27a46e9a Reviewed-on: https://gerrit.libreoffice.org/79750 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27KWINDOWSYSTEM_DEPRECATED static void setMainWindowJulien Nabet
/home/julien/lo/libreoffice/vcl/unx/gtk3_kde5/kde5_filepicker.cxx: In member function ‘virtual bool KDE5FilePicker::eventFilter(QObject*, QEvent*)’: /home/julien/lo/libreoffice/vcl/unx/gtk3_kde5/kde5_filepicker.cxx:271:51: error: ‘static void KWindowSystem::setMainWindow(QWidget*, WId)’ is deprecated [-Werror=deprecated-declarations] 271 | KWindowSystem::setMainWindow(w, _winId); | ^ In file included from /usr/include/KF5/KWindowSystem/KWindowSystem:1, from /home/julien/lo/libreoffice/vcl/unx/gtk3_kde5/kde5_filepicker.cxx:24: /usr/include/KF5/KWindowSystem/kwindowsystem.h:255:42: note: declared here 255 | KWINDOWSYSTEM_DEPRECATED static void setMainWindow(QWidget *subwindow, WId mainwindow); | ^~~~~~~~~~~~~ Change-Id: I6c8d4277b06d503b402042fbf234e9300db423c5 Reviewed-on: https://gerrit.libreoffice.org/79751 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-27Missing include (for std::move)Stephan Bergmann
Change-Id: I38a59d2955a8081bf3ae701a102b0b5c68bd16f3 Reviewed-on: https://gerrit.libreoffice.org/79749 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27loplugin:virtualdead in sdNoel Grandin
Change-Id: Idca2a3a53c4b79ba21a3113da63a8a96d8b2cd81 Reviewed-on: https://gerrit.libreoffice.org/79641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-27add translator comments to [L] [S]Caolán McNamara
Change-Id: Id4943a906fe412aab2250fc7ddbc5fb34fa669f7 Reviewed-on: https://gerrit.libreoffice.org/79722 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27tdf#50846 - Wrong type of function GetLastUsedRowAndreas Heinisch
Changed the type of the function GetLastUsedRow from int to long in order to avoid overflows. Change-Id: Ia0d789611f732eecdfdbe557b751dbead5748c45 Reviewed-on: https://gerrit.libreoffice.org/79586 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-27loplugin:virtualdead in slideshowNoel Grandin
Change-Id: Ie158b76e6d552b1189173e30fbea5a43a774180b Reviewed-on: https://gerrit.libreoffice.org/79640 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-27tdf#127676: avoid flickering in line width popupXisco Fauli
Change-Id: Ie69a5b4d33d12316e6fd7e443b92851cffc95b8c Reviewed-on: https://gerrit.libreoffice.org/79667 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-27tdf#62326 - Macros: Converting Hex strings of negative valueAndreas Heinisch
If the value of the hex string lies within the range of 0x8000 (SbxMAXINT + 1) and 0xFFFF (SbxMAXUINT) inclusive, cast the value to 16 bit in order to get signed integers, e.g., SbxMININT through SbxMAXINT. Moved unit test to test_scanner.cxx in order to test basic hex convertations. Removed old vba unit tests. Change-Id: I247b41c40197afc5328ef5685c758c1dd1cefae5 Reviewed-on: https://gerrit.libreoffice.org/79583 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27Revert "tdf#121925 test for URLClassPath.ClassPathURLCheck"Stephan Bergmann
This reverts commit 905c107cde4a0a7059b1e11b5f23a0a59188cb0c. Conflicts: configure.ac As discussed at <https://bugs.documentfoundation.org/show_bug.cgi?id=121925#c12> "Fix Java Jar dependency classpath to pass the ClassPathURLCheck": "At least with java-latest-openjdk-headless-13.0.0.33-1.rolling.fc31.x86_64, the testurlcheck program in configure.ac reports 'false', but (when you convert the corresponding AC_MSG_ERROR into a AC_MSG_RESULT to not make configure fail) a full `make check screenshot` works fine for me." Change-Id: I205bada5e8eeede7b33cdbc3f87a629edb8b9872 Reviewed-on: https://gerrit.libreoffice.org/79687 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27tdf#125585 write default layer status for OLE objectsRegina Henschel
The layer status is taken from the active view, when saving the document. But embedded documents have no view. Error was, that for all layers value 'false' was written in that case. With this patch the defaults (visible, printable, not locked) (true, true, false) are written. Change-Id: I2388ce31cc208fba075083889ec1bb2f874ef482 Reviewed-on: https://gerrit.libreoffice.org/79701 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-09-27cid#1453996 Unchecked return valueCaolán McNamara
Change-Id: I0b5010aec8ad941d662e851833923a8b6b0a383d Reviewed-on: https://gerrit.libreoffice.org/79672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27filter: XHTML: make "calc-heading-digit" a little fasterMichael Stahl
Exporting OpenDocument-v1.3-csd01-part3-schema.odt to XHTML fails with: runtime error: file share/xslt/export/xhtml/body.xsl line 1404 element variable xsltApplySequenceConstructor: A potential infinite template recursion was detected. You can adjust xsltMaxDepth (--maxdepth) in order to raise the maximum number of nested template calls and variables/params (currently set to 3000). Unfortunately the document contains this many headings, and the calc-heading-digit computes the value by recursively looking at every preceding heading in the document, without TCO apparently... Try to improve this by using XPath to filter early the headings that are effectively ignored in the 3rd xsl:when case anyway: the ones with a level lower than the one for which the number is requested; this limits the recursive calls to the number of headings on the same level. Change-Id: Iddf5a91664402a57a0138731ddc9cebb06b0a126 Reviewed-on: https://gerrit.libreoffice.org/79720 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-27sw: document what Cont means in SwFootnoteContFrameMiklos Vajna
It's container, not content or continuation. Change-Id: I741798ff9dd72cc5d277107a935d8ccdf33d495c Reviewed-on: https://gerrit.libreoffice.org/79721 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-27Deduplicate O(U)StringNumber definitions; add toAsciiUpperCaseMike Kaganski
Change-Id: I00e7ce62940907b5f4efc2b7f23f355c3e43ed6b Reviewed-on: https://gerrit.libreoffice.org/79686 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-27loplugin:virtualdead in svlNoel Grandin
Change-Id: Idbb5d0a633f12d5813561a2ad8aed46ec6d67c48 Reviewed-on: https://gerrit.libreoffice.org/79639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-27cid#1448334 silence Untrusted value as argumentCaolán McNamara
Change-Id: I13f626c29ceeafbca91b06e5efd11b79b0f25a76 Reviewed-on: https://gerrit.libreoffice.org/79679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27Related: tdf#124601 DOC import: always allow floating tables in header/footerMiklos Vajna
So now the DOC import is in sync with the DOCX one, see commit 81ef96a2417c7843dfed0558c920ad3064e58921 (tdf#79639 DOCX import: don't delay text frame conversion of in-header tables, 2015-06-01). The bugdoc used to have 2 additional pages in Writer (compared to Word), it has only 1 after this. Change-Id: I24f0dc28599e608737dc19a0143e72832202a034 Reviewed-on: https://gerrit.libreoffice.org/79682 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-27Resolves: tdf#122487 avoid duplicates when auto-naming drawing objectsCaolán McNamara
we were looking inside groups already, but our set was limited to the length of toplevel objects, so it wasn't sufficient. just collect all used nums and return the first unused number Change-Id: I239118e9cff7b7ed2a40d68f284c3c4d1d9eb6c4 Reviewed-on: https://gerrit.libreoffice.org/79657 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27cid#1453994 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ife94e1e8861f108cd6db54694232c7686f47dc6e Reviewed-on: https://gerrit.libreoffice.org/79671 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Housekeeping: replace png by svg in Math Change-Id: I927b99852b6741e70ee168a8cb146ef9a59d4f1b Reviewed-on: https://gerrit.libreoffice.org/79659 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-09-27Fix Typo SvxMenuConfigPage -> SvxConfigPageStephan Bergmann
...introduced with ccb2b0078f07194befa61f1e3fd88e53ff236871 "weld SvxMenuConfigPage/SvxToolbarConfigPage", causing -fsanitize=dynamic-type- mismatch during UITest_writer_demo: > include/tools/link.hxx:163:10: runtime error: downcast of address 0x613000204b40 which does not point to an object of type 'SvxMenuConfigPage' > 0x613000204b40: note: object is of type 'SvxConfigPage' > 83 01 00 4e b0 a1 bb 2e f6 7f 00 00 20 c4 56 00 e0 60 00 00 50 f8 a4 00 40 60 00 00 e8 49 38 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SvxConfigPage' > #0 in SvxMenuConfigPage* tools::detail::castTo<SvxMenuConfigPage*, SvxConfigPage*>(SvxConfigPage*) at include/tools/link.hxx:163:10 > #1 in SvxConfigPage::SvxConfigPage(weld::Container*, weld::DialogController*, SfxItemSet const&) at cui/source/customize/cfg.cxx:997:41 [...] Change-Id: Ie36ebabd3075cade590cc504fb06b5319b346dcf Reviewed-on: https://gerrit.libreoffice.org/79666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27cid#1454003 silence 'Constant' variable guards dead codeCaolán McNamara
Change-Id: I4ba26647f4081f5c13726b78c737b54e8ab1773d Reviewed-on: https://gerrit.libreoffice.org/79675 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27cid#1454002 Dereference after null checkCaolán McNamara
Change-Id: I855922a70b615b8ac4de147d081d530edcc5be63 Reviewed-on: https://gerrit.libreoffice.org/79674 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27cid#1454001 silence Unchecked dynamic_castCaolán McNamara
Change-Id: Idc17c90d6cf0f843ab6b9bf2ace4199102aaf29a Reviewed-on: https://gerrit.libreoffice.org/79673 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27cid#1448369 silence Unchecked dynamic_castCaolán McNamara
Change-Id: I578eac509805b2d363b09026899f2b2d60dc368e Reviewed-on: https://gerrit.libreoffice.org/79678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27cid#1448524 silence Unchecked dynamic_castCaolán McNamara
Change-Id: I9ba17a4a31382850b76c98bb435e63eb19ee7903 Reviewed-on: https://gerrit.libreoffice.org/79677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27harmonize shadow sidebar with area sidebarandreas kainz
Change-Id: I7d157815c291de7ef88bf9973bf780de3e340340 Reviewed-on: https://gerrit.libreoffice.org/79511 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-09-27Silence false cid#1454000 "Side effect in assertion"Stephan Bergmann
The side effect is intentional here. Change-Id: I05d166bb312ea3a97905607c5effccf1e8d8eef7 Reviewed-on: https://gerrit.libreoffice.org/79668 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27cid#1453999 move coverity suppressionCaolán McNamara
Change-Id: I539acc147193dcf2c8687a4f2e5d39c11f447782 Reviewed-on: https://gerrit.libreoffice.org/79669 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27cid#1453993 Unchecked return valueCaolán McNamara
Change-Id: Ie30e1b40b8867246c793294b7b34b38a86f9ad01 Reviewed-on: https://gerrit.libreoffice.org/79670 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27Error: attempt to subscript container with out-of-bounds index 24Stephan Bergmann
...doing `bin/run vcldemo` and clicking on the third column in the third row Change-Id: Ibe93f701a1ebf2447d5f5240e9a4ecab378918ef Reviewed-on: https://gerrit.libreoffice.org/79665 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27tdf#42949 Fix IWYU warnings in xmlhelp/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I266367d4f9e2b9bf637fc103a5e4876bd6b1d2b9 Reviewed-on: https://gerrit.libreoffice.org/79261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-27tdf#116685: Make the RICHTEXT take precedence over EMBED_SOURCE.Jan Holesovsky
Before this patch, copy in Calc, Paste in Writer produced an embedded sheet. I suspect is it not what the people usually want; working with the embedded sheets in Writer is non-intuitive, I suspect people will be happier with a normal table which they can style etc. appropriately. OTOH - this is a general change, so it might have some unwanted side-effects; let's see what if we get bugreports :-) tdf#127673 was related; but in my view, we shouldn't create the embedded objects in the first place. Change-Id: I73710168d8924fdd6275d65e20cf55f38971a3f9 Reviewed-on: https://gerrit.libreoffice.org/79606 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-09-27Removed duplicated includeAndrea Gelmini
Change-Id: I7571da9c657be845c62c9f452210f55fde67883d Reviewed-on: https://gerrit.libreoffice.org/79653 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-09-27Related: tdf#124601 DOC import: improve fLayoutInCell handlingMiklos Vajna
There were 3 problems here: First, SwWW8ImplReader::IsObjectLayoutInTableCell() should not use m_nProduct to determine the Word version. It depends on an undocumented field of the [MS-DOC] format and the bugdoc shows how it interprets a Word 2007-produced document as a Word 97 one. Instead, parse the cswNew field of the file header, which is a more or less documented way to find out if this file was produced by >=2000 or 97. See e.g. <https://docs.microsoft.com/en-us/openspecs/office_file_formats/ms-doc/841b5f72-487e-4fe7-8657-ec90d5af8750> where the Dop structure maps cswNew values to Word versions. Second, parse the fLayoutInCell correctly: it's part of a bitfield, with two variables: a bool and an other one which decides if the bool should be read at all. The bugdoc's case was evaluated as false, so do the proper parsing in that case and leave the existing logic as-is for now. Third, there doesn't seem to be a reason to exclude the wrap-through case for the fLayoutInCell -> follows-text-flow mapping. The bugdoc shows that Word interprects fLayoutInCell the same way for wrap-though objects, too. Change-Id: Iaddd5e522e0380b731899f32a17c14ce4442ac35 Reviewed-on: https://gerrit.libreoffice.org/79629 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-27xmloff: create XMLDrawContentExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Ib63744f720a886cd67b4158399e6bf91c6efb128 Reviewed-on: https://gerrit.libreoffice.org/79660 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-27loplugin:virtualdead in svxNoel Grandin
Change-Id: I8af09a2f0a4a8c7952c5855b2934f2d0a64d9740 Reviewed-on: https://gerrit.libreoffice.org/79638 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-27external/breakpad: glibc 2.30 declares tgkillStephan Bergmann
...so building against glibc-headers-2.30-4.fc31.x86_64 fails with > src/client/linux/handler/exception_handler.cc:109:12: error: static declaration of 'tgkill' follows non-static declaration > static int tgkill(pid_t tgid, pid_t tid, int sig) { > ^ > /usr/include/bits/signal_ext.h:29:12: note: previous declaration is here > extern int tgkill (__pid_t __tgid, __pid_t __tid, int __signal); > ^ > 1 error generated. Upstream commit <https://chromium.googlesource.com/breakpad/breakpad/+/ 7e3c165000d44fa153a3270870ed500bc8bbb461%5E%21/> "Fix double declaration of tgkill when using Android NDK Headers" looks like the perfect fit. Change-Id: I1b4805886fb7c770cf9733f34a31296e6b859d92 Reviewed-on: https://gerrit.libreoffice.org/79661 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-13 22:37:47 +0000