summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-12-18tdf#108580: integrate vc_redist.exe into MSIMike Kaganski
... in InstallUISequense. Use --with-vcredist-dir to point to a directory with vc_redist.x64.exe and/or vc_redist.x86.exe. Use --without-vcredist-dir (or --with-vcredist-dir=no) if you don't want to ship it as part of installer and want to silence the configure warning. VCRedist 2015 version 14.0.24215.1 is available at https://www.microsoft.com/en-us/download/details.aspx?id=53840 Since VisualStudio 2015, VC redist merge module that we used before started to work differently: it installs the UCRT only on WinXP, but not on later OSes (Vista to 8.1) which may lack the UCRT (Win10 has it out of the box). The merge module only installs VCRuntime on those systems, which still leaves us with "api-ms-*.dll is missing" problem. (https://blogs.msdn.microsoft.com/vcblog/2015/03/03/introducing-the-universal-crt/ gives more information on VCRedist refactoring background.) Since commit 71d9a61302e65fe091cf70c13fa72b3df09b7e3a, we use a workaround described at the page mentioned above as "App-local deployment of the Universal CRT". We just copy all UCRT DLLs to LibreOffice/program. This has a drawback though, that our UCRT is not updated by Windows Update, so users would rely on LibreOffice updates in case of some vulnerabilities in UCRT (and they could even not realize they have that problem). MS recommends to install UCRT using EXEs they provide from their site. The EXEs install both VCRuntimes and UCRTs, along with required patches, for all Windows versions (Windows XP through Windows 10, where they only install VCRuntimes); the installed libraries are managed by system's update mechanism. But those EXEs cannot be used in MSI custom actions inside InstallExecuteSequence, because they use MSI themselves. So this patch integrates the vc_redist.xXX.exe into MSI binary table, and uses custom action to run the EXE after ExecuteAction in InstallUISequence. This will show the user a VCRedist install window after the main LibreOffice installation finishes; no user interaction is required (except for one additional UAC request), and errors are ignored. Since this installation takes care of both VCRuntime and UCRT, we can ultimately drop both the app-local workaround, and vcredist merge module (so VCRuntime would also be updated by system). The former is done here: this reverts commit 71d9a61302e65fe091cf70c13fa72b3df09b7e3a. This approach has its drawback: if one wants to use unattended installation (without UI; one example is deployment using ActiveDirectory GPO), then InstallUISequence is not run, and so VCRedist isn't installed. In this case, one should install VCRedist separately. Supposedly this should not be huge problem, because this is the case for many existing applications that need separate VCRedist deployment in these scenarios, and unattended installation is advanced stuff that requires prepared user. A notice would be required in release notes and FAQ, though. Change-Id: Ia6a16be60af8a08f41ea7c3dbd457d8f89006006 Reviewed-on: https://gerrit.libreoffice.org/46356 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-18chart2: When creating objects prevent setting object rects dirtyTomaž Vajngerl
3D objects using a E3dScene are traversing all object in the tree when setting rects dirty. When we are creating objects, setting properties and adding them to the tree we trigger setting rects dirty which slows down considerably - more are added objects, bigger the slowdown gets. So the solution here is to temporary disable setting object rects dirty during creation of objects. Change-Id: Id068cda9cb798d49b75bf4228cf6460f7e98c033 Reviewed-on: https://gerrit.libreoffice.org/46446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-12-18chart2: Batch changes to properties when creating 3D objectsTomaž Vajngerl
MultiPropertySet doesn't broadcast ItemSets as often as setting each property separately. This can help when we create a lot of 3D objects. Change-Id: I4eb842a5d8c43963bdceee84468593f5f6b47336 Reviewed-on: https://gerrit.libreoffice.org/46445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-12-18Updated coreChristian Lohmaier
Project: translations 9a856d562ebae5d1ae691ec623cf4ebb23299930 update translations for 6.0/master and force-fix errors using pocheck Change-Id: Ie978deb62c62ea4ad661ea45d155bdd4b0d1f811
2017-12-18loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Icf42fdd40a2cf6cda82254f81a7e389c7bac8558 Reviewed-on: https://gerrit.libreoffice.org/46683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18partially revert "Use for range loop in sdrhhcwrap (sw)"Noel Grandin
commit 01b64e5f5e3658810c7e66c6577705764ef7e288 managed to drop a fairly important assignment to a class field. Change-Id: I3fc28fd8b6a47e2ed6a363f42876ce57c9f2e5c2 Reviewed-on: https://gerrit.libreoffice.org/46682 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18coverity#1426312 Unchecked return valueCaolán McNamara
Change-Id: I59c65a2fc43e55c445efde351e7bd959f6dfbd04
2017-12-18coverity#1426315 Logically dead codeCaolán McNamara
Change-Id: I61368c5fa5675ac6a9e43642700ae3ea03d2fda9
2017-12-18ofz: Null-derefCaolán McNamara
Change-Id: Ice265d7c868b44c6673f3960dffc227d8352ccd0
2017-12-18clear the data provider cache after import, tdf#111960Markus Mohrhard
This might also fix some problems with normal ODS files and not just with FODS files when we recompile formulas after the whole import. Change-Id: Iec05d2052ca5ce3bdf03abf02d502e4537fd3082 Reviewed-on: https://gerrit.libreoffice.org/46672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-18tdf#113928 More handling of SID_READONLYDOCMaxim Monastirsky
At least the second change makes a difference when attempting to switch to read only mode, when there are unsaved changes (by either choosing "Save" or "Don't Save"). Change-Id: Ic46b7f9b18900dd7ce83144be0319d6062cef6c8 Reviewed-on: https://gerrit.libreoffice.org/46671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-18loplugin:unusedindexMike Kaganski
Change-Id: I256a807dd2a4c81126b5a76f3d472e31b8224146 Reviewed-on: https://gerrit.libreoffice.org/46652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18convert EEHorizontalTextDirection to scoped enumNoel Grandin
Change-Id: Icb7298742ae80fa17d5e6f6a3a09a6bb30892b6d Reviewed-on: https://gerrit.libreoffice.org/46590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18convert HyperLinkPageType to scoped enumNoel Grandin
Change-Id: I9554cdee56c7079ed8633ffb16074c99d5ab144e Reviewed-on: https://gerrit.libreoffice.org/46588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18convert ColorPickerMode to scoped enumNoel Grandin
and drop unused Add constant Change-Id: I4e4f0d35e4d081883b78e0205ffd7086c9cadf04 Reviewed-on: https://gerrit.libreoffice.org/46587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18sal_uIntPtr->size_t in ObjOrderChangedNoel Grandin
to match the other position parameters used in SdrObject Change-Id: I100f4fb99f902bb6261b5470dd6b5553aefd764d Reviewed-on: https://gerrit.libreoffice.org/46586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-18Handle merged cells.Kohei Yoshida
Change-Id: Iaa7194d4226300e495982bb1f90f72c31d748955 Reviewed-on: https://gerrit.libreoffice.org/46660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Remove unused method.Kohei Yoshida
Change-Id: Idc7919f04898b0298d6448d2dd84222b211cf5db Reviewed-on: https://gerrit.libreoffice.org/46659 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Take into account the fact that ScDocument already has one sheet.Kohei Yoshida
ScDocument already has one sheet upon creation, so we need to avoid appending sheet when the request is for the first sheet. Change-Id: Ie5526d6791e545f5faa0bf3f16988351c09e94c8 Reviewed-on: https://gerrit.libreoffice.org/46658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18All the other orcus-based filters should take the same code path.Kohei Yoshida
Change-Id: Iac96c6eb842a769d70c3f39830cbdb0e1ee93dc8 Reviewed-on: https://gerrit.libreoffice.org/46657 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Remove code duplicates.Kohei Yoshida
Change-Id: I424e5999ef2ec6e71f6b6361ed91079b8d949555 Reviewed-on: https://gerrit.libreoffice.org/46656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Initial step on enabling the orcus-based Excel 2003 XML filter.Kohei Yoshida
Still some work remains in the orcus interface implementation code in sc. Change-Id: Idc4d95b489e8e55fbe3593557399610abe6c4ae0 Reviewed-on: https://gerrit.libreoffice.org/46655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-12-18Unit test for implicit intersection with shared formulas, tdf#114251 relatedEike Rathke
Change-Id: I8c11c2719b9496fd33194a7a9906e53f23f38f66 Reviewed-on: https://gerrit.libreoffice.org/46648 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-17tdf#113928 Add uno:ReadOnlyDoc command.Gulsah Kose
That uno command is opposition to uno:EditDoc command. Change-Id: I34977a46c274574e8e44097a16c0fa8972d68559 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/45005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-17ofz: ensure ppHead validity for remaining scopeCaolán McNamara
Change-Id: Ia7d81a80663008aac54ee7d8c3057a4d85c110b3 Reviewed-on: https://gerrit.libreoffice.org/46646 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-17ofz#4678 ensure null terminationCaolán McNamara
Change-Id: I6b6b0763e85a41d03f9e03c6abc17c6c311f6519 Reviewed-on: https://gerrit.libreoffice.org/46641 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-17ofz#4677 Indirect-leakCaolán McNamara
Change-Id: Ifffcd229db10de933f34367f3b283227634a358a Reviewed-on: https://gerrit.libreoffice.org/46640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-17svtools: Delete copy ctor in a standard wayTakeshi Abe
Change-Id: I3d44c7b0ff16897b49f3f3e5a7026dcd1be1301f Reviewed-on: https://gerrit.libreoffice.org/46645 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-17sfx2: remove SfxInPlaceClientListChris Sherlock
After commit 21680809, which converted SfxInPlaceClientList to a vector, the class name is out of whack. There is no need for SfxInPlaceClientList, just use std::vector, also renamed the variables that use the class. Change-Id: I9f0c8d5800376617ac29fbe7da140af2703c0de7 Reviewed-on: https://gerrit.libreoffice.org/46631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-17Related: tdf#114251 disable vectorization of svDoubleRefEike Rathke
It doesn't work, not knowing how to handle implicit intersections not only produces huge unnecessary matrix operations but also delivers wrong results. Unit test will follow as a separate commit. Change-Id: I14982d4a53d6af57196da998e53d426502c22fec Reviewed-on: https://gerrit.libreoffice.org/46647 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-17Related: tdf#114251 disable ocName named expressions for vectorizationEike Rathke
Recursive checking of their token arrays would be needed. This solves the slowness in the non-threading case of tdf#114251 because no arrays are generated for the named ranges, which is rather a lucky workaround than a solution. The wrong handling of range references in general (array where scalar is expected, no implicit intersection) still persists. Change-Id: I57385bd95efa584108d93d724921285c97a91a45 Reviewed-on: https://gerrit.libreoffice.org/46623 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-17Type svIndex does not necessarily mean range name, tdf#114251 relatedEike Rathke
Change-Id: I5e7930b7f93ee44fb0d6b4c86f261afde8ed2ccc Reviewed-on: https://gerrit.libreoffice.org/46615 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-17coverity#1426163 Improper use of negative valueCaolán McNamara
Change-Id: I2c9fea13981ac9c429d55461869b22097cc1b330 Reviewed-on: https://gerrit.libreoffice.org/46604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-17coverity#1426169 refactor to be less obscureCaolán McNamara
and coverity#1426166 no logic changes intended Change-Id: I241f3f09c6a4ab143b67eb9341e8a52acbae64e3 a026f03980fdf1c80d1c6cffbd8ad0325c8f5d02 Reviewed-on: https://gerrit.libreoffice.org/46619 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-17Related tdf#114455: fix mem leak on olmenu (sw)Julien Nabet
Change-Id: If1da0b1c1dab15694bd741e1827c6a6edf5c46e9 Reviewed-on: https://gerrit.libreoffice.org/46613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-17Fix typosAndrea Gelmini
Change-Id: I4630ba4a93a32c47753422b29535c36b53ff3d5e Reviewed-on: https://gerrit.libreoffice.org/46635 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-17Fix typosAndrea Gelmini
Change-Id: Ifcbf431291cc77ffc33cc1cbcc493181ffc9943d Reviewed-on: https://gerrit.libreoffice.org/46634 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-17tdf#91857 Round of improvements to Impress's menus for 6.0Yousuf Philips
Change-Id: I844b8396a55820da904d4813cbb84c56c33af51c Reviewed-on: https://gerrit.libreoffice.org/46583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-17tdf#91820 Round of improvements to Calc's menus for 6.0Yousuf Philips
Change-Id: Ia738456e5b351cc92777cd9795a3bfc641c454bc Reviewed-on: https://gerrit.libreoffice.org/46582 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-17tdf#98058 Respect menu:style="text" settingMaxim Monastirsky
It was implemented on the xml handling side, but ignored by the menubar code. In addition, make the menu:style attribute survive customization (similar to tdf#114261). Change-Id: I92a3517ee7ba2fe7a0782985d89fb5d0fdbac246 Reviewed-on: https://gerrit.libreoffice.org/46627 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-17loplugin:unusedindex Remove useless outer loopMike Kaganski
Change-Id: I6e5e7162b1e0ea2b9f33866ea76e2614acdffb06 Reviewed-on: https://gerrit.libreoffice.org/46606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-17Updated coreOlivier Hallot
Project: help b6e0ecde5fb3eafe88846f055a4917ac99d38e36 tdf#112155 Help page for Save a Copy Change-Id: Ie514f96925c0283e05ac9686b06edbda7853801b Reviewed-on: https://gerrit.libreoffice.org/46632 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-17Updated coreOlivier Hallot
Project: help f583ac513198a3aa70840f63aa26d766e5f9daf3 tdf#106421 Terminology change Set Paragraph Style Change-Id: Ia05979c826a283296396ecca42277ce8d352ef1c Reviewed-on: https://gerrit.libreoffice.org/46629 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-17fix searched attribute for 3D chart shape, tdf114169Markus Mohrhard
Change-Id: Ic0642d4b223db121bdf5968af73811af8571bd72 Reviewed-on: https://gerrit.libreoffice.org/46614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-17Updated coreOlivier Hallot
Project: help 8b0a4944747cde7395b36e53893d85dc8b07ee05 tdf#40460 Improve help for Calc IRR function Change-Id: Ie61635f75ec8d208656623c61b31d1bc82c75663 Reviewed-on: https://gerrit.libreoffice.org/46625 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-17Updated coreOlivier Hallot
Project: help 52613d9b557df908883211cbfb49e7a5f2b9ce3c tdf#106535 better help pg. for text selection modes Change-Id: I4d48553d9ca261493e52183a4b47d5a9e40595d4 Reviewed-on: https://gerrit.libreoffice.org/46620 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-17Updated coreOlivier Hallot
Project: help 3114a84355a738b365d3c65c403a8062305ddaff tdf#104171 Cleanup of Macro Help pages Removed shared/main0600.xhp (obsolete) Fixed links between help pages Added entry to tree file (contents) Change-Id: I2a954c328f214728d554bff2166f82b2c2b96f35 Reviewed-on: https://gerrit.libreoffice.org/46618 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-17coverity#1426171 Unchecked dynamic_castCaolán McNamara
and coverity#1426170 Unchecked dynamic_cast coverity#1426164 Unchecked dynamic_cast coverity#1426165 Unchecked dynamic_cast and duplicated lines look like cnp gone wrong Change-Id: I195204e9d0a4d591fbe210241203a17b22b25ec1 Reviewed-on: https://gerrit.libreoffice.org/46603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-17coverity#1426167 refactor to be less obscureCaolán McNamara
no logic change intended Change-Id: I10ef6038351b2808c2030aa55f05e078d80345ae Reviewed-on: https://gerrit.libreoffice.org/46609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-16coverity#1426162 refactor to be more clearCaolán McNamara
and help out coverity wrt 'Dereference after null check' Change-Id: I8c07fd0afc686e1c0bfd87d9c8bd1ea341f6e616 Reviewed-on: https://gerrit.libreoffice.org/46610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-05 00:06:50 +0000