summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-08-23vcl: move ImplEmphasisMarkStyle() to vcl::Font and add unit testChris Sherlock
Change-Id: I958296225c5491a2cd78d64fb16d079272d7c28d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138140 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-23sw: document SwUndoAcceptRedlineMiklos Vajna
Both redlines and undo track edits to the document. There is an undo for accepting redlines, but there is no redline for interacting with undo actions. Change-Id: I4b6f88d6d06aa68abdef4c26dc58aae334a2cb94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138704 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-08-23asserts unnecessary for SwNode::operator==Noel Grandin
since we're directly comparing pointers. Various places are already comparing SwNodeIndex from different documents like this, so this doesn't make the code any looser than before. Change-Id: Ic8feacee67b9495649ffc9560ce105078850a677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-23tdf#57317 odf export: avoid autolist conflict with NumberingStylesJustin Luth
Somehow you can have autoStyles writing into the styles.xml. Well, the code to prevent duplicates for that needs to exist for autoStyles written into document.xml as well. Change-Id: I9602b7023a1ef009ad644374dc5081afb8a76916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138703 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-08-22make an effort to fix the UITest_inputLine intermittent failureCaolán McNamara
debugging what normally happens I see that the EditEngine belonging to this inputbar widget is thrown away by calc when the content of the cell changes and is only recreated on the next "Paint" of the inputbar. It's plausible that throwing processEventsToIdle at the problem solves this. Change-Id: I620bae9eb87b2ff91755da9b8d7821791f0e4240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138708 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1509273 Unchecked dynamic_castCaolán McNamara
get ScDocument the way the rest of ScNavigatorDlg does Change-Id: Ib1e66a48cc385ac1ad479e8e3b6efa04349116e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138706 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1509296 silence Use after freeCaolán McNamara
Change-Id: I6c1d8c0365cb59f3c63537c08e27a34bac111aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22I see this empty entry for the separator in the styles dropdownCaolán McNamara
Change-Id: I0c0787f893e50ea32b3dc7bf4356b4603d8f8cdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138689 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22Resolves: tdf#150288 Do not prepend the locale's full date acceptance patternEike Rathke
... if it wasn't present as first, but take the date acceptance patterns as specified by the user. Change-Id: Ife2fd39731bac0e0b121f22392f22b48ffc9c978 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138694 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-08-22tdf#150507 set hint style even if the platform returns no default font optionsCaolán McNamara
if the platform (e.g. gen/kf5) doesn't return anything for GetCairoFontOptions() but we have need for specific font options then we also need to set them Change-Id: Ia805341d2ec75bdaf3d9de62955a247c33b106d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138684 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22chart2: always use the series for the keys (symbols) in data tableTomaž Vajngerl
In special case the legend keys are not series, but can be each value of a series. This can't be done for the data table where so this has been disabled. This caused a crash when positioning the symbols, as in some cases we got 0 symbols (due to another bug that didn't put the symbols into the collection) or more symbols that there were series (and the symbols couldn't be positioned correctly). With this change we now get the correct number of symbols for the data table. Also added the test document and test to open the document, to make sure we don't crash anymore. Change-Id: Idbebdd5295595a823b5420958e803b13258df035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138697 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-22sw: Navigator: Protect Bookmarks should allow editing the text ...Michael Stahl
... in the bookmark. Only deleting/renaming it is forbidden. Change-Id: I66c6d106f0fd97b416edabd0271cd3230909a279 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138692 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-08-22tdf#150139 - Add a concrete name to the error messageAndreas Heinisch
Add a concrete name to the "Property or method not found: $(ARG1)" error message when creating a listener. Change-Id: I76c904793a96082c49f8aa2d45c76c50a453d892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138061 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-08-22use more SwPosition::AssignNoel Grandin
as part of the attempt to keep the internals of SwPosition in sync with each other Change-Id: I6f109c32f5748ef3f76ab178a2aa9d6822bc58a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138688 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-22tdf#148849 sw: fix cursor pos at tracked DeleteRow in Hide ChangesLászló Németh
In Hide Changes mode, the text cursor jumped to the start of the document after tracked deletion of a table row, instead of remaining in the table in the next table row. Regression from commit a74c51025fa4519caaf461492e4ed8e68bd34885 "tdf#146962 sw: hide deleted row at deletion in Hide Changes". Change-Id: Iff959c9a9940db013827e1c827bcb92c07b4b26a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138683 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-08-22Remove code duplication in GraphicDescriptor for PSDofftkp
GraphicFormatDetector and GraphicDescriptor have duplicate format detection code so now GraphicDescriptor uses GraphicFormatDetector functions instead to detect the format for PSD files Change-Id: Icae532a7143477dada411224293250a26676c684 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138227 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-22Remove code duplication in GraphicDescriptor for PNGofftkp
GraphicFormatDetector and GraphicDescriptor have duplicate format detection code so now GraphicDescriptor uses GraphicFormatDetector functions instead to detect the format for PNG files Change-Id: I8ce1c5eee44ff4122f4ecf1094d3d8b18379c6b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138226 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-22Remove code duplication in GraphicDescriptor for BMPofftkp
GraphicFormatDetector and GraphicDescriptor have duplicate format detection code so now GraphicDescriptor uses GraphicFormatDetector functions instead to detect the format for BMP files Change-Id: I1cf096034a77826e61c36f0a5094976f49814747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138216 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-22Remove code duplication in GraphicDescriptor for RASofftkp
GraphicFormatDetector and GraphicDescriptor have duplicate format detection code so now GraphicDescriptor uses GraphicFormatDetector functions instead to detect the format for RAS files Change-Id: I736c583a9cc974a9eb4151443295dbb4b1e71053 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138212 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-22Remove code duplication in GraphicDescriptor for WEBPofftkp
GraphicFormatDetector and GraphicDescriptor have duplicate format detection code so now GraphicDescriptor uses GraphicFormatDetector functions instead to detect the format for WEBP files Change-Id: Ib9d7169433b391e2520d6b9bca831fa964a8d136 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138211 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-22Remove code duplication in GraphicDescriptor for METofftkp
GraphicFormatDetector and GraphicDescriptor have duplicate format detection code so now GraphicDescriptor uses GraphicFormatDetector functions instead to detect the format for MET files Change-Id: I3188fe4bcdd5e0d9a942c6606d28a01c56319619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138210 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-22Remove code duplication in GraphicDescriptor for TGAofftkp
GraphicFormatDetector and GraphicDescriptor have duplicate format detection code so now GraphicDescriptor uses GraphicFormatDetector functions instead to detect the format for TGA files Change-Id: I939426d3016c90500c2a250ef464213b0fd7d642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138209 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-22upgrade to hunspell 1.7.1Caolán McNamara
Change-Id: Ifff2f17d17ab2764f3703b008fcb096ff08c9315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22ScriptForge - (SF_Calc) support of 16384 columns in a sheetJean-Pierre Ledure
Alignment with Calc support of 2^14 columns as from LO 7.4 instead of 2^10. Review of comments accordingly. Minor optimization of internal method _GetColumnName() More accurate control of boundaries in internal method _Offset() Change-Id: I590ae9a4fab0b90a6e9cc9bbacf6c1b582f9c6e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138666 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2022-08-22crashtesting: fix DOCX export of tdf135569-1.docxMiklos Vajna
This went wrong in commit 9700c1b2170ad04453a361ed5647937833ac3c18 (sw content controls, plain text: add DOCX import, 2022-07-25), which conditionally disabled the DOCX export of content control starts. The trouble is that the matching content control end is still written unconditionally, leading to a not-well-formed XML output. Reading the commit message, the motivation for the conditional start was testSdtAndShapeOverlapping in CppunitTest_sw_ooxmlexport7, but it seems that is no longer necessary since we try it harder to not pollute the doc model with never-read grab-bags in commit 7ad44f3dd271a591529b048212c4391d8b38ed9d (crashtesting: fix DOCX export of forum-mso-de-99522.docx, 2022-08-16). Fix the problem by just reverting the problematic hunk, seeing it's no longer needed for the testSdtAndShapeOverlapping scenario and it causes a problem here. Change-Id: I5cc94ee00dfdf55de1fffe1c28242388549862ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138685 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-08-22Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to f69bba3fa11f5345ec32bea471dbdfbbad3134a3 - updatetemplastes for master/7.4.1 rc1 and force-fix errors using pocheck Change-Id: I265246d2f2ee85ea07314dc4632ac97952c7c7aa
2022-08-22sw: forgot to remove temp FIXME of draft patchMichael Stahl
Change-Id: Ic4e0a9fcace27b781d401f9812df89e36f87bcd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138691 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-08-22cid#1500671 silence Resource leakCaolán McNamara
Change-Id: I295d7877100b49a867a0f67e2edcc923d943401b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138664 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22ensure no font/glyph fallback is happening for repeatable resultsCaolán McNamara
Change-Id: I7098ea59f1da2c80cde138109dd6a5c8e5b7e997 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138681 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22add Noto Sans Arabic to fonts known not to have bulletCaolán McNamara
when measured by ImplFontMetricData::ImplInitTextLineSize Change-Id: I328436b3728927b58adc75f51061ebfa1d00b01d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138680 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1509220 Explicit null dereferencedCaolán McNamara
Change-Id: I5cc8958a5dd4f05fd8798eb561779027a868e386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138679 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1509228 Explicit null dereferencedCaolán McNamara
Change-Id: I60c806e08c23219b7f652fef55dae93a668290f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138678 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22only need to call ReleaseMouse once, the 2nd one is a no-opCaolán McNamara
Change-Id: I7892a6956feef84e23b11a47199961052faf589a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138677 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1509233 Explicit null dereferencedCaolán McNamara
Change-Id: Ib48bc9fd9600115f00674eed385f9e2cdc80eafd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138676 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22Add a VisualStudio cpp.hint fileMike Kaganski
It allows to improve IntelliSense results. E.g., this specific SAL_THROW_EXTERN_C define prevented from navigating to function implementations like rtl_str_hashCode_WithLength from IDE using 'Go To Definition' feature. As described in the respective documentation [1], "Hint files relate to physical directories, not the logical directories shown in Solution Explorer", which means that the file can't be placed e.g. in solenv/vs, together with the .natvis file. [1] https://go.microsoft.com/fwlink/?linkid=865984 Change-Id: I144d07b66b4a52c108a7e82b0aa9628843f5ae2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138665 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-08-22tdf#87535: Preview styles using CTL/CJK fonts in the sidebarKhaled Hosny
Code is similar to code in svx/source/dialog/fntctrl.cxx and source/ui/chrdlg/drpcps.cxx, etc. Instead of using only the “western” font, it splits the text based on script type and uses the appropriate font for each script type. Change-Id: Iacdf92829d4568f2d580b39ca14ffe1218ceaa9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22tdf#87535: Preview styles using CTL/CJK fonts in the styles menuKhaled Hosny
Code is similar to code in svx/source/styles/CommonStylePreviewRenderer.cxx, etc. Instead of using only the “western” font, it splits the text based on script type and uses the appropriate font for each script type. Change-Id: I1db87748119beac18e5b7e61617419c149400c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138601 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1509244 silence Dereference null return valueCaolán McNamara
Change-Id: I2dc9baee3e42712f6bf09aed5243e451aee6018a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1509396 Explicit null dereferencedCaolán McNamara
and cid#1509395 Explicit null dereferenced Change-Id: Ifd8dffe2ff2432ee2f0ef18bb2a480c2f042910b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1500530 return early to silence Dereference after null checkCaolán McNamara
Change-Id: Ia549ae31c7f13d70228620ffb4bce78ea95ba083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138673 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1500544 Uninitialized scalar variableCaolán McNamara
Change-Id: Ibe55cef41b6e6fd2ea10a9f4684e5f3e7926983a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22qt a11y: Don't set invalid Qt relationsMichael Weghorn
When no matching relation type is found when when trying to match LO's `AccessibleRelationType` to a corresponding Qt equivalent, don't set an invalid value, but skip this relation. Previously, when navigating to a Writer paragraph with the qt6 VCL plugin and Orca enabled, this would show up on stderr: warn:vcl.qt:220606:220606:vcl/qt6/../qt5/QtAccessibleWidget.cxx:218: Unmatched relation: 1 warn:vcl.qt:220606:220606:vcl/qt6/../qt5/QtAccessibleWidget.cxx:218: Unmatched relation: 2 Cannot return AT-SPI relation for: QFlags() Cannot return AT-SPI relation for: QFlags() This addresses the warnings emitted by the Qt library (lines 3 and 4). The first two warnings are from LO and remain for now, as long as Qt does not implement an equivalent for `AccessibleRelationType::CONTENT_FLOWS_FROM` and `AccessibleRelationType::CONTENT_FLOWS_TO`. Change-Id: If2cb5394b27d23926e4d4093ba8ab477997a16ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138671 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-22cid#1510101 silence Copy-paste errorCaolán McNamara
Change-Id: Ic5fcf10889147b6dfe22b18ea4ebee51ac547a4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138660 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1500700 silence Resource leakCaolán McNamara
Change-Id: I606583919bceac98b480f3821c349069611808b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138662 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22change hi to ar and Lohit Devanagari to Noto Sans ArabicCaolán McNamara
for reproducible tests Change-Id: Ia5429c259190b2263dc4a9de971538dda0f53166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22cid#1500675 return early to silence Dereference after null checkCaolán McNamara
Change-Id: If43b82c9db4517e24cc3c6d8b61a38624e6243b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22use more SwPosition::GetNodeNoel Grandin
Change-Id: Iba1207fd5006c3bd56f45da3c46b84f5e8c43340 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-22cid#1500470 silence Resource leakCaolán McNamara
Change-Id: I846746a351c619a4de7abce7a6443f510dc41690 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138661 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-22sw: prefix members of NumberingPreview, SwDocStatPage, SwEnvDlg and ...Miklos Vajna
... SwTestTabPage See tdf#94879 for motivation. Change-Id: Ie60001ada507d5355715ebaaed3897de9854f7d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138655 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-08-22Remove NULL-terminated requirement where not applicableMike Kaganski
These functions take the string length instead, so may take non-NULL-terminated strings. Change-Id: I21dbfd97adec197ba52ae5f9e01340b44689805b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138658 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2024-08-04 21:40:10 +0000