summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-10-18tdf#157573 sw floattable: fix incorrect lack of left margin after tableMiklos Vajna
Regression from d477fa8ac1b0d3ee81427217bbb5950278ab16db (sw floattable: unconditionally map <w:tblpPr> to SwFormatFlySplit, 2023-03-17), the paragraph after the anchor of the floating table in the document lost its left paragraph margin at a layout level. Turns out the problem was there earlier, but it was hidden for this specific document, because we used to map DOCX floating tables to Writer inline tables in some cases before. The real problem was introduced earlier, in my 50a1df360c907d8419ce49f098b6bc87a37a9956 (n#775899 sw: add FloattableNomargins compat flag, 2012-08-23), even a TODO was added to point out this will be problematic. The old bugdoc wants to get rid of margins, because the floating table is already shifting text towards the right, the new bugdoc wants to keep the original margin as the paragraph after the anchor is not wrapping. Fix the problem by reverting the older fix and re-fix the old document differently. Don't do changes to the paragraph margin: that's not a good idea. If there is enough anchor text, it'll lead to a visibly bad paragraph margin anyway. Instead of reducing the paragraph margin, reduce the width of the fly portion in the paragraphs that intersect with the floating table. That's reasonly straightforward to do, because SwTextFormatter::CalcFlyWidth() already has a case when we know we're intersecting with a floating table and we also know that the floating table is aligned to the left. In this case we can simply reduce the fly portion width with the paragraph margin. This keeps the old bugdoc fixed and fixes the new bugdoc. It also means that DocumentSettingId::FLOATTABLE_NOMARGINS is now effectively unused, but that's not yet removed in this change. Change-Id: Ibaccc4807fd8c11bd45955b76e96cd4a5e55976f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158103 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-18Drop duplicated forward declarationsMike Kaganski
Change-Id: I0804518ce97e3f5f8098c4a4416675409746aaea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158044 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-18tdf#156033 sw: Don't capture mouse when executing file dlgMichael Weghorn
When the mouse is captured in `SwView::InsertGraphicDlg`, temporarily release it while executing the file dialog, so the user can use the mouse to interact with the file dialog. At least with qt5/qt6/kf5, this would otherwise not work in the file dialog shown after clicking on a previously inserted Picture Content Control, because `QWidget::grabMouse()`'s "other widgets get no mouse events at all" [1] apparently applies for the file dialog and other running applications as well. [1] https://doc.qt.io/qt-6/qwidget.html#grabMouse Change-Id: I80a81c57c80debc716a1b111a9c07eef0c005c65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158109 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-18tdf#157792 followupNoel Grandin
avoid doing some extra Invert() operations by creating an AlphaMask instead of a Bitmap to pass to the BitmapEx constructor. Change-Id: I1af3a5e65010b346fa0d0c56836d567e51c9b58b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-18tdf#157696 a11y: Report spelling error via IA2 "invalid:spelling" attrMichael Weghorn
Let `AccessibleTextAttributeHelper::GetIAccessible2TextAttributes` also report spelling errors as a text attribute, since the "invalid:" text attribute with a value of "spelling" is specified for that in the IAccessible2 tex attributes specification [1]. In order to adapt the start/end index for the attribute run, iterate over all of the text markups that can be retrieved from the `XAccessibleTextMarkup` interface instead of just deterining whether the offset itself lies within a range of misspelled text via `XAccessibleTextMarkup::getTextMarkupAtIndex`. (This is strongly inspired by how the gtk3 a11y implementation does it, s. `handle_text_markup_as_run_attribute` in vcl/unx/gtk3/a11y/atktext.cxx.) When using the qt6 VCL plugin on Linux, the attribute shows up as expected in Accerciser and the Orca screen reader announces "misspelled" when moving the cursor in front of a misspelled word using the Arrow_Right key. Announcement by NVDA works once winaccessibility and NVDA have been switched over to use IAccessible2 text attributes instead of custom LibreOffice ones. [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes Change-Id: I54e5bcbb4bef4c73068243f91a3ee69c10326460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158089 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-18tdf#157696 qt a11y: Move handling for text attr offsets to helperMichael Weghorn
Add a new method `AccessibleTextAttributeHelper::GetIAccessible2TextAttributes` and move some more of the logic from `QtAccessibleWidget::attributes` there to prepare adding handling for spelling errors via the "invalid:spelling" IAccessible2 text attribute and for reuse in winaccessibility. Change-Id: I3b4a89ee680437fa2c35c429639b372a55f5a4b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158088 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-18tdf#155410 shave 1% cost off SdrGroup::GetLayerNoel Grandin
by avoiding repeated indexed lookup into the std::deque inside SdrObjList Change-Id: Ifcf736d0ecef1239b8a236fe1937f347a3d49e4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-18Replace useless typedef OSharedConnection_BASE2 and replace it by its valueJulien Nabet
Change-Id: I660813058077a36bcf80a3128b53767c851c2672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158105 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-18Clean up the remaining uses of OUStringConstExpr, and drop itStephan Bergmann
Change-Id: I30b2ac77b58e2ae1d1e997a0c830c513542b973d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158101 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-18qt: Drop now obsolete workaround for Qt < 5.12Michael Weghorn
This workaround was only applied for Qt < 5.12 and is no longer needed now that support for Qt < 5.15 has been dropped in commit afb4c96d271958ced3175dfc2cf8bb9e8b0a9d3b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Aug 3 21:30:22 2023 +0200 qt: Drop code for Qt < 5.15 Commit originally adding the workaround: commit fe2baf9e84e0ca9aeaa683e37076f57fa3f38dca Author: Jan-Marek Glogowski <jan-marek.glogowski@extern.cib.de> Date: Tue Dec 3 08:32:58 2019 +0100 Qt5 fix missing XCB_ICCCM_WM_HINT_WINDOW_GROUP This is the application level equivalent of the Qt5 fix for bug QTBUG-46626 / commit 0de4b32 ("xcb: fix issue with dialogs hidden by other windows"), which was broken since Qt 5.4 and is just fixed since Qt 5.12. It is needed for some window managers, which don't know about the WM_CLIENT_LEADER property. Both settings are the same, but just the latter is set by older Qt5 releases. This probably isn't a real problem, as GNOME or XFCE would use the gtk VCL plugin, but since I already wrote the code when debugging tdf#129071, there is also no reason to drop it (except: more code, more bugs...). This fix is optional and needs development headers for xcb-icccm, which can actually be compiled into Qt5. If missing configure will just print a warning, since it's a runtime requirement and we explicitly drop the linked Qt version symbol, so the potential build Qt version won't matter. Change-Id: Ifc5a8f8a40ee13779a911efb53e8b8b868614d0b Reviewed-on: https://gerrit.libreoffice.org/84299 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Change-Id: I56b708449cf686f787f55256c76673be604d31e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158102 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-18Related tdf#144256: fix order of disposing in OSharedConnectionJulien Nabet
In dbaccess/source/core/dataaccess/SharedConnection.hxx, we got: 35 typedef ::cppu::WeakComponentImplHelper< css::sdbc::XConnection 36 > OSharedConnection_BASE; 37 typedef ::connectivity::OConnectionWrapper OSharedConnection_BASE2; 38 39 class OSharedConnection : public ::cppu::BaseMutex 40 , public OSharedConnection_BASE 41 , public OSharedConnection_BASE2 so first OSharedConnection_BASE ctr is called before OConnectionWrapper ctr therefore OConnectionWrapper dtr should be called before OSharedConnection_BASE dtr It doesn't fix the bug but investigating in all this mess, I'd like to fix these things since it may help. Change-Id: I47255357b4ca02261f31ebf500f3f1ff55642e69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158096 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-18Simplify a bitMike Kaganski
Change-Id: I594b3317f8298966d59f8674b71bddd89998b9f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158092 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-18CppunitTest_sw_ooxmlexport8: clean up not needed preTest()Miklos Vajna
This would set (and unset) custom configuration based on filenames, but the suite has no such files anymore, so this can be removed. Change-Id: I8f1dd40b62adcd71a0e4ae303c5d317943ef438b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158094 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-18qt: Drop code for Qt < 5.15Michael Weghorn
Our new AlmaLinux 8 baseline provides Qt 5.15.3, so require 5.15 and drop the code for older, now unsupported Qt versions. Change-Id: I512ade1ba503fc7a86527a45142f37f043db6784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155325 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-18O[U]String move ctors should be constexpr, tooStephan Bergmann
...similar to 5f2206e3ccf1cf64d2b11b0e5d419973269920a8 "O{U]String copy ctor should be constexpr", which will again be useful for some upcoming replacements of OUStringConstExpr with OUString, and making data actually constexpr. (For example, the static o3tl::enumarray<INetProtocol, SchemeInfo> const map in INetURLObject::getSchemeInfo (tools/source/fsys/urlobj.cxx) can actually be constexpr, but the o3tl::enumarray ctor forwards its SchemeInfo arguments by forwarding references, so uses an implicitly generated constexpr SchemeInfo move ctor, which in turn requires constexpr member move ctors. So when the m_sScheme member will be changed from rtl::OUStringConstExpr to OUString, the OUString move ctor better be constexpr.) Change-Id: Icfc5edbb8422919186517667f876ea90bec1be90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158099 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-18tdf#156114 UNO commands / menu entries to enable PS/CS spotlightJim Raykowski
Change-Id: I2796b595ef961c477dea85c337ad343599aea7cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158055 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-10-18tdf#127038 sw notebookbar: remove redundant "more fields"Justin Luth
.uno:InsertFieldCtrl includes all the fields plus "more fields". While it can be nice to include 1-click access to the most common fields, there is no need for 1-click access to the rather large "more fields", so it has been removed from the tabbed notebookbar ribbons. Change-Id: I5ebd394106a8d44832adb6dcd598f92e696f48a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158097 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-10-18tdf#45949, tdf#152492: move UITest to CppUnittestXisco Fauli
Disable the test on mac because it fails with Test name: testTdf45949::TestBody equality assertion failed - Expected: 2 - Actual : 1 Change-Id: I366eba2db939b25f70a859c6622901c1e0f55718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158082 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 7d08444f187ddea8a983565fc2c7fb8b2a38176c - tdf#155876 UI cmds Calc (04) + refactoring + Edit - cell edit mode Change-Id: I43bcbd6f0467f0e923450a3b74b197b7166db15c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158095 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to e3fa34a71832b722a496534970be68e63ff1c0b8 - fix bad index entry Change-Id: I5cb5f87e727101700446e8b94ab854ece8a9c269 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157956 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-17tdf#157442: sw_uiwriter6: Add unittestXisco Fauli
gerrit_mac fails with [_RUN_____] testTdf157442::TestBody Error: a unit test failed, please do one of: make CppunitTest_sw_uiwriter6 CPPUNITTRACE="lldb --" # for interactive debugging on macOS make CppunitTest_sw_uiwriter6 VALGRIND=memcheck # for memory checking You can limit the execution to just one particular test by: make CppunitTest_sw_uiwriter6 CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params... so disable it for now on mac Change-Id: Iaf51987010a976a3a38f264d6b45c8cc6eb7f283 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158079 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-17disable more unreliable navigator UITestNoel Grandin
Change-Id: I5df1edd842f4b1ed0936f6b903c6d2b2ac3aad39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158091 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 020c1cb426fa951da23f51c1d93b59259ec87608 - tdf#155876 UI cmds Calc (03) + refactoring + Edit - Select menu and commands Change-Id: I2c1e7c37cf40184391f04c29b0b6f49f43bef0e5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158087 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-17tdf#157792 FILEOPEN: PPT: logo not displayedNoel Grandin
regression from commit 3622404f09448b82c095256140afe6240b522ece Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Oct 11 12:54:43 2023 +0200 tdf#157636 FILEOPEN: PPT: Images have no background But actually from commit 81994cb2b8b32453a92bcb011830fcb884f22ffe Convert internal vcl bitmap formats transparency->alpha (II) where BitmapEx::CombineMaskOr was not properly updated. To make this stuff more obvious, add a version of CombineOr called AlphaCombineOr that only operates on AlphaMask objects. Change-Id: I8222bcdd7babefb748d21a71d02775c6a74bf068 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-17Related tdf#157726: make iterators local to loopsJulien Nabet
to avoid crash in debug mode, see bt here: https://bugs.documentfoundation.org/attachment.cgi?id=190245) + use != for iterator comparisons Change-Id: I5b1e502097d723e6acc17687171195d81c60dcbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158086 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-17tdf#154454 sw: make comparison of changed paragraph numbering optionalMatthew Kogan
by the new config option "DisplayChangedParagraphNumbering", as a temporary fix to hide incorrect changes in corner cases. Regression from commit 2413f213625253a9c2b1787b3b9fe859d724a9bd "tdf#115523 sw_redlinenum: show correct, also original numbering". Change-Id: I6d85033cc3f60ac1075501fedfcd4c9862e00a9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157940 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-10-17Bump Java build baseline from JDK 9 to 17Michael Weghorn
As discussed in the ESC call on 2023-08-10 [1], bump the Java build baseline to 17. This should not affect the Java runtime requirement, since the target version is explicitly specified already. [1] https://lists.freedesktop.org/archives/libreoffice/2023-August/090759.html Change-Id: I18251151392ca5edec8ca3d5cffd192d5f9f38b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155827 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-17related tdf#141457 sc notebookbar: make statistics a submenuJustin Luth
With so many different statistics commands, the super-popular insert menu was dreadfully long. And since it is a now single entry, might as well add it to all MenuDatas to keep them all pretty much identical. Change-Id: I89247a1806f884e92a52b66015c766180d89149e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158065 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-10-17tdf#130088 tdf#119908 smart justify: fix DOCX line count + compat opt.László Németh
Writer typeset DOCX files with more lines/pages, because of new default paragraph justification algorithm of MSO 2013 and newer, which resulted in losing text layout interoperability for new DOCX documents. Add new compatibility option "JustifyLinesWithShrinking" to store also the new type of justification in OpenDocument files. First analysis of the unknown justification algorithm shows up to 2% shrinking of plain justified line. Apply this value to break the lines in the same (or very similar) positions during importing a DOCX file with compatibilityMode >= 15 (created in MSO 2013 or newer), to avoid typesetting more lines and pages. Note: shrinking will be added by the next commits, fixing the temporary exceeding lines. Change-Id: I9a00db888e9af3f6723e4c502158e8e56a00ef02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158063 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-10-17check earlier on loading ole objects if parent doc is untrusted refererCaolán McNamara
Change-Id: Ib1169d5c40ca87f789c71b48124754e073895fcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-17n#775899 sw: add testcase for the FloattableNomargins compat flagMiklos Vajna
This was added in commit 50a1df360c907d8419ce49f098b6bc87a37a9956 (n#775899 sw: add FloattableNomargins compat flag, 2012-08-23), without a testcase, so it was hard to make later changes without breaking the old behavior. Later commit 0898871b7b9492ada947ebc7b8429c5cb56db23c (n#775899 testcase, 2012-08-27) did add a testcase for the bug, it was a different sub-task there, so the test document had no margins, while this compat flag is about some special handling around non-zero paragraph margins and floating tables. So add a new test that fails without the DocumentSettingId::FLOATTABLE_NOMARGINS block in SwBorderAttrs::CalcLeft() to make sure that this keeps working after I fix tdf#157573, which is a related problem. Change-Id: I09661be726e3db6be51d0cbb44cb5c504510e5ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158069 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-17tdf#157788 Saving the "Show navigation panel" setting for a deviceIrgaliev Amin
Currently, the value of the "Show navigation panel" parameter for presentations is not saved. The section in which this setting is now located, apparently, is saved in files. It might make sense to move this setting to Tools -> Options -> LibreOffice Impress -> General, because it relates to the device rather than the slideshow. Change-Id: I2286a4a6d432b11fce2b9c3e65fa6b82e004275f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158057 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-10-17tdf#157786: sc_datetime_functions: Add unittestXisco Fauli
Change-Id: I94f2d40ced8e59aea5875831289368722a58c42a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158056 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-17svx: prefix members of SdrHdlListMiklos Vajna
See tdf#94879 for motivation. Change-Id: I9e529ef12c05e333e2eeb535d2ae72e5d4c84a72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158062 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-17gtk3 a11y test: Let xvfb-run auto-determine free server numMichael Weghorn
As the xvfb-run manpage says, it uses a default server number of 99: > -n servernumber, --server-num=servernumber > Use servernumber as the server number (but see the -a, --auto-servernum option above). The default is 99. The gtk3 a11y tests use xvfb-run. Running the test multiple times in parallel (e.g. when doing two separate builds with tests, as happens on CI) would fall like this on Debian testing: $ make CppunitTest_vcl_gtk3_a11y make -j 12 -rs -f /home/michi/development/git/libreoffice/Makefile.gbuild CppunitTest_vcl_gtk3_a11y [CUT] vcl_gtk3_a11y xvfb-run: error: Xvfb failed to start Hint: You are currently not seeing messages from other users and the system. Users in groups 'adm', 'systemd-journal' can see all messages. Pass -q to turn off this notice. No coredumps found. Error: a unit test failed, please do one of: make CppunitTest_vcl_gtk3_a11y CPPUNITTRACE="gdb --args" # for interactive debugging on Linux make CppunitTest_vcl_gtk3_a11y VALGRIND=memcheck # for memory checking make CppunitTest_vcl_gtk3_a11y DEBUGCPPUNIT=TRUE # for exception catching You can limit the execution to just one particular test by: make CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params... However, it behaves differently on Alma Linux 8, where it looks like xvfb-run seems then to reuse the existing Xfvb session, causing the tests to potentially find the LibreOffice instance from another test run, and then inspecting the wrong one, leading to failures like the one in [1]: equality assertion failed - Expected: ecclectic.fodt — LibreOfficeDev Writer - Actual : ecclectic.fodt — LibreOfficeDev Writer 24.2 [9bc2aede99017ed0338e97b21b4735919b705b47] The fact that the second instance of xvfb-run reuses the session of the firs one and finds the LibreOffice there can also be reproduced on Alma Linux 8 by just running these 2 commands in parallel: 1) start LO in xfvb-run session: $ xvfb-run dbus-launch libreoffice 2) run below Python script that lists the running applications: $ xvfb-run dbus-launch python3 /home/vagrant/atspi-list-apps.py --------start-------- [application | soffice] --------end-------- /usr/bin/xvfb-run: line 186: kill: (27078) - No such process This *should not* list the applications from the other xfvb-run. It works as expected when passing `--auto-servernum`: $ xvfb-run --auto-servernum dbus-launch python3 /home/vagrant/atspi-list-apps.py --------start-------- --------end-------- Therefore, pass the `--auto-servernum` arg to xvfb-run, so that it automatically determines a free server number instead. > -a, --auto-servernum > Try to get a free server number, starting at 99, or the argument to --server-num. Python script mentioned above used for testing: $ cat atspi-list-apps.py #!/usr/bin/python3 import pyatspi registry = pyatspi.registry.Registry() apps = list(registry.getDesktop(0)) print('--------start--------') for app in apps: print(f'{app}') print('--------end--------') [1] https://ci.libreoffice.org/job/gerrit_linux_gcc_release/151750/consoleFull#-1985341263d893063f-7f3d-4b7e-b56f-4e0f225817cd Change-Id: I0673212fb8fed5c9698c9f797b7bf49ba51033b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158021 Tested-by: Jenkins Reviewed-by: Colomban Wendling <cwendling@hypra.fr> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-17tdf#148725: Reset must clear respective items from m_pOutSetMike Kaganski
After Reset, the tabbed dialog's output set should restore to the same state (concerning the current tab page) as immediately after creation. This state means that pressing OK immediately afer Reset would not try to set or remove any items in the target. SfxTabDialogController::Ok has this code: if (m_pOutSet && m_pOutSet->Count() > 0) bModified = true; meaning that m_pOutSet is expected to be empty in case of completely unmodified dialog; and Reset must make sure this for a given page. Instead, commit 28fc0962b10519ab84654d189d2ad0cca8f84f95 (weld SwLabDlg, 2018-04-27) made Reset handler to populate the output item set with all the items from the input set, that belong to the page's which ranges. This made all the settings set in parents (which therefore appeared in the input set) to be set directly in the target upon application. Change-Id: Iacfffb5670cc3ade950ac412b818acb482845255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158067 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-17Related: tdf#148725 Fix SvxExtParagraphTabPage::ChangesAppliedMike Kaganski
It was setting values, instead of saving them, ever since commit a212ef2b6ebadb22a9abf6d042aa2b5fd9ac1cf0 (tdf#93901: apply handling in style/edit dialog improved, 2015-09-11). The same thing in SvxStdParagraphTabPage::ChangesApplied was fixed in commit 8b0dae14a5af0ad2892bac0e606467af6148c8d1 (weld SvxStdParagraphTabPage, 2018-06-14); but a similar commit eb1d6b16e787a87c3d918135ca98c5694d352557 (weld SvxExtParagraphTabPage, 2018-06-14) kept this in SvxExtParagraphTabPage. Change-Id: I5fb61a9416dab4ccf9fa690eca87a16f7b9378bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158066 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-17tdf#144349 related: Make master document navigator track Text contentJim Raykowski
Done, with a related patch to make the master document navigator track TOX content, to make the Navigator less likely not to have an item selected, which may be enough to resolve tdf#155741 - Allow insertion of items into master without a selected item Change-Id: I1a9d2a12a01ca2c5f3f162e8da932c04ced9a461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157741 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-10-17tdf#144349 related: Make master document navigator track TOX contentJim Raykowski
Done, with a related patch to make the master document navigator track 'Text' content, to make the Navigator less likely not to have an item selected, which may be enough to resolve tdf#155741 - Allow insertion of items into master without a selected item Change-Id: I6df1b668c502cadbe057229e031ede9aa4f4089a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157695 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-10-16Resolves: tdf#157797 Let GetCellValue() propagate previous error, if anyEike Rathke
Change-Id: I27ee8d19e4f45bef81e133c82ac17b825790208f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158064 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-10-16tdf#157482 UI: Turn Security Warnings popup windows into infobarsBalazs Varga
In case of all the 4 security warnings we will have a new infobar warning dialog message with an infobar button which can open the security windows option settings and we can set which security issues should warn us, and also which security infos we want to remove. (etc after saving) TODO: If the directly the file dialog window pop up the Infobar message will only update after closing the file dialog window. That should be fixed later. Change-Id: Idf0f728fd40089d3691f8f044d3718a4e0d99cad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157797 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-10-16Simplify a bitMike Kaganski
Non-negative nCommentPos implies non-empty selection. Change-Id: Id3e5701fbddca3159d81513d8c7d54816e45e4c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158060 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-16Simplify a bitMike Kaganski
Change-Id: Ic621da194d92e3a4202c47ec4828272e8102a146 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158061 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-16Execute notifyViewRenderState on view constructorParis Oplopoios
notifyViewRenderState should be executed as soon as a view is created in order to give a view id to the client Change-Id: I31b7e61599f546bd5ec134775e6235633a6526f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154681 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com> (cherry picked from commit 6c6bb1d434d5c0be2f71470483f3ce56f5210e01) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154709 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-16ofz#63295 Null-dereference READCaolán McNamara
Change-Id: Ib8bfa814099c1c1f3d65b18026ea812c80b6e9c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-16qtcreator: Specify C++ std version using CONFIG qmake varMichael Weghorn
Extract the C++ standard version to use that is specified by a `-std=<version>` or `-std:<version>` compiler flag, and set that via "CONFIG += <version>" in the .pro files used by Qt Creator. This makes the Clang Code Model use the correct mode and no longer complain about `char8_t` after the switch to C++20 in my Windows development setup in Qt Creator: > accessibletabbarpagelist.hxx:22:10: In included file: use of undeclared identifier 'char8_t' > stringutils.hxx:252:31: error occurred here The previous way of specifying this via `QMAKE_CXXFLAGS` as introduced in commit 92c03d9bf644b0f10de52ce0da09f97056e46247 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Jun 7 21:44:03 2019 +0200 qtcreator: Take over '-std=...' from CXXFLAGS appears to not (no longer?) work at least with Qt Creator 11.0.3 on Windows. On the contrary however, setting only `CONFIG` and not `QMAKE_CXXFLAGS` causes the exact same problem in my Linux setup. Therefore, set both qmake variables. Note that there is a specific set of accepted values for the the `CONFIG` variable in .pro files [1], but at least "c++20" and "c++latest" are accepted and have the expected meaning, so that should be fine for now. [1] https://doc.qt.io/qt-6/qmake-variable-reference.html#config Change-Id: Idc75b74300c7bdd0f6193fcfc1758b536728b887 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158053 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-16tdf#141892: Set chart view to dirty state after loadingMike Kaganski
Previously, ChartViewHelper::setViewToDirtyState was only called in ChartModel::impl_notifyModifiedListeners during the load process of inline charts; after commit 574eec9036c5f185b3572ba1e0ca9d111eb361dc, the chart doesn't set its modified state when loading, and thus the view did not get notified about the necessary updates. This change introduces a hidden property in ChartDocumentWrapper, named 'ODFImport_UpdateView', which is set in SchXMLImport dtor to force the notification after the loading. Change-Id: Id9d82f16d233d2172cd6808a8498822e13b21b21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158051 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-16tdf#157776: Do not set chart and its parent modified when paintingMike Kaganski
When the chart is painted for the first time, its update may create the initial set of objects, which used to set modified state after loading documents. Change-Id: Ie50ef34875440058020486192fe649b492e4baf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158015 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-16Fix UITests on WindowsMike Kaganski
... after commit 0d21e1075f0288a007cb427ce508d6fbbf8503dd (uitest: add signal_handler function, 2023-10-04), which added handlers unconditionally, for signals unavailable on Windows. Change-Id: I8b177c4110f869781b2501ee6f15ae7ff4862a94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158050 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-16retain Referer information available in OCommonEmbeddedObject ctorCaolán McNamara
Change-Id: I2cb901e81de3b7db73cd2088348ddad46ae603dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-02 05:13:43 +0000