summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-06-20switch to EHs on windowsMarkus Mohrhard
This seems to be a good idea based on several discussions in the project. In the end catching SEH exceptions is just going to cause strange platform dependent bahavior. This patch is based on on http://thread.gmane.org/gmane.comp.documentfoundation.libreoffice.scm/39102/focus=55516 and includes some additional cleanup of the sal signal code. Change-Id: Iedc998e37e6495afec445eccb60fa1c2b1a7defd Reviewed-on: https://gerrit.libreoffice.org/26497 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-20Remove no longer needed SdrModel::libreOfficeKitCallback()Miklos Vajna
All former clients are changed to call SfxViewShell::libreOfficeKitViewCallback() instead. Change-Id: Ic5dcf0a8a4241338fcd6941f13ce438157676481 Reviewed-on: https://gerrit.libreoffice.org/26521 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20sw lok: add LOK_CALLBACK_INVALIDATE_VIEW_CURSORMiklos Vajna
So a view can be aware where cursors of other views are. Change-Id: I6133fb55aa2869843c0284b7d76264bab3b3d5da Reviewed-on: https://gerrit.libreoffice.org/26513 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20add some OpenGL info to the crash reporterMarkus Mohrhard
Change-Id: Id377bc3bd814fad822d577603b1f147b71ad9ae2 Reviewed-on: https://gerrit.libreoffice.org/26445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20Updated coreAdolfo Jayme Barrientos
Project: help 1abe8b8b3462e7f62e1d5563402672c0b2ae4851 “Page Break Preview” → “Page Break” in Calc Change-Id: Ic0d6cbe429305760a21ebc9fdbee67f0d752fe23
2016-06-20Check that EASTERSUNDAY with negative value causes errorStephan Bergmann
...even though that's not obvious from the implementation of ScInterpreter::ScEasterSunday (sc/source/core/tool/interpr2.cxx), which calls SvNumberFormatter::ExpandTwoDigitYear on that value, which also only checks that the value is < 100, but not whether it is non-negative. However, ExpandTwoDigitYear takes its argument as sal_uInt16, so any negative value is guaranteed to be converted into a large sal_uInt16 value that is not < 100. Change-Id: I6f10672e510918f6e9010061541829fcd98e6dd0
2016-06-20GSoC Table Styles, Export Cell StylesJakub Trzebiatowski
Exporting cell-styles Exporting table-template To be able to map SwTableAutoFormat to table-template 1:1 extended table-template by the following elements: loext:first-row-even-column loext:last-row-even-column loext:first-row-end-column loext:first-row-start-column loext:last-row-end-column loext:last-row-start-column Added attributes describing box format to SwXTextCellStyle Change-Id: I2967ba461dfc6f030c1e5cdbba62e2673d3b232b Reviewed-on: https://gerrit.libreoffice.org/26185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-20cppcheck: oppositeInnerCondition if new fails, its going to throwCaolán McNamara
not return nullptr Change-Id: I8f46e49b28fd9547fb3e32dca0c6b99ee2cd5c7d
2016-06-20cppcheck: catchExceptionByValueCaolán McNamara
Change-Id: I1e6001d2c806a5808b2c2a8057d0ea403ab0f894
2016-06-20cppcheck: redundantConditionCaolán McNamara
Change-Id: I02566ed92197a2573cd4a1a6c7e9fe54aeab3301
2016-06-20sw: prefix members of SwWriteTableMiklos Vajna
Change-Id: I4e8885b9fd85fdecec4f936c3c306887f1964c4b Reviewed-on: https://gerrit.libreoffice.org/26498 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-20Mark these functions as finalXisco Fauli
Comment from Michael Stahl in Gerrit: "to prevent potential disasters if somebody adds a sub-class and overrides ImplCommit, which is then not called here." Change-Id: I2d991c713734fd516827a5dd6c8929aa64e59409 Reviewed-on: https://gerrit.libreoffice.org/26278 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-06-20-Werror,-WswitchStephan Bergmann
Change-Id: I319f932f24a5b4c2eb331eac6795731a1bc483ca
2016-06-20tdf#79889 Make Recent Docs thumbnail titles consistent with recent files menuAkshay Deep
Change-Id: I839039e68c766480458a5956cf1261819c0ea005 Reviewed-on: https://gerrit.libreoffice.org/26465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-06-20Clean up uses of Any::getValue() in comphelperStephan Bergmann
Change-Id: I433cca20fb29c6b6ede934edcb2e200f15b060f2
2016-06-20tdf#100441: Fix listbox state in master vs. normal modeKatarina Behrens
Events appear in following order: normal -> master: 1. EID_EDIT_MODE_MASTER, 2. EID_EDIT_VIEW_SELECTION master -> normal: 1. EID_EDIT_MODE_NORMAL, 2. EID_END_TEXT_EDIT This is only partial fix, selecting the right master page in other than normal mode is still broken Change-Id: I2dd91e77c4ed5627079fc9d2b39e40c8e74a9f8e Reviewed-on: https://gerrit.libreoffice.org/26484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-20Convert PART to scoped enumNoel Grandin
Change-Id: If4c2849beb207593d3d450ae3846ed24eaf66ca4 Reviewed-on: https://gerrit.libreoffice.org/26173 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-20tdf#95797: Don't jump to the cursor position after auto-save.Jan Holesovsky
Apparently the commit 07c7c88bc2d9d860ea92ab562ea0431ec1949b29 changed the condition; I suppose that not deliberately. Big thanks to raal for the bisect! Change-Id: I775e133396ceb763e31aca101d365880652e1ac8
2016-06-20ScFilterListBox::LoseFocus doesn't seem to have a purpose...Caolán McNamara
after the strange code was removed by... commit c3a5012c5a9699040698505d3e34672382c026b8 Author: Caolán McNamara <caolanm@redhat.com> Date: Sun Jun 19 17:42:56 2016 +0100 Related: tdf#99310 data validity cell range dropdown empty under windows Change-Id: Icf6acdb2e5fff90aff45704f17f7918c877e166e
2016-06-20Avoid undefined behavior when converting from double to sal_Int16Stephan Bergmann
Change-Id: Iced9d25a15f25076b1c23b064eabfe5f0899882c
2016-06-20improper use of this/that just bugs meNoel Grandin
Change-Id: Ie05062cfe384971f5c358769ab16461a76f911cf
2016-06-20tdf#90834 Turn in-line version controlapurvapriyadarshi
Some unnecessary comments removed Change-Id: I01b90f760106819e2c5d065e0bb32d5f132ae33c Reviewed-on: https://gerrit.libreoffice.org/26462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-20add TIMEVALUE test caseZdeněk Crhonek
Change-Id: Ibbb5bd78b5d2878d0a73a3ff85879ad2b6f7225d Reviewed-on: https://gerrit.libreoffice.org/26385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20add TYPE test caseZdeněk Crhonek
Change-Id: I1fec7355de2ab67251ae39dd5ba1d06f30779910 Reviewed-on: https://gerrit.libreoffice.org/26476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20add WORKDAY test caseZdeněk Crhonek
Change-Id: I919ce6aec83acd458b8a067f61375215672765d2 Reviewed-on: https://gerrit.libreoffice.org/26388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20uitest: add demo for spinfieldMarkus Mohrhard
Change-Id: I45751598df2c14c1e8e3a7f17705fe52321b0c89 Reviewed-on: https://gerrit.libreoffice.org/26493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20support typing into the spin fieldMarkus Mohrhard
Change-Id: I2cae24d36d1eebf48f52646d84e7f6d291c8e473 Reviewed-on: https://gerrit.libreoffice.org/26492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20uitest: set id for chart windowMarkus Mohrhard
Change-Id: I443dcccf6d560c252da38a0f0c63cc48a212c127 Reviewed-on: https://gerrit.libreoffice.org/26494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20Updated coreAdolfo Jayme Barrientos
Project: help 2db75854e290a7ce93e869214b3d6fba86d93ae7 tdf#100478 Correct the syntax of two examples of the N formula Change-Id: If97787808183045e3a9573cf1a26ed3e923f3bdb
2016-06-20add N() test caseZdeněk Crhonek
Change-Id: Ia7c3f57b17c63c64296307f618c14aa875f03796 Reviewed-on: https://gerrit.libreoffice.org/26474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20add ISODD and ISODD_ADD test caseZdeněk Crhonek
Change-Id: I0395c511d9e0c96942d8857b7dd2db2edbbd6a1d Reviewed-on: https://gerrit.libreoffice.org/26471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20starmath: Possible cases are exhaustedTakeshi Abe
Change-Id: Icc48aa8ffa6a56f804c4d01f2fb3bcdf7de838d4 Reviewed-on: https://gerrit.libreoffice.org/26397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-20add ISBLANK test caseZdeněk Crhonek
Change-Id: I41d5e39d30fdf92fe2df86fc7f02b98f7ec7ef74 Reviewed-on: https://gerrit.libreoffice.org/26446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20add ISTEXT test caseZdeněk Crhonek
Change-Id: I82e02f08767b5b23089051019f94b873ce52e062 Reviewed-on: https://gerrit.libreoffice.org/26473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20add ISREF test caseZdeněk Crhonek
Change-Id: I615e248b0f1e4325bf4b52c42ee889995da44a0a Reviewed-on: https://gerrit.libreoffice.org/26472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-20add ISERR test caseZdeněk Crhonek
Change-Id: Iba099d662f93052c074bb5071be5e46083b1c6ab Reviewed-on: https://gerrit.libreoffice.org/26450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-19add ISNUMBER test caseZdeněk Crhonek
Change-Id: Ib61e97bef590a33277f5d37d7ad80e87f9093491 Reviewed-on: https://gerrit.libreoffice.org/26469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-19tdf#39468 translated german comments in sc/filters/lotusAlbert Thuswaldner
Change-Id: Icf87fadd9a9ffb344d4f1134a54b300fdb86a7b7 Reviewed-on: https://gerrit.libreoffice.org/26481 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-19tdf#91820 A round of minor tweaks to Calc's menusYousuf Philips
Change-Id: I4724e5fd927371ce5df58451dbd0a0ae7eeca0e9 Reviewed-on: https://gerrit.libreoffice.org/24086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-06-20Try to fix the crashreport with SaveToolbarController::modifiedMaxim Monastirsky
No idea how one managed to trigger this. The only way I see is to add the save button to one of the custom shapes dropdowns. The ToolBox there has mpData->mbWillUsePopupMode set to true, which causes ToolBarManager to call the update method of the controller twice. update registers additional modify listener each time, but there is only one "remove listener" call in dispose. Change-Id: I2a1d6e02f6d8b6bc847fb7694fffa6e85b1f5604
2016-06-19loplugin:defaultparamsStephan Bergmann
Change-Id: I7a74f10d3dbae16641c6c3aa3b8e53dde12df047
2016-06-19loplugin:redundantcastStephan Bergmann
Change-Id: I0fc720f677440ed659c445151c5fd4e53f63444c
2016-06-19loplugin:salbool: Implicit conversions from non-Boolean fundamental typesStephan Bergmann
Change-Id: I67eac95686678e6f5a2d60798535b2c65a9ba5d7
2016-06-19Related: tdf#99310 data validity cell range dropdown empty under windowsCaolán McNamara
if I make this block unconditional then it also disappears under Linux so I speculate that this is why its missing under Windows. I can't see why this is the way it is (since initial import in 2000), This is reportedly a problem since commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves; tdf#87120 no keyboard navigation inside floating windows Change-Id: I6159d419bccef851c8f9e965d063882173d91620
2016-06-19LOK: tile rendering regression fixAshod Nakashian
Calc fast rendering requires us to offset the are being rendered and shift all bitmaps accordingly. This however is breaking Impress rendering since the offseting logic is common (in svx and vcl). This adds new API to enable or disable this local rendering (as opposed to rendering a full document as was previously done. The new flag is then set by Calc to enable the offseting logic in isolation without affecting other applications. In one case isolation was achieved by checking the MapModeUnit. Change-Id: Ia0aadfc3f6df7c1a891b97dc731f5897414c9420 Reviewed-on: https://gerrit.libreoffice.org/26367 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 60fdcda65bad242f99895cb453182578250fbdea) Reviewed-on: https://gerrit.libreoffice.org/26378 Tested-by: Jenkins <ci@libreoffice.org>
2016-06-19Resolve: tdf#100429 gtk3: set custom icons in native gtk menusCaolán McNamara
Change-Id: I4798274f38c34c99d6f22f3c7959ebd9673a8966
2016-06-19coverity#1362777 Explicit null dereferencedCaolán McNamara
Change-Id: I5db9cf469677b8509c19d6489472a4cf0babeca5
2016-06-19bogus warningCaolán McNamara
since... commit 9c79945ca62b18213728cdd23d9f390304aee1de Date: Sun Jun 12 20:11:20 2016 +0200 convert DBG_ASSERT in vcl Change-Id: I67b2f0d21965a70980c4f0c522a0431107216a27
2016-06-19sc lok: Unit test for empty column selectionPranav Kant
Make sure newline characters are not copied, fixed in 82ed95b7554cfa3b5e98f67cc53c6219e3a09886 Change-Id: Ic8d45ba44c1092d733bed4afc049463e546d10d9
2016-06-19sc lok: Remove useless comment/codePranav Kant
Change-Id: I69a0c2b6810b38de5de94eb9789839a4d6de8d87