summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-09-08ofz#27296 limit row span when fuzzingCaolán McNamara
Change-Id: I3069875f64acaf394cfef7f6478abc974022d536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-08tdf#141908: replace usage of sal_Int32 with colorsBaran Aytas
Change-Id: I536e2c8d15db7c4973525ffc1e0abfb211228751 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121703 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2021-09-08no need to do this dynamic_cast in a release buildNoel Grandin
just make it an assert Change-Id: I6cd84c9988a3d5111d24b44aae46dc6d69ca06ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08tdf#143359 sw: track deletion of empty table rowsLászló Németh
Empty table rows were deleted immediately during change tracking, or in the case of a deleted table also with non-empty rows, accepting table deletion kept empty rows. Note: as a workaround for tracking of the empty rows, i.e. rows without text content, add a redline with invisible text ZWJ in the first cell of the empty row. See also commit a483a44ca00f43a64ae51d62b8fbb4129a413f6d "tdf#143215 DOCX import: fix tracked empty row insertion/deletion", commit b50d386dfa70f7c1d4eb1a49091ec9dd782b767b "tdf#142701 track changes: fix layout regression of image deletion" and commit 05366b8e6683363688de8708a3d88cf144c7a2bf "tdf#60382 sw offapi: add change tracking of table/row deletion". Note: switch off unnecessary redlining of tdf#132744 unit test to keep the sake of that test (i.e. cut of the selected table with empty rows). Change-Id: Ief59008e8714fb88afdfce867598e3dda21bfba5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121784 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-09-08indexing: fix correct size and pos. for shapes + more testsTomaž Vajngerl
Determining the position and size of the shapes (SdrObjects) was wrong as the assumption was the values are in Hmm but were in twips. Added some more tests that check rendering of SdrObjects. Change-Id: I6ef9287892d1774a1243118a5c97f58384bcfd68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121801 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-08tdf#114878: sc: Add UItestXisco Fauli
Change-Id: I4edac5f45f18e1aa85d1936a2577420ee274f43e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121804 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-08ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9117bc6b499c8f86663980c26b7247e58c9737d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-08simplify static_cast after dynamic_castNoel Grandin
Change-Id: I53ae7f18519fdd878730d1d0316ebc408271c66d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08cui: fix spell check dialog pointlessly modifying text shapeMichael Stahl
In Impress, closing the spell check dialog without doing any changes will replace the entire text of a shape, creating an sd::UndoObjectSetText and messing up the formatting. Apparently in commit bbb1428e3666acc7503d86704bbf1e1a4ac04795 a check of the modified flag was removed, but it's not obvious why, so add it back, which appears to fix the problem. Change-Id: I8ce6c75f097baa82f11f7b1c813262845001ae7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121807 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-08Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 4460c7babd574c5040a528d10fe51001c27680bc - update translations for 7.2.1 rc2 and force-fix errors using pocheck Change-Id: I4b8c8e545d7aba21bf9e925bfb9018be6e4c04f8
2021-09-08indexing: rename "parent" attibute and parse the attribute backTomaž Vajngerl
Rename the attribute "parent" to "object_name" and "parent_index" and parse the "object_name" attribute for JSON and XML when used as input to SearchResultLocator. Change-Id: I46ad8d6aa14f15d1b759126af71284f7d73a7a96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121797 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-08Revert "Tentative fix for crash in the iOS app"Tor Lillqvist
The root cause for the problem was fixed elsewhere by 0f65b4b6f33891a724bee5356aa5549c76fa0ce3 (and back-ports). This reverts commit 9e4c72ec7ea83aa0d023a90a6b02ddb17c6b2d74 Change-Id: I0167846d2aaeacc66657b4203d0118b7847679ba
2021-09-08svx: try to avoid crash in AccessibleEditableTextParaMichael Stahl
There is an out-of-bounds access to a non-existant editengine paragraph: warn:legacy.tools:40400:40400:editeng/source/editeng/editdoc.cxx:1136: Index out of range in Adjust(2) warn:legacy.tools:40400:40400:editeng/source/editeng/editeng.cxx:1984: Paragraph not found: GetWindowPosTopLeft /usr/include/c++/11/debug/vector:438: Error: attempt to subscript container with out-of-bounds index 1, but container only holds 1 elements. 4 ParaPortionList::operator[](int) (this=0x6270d38, nPos=1) at editeng/source/editeng/editdoc.cxx:722 5 ImpEditEngine::CalcParaWidth(int, bool) (this=0x6270ca0, nPara=1, bIgnoreExtraSpace=true) at editeng/source/editeng/impedit2.cxx:3307 6 EditEngine::GetParaBounds(int) (this=0x6264a00, nPara=1) at editeng/source/editeng/editeng.cxx:646 7 Outliner::GetParaBounds(int) const (this=0x30fb510, nParagraph=1) at editeng/source/outliner/outlin2.cxx:414 8 SvxOutlinerForwarder::GetParaBounds(int) const (this=0x3424710, nPara=1) at editeng/source/uno/unoforou.cxx:326 9 SvxAccessibleTextAdapter::GetParaBounds(int) const (this=0x73d7d30, nPara=1) at editeng/source/uno/unoedprx.cxx:757 10 accessibility::AccessibleEditableTextPara::getBounds() (this=0x27c45c0) at editeng/source/accessibility/AccessibleEditableTextPara.cxx:1050 11 accessibility::AccessibleTextHelper_Impl::UpdateBoundRect() (this=0x73d7c90) at svx/source/accessibility/AccessibleTextHelper.cxx:799 12 accessibility::AccessibleTextHelper::UpdateChildren() (this=0x2ae5eb0) at svx/source/accessibility/AccessibleTextHelper.cxx:1658 13 accessibility::AccessibleShape::notifyShapeEvent(com::sun::star::document::EventObject const&) (this=0x73d7690, rEventObject=...) at svx/source/accessibility/AccessibleShape.cxx:926 14 SfxBaseModel::notifyEvent(com::sun::star::document::EventObject const&) const (this=0x2eb1b80, aEvent=...) at sfx2/source/doc/sfxbasemodel.cxx:3341 15 SdXImpressDocument::Notify(SfxBroadcaster&, SfxHint const&) (this=0x2eb1b80, rBC=..., rHint=...) at sd/source/ui/unoidl/unomodel.cxx:408 16 SfxBroadcaster::Broadcast(SfxHint const&) (this=0x2e6f120, rHint=...) at svl/source/notify/SfxBroadcaster.cxx:39 17 SdrObject::BroadcastObjectChange() const (this=0x30fb190) at svx/source/svdraw/svdobj.cxx:1028 18 SdrUndoObjSetText::Undo() (this=0x732acb0) at svx/source/svdraw/svdundo.cxx:1050 19 sd::UndoObjectSetText::Undo() (this=0x732acb0) at sd/source/core/undo/undoobjects.cxx:204 This was replaced when GetTextForwarder() apparently replaced the editengine object or something along those lines: 5 ParaPortionList::Insert(int, ParaPortion&&) (this=0x6270d38, nPos=0, p=...) at editeng/source/editeng/editdoc.cxx:740 6 ImpEditEngine::InitDoc(bool) (this=0x6270ca0, bKeepParaAttribs=true) at editeng/source/editeng/impedit2.cxx:241 7 ImpEditEngine::RemoveText() (this=0x6270ca0) at editeng/source/editeng/impedit2.cxx:678 8 ImpEditEngine::SetText(rtl::OUString const&) (this=0x6270ca0, rText="") at editeng/source/editeng/impedit2.cxx:694 9 ImpEditEngine::SetText(EditTextObject const&) (this=0x6270ca0, rTextObject=...) at editeng/source/editeng/impedit4.cxx:1139 10 EditEngine::SetText(EditTextObject const&) (this=0x6264a00, rTextObject=...) at editeng/source/editeng/editeng.cxx:1535 11 Outliner::SetText(OutlinerParaObject const&) (this=0x30fb510, rPObj=...) at editeng/source/outliner/outliner.cxx:568 12 SvxTextEditSourceImpl::GetBackgroundTextForwarder() (this=0x73d7990) at svx/source/unodraw/unoshtxt.cxx:553 13 SvxTextEditSourceImpl::GetTextForwarder() (this=0x73d7990) at svx/source/unodraw/unoshtxt.cxx:658 14 SvxTextEditSource::GetTextForwarder() (this=0x73c9580) at svx/source/unodraw/unoshtxt.cxx:936 15 SvxEditSourceAdapter::GetTextForwarderAdapter() (this=0x73d7d20) at editeng/source/uno/unoedprx.cxx:324 16 SvxEditSourceAdapter::GetTextForwarder() (this=0x73d7d20) at editeng/source/uno/unoedprx.cxx:339 17 accessibility::AccessibleTextHelper_Impl::GetTextForwarder() const (this=0x73d7c90) at svx/source/accessibility/AccessibleTextHelper.cxx:265 18 accessibility::AccessibleTextHelper_Impl::UpdateVisibleChildren(bool) (this=0x73d7c90, bBroadcastEvents=true) at svx/source/accessibility/AccessibleTextHelper.cxx:750 19 accessibility::AccessibleTextHelper::UpdateChildren() (this=0x2ae5eb0) at svx/source/accessibility/AccessibleTextHelper.cxx:1657 20 accessibility::AccessibleShape::notifyShapeEvent(com::sun::star::document::EventObject const&) (this=0x73d7690, rEventObject=...) at svx/source/accessibility/AccessibleShape.cxx:926 21 SfxBaseModel::notifyEvent(com::sun::star::document::EventObject const&) const (this=0x2eb1b80, aEvent=...) at sfx2/source/doc/sfxbasemodel.cxx:3341 22 SdXImpressDocument::Notify(SfxBroadcaster&, SfxHint const&) (this=0x2eb1b80, rBC=..., rHint=...) at sd/source/ui/unoidl/unomodel.cxx:408 23 SfxBroadcaster::Broadcast(SfxHint const&) (this=0x2e6f120, rHint=...) at svl/source/notify/SfxBroadcaster.cxx:39 24 SdrObject::BroadcastObjectChange() const (this=0x30fb190) at svx/source/svdraw/svdobj.cxx:1028 25 SdrUndoObjSetText::Undo() (this=0x732acb0) at svx/source/svdraw/svdundo.cxx:1050 So try to update the number of paragraphs when GetTextForwarder() was called. Change-Id: I5c0712cdf0c01d2aa0e8cd929ba51aaf1c710123 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121789 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-08reduce cost of creating large charts (tdf#144052)Noel Grandin
creating a temporary SfxItemSet for each geometry object adds up fast, so only create the temporary for those SdrTextObj subclasses that need it. Change-Id: I0c03a630057718f09c12a4a2d07ad23fca46fd2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121800 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08avoid painting to windows in LOK modeLuboš Luňák
There are no actual toplevel windows in that case, and tiled rendering is used to paint whenever any painting is needed. The painting is already made useless by using (1,1)-sized Cairo surfaces for windows (SvpSalFrame::SetPosSize() calling SvpSalFrame::GetSurfaceFrameSize()), this should avoid it altogether. It is possible this commit causes regressions if some code relies on Paint() getting called at specific times (such as 2f961c7a811bdff66 doing relayout there, causing geometry changes), but those should be fixed. Change-Id: Ie4be16301fdddb7c1b0350e6458178efca88aa4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119385 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-08patch SdrPageWindow in SdXImpressDocument::paintTile()Luboš Luňák
This is based on commit 424312aa99307da9f0ee60ea6e3213b2b3dc26b4 amd I don't quite understand everything that happens, because the drawing layer classes have all kinds of comments except those that would explain the purpose or usage of the classes. My understanding is that drawing layer keeps all kinds of state in Sdr* classes and when drawing it tries to find those based on the OutputDevice. But since tiled drawing uses its own VirtualDevice for the drawing, the search fails and a temporary state is used that's always setup up and cleared again. Which is wasteful, and not having the state around also means that e.g. when clicking a checkbox for impress master background, with idle painting disabled there's nothing to react to the event and cause a tile repaint. Change-Id: Ic9036680c628d67615a82dcc4f585ab827b91525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121780 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-08avoid repeated writer layout calls with tiled renderingLuboš Luňák
My next commit will disable idle paints for tile rendering, as they do nothing in that case (or at least that should be the case). But this code causes an infinite loop with idle layout timer, because painting resets the SwViewShellImp paint region, which is not performed if painting is done only later by idle rendering. Change-Id: Ic401f16254aade02ddb3e4faffd99f0ce29d4df4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120201 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-08explicitly send LOK_CALLBACK_TEXT_SELECTION at the end of FindAllLuboš Luňák
It normally gets emitted by SwSelPaintRects::Show(), called from paiting, but Online uses tiled painting and so doesn't need normal painting. Change-Id: If276ce176f4e65b4efe3d053941b83917df2ae1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119382 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-08no need to allocate this separatelyNoel Grandin
Change-Id: Ib92bd39d1c5057731d670a79bf788909856247be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-08vcl: move OutputDevice output flag functions to outdev.cxxChris Sherlock
Add unit test for EnableOutput(), IsOutputEnabled() and is IsDeviceOutputNecessary(). Change-Id: Ic07bcdc650575c1a2788adc3c967cb02e2f68302 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121019 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-08vcl: migrate GetDownsampledBitmap() from OutputDevice to vcl::bitmapChris Sherlock
Change-Id: Iee6caa8292472a3acca66d670a113b701f4b637e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121581 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-08vcl: make GetDownsampledBitmap() take destination size in units of twipsChris Sherlock
This removes the need to use OutputDevice functions, which means we can later move this function to bitmaptools.cxx Change-Id: If547563808c2656d395d4669507f5f8dcfadcabe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121580 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-08vcl: remove CustomWidgetDraw as it is not needed anymoreTomaž Vajngerl
CustomWidgetDraw was the first implemetation for custom drawing of widgets, which was now replaced by FileDefinitionsWidgetDraw so CustomWidgetDraw is not needed anymore. Change-Id: I1c7a9fcf720bbfd91d9c44ad4b15a7281a0d0e14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121740 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-08Fix typosAndrea Gelmini
Change-Id: Ic3793bd77a7db52e59797cc6b2153850b1cec42e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121737 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-08Fix typosAndrea Gelmini
Change-Id: I42d38399726acb1d044b4b9f032de96ded00e5bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121542 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-08CppunitTest_sw_ooxmlexport9: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Ic11b52a2a54aa4865d3a9663e5aaf3ee9ac85cc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121790 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-09-08remove unnecessary meta.xml from autotextJustin Luth
I kept this separate to simplify spotting errors. There were about 130 unique md5sum hashes, and all were roughly the same size. I spot checked a few with "meld" and didn't see anything that seemed valuable. find . -name meta.xml -exec rm {} \; git grep -l \/meta.xml *.xml | xargs sed -i /\/meta.xml/d git grep -l \/meta.xml ../CustomTarget_autotextshare.mk \ | xargs sed -i "/\/meta.xml/d" Change-Id: Id11ec9973a8764ffbc809f9161868d6cacb80a85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121606 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Laurent Balland-Poirier <laurent.balland-poirier@laposte.net>
2021-09-08indexing: rename "type" for prargraph an object nodesTomaž Vajngerl
They are conflicting, so rename the one for paragraphs to "node_type and the one for objects to "object_type". This needs adusting all the tests. Also change the node_type from numerical value (correcponding to a enum) to string based - "writer" or "commom" values. Change-Id: I0465cd4c2c6989e436d5a675db20c87066d19208 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121743 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-08indexing: support JSON and XML as input for SearchResultLocatorTomaž Vajngerl
JSON is much easier to deal with when using REST and javascript, so support both. Change-Id: I61035452d9a7ba889ac355a42201d79b9fafec6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121742 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-08Drop unused rUsedDetectors argumentMike Kaganski
... ever since commit e4003b67062e575f9b77772488f9b9691fa9fc38 Author: Kohei Yoshida Date: Thu Mar 7 01:35:09 2013 -0500 Make check passes. Remove deep-only detection for real. Now the type detection process is a lot more simpler. Change-Id: Ib0c08e28edf85a3642e187798a08ed2e143bf56c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121765 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-07Guard Orcus detection shortcutMike Kaganski
So that its policy matches the other places in this function Change-Id: I309441f63cf82bbae2b19c7de588d4228b988bad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121764 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-07Fixed typos in the description of the default case for optionalsAndreas Heinisch
Change-Id: Ib80faf454fe4ef22b3ebb0b633769d4479cd84a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121793 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-09-07Fixed a copy paste error in the test casesAndreas Heinisch
Change-Id: Ib11b6cfe385542664b28de35897caee67099d22c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121792 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-09-07tdf#144245 - Added test file to automatic testAndreas Heinisch
Change-Id: I92b71b7e7ac8c2262d36875e4b04ed91e17bc495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121791 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-09-07unbalanced [Beg/End]Undo possible on self-dnd in impressCaolán McNamara
repeatedly holding the mouse button on an object long enough to start a drag and then trying again will eventually result in a situation where View::StartDrag is called, triggering a gtk_drag_begin which neither fails with drag-failure or succeeds with drag-end and so no View::DragFinished gets called. This is possibly only an issue under (Fedora 34) wayland. When it happens it leaves an unbalanced BegUndo from StartDrag with no EndUndo which will eventually be fatal if the user uses undo. So remove the BegUndo from StartDrag because we can't be sure to get a DragFinished and... a) put the removal of original objects (when ACTION_MOVE) in DragFinished in a simple BegUndo/EndUndo block of its own. Whether the dnd is to another application or to ourself won't matter. b) in View::InsertData detect if the action is a self-dnd and if so put that in another BegUndo/EndUndo block and explicitly call DragFinished before EndUndo to put a) within that group so a drag of an object from one slide to the other gives a single "Drag and Drop" move undo action listed for the copy and delete. DragFinished will get called again but that's ok in this case and its 2nd call won't affect the undo stack. c) when this problem arises, later Drag attempts fail to do anything because View::StartDrag returns early if a mpDragSrcMarkList from an earlier attempt is set. Remove that guard and allow mpDragSrcMarkList to be replaced after a silently failed drag attempt. Change-Id: I3933663ff74f1ca99d9410b7752227ecf8d0da46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121787 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-07ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I07ab38df2855a55cea1993ad29c7e2b58c6a3142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121781 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-07tdf#142129 vcl: add unit testMichael Stahl
Reportedly bug was fixed by commit 5fc6a601d7a1978db291fd0f7dcec638a7c25651 Change-Id: Iee32cacff0c939bdf498e9dc8102eb2d22a5a1c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121776 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-07vcl: rename PrinterOptions to vcl::printer::OptionsChris Sherlock
Move Options to own source and header files. Options moved to own source and header files, however also put Options into vcl::printer namespace. I have renamed and moved PrinterOptions into the vcl::printer namespace because the word "Printer" is redundant, and we want to organize the vcl namespace better. Change-Id: I2ef188af381dd65907d48f7b190e4ab69417606d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121389 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-09-07dynamic_cast followed by static_castCaolán McNamara
Change-Id: If917550a1425d3ec82fcf7ad06dd9f9438fb2e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-07Fix typoMike Kaganski
Change-Id: Ie7481a122436ae765e36642f27afa45b8a11bba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121761 Reviewed-by: René Engelhard <rene@debian.org> Tested-by: René Engelhard <rene@debian.org>
2021-09-07Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 77c10ceaaabe76f57014e53dbdd4560d988bb8a1 - Fix typo in path to Tip-of-the-day xhp Change-Id: Id7a058cd490fcf52151e7ae8897016039d16f3d1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121786 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-09-07wina11y: Drop CAccTable::GetXInterfaceMichael Weghorn
Consistently use the 'pRXTable' member directly instead of mixing both ways to access it in almost every CAccTable method. While at it, also unify code a bit which is used to check 'pRXTable' inside of most CAccTable methods. Change-Id: Iafbff80b8304edd994507f86abd57b6dae7fe353 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121778 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-07wina11y: Move "stdafx.h" include to headersMichael Weghorn
Move the "stdafx.h" include to the MAccessible.h and UNOXWrapper.h headers from the corresponding source files, since the 'ATL_NO_VTABLE' define from stdafx.h is already used in the headers. (This e.g. also makes sure that the define is known when opening one of those headers in an IDE.) Change-Id: I3b6b7df037846daaad4d702e0e0c0bd2970dc663 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121773 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-07Revert: #i47175# update eventual pointer grab with cursorCaolán McNamara
revert commit: commit d4f61372b23d6bb7f4df1e563f0823b3a3211c1d Date: Mon Mar 5 14:25:35 2007 +0000 INTEGRATION: CWS vcl74 (1.59.42); FILE MERGED 2007/01/31 15:25:15 pl 1.59.42.1: #i47175# update eventual pointer grab with cursor this got later modified by... commit e9cb118e6e98eb13b3ad1901c8c912bed674f096 Date: Tue Jan 29 15:21:11 2008 +0000 INTEGRATION: CWS vcl85_SRC680 (1.71.70); FILE MERGED ... 2007/12/13 15:30:31 pl 1.71.70.1: #i80791# use correct owner events parameter in SetPointer but now in impress, under wayland, if I click and hold on the border of a textbox and then try to use SetPointer while the mouse is captured then the cursor doesn't change, the regrab drops the cursor. The original problem reported back in #i47175# no longer arises in gtk as the dialog is a native gtk one. Drop this workaround as its weird to potentially do a special grab when we just want to change the mouse cursor. Change-Id: Ifb7f55a17692a5e79cd4221d1e0f440dacbee0bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121775 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-07loplugin:unusedmethodsNoel Grandin
Change-Id: I6295d6ff6fb7410852351801c324244308c5c472 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121751 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-07explain a 'not sure why' comment about cairo (1,1) sizesLuboš Luňák
This is from 9090dc1f3b27195f5defd35586ac79357992be21. Change-Id: Iae98628b58022c8bb3c50eef6889923023b67319 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121777 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 280680693746332e5bf1d49f53285b29b0ae321d - tdf#141179 Add tip-of-the-day help page Change-Id: I0fe0a3d6615b98d943d6a4cb9f47bc255cf4eef8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121689 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d883745bda47f21301f6cbf29bbd47512ef9d000 - tdf#144339 Add Help page for ProtectFields and ProtectBookmarks Change-Id: Ib784738af17d89b356bc6954c9402b2423cfd478 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121739 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 2753562419d2407c22db5af9c216f2ac00eb5000 - tdf#137084 Update Writer Table and Tools menu Help Change-Id: I546f247253bd7c8f041342ae2cf7447be34caf38 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121733 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to e02e75de71eed2d22a4ad4bb18bbfb1f60aa5480 - tdf#144332 Add Help page for Accessibility Check Tool Change-Id: Ifdca4c17a5f2f97d27cd59e65b1855abb2d243f6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121731 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-01-15 07:19:23 +0000