summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-03-03drop TransparentType::Color usageNoel Grandin
which is dead code, since we convert to TransparentType::Bitmask in the constructor of BitmapEx Change-Id: I047b7d25317c4be4d17a8b0db9a90ec101875c9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111683 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-03loplugin:refcounting in scNoel
Change-Id: I0b808785e54bf1dfc9387a649aacf731b2f34d12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111801 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-03tdf#140606 make PDF parsing more lenient and prevent a crashTomaž Vajngerl
If the external document can't be opened, it tried to continue with the export anyway, which eventually lead to a crash. This is fixed by handling this situation and prevent a crash, however the part of the document in this case isn't exported. The document couldn't be opened because of a parsing error - there was a unexpected null character instead of a whitespace, which made the parser panic. Fix this by making the parser more lenient in such a situation when there is an unexpected null and try to continue parsing. Bug document seems to be created with a buggy PDF writer, but other PDF readers don't complain when parsing the document so it looks to be a valid. qpdf --check doesn't complain either. Added a test that checks a document with a null parses. Change-Id: I61eb281e821ccd195ef006d778556e25d1c7f5e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111820 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-02loplugin:refcounting (macOS)Stephan Bergmann
Change-Id: Ia68887778e6779cfaee58c88344c748a2b3d4579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111831 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-02tdf#116136 don't show status bar LangSelection control tool tipJim Raykowski
in print preview Change-Id: I85bcb547a71b2a5666310e184d8ba1da16acc97c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111671 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-03-02tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapseJim Raykowski
Provides parent child expand/collapse for Headings in the Hyperlink- Target in Document dialog target treeview Change-Id: I8cc57b4cbf3830cec76d64a0ef587e199c39e360 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109930 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-03-02Fix null-pointer-useStephan Bergmann
Since df33714f0ecaf4d35011f2d2116e5e1a4ec75f1a "tdf#131000: sc: Add UItest" introduced that test, UITest_calc_tests9 UITEST_TEST_NAME=forms.Forms.test_tdf131000 fails with > /framework/source/services/frame.cxx:1451:34: runtime error: member call on null pointer of type 'vcl::Window' > #0 0x2b0f4825f68f in (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) /framework/source/services/frame.cxx:1451:34 > #1 0x2b0f59361178 in FmPropBrw::impl_ensurePropertyBrowser_nothrow(FmFormShell*) /svx/source/form/fmPropBrw.cxx:508:27 > #2 0x2b0f5936236e in FmPropBrw::StateChanged(unsigned short, SfxItemState, SfxPoolItem const*) /svx/source/form/fmPropBrw.cxx:539:13 > #3 0x2b0f4fb3a8f0 in SfxStateCache::SetState_Impl(SfxItemState, SfxPoolItem const*, bool) /sfx2/source/control/statcach.cxx:423:24 > #4 0x2b0f4fb39a28 in SfxStateCache::SetState(SfxItemState, SfxPoolItem const*, bool) /sfx2/source/control/statcach.cxx:324:5 > #5 0x2b0f4f868e30 in SfxBindings::UpdateControllers_Impl(SfxFoundCache_Impl const&, SfxPoolItem const*, SfxItemState) /sfx2/source/control/bindings.cxx:1218:16 > #6 0x2b0f4f865d34 in SfxBindings::Update_Impl(SfxStateCache&) /sfx2/source/control/bindings.cxx:271:17 > #7 0x2b0f4f86d30c in SfxBindings::Update(unsigned short) /sfx2/source/control/bindings.cxx:350:13 > #8 0x2b0f4f900fc6 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:279:24 > #9 0x2b0f4f91693f in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:753:9 > #10 0x2b0f4f88e55f in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) /sfx2/source/control/bindings.cxx:1060:22 > #11 0x2b0f4fd7a482 in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:758:53 > #12 0x2b0f4fd753c1 in SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/control/unoctitm.cxx:229:16 > #13 0x2b0f3ff4de92 in comphelper::dispatchCommand(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /comphelper/source/misc/dispatchcommand.cxx:61:12 > #14 0x2b0f3ff4e605 in comphelper::dispatchCommand(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /comphelper/source/misc/dispatchcommand.cxx:76:12 > #15 0x2b0f75905186 in UITest::executeCommand(rtl::OUString const&) /vcl/source/uitest/uitest.cxx:24:12 > #16 0x2b0f75917a20 in (anonymous namespace)::UITestUnoObj::executeCommand(rtl::OUString const&) /vcl/source/uitest/uno/uitest_uno.cxx:69:12 > #17 0x2b0fb07ea8db in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) /bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 > #18 0x2b0fb07e4bf2 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) /bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 > #19 0x2b0fb07e173d in unoInterfaceProxyDispatch /bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13 > #20 0x2b0fb5c1835a in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const /binaryurp/source/incomingrequest.cxx:235:13 > #21 0x2b0fb5c11f7a in binaryurp::IncomingRequest::execute() const /binaryurp/source/incomingrequest.cxx:78:26 > #22 0x2b0fb5ceecc7 in request /binaryurp/source/reader.cxx:85:9 > #23 0x2b0f4145fac4 in cppu_threadpool::JobQueue::enter(void const*, bool) /cppu/source/threadpool/jobqueue.cxx:100:17 > #24 0x2b0f414838eb in cppu_threadpool::ORequestThread::run() /cppu/source/threadpool/thread.cxx:165:31 > #25 0x2b0f4148f62f in threadFunc /include/osl/thread.hxx:189:15 > #26 0x2b0f37f38da8 in osl_thread_start_Impl(void*) /sal/osl/unx/thread.cxx:264:9 > #27 0x2b0f39ddaea4 in start_thread (/lib64/libpthread.so.0+0x7ea4) > #28 0x2b0f3a71096c in clone (/lib64/libc.so.6+0xfe96c) (<https://ci.libreoffice.org/job/lo_ubsan/1933/>). The code in XFrameImpl::setComponent is like that ever since 79d6899a2f859d155d703699d0f7fe178b0c8ebf "INTEGRATION: CWS inplaceobjects" did > - sal_Bool bHadFocus = m_eActiveState==E_FOCUS; > + Window* pOwnWindow = VCLUnoHelper::GetWindow( xContainerWindow ); > + sal_Bool bHadFocus = pOwnWindow->HasChildPathFocus(); Lets assume that pOwnWindow can legitimately be null here (i.e., it is not just a consequence of an error that should be fixed elsewhere), and that bHadFocus should be false in that case. Change-Id: I73ce2c24e011d5b2ba95d09fd56bd59e47b4b991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-02loplugin:refcounting in swNoel
Change-Id: I5d3768503effa002c4a308bfad30d9b56d5365f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111802 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-02loplugin:refcounting in toolkitNoel
Change-Id: I7564951f3e3fdc0554de9a4af3833bc4f0facce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111770 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-02update creditsChristian Lohmaier
Change-Id: I9493971d90d9bc1629b1f2a0a1259db233656284
2021-03-02Fix typosAndrea Gelmini
Change-Id: Ieedfe4b3d6bedfd09851836575cdc7e864a7635a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111766 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-02fix xhtml list export in other localesNoel
where other locales will have lists with ',' instead of '.' which generates an invalid HTML margin-width value Change-Id: I30ec6f88140ba1187f7c30b697dfe82055b2e25c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111604 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-02Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 85f10dd2ed8485af159bf2e15e7e3e024b04bcf6 - tdf#140669 add "No List" to Formatting toolbar help ( swriter/main0202.xhp ) "Formatting" toolbar * update two renamed German IDs + add embed to "No List" command + add embed to "No List" icon table See https://gerrit.libreoffice.org/c/help/+/111575 for the main patch. This piece was put in separately to get around a merge conflict. Change-Id: Ibe1ebe2ec1bb28f4c6860334ffd83549a244206b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111784 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-03-02Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 5e9ca1b304afe987a99cecc298dac6c43a0e17cb - tdf#140669 (related: tdf#92622) update help pages for "No List" https://gerrit.libreoffice.org/c/core/+/108841 changed the "Numbering Off" command to "No List" The present patch make relevant adjustments in help pages. ( swriter/02/06040000.xhp ) "No List" command * "Numbering Off" -> "No List" + clarify that list indenting is also lost + add <tip> about how to preserve indenting, but remove number + add <relatedtopics> section and embed a related topic * rename two German IDs ( shared/02/06120000.xhp ) "Toggle Unordered List" * "Bullets On/Off" -> "Toggle Unordered List" * rename two German IDs - remove colspan="" rowspan="" * update icons size to 1cm * update to <h1> ( swriter/main0206.xhp ) "Bullets and Numbering" toolbar - remove embeds to "No List" and its icon table ( shared/guide/numbering_stop.xhp ) * "Numbering Off" -> "No List" * "Bullets On/Off" -> "Toggle Unordered List" * correction about location of "No List" icon * clarify that indenting is also lost * make descriptions be relevant for both bullets and numbers * clarify when indenting is lost or not + move icons to separate icon tables + add labels to icons * update icons size to 1cm + add <note> about how to put number or bullet back + add <keycode> + add appl-switch to Related topics * update to <h1>,<note> Change-Id: I8880f0aa46b2e036926497bf185092c2c5ae6d52 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111575 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-02Handle floating-point return values correctly on iOSTor Lillqvist
The code did not work at all. The contents of register d0 that we tried to access in MapReturn() was not what the called function had stored there. Probably the clobber list in the __asm__ statement is wrong? Anyway, simpler to fix it by explicitly storing d0, too, into a variable after the call, like we do for x0 and x1, and then pass that variable, too, to MapReturn(). Fixes https://github.com/CollaboraOnline/online/issues/1519 . Change-Id: Id05c8c57209eb9ade4d67035830b2dec601bc046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111826 Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111835
2021-03-02Related tdf#128469 - Change label of Standard buttonHeiko Tietze
Change-Id: I1bfc7cbfa71cf76d1cd76db83d8a7f951535e47e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111821 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-03-02Revert "tdf#43175: Adapt ranges when copying or moving several sheets"Noel
because it causes failure in the tdf101894 part of UITest_chart This reverts commit 3078044653f1e1b0a055c47eeb8d27834c07268a. Change-Id: If187b7a1125eb6f85bb7329bd9029dc8236a85f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111822 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-02Build libvisio with user CXXFLAGSVincent LE GARREC
Related with commit 8ae9d4727d8010a8f5d51f76ff0ebc5f88f0709f Change-Id: Ic38585f5f5ea5a633a67026d2640e0c43ea43f2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111503 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-03-02Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to ce92ec4ae71e03d3ee0a52c869f541c5f24fcb72 - Fix typo Change-Id: Ia5b8b1aa284dad599452c14d662a9583b9087498 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111763 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-02HTML XSLT: Adding explicitly whitespace - prior been erased in patch - as it ↵Svante Schubert
is often missing in our LO version used to create the MathML Change-Id: I90468c89297b5f3d70e7ba61cde5481069fc600b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111622 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML MathML update - enabling inline MATHML & fixing duplication (regression ↵Svante Schubert
from last commit) Change-Id: I22dba4fef5d1de7e4ef056a2e7f33511fa91318d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111621 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Adding missing MathML siblings. The floating draw:frame sibling ↵Svante Schubert
content being text were not shown, nor further occuring draw:frame (other MathML) Change-Id: Ifc5cdd4c58bdf01ceebcf10c01b85cdf96b60d26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111620 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Added missing listLevelStyle parameter otherwise prefix/suffix ↵Svante Schubert
did not work for list level > 1 Change-Id: I5bddde8ad620d91163688e6748b15e14693c41b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111619 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Appendix headings looked incorrect (in general heading within ↵Svante Schubert
lists were missing HTML element heading number) Change-Id: I125b095a436be3c6d9f5f64496564d63ea10a5fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111618 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Missing paragraph BORDER of stand-alone border paragraph ↵Svante Schubert
(@style:join-border problem) Change-Id: I20afce950213d4d55541d66a438db14a54b6ddd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111617 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: 1)FEATURE: ODF @text:min-label-distance becomes CSS ↵Svante Schubert
padding-right; 2) FIX: List @text:style-name only exists at root and have to be provided by parameter within recursion Change-Id: I287482ddbe394815268ef84d3207af2b0fdd3e18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111616 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Overtaking masking ' for ODF font-family with spaces in namesSvante Schubert
Change-Id: I718fc232a3903d0b449a4c9a4ef4dff601744756 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111615 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Adding default language for accessiblitySvante Schubert
Change-Id: I1e608239bd2524f0d2372871f465d926ea24ba42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111614 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Removing old IE7 fix, which was enabled by fixing invalid CSS and ↵Svante Schubert
corrupts layout these days Change-Id: Ic5531439521a94be9dadabff7278f964472aa39f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111613 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: List empty CSS styles (ODF styles without CSS mappable styles) ↵Svante Schubert
only as a comment Change-Id: I0be491ff96d0b454d064618426da5aa3f861b7f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111612 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Only write page {} information when they existSvante Schubert
Change-Id: I213645835745e992fe6f2aa79a678d177a97c45f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111611 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Placing font-family names within 'double quotation marks' in case ↵Svante Schubert
of spaces within the font name Change-Id: I780845df636c6a07bd621fa01cb60134d3ead592 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111610 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Set default to 0 in case of not-a-number: min-width:NaNcmSvante Schubert
This had a conflict with commit 9804cb2f195451811eff8924d7997a3cbd6d679d Fixing bodx.xsl: Invalid min-width:NaN check (Michael's GitHub Review) Change-Id: I0bd5bbae1411c6b4892bf332e6ff3c7027f8c341 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111609 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Fixing CSS selectorSvante Schubert
Change-Id: I4c26f71936e6df655bb5c11bf9137b91ca894cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111608 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Excluding loext namespace from outputSvante Schubert
Change-Id: I603e8eec319c83b1cb1a47dd095d82761dda3cd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111607 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02HTML XSLT: Neglecting redundant @type of styleSvante Schubert
Change-Id: I64d277776ba023910b6c7743c2c4f60bcc2ca4cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111606 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02Minor XSL updates to improve for the XHTML of our specificationSvante Schubert
Change-Id: I8a4f82e3e67c1f9f9e7c0b228216036cee22eb71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111605 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02Filepicker: Add note about possible raceSamuel Mehrbrodt
Change-Id: I17b928c467354d4b5e4a178e3320678875573f60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111743 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-03-02lok: sc - suppress LOK editengine events for the calc input bar.Michael Meeks
The calc input uses an EditEngine - but it emits events as if it is part of the document - as well as emitting events as if it is a dialog window. This causes horrible jumping artifacts to the top of the document with word auto-completion and typing in cells a few page down. Also remove obsolete tweak to turn off autocorrect for LOK, since it was contradicted by: 1f0943e5e9432f96daff9f3b006388d5bc7415b2 Change-Id: I7352cd3b5ca6d18645cfd9e18959b0e44ec969d7 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110422 Tested-by: Jenkins
2021-03-02tdf#140117 sw UI: keep headers/footers when inactiveDaniel Arato (NISZ)
Custom left page and first headers (and footers) used to disappear forever if hidden temporarily by checking the "Same content on left and right pages" or "Same content on first page" options, respectively. This commit stashes the endangered headers (footers) in SwPageDesc and restores them on demand. Change-Id: I1f6b605e2bd19af18726de1b825721487d29b4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110398 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-02split out MoveAttrFieldmarkInsertedCaolán McNamara
Change-Id: Ib48bd62994167b1703790857cb562fc7f7dbd76f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111755 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-02Revert "sw_fieldmarkhide: init fieldmark mode from options"Michael Stahl
This reverts commit c0864f26f3143ea81c65d3826fae32a8fd54c531. Revert "sw_fieldmarkhide: toggle mode depending on View->Field Names" This reverts commit c74a2fd835474caf311be10703c985e2f916a83b. Currently no time to fix the remaining bugs, for example tdf#138771 tdf#139638 tdf#139737 Change-Id: I800c5c8df10c02ac8be6234141e7c58d73915cd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111758 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-02Value for display size in 32bitHeiko Tietze
Follow-up to 28e022c258682dc030668fed7879d9d3f078b720 Change-Id: I05a7edd2e24071e4ddbbbf8eb6a9232912f4a376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111738 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-03-02tdf#140552 RTF export: fix hyperlink, in footnote, in hyperlinkMiklos Vajna
Regression from commit 7d42346ba77c9c4df241ea40eaf550993ca18783 (tdf#90421 RTF export: ignore hyperlinks without an URL, 2015-04-21), URLs can be nested in the footnote case, which requires a stack. Otherwise the inner URL clears "the" URL and we don't close the outer field as we believe it's empty, so it was not started. Change-Id: I9f87ddbb7e597c413bf836eb9b58beb76722361f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111794 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-02Implemented MoveShapeHandle uno command for scmert
Change-Id: I5f81348cd778d7fbcb3b4e721fbf0412c4f5753d Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111195 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111514 Tested-by: Jenkins
2021-03-02Convert MapModeUnits If necessary.mert
Connecting to a glue point or handle callback messages contain points which may need a unit conversion depending on the module Change-Id: Icc0b2bc5981bb7d135efd38e60ac06fe12a70480 Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111193 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111513 Tested-by: Jenkins
2021-03-02Implemented MoveShapeHandle uno command for swmert
Change-Id: I9feccc4fa1a4d7426609afa474f87ab12c769090 Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111192 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111512 Tested-by: Jenkins
2021-03-02tdf#43175: Adapt ranges when copying or moving several sheetsOuyang Leyan
When copying several sheets at once using the "Move or copy sheets..." feature, the ranges were not updated, in charts for example. Same when moving a sheet and choosing a new name at the same time. Change-Id: I0d05f2d123dfe1174ba126d7f73845988ec1e983 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108739 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-02Correct arguments to create a svl::GridPrinterOuyang Leyan
Otherwise, the application does not compile with the DEBUG_CHART2_TOOLS flag Change-Id: I3c481f09502e810eb8b641bc1e2ff2ac87425596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-02loplugin:refcounting in chart2Noel
Change-Id: I7f49a25fccf853b6e61c37f35c116888163153f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111746 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>