summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-03-02Qt5 unify font attribute conversionsJan-Marek Glogowski
Adds conversion functions for VCLs FontWeight, FontWidth and FontItalic to Qt5FontFace and remove the partial "switch" tables from KF5SalFrame. And correctly handle the FontWidth in Qt5Font as the stretch value, so the default font in qt5 gets the correct stretch and doesn't look bold. Change-Id: I698986416dff13e6dfaf9dfa7f95851b89e9137d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89813 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-02clang-format lotuswordpro with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I4527dcc9aaabd1fba3363c0aa2bf3217e42ef45e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89776 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-02fix get_SHA_for_change in logerrit scriptNoel Grandin
after commit 02b5d09c0dab1621ce23f9a8df45fa1628be3ece tdf#105204 fix shellcheck warnings in logerrit the previous get_SHA_for_change returned a URL with a leading space, which was previously implicitly stripped. Adding quotes prevents that stripping, so we need to explicitly strip here Change-Id: I5b303f6ca5b1dc7d2a369afc2c52830b1b9586eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89816 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02tdf#118893: avoid nullptr dereferenceMike Kaganski
Change-Id: I56ada18348ed1b1ebe5e1d6f000391965d822b4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89815 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-02Qt5 some refactoring for HiDPI mergeJan-Marek Glogowski
This is a preparatory patch for merging the initial fix for tdf#127687, the Qt5 HiDPI scaling support, and generally to make the style handling code a little bit more readable. It includes: * Moving all lcl_ Qt5Graphics_Controls functions into the class as private functions without lcl_ prefix. * Add three additional helpers - pixelMetric, sizeFromContents and subControlRect - to cut down boilerplate QApplication::style()-> prefixes for the style calls everywhere. * Drop the superfluous Qt5Frame::TriggerPaintEvent functions. * Drop the single, broken maGeometry.nTopDecoration filling. * Split some very long lines of nested call code by using some intermediate variables. * Move a Qt5Data include from hxx into cpp Change-Id: Iae1bfafd14c4163447f3d55e2307f0f617e68a0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89751 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-02speedup sw build a littleNoel Grandin
from 11m46 to 11m21 Used ClangBuildAnalyzer to find headers that took a long time to parse (in total, across all modules). (*) moved the boost stuff out of sw/inc/docary into a new header. (*) make sw/inc/ndtxt no longer include doc.hxx Change-Id: Ia1d4ebddb4ddd4ec4ffbc011f4a5e24a42b46d3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02prevent gbuildtojson.py from removing the GBUILD_TRACE fileLuboš Luňák
It starts a new make (MAKE_RESTARTS is again not set), so the code for removing the file gets triggered again. Change-Id: If48214703fd86337a5bfa2c1c8e67cbdfbdfdfad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89814 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-02cid#1459023 Dereference null return valueCaolán McNamara
Change-Id: Id99adac0a544b59b6ac8f6ac225df1f218ed8405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02tdf#126904 calc right arrow large unexpected column jump in protected sheetNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I3b6f6e5430c97ef52f63c406eb3c3b39b9dd578e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02tdf#42949 Fix IWYU warnings in svx/source/s*/*cxxGabor Kelemen
Except for already done svx/source/sdr/ Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I1c4b34cf42aa9faa2f7de36fe1602059460c6c1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89656 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-02sw: layout: fix wrongly positioned table rows in --convert-to pdfMichael Stahl
If the document is loaded via UI, the first layout action is triggered from resizing the Window and the table is positioned properly on the first try. If the document is loaded via --convert-to, only getRendererCount() formats the content of the table, and the table is positioned 3 times but its first row is only positioned 2 times. The first time the table id="56" is positioned, the previous table id="50" is at correct Y 5988 but its content isn't formatted yet, so its height is almost 0 (just table's border etc.), so the table ends up at y = 6271. The second time the table id="56" is positioned, the previous table id="50" is at wrong Y 7937 and its content is valid, so its height is 1203, so the table ends up at y = 9140. The third time the table id="56" is positioned, the previous table id="50" is at correct Y 5988 and its content is valid, so its height is 1203, so the table ends up at correct y = 7191 ... but the first SwRowFrame remains at y = 9140 and is never repositioned, and the lower rows are cut off (invisible). Change SwTabFrame::MakeAll() so that a MakePos() that moves the table itself does not leave the first SwRowFrame's position valid, which should ensure that all rows are repositioned. (And work around C++'s particularly unhelpful type system.) This happens since the earliest version checked, OOo 3.3. Change-Id: If3dfe1ffcb81e03aa4f4bffcf33a237f0c92bd08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89735 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-02tdf#131031 Gtk3 presume the resize did happenJan-Marek Glogowski
Regression from commit b26ca5b13733b46c2df0787502f885e15b390956 ("tdf#130841 resize to client size after SetPosSize"). It just happens for me on gtk3, not gen and not win. But since gtk3 also sets the nX and nY value SetPosSize eventually before the fact, do the same for the nWidth and nHeight. Change-Id: I2898c403b73de790f3f988b8b8ec2067f4b0b43f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89760 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-03-02tdf#131062 DOCX import: fix table-style paragraph background colorLászló Németh
by comparing fill attributes to ParaBackColor to avoid losing them. Regression from commit a9ba8e57a41c5ddf3597272bddab30e51fb3fd38 (Revert "tdf#118947 sw tablestyle: manually scan parents for ::SET"). See also commit 24077b2d52ab3d0fd0db5afb25d8b94b62386e3e (writerfilter: import paragraph color as fill attributes) Change-Id: Id42ea3adaddf883435dd61e5dea0e6c5fb89f927 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89215 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-02Make Chart Creation Wizard asyncSzymon Kłos
* FuInsertChart as a memeber in ScTabViewShell stores instance is needed to react on the dialog's result * CreationWizardUnoDlg converted to XAsynchronousExecutableDialog added dialog close handler which notifies listeners In the Online dialog become dead after closing, additional PostUserEvent was needed to kill the dialog after real close (without it user needed to select any cell to close dialog) * Reuse in Writer Change-Id: I9fe123d5c189d568f0edb4d36173a224a820a8a3 Reviewed-on: https://gerrit.libreoffice.org/79654 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/79571 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-03-02tdf#36737 - Initialize default values of optionalsAndreas Heinisch
Initialize default values of optionals in function headers. In LO Basic, optional parameters are allowed, but without any default values. Missing parameters will not be initialized to their respective default values of its datatype, either. With option Compatible, optional parameters are allowed with default values. Missing optional parameters that don't have explicit default values will not be initialized to their default values of its datatype. With option VBASupport, optional parameters are allowed with default values. Missing optional parameters that don't have explicit default values will be initialized to their default values of its datatype. Change-Id: I57aabae5f70d1cf6c4e8feb95ce0db6af753383c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87550 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-02dtoa needed by salCaolán McNamara
Change-Id: I79067b047384425c65a2653b20e637d8461cf7f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89780 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-02sw: prefix members of SwRedlineSaveData, SwUndoAttrTable, SwUndoCpyTable ...Miklos Vajna
... and SwUndoFormatColl See tdf#94879 for motivation. Change-Id: I004a80401c48d9706537cce318d0dc44fb4204be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89807 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-03-02Revert "Stop Navigator content view flashing"Stephan Bergmann
This reverts commit 201a7652092c6a7796a59e6ddee144e4f0c9ece9. Was this submitted in the wrong order? There is no m_bIsInPromoteDemote across the code base. Change-Id: I85cfbb797fccfd0c03c1ec19a792da8e10c7acde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89806 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-02Add functionality for promote/demote chapter/level shortcut keysJim Raykowski
The following arrow key shortcuts for these actions can be used when focus is on outline content in Writer Navigator: Ctrl+Up promote chapter Ctrl+Down demote chapter Ctrl+Left promote level Ctrl+Right demote level Holding the Shift key, in combination with the above, will exclude children from the action. Change-Id: I73a320d571791e2e9e1c0e4efb579c9977220494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89491 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02Adapt compilerplugins to Clang trunk changeStephan Bergmann
<https://github.com/llvm/llvm-project/commit/ 93184a8eda272c65308906836b47cbf209de779e> "Remove unused parameter from CXXRecordDecl::forallBases [NFC]" Change-Id: I8efdda2a37fd0df3b964401e8851a0f95f8d0ab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89781 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-02don't rely on parser ::characters callback only firing onceNoel Grandin
which is true for the old parser, but not always so for the FastParser. So pre-emptively fix some stuff Change-Id: I405834f1dfd28c98cae87b6de38d238f723edafd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89712 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02Stop Navigator content view flashingJim Raykowski
Redraw flashing occurs in the content tree when outlines are moved during promote/demote chapter/level and when switching content navigation view mode. Also, the focus rectangle is briefly shown. This patch uses the m_bIsInPromoteDemote flag, that indicates when outline levels are in the process of being moved, to not redraw the content tree until after the moved outlines are reselected. To stop focus rectangle flashing a check for tree emptiness is used in the Paint function. Change-Id: I252c5a0032157c0a8287c748071d180675b3a70d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89659 Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-02Add XServiceInfo tests to ScTableSheetsObjJens Carl
Change-Id: Iaaadc2554bb0ce103ef01bbf02c316d21fae51af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-03-02gtk3 a11y: fix get_text(1,-1)Samuel Thibault
Even when the end offset is -1, we have to return the text starting a the given starting position, up to the end, but not necessarily from the beginning. Change-Id: I6a79092c683c273eaedb8661545df71b742110ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89486 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-02tdf#130945 Writer: Preview of linked doc is not updated when editedSerge Krot
Change-Id: Id8ee653cc9cb5dbcb3ad0a31688a0b5e34d99fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89499 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-03-02tdf#129096: Document Recovery: Use TypeDetection on loadVasily Melenchuk
Loading of recovered document happend before via XFilter::filter is not updating media descriptor of document. But this is important for password protected documents to store entered password and used encryption type. To avoid this problem let's use TypeDetection which during its work will ask user for password and store all the info in modified media descriptor before actual recovery attempt. Change-Id: Ide2ebf0955e0937cdc7c9d7165593b71f904649b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88844 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins
2020-03-02tdf#130348: Add special case for ChartDeck, tooTor Lillqvist
Change-Id: Idf6cc1469f074debfc4351a58826a3a7411391ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89722 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 6a031edca26cadd5917a94de2d3b6a706197a8fc)
2020-03-01nDepth is only written to, not readCaolán McNamara
Change-Id: Idf6f038e535f48558b04f3aea63c01c9e164ee8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89779 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-01Catch by referenceEike Rathke
error: catching polymorphic type ‘class qrcodegen::data_too_long’ by value [-Werror=catch-value=] Change-Id: I34cd429186b737f32ceec124849d48860788a9d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89778 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2020-03-01lok: Set default text for new text box on mobileMuhammet Kara
Change-Id: I0b6056e9dbf5fb81d092092cc183b05120b95d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89352 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89710 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-01Related: tdf#130371 Broadcast ScAreasChanged for created namesEike Rathke
... to notify the Name Box to refresh its name list. Change-Id: I20fb461d59c0dd98698837d91e2a7ef9a8c5a4ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89768 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-01gla11y: Fix checking orphan labelsSamuel Thibault
Change-Id: Icd43014f40a655b512b6328f4800906325d9b164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89767 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-01cid#1459020 Resource LeaksCaolán McNamara
Change-Id: I124a61ee34b315c4853ee0f1d96eb9ee45a76e8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89764 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-01cid#1459028 various checked_return warningsCaolán McNamara
and cid#1459027, cid#1459026, cid#1459025, cid#1459024, cid#1459021, cid#1459018 Change-Id: If92e7665fcf947c5daf3094b9003e85c5c51f48f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89763 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-01cid#1459022 Uninitialized membersCaolán McNamara
Change-Id: I672c55ac562836f5ca7fe9e8c6a9d313dbbc40a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89762 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-01Drop unused suppressionsSamuel Thibault
Change-Id: Ibeba908d39234b5f3224ffdf6bda0673d6ccaa8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89766 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2020-03-01Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to f2a0ebccd289ae50a38def8beb38943579e94a62 - tdf#106668 update help page about applying Styles - update command labels - add module conditionality to howtoget access - add sys conditionality on shortcut key - updated access commands - updated id=gestalter to id=stylewindow - added "Related Topics" section - moved "tip" about "styles" to "Related Topics" - add link to Creating Page Styles in "Related Topics" - updated "Autoformat in Tables" page - changed "Default Style" to new "Default Table Style" - adjusted order of elements - corrected grammatical error - changed to <h1>, <h2>, <h3> Change-Id: I1d0167f8d8b8205a4f94d56c388a5271fdbac477 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87415 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-01lok: Unlock chart contollers after insertion on mobile viewMuhammet Kara
The chart controllers were locked until the dialog finishes its execution, but at some point, dialog is disabled for mobile view, and seems like it was forgotten to unlock the controllers. Change-Id: Ib1e5799f5c84ef8b3ebc0f538909b4f8b586ff1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86716 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89708 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-01Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 7d11198c0935ed1d87857e9dcd7d8ba200555884 - Wrong word Change-Id: I7a9d3d9c3a202e2c230d71c327bb544e667c6745 - Remove erroneous ellipsis This particular button does not open any further settings, so this punctuation was always unwarranted. But as a general rule, please never add UI ellipses to the help. Change-Id: I363c0f53f7be3aa960cc2fe7267ccad002e9c575
2020-03-01lok: Create Text boxes directlyMuhammet Kara
Change-Id: I281d4648d0e91f74d6f0f5880945d8e7e8659efe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89344 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89709 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-01use the SetAttribute override in SvXMLStyleContext subclasses consistentlyNoel Grandin
Change-Id: Ibdbf73c5e54fbbb051e4898fd8b3a7a155647b15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89702 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-01Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' to 8eeb48c64d6ee09cfcfad76392b405df871b3a2c - Small whitespace issue +line breaks Change-Id: I3156faf67b6819e1706b457f895e7c14f2d3f4cf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88032 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-03-01lok: Improve hyperlink insertion to cell with contentMuhammet Kara
Change-Id: I520939dd5b44236cf835108ee2bc96c29f0a9677 Reviewed-on: https://gerrit.libreoffice.org/85509 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89707 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-29Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to a843fb6d63416be6d1dd202876d304a502679929 - tdf#130993 remove embedded keyboard shortcuts -some languages need to translate keycodes contextually Change-Id: Ife65552bc080b32156de139c7332ad966e000b8b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89684 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-02-29tdf#124176: Use pragma once instead of include guardsBugra
Change-Id: I7ab74181ba68ad722929b6022736179327ac909f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89754 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-02-29ofz#20904 check boundsCaolán McNamara
Change-Id: I5d6d381ebd359b233b309e08131f3dda21310d80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89620 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-29send hyperlinkclicked callback on calc mobileMert Tumer
for opening links ctrl+click must be pressed but in mobile this cant be done This patch allows it to send the callback and also cell coordinates for hyperlink popup Change-Id: I8c0fac167627ef449d9cf20a36a7a5a77978ae0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89121 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 9bfa939f87f28cdaed2a24c3dc5f9a21004b19da) Blind build fix for Android After 9bfa939f87f28cdaed2a24c3dc5f9a21004b19da Also, replace chained OStringBuffer::append() with operator+ Change-Id: I7012667b3c4173cc0193720e0197992e5942bc7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89693 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-29tdf#130955 chart export: fix repeated custom labelsBalazs Varga
Do not add mCustomLabelText to aDataPointVector when we write leading empty data points, it is enough to add them, when we write data-point with style. Note: this fixes also DOCX import, when the embedded charts are imported by using ODF export in the background. Regression from commit: 7d2c7e7af04d9604d86d2d605ef95b9abb10966c (tdf#123206 Store custom label as chart:data-label) Change-Id: Ib3b370236323a57ac6800035d71321f7ee5dbe41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89504 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-29tdf#92472 DOCX import: fix checkbox size set by direct formattingLászló Németh
at beginning of paragraphs. Follow-up of the commit 22ad4d69d771708f28a2d9e137cfd43ac846cf3a (tdf#121045 DOCX import: fix checkbox size in table). Change-Id: I06f0dfa4376ff8f5730d8cfe1cbc3de022e8aaff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89726 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-29lok: Resolves: Calc - selecting a hyperlink doesn't show link in dialogMuhammet Kara
Change-Id: Ic4264fad8035029ba6593c91fa57efa772d394ca Reviewed-on: https://gerrit.libreoffice.org/85468 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89705 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
generated by cgit (git 2.34.1) at 2025-03-07 06:39:02 +0000