Age | Commit message (Collapse) | Author |
|
First of all, it should not be clamped to allocated columns. Second,
06d3294502413a231e5c5265609862c7f67a2f2b incorrectly handled
unallocated columns by setting the attribute for all rows, instead
of handling the inner ones differently.
Change-Id: I3115b314971f8c152cbdeda674863a8a78ee12eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135131
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
e4008dc0c3b43c9eacdd88511075be2b88 did this for ApplyBlockFrame()
but didn't chagne ApplyFrame() which is only called from there.
Change-Id: I9f1dce3dc7fda23b42e90432c13dfca0aa7f267e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135130
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I5dbc302216b0d8b94ad29a336495856ce8cfc4b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135139
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
> sw/source/core/text/guess.cxx: In member function ‘bool SwTextGuess::Guess(const SwTextPortion&, SwTextFormatInfo&, sal_uInt16)’:
> sw/source/core/text/guess.cxx:220:37: error: ‘bHyphenationNoLastWord’ may be used uninitialized [-Werror=maybe-uninitialized]
> 220 | if ( bHyphenationNoLastWord && sal_Int32(m_nCutPos) > nLastWord )
> | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sw/source/core/text/guess.cxx:201:14: note: ‘bHyphenationNoLastWord’ was declared here
> 201 | bool bHyphenationNoLastWord;
> | ^~~~~~~~~~~~~~~~~~~~~~
since 8c018910ae4d8701b1ce2a95727b9baed4016da3 "tdf#149248 sw offapi xmloff: add
option to not hyphenate last word"
Change-Id: Id3be25bf9f5d6769555bfe461a0f4e1e27e0e39e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135137
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
|
|
Change-Id: I53d370bf6bc5133b7279e569516fc5a0a5ede1b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135135
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
since vector is a moveable type, and we always initialise this field
Change-Id: Icd598ad942dcfbdf77c7c8eef9fa0b6b7c6fe1be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135134
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Icceaf255a3a71d612b17dad41d04b1906550a7a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135133
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ief9a0732d50af95d679d1d6b66dec9d2e2d141df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135132
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ifa67ab7198f5d3b06171869f57703acdaa959f7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135128
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If0d1ea55a194961fdb05ed2023bcfdaa6f933bfa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135129
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
and destroy when it is fully faded out. Otherwise windows runs out of
gdi handles with document with large number of page breaks
todo: rename some things in a follow up commit after this more easily
backportable commit is merged
Change-Id: Ibbe3cd00d1027ac34915c4bff73e3a330e300f38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135027
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Addresses
<https://gerrit.libreoffice.org/c/core/+/135114/2#message-6f69c01338150fe3114c2699b417fc7223154cd2>.
Change-Id: I36d48288be1456f06813befbb24e896767957eb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135126
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I1ff31ae1291a82630ae32185077e369bbdfd3a0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135127
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iae284fcad199684920aef0bd91ff39c407b48e0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
make an owner for the PropertyMapEntries
Change-Id: Ie915a8a312f2b24488566814ad67fdeef89b5941
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135123
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to 76f954f62ccd344d1760970d13a84645ceb6dd5e
- tdf#91344 help for Writer "View" menu is not updated
Writer View menu Help page was already updated modulo
one minor correction in an embedded file.
Change-Id: I7eac912669a30b9d675a51b966dcf6497269f502
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135092
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I7be63816fcdc3572d751fdd9ceab5931d0559ffc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135124
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes
picking up instdir/program/libnspr4.so", to avoid
> Test name: (anonymous namespace)::testThemeExport::TestBody
> equality assertion failed
> - Expected: 0
> - Actual : 32512
> - failed to execute: sh .../bin/officeotron.sh .../tmp/_anonymous_namespace___testThemeExport__TestBody_w8epm.tmp > .../tmp/_anonymous_namespace___testThemeExport__TestBody_w8epo.tmp 2>&1
> java: symbol lookup error: .../instdir/program/libnspr4.so: undefined symbol: __asan_init
Change-Id: Id6f49c08a8bcd0ad9b5600de147624d5cfc6019b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135122
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Fixing z-order was incomplete for textboxes
(shape + frame pair), because only the frame
moved to back, but not the shape, covering the
textbox.
Regression from commit 504d78acb866495fd954fcd6db22ea68f174a5ab
"tdf#143574 sw: textboxes in group shapes - part 1".
See also commit 0e6d963fbca16f98a3dbb6ef2fee3736a89d055b
"tdf#138141 sw: fix textbox z-order".
Change-Id: I03e3b55302c984e5968e579e77ccd5ed0a336dd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134942
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
...in case osl_create_temp_file_impl_ doesn't assign to it, for whatever
osl_error reason, which then apparently leads to
<https://crashreport.libreoffice.org/stats/crash_details/e47a9fbb-a6f1-4020-ade8-ab51549b727a>
SIGSEGV at (relative to libreoffice-7-1)
> 0 libuno_sal.so.3 osl_closeFile sal/osl/unx/file.cxx:1154
> 1 libuno_sal.so.3 osl_createTempFile sal/osl/unx/tempfile.cxx:330
> 2 libmergedlo.so PackedFile::flush include/osl/file.hxx:310
> 3 libmergedlo.so comphelper::BackupFileHelper::tryPush_file comphelper/source/misc/backupfilehelper.cxx:2090
[...]
Change-Id: I2e81bbeab7daaaa3c19de4accce8a76ad24faa47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135111
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
to avoid of detaching connections between shapes,
when these connections were created in Impress.
Change-Id: I1bc90bb8a408546b303b70bcfb27d3549d5e72d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134940
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: Id91ca2d7002b3743ecaed7b40edda3f85e080884
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135061
Tested-by: Jenkins
Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
|
|
Change-Id: I86956ab4beaba6b2b0905123ccea76c8ffad57fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135063
Tested-by: Jenkins
Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
|
|
As reported by Julien, once the mediawiki extension is installed, the
xHandler in framework::DispatchProvider::implts_searchProtocolHandler()
points to an UNO component implemented in Java, and we crash in
dynamic_cast<>(), at least on Linux with gcc 7.5 and libstdc++.
This dynamic_cast<>() call was added in commit
c0fa456436947a5c167c652d19a884064b43c03d (tdf#149261 sdext: fix crash on
starting the presenter console for the 2nd time, 2022-05-26), to allow
the presenter console to opt out from protocol handler caching. It was
expected that the proxy object created for a Java UNO component would
simply return nullptr when we try to dynamic_cast<>() it down to a C++
interface.
Fix the problem by moving the interface to an UNO one: this side-steps
the dynamic_cast<>() crash at the price of introducing an UNO interface,
which is not meant to be part of the public UNO API (but at least it's
not published).
It may still make sense to improve the bridges/ code at some stage to
not crash in dynamic_cast<>() on generated Java proxy objects.
Change-Id: Iaac44515339e0dc15dddc3be45ef7dee7331e47a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135114
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
If there is no color value we should not also try to write
transparency information: otherwise w:srgbClr will have no
parameter value and MS Word won't open such documents.
Change-Id: Id67f174c5ae9aadf90ae54c126aef9a43ff3ba17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134945
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Change-Id: I3a0c5aab62a7b6723df5820abb3f56e3f110d8b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135113
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
if there is a max/min set.
Change-Id: I2dc7ccccad9ec2aa7eb89d8b5fa137e077a846fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135105
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ide40a08f70cbb30a4f18c496d986feb78e5dfa1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135103
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and just feed the data in as we create it
Change-Id: I5112e0b61bc4f4976978d5e4724053ab9ffc97e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135102
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
which lets me move data around instead of copying
Change-Id: Ibc7d8c2b5e0244537aa66561132facd93b424d61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135101
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I759775bb672478f3baee782aba08ef17bd36124c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135100
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Removed unused variables in the 'with' statement as the syntax
allows the statement to be used without a variable.
Removed variables like 'xcomments' and 'xseedspin', which seem
to have been copied and not cleaned up.
Removed variables 'gridwin' and 'xCalcDoc' if 'gridwin' is not used.
Change-Id: Ia97692a0fb2e2af1d2693e09ac8f7c614360ade8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135042
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
... WW8AttributeOutput and wwSection
See tdf#94879 for motivation.
Change-Id: Iefc7aaf4caaaca5382ac0b28ea8e3ebe63250020
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135108
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
- map
<w:date>
<w:dateFormat w:val="..."/>
<w:lid w:val="..."/>
</w:date>
to the Date, DateFormat and DateLanguage UNO properties of content
controls instead of fieldmarks, which model content controls poorly
- fix CppunitTest_sw_ooxmlexport8's testN820509: date SDT is now a
content control
- add current date DOCX import
- fix CppunitTest_sw_ooxmlexport13's testDateControl: date SDT is now a
content control
- fix CppunitTest_sw_ooxmlexport13's testInvalidDateFormField: date SDT
is now a content control
- fix CppunitTest_sw_ooxmlexport5's testfdo83048: minimal support for
nested SDTs in DomainMapper::lcl_attribute()
- fix CppunitTest_sw_ooxmlfieldexport's testDateFieldAtEndOfParagraph:
date SDT is now a content control
- fix CppunitTest_sw_ooxmlfieldexport's testDateFieldInShape: date SDT
is now a content control
- fix CppunitTest_sw_ooxmlfieldexport's testSdtDateDuplicate: date SDT
is now a content control
- fix CppunitTest_sw_ooxmlfieldexport's testSdtDatePicker:
- retain placeholder
- retain data binding
- retain color
- fix CppunitTest_sw_ooxmlimport2's testTdf121203: date SDT is now a
content control
- fix CppunitTest_sw_globalfilter's
testDateFormFieldCharacterFormatting: date SDT is now a content control
- fix CppunitTest_sw_globalfilter's testDateFormField: date SDT is now a
content control
Change-Id: I5a4c34217d23ed6fa0916e4dd6290351456b7232
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135109
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ife73d08e57bb1c896a27f8cbbd6b1f4b106587a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135062
Tested-by: Jenkins
Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
|
|
instead of copying
Change-Id: I3f851b877ece609547eed6f772b2b8df57aeae96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135097
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 580f62a41db6366a3ab13bf16a96a643710605a3
- tdf#149253 improve help about anchoring
shared/01/05260000.xhp (Anchor)
* corrected entries for "to page" and "to character"
- removed double presentation of "Anchor" icon
+ add <relatedtopics> for Writer, with link to guide page
on positioning objects
- moved "note" on "Frame", which has been present since
initial checkin in 2004, to after the option "To Frame"
There is nothing special or unusual about anchoring to frame
that needs attention. Maybe this note should be deleted, but
have left it for now.
+ added variable to <h1> so heading and link can be embedded
* refactor to <h1>,<note>
shared/01/05260100.xhp (To Page)
* elaborate explanation of this option
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/01/05260200.xhp (To Paragraph)
+ add information about what positioning regions can be used.
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/01/05260300.xhp (To Character)
- remove incorrect limitation
* generalize the tip from ”image” to include frame and OLE object
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/01/05260400.xhp (To Cell)
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/01/05260500.xhp (To Frame)
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/01/05260600.xhp (As Character)
* correction to what changes the height of the current line
+ add related topics section and links
* refactor to <h1>
* update renamed German id
shared/02/03200000.xhp (Change Anchor)
* Update command name
* refactor to <h1>,<menuitem>
swriter/guide/anchor_object.xhp
* make explanation more general than image
+ adding headings for ”Moving an Anchor” and ”Changing an Anchor”
+ added section ids so these can be embedded elsewhere.
* refactor to <h1>
shared/00/00040501.xhp
+ add additional toolbars that have Anchor icon, and make
an switchinline because Calc and Writer are different
+ add context menu access
+ indicated need to select an object before using command
* rename German ids
Change-Id: I43881be154163f71ca188a5446385e2dc5805f1e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134786
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I2674ea52bc6217aa7cf9283c17f1d63533baaa49
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135107
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
...that 3ca1a169e571a829598a00a2ffef6e1018d2cb18 "Use boost::noinit_adaptor"
forgot to remove
Change-Id: I82818c72e9178cda7b9698d8a30e1b8f3c3d87c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135099
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...between d203e3f35dc4547bb46151637ba6054d13025d01 "use comphelper::ByteWriter
in UNOMemoryStream" and 3ca1a169e571a829598a00a2ffef6e1018d2cb18 "Use
boost::noinit_adaptor"
Change-Id: Ie890288485f499505184a12b0797d5fc9b877922
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135098
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Icf5a3ae47aec43854e669133f3d0c2bace1d942d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135090
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...introducing o3tl::cmp_equal etc. implementing C++23 std::cmp_equal etc., plus
an o3tl::IntCmp wrapper around it for convenient operator syntax
Change-Id: I1d2e0d1aef99c531039fb83de31ed8e6036fde03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135095
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
which we can std::move the data around, instead of copying
Change-Id: Id7aaad3970b942599807b7fda73d028f082a0f38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135089
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and save some copying
Change-Id: I34cbc2edfd53fcc440d1765dba471fcbb05b2b7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135088
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
avoiding creation of temporary OString instances
Change-Id: I27b4cb59b48b3ba40311a1f935a20250c8317d00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135093
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ide5f0394172548ed6a1ef4a6277ebf4752e685bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135094
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...and simplify the remaining code using the (now const) nCacheSize
Change-Id: I4468cf223c158a318ba56ba63f5f60121c94f42d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134879
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I5dd9552eb267ffb67aa0aae36b474eb28790b5c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135091
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to 7bea4ecaa0fdc5dd19077c63f8901a4dde78cc67
- Consistently capitalize acronyms
Small follow-up/fixup for commit 2df65a1ff7072dc0ec866f5dfe11846c15208199
Change-Id: I16f4c999c03af3828d6a279e862cc4c88c642138
|
|
Change-Id: I172057b76ff4e6e1cf3d5e67a99360ecfc0a3fc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135081
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|